The distinction between OFONO_VENDOR_QUECTEL and
OFONO_VENDOR_QUECTEL_SERIAL does not suffice for EC21/EC25 in some
places, so introduce and use a new vendor:
OFONO_VENDOR_QUECTEL_EC2X
There are a large number of files in the tree that define _GNU_SOURCE
despite not actually using features hidden behind this flag. This patch
removes all these definitions in one fell swoop...
The driver vtables are read-only structures. This patch declares them as
'const' allowing the compiler to (optionally) put them in the RELRO
section. RELRO pages may be marked as read-only by the linker after
the relocations have been done ensuring that they aren't inadvertently
or maliciously altered at runtime.
On the SIMCom SIM7100E, setting AT+COLP=1 causes there to be no
response at all from "ATD...;" commands until the call is answered.
The results in oFono stalling rather than creating a new VoiceCall
object.
We fix this by adding SIMCOM to the list of vendors for whom we set
AT+COLP=0 rather than AT+COLP=1.
The voice call support of the Qualcomm MSM based modems does not report
NO CARRIER, NO ANSWER or BUSY unsolicited notifications. So keep polling
for call state changes via AT+CLCC even during an active call.
In case of Qualcomm MSM based modems, AT+COLP=0 needs to be used to make
ATD<number>; return right away. Otherwise it only returns once the remote
party accepted or rejected the call.
Even in the case of CRING and CLIP being used, we should start a CLCC
poll. This is because we must still rely on polling CLCC to detect when
an incoming call has been terminated by the remote side.
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
AT+VTS responds with an OK immediately, so add a wait in the driver
before returning so that core knows when the tone has finished. Note
that some modems actually do wait against 27.007, and other modems
use a manufacturer specific AT command and the drivers will need to
handle accordingly.