sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity
6,223 Commits 12 Branches 0 Tags 8.9 MiB
Commit Graph

129 Commits

Author SHA1 Message Date
Denis Kenzior d218070689 stk: find_atom only returns registered atoms 
This seems to be an oversight from an earlier refactoring.
 2012-01-18 12:58:20 -06:00
Denis Kenzior ae14a3056a stk: Use __ofono_atom_find 2012-01-18 12:50:55 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Denis Kenzior c8131fb10e stk: Fix crashes 2011-08-14 22:56:45 -05:00
Denis Kenzior 968efe08ba stk: Fix missing break statement 2011-07-25 22:59:06 -05:00
Denis Kenzior 55279f16c2 stk: Make sure to set cancel_cmd 
For handled commands, in case the terminal response is not reported by
the modem, we must set the cancel_cmd variable so the command is
canceled properly.

This patch also modifies the behavior so that pending_cmd is freed,
since stk_proactive_command_cancel expects cancel_cmd to be set if
pending_cmd is not NULL.
 2011-07-25 22:45:55 -05:00
Denis Kenzior bb59d39539 stk: Remove code that does nothing 2011-07-25 22:25:05 -05:00
Denis Kenzior 0c42430f2b stk: Fix possible crash 
We can't call stk_command_free on a NULL object
 2011-07-25 22:21:46 -05:00
Jeevaka Badrappan f837bdc90a stk: Handle set up call in handled_notify 2011-07-25 21:44:55 -05:00
Jeevaka Badrappan 213d70dca3 stk: Fix crash seen in stk_alpha_id_unset 
If there is no default agent, then current agent also will
be NULL. So, call stk_agent_request_cancel only when there is a valid
current agent.
 2011-07-15 11:35:13 -05:00
Andrzej Zaborowski 045ac8cf94 stk: Use the right command pointer 2011-07-06 04:14:47 -05:00
Denis Kenzior cdb98a70d0 stk: Cancel pending DTMF tones if session is ended 
The Send DTMF command is special in its use of DisplayAction method of
STK agent.  This allows the user to send a 'User Terminated Session'
response to the SIM.  If the user performs this action, then any pending
DTMFs should also be canceled as soon as possible.
 2011-05-31 23:31:41 -05:00
Philippe Nunes 4c2d897614 stk: simplify respond_on_exit flag handling 
respond_on_exit flag is set by commands which are dispatched to the
agent, so that if the agent exits prematurely, a 'User Terminated
Session' response is sent to the SIM.

There were a couple of corner cases not quite handled correctly:

- During Set Up Call, if the user confirmation phase succeeded and the
  call was dispatched to voicecall atom successfully, and the agent
  exited at this point, then no terminal response would be sent until
  the call succeeded / failed.  Now the agent termination results in an
  'User Terminated Session' response being sent immediately, but the
  call setup proceeding.
 2011-05-31 18:43:04 -05:00
Denis Kenzior 8900cf81a6 stk: No more need to use get_registered 
__ofono_modem_find_atom returns only atoms that are registered now.
 2011-04-05 00:18:34 -05:00
Denis Kenzior 73b9e06c40 stk: Check for USSD atom before others 
For efficiency (and consistency) we should check for the USSD atom
before checking CallForwarding, CallBarring, and CallSettings atoms.
 2011-04-05 00:16:23 -05:00
Andrzej Zaborowski d77f0ff799 stk: Check if terminal is busy before SIM Refresh 2011-04-05 00:12:10 -05:00
Philippe Nunes 5ba49490c8 stk: Handle user termination for Send DTMF 2011-03-30 12:07:49 -05:00
Jeevaka Badrappan 8e6becc57e stk: Fix getenv failure case 2011-03-23 09:54:46 -05:00
Jeevaka Badrappan 7de1717d42 stk: fix issue with Get Inkey variable timeout 2011-03-16 21:36:11 -05:00
Andrzej Zaborowski 4b6d1b1878 stk: Handle Refresh if also performed by modem 2011-03-02 23:29:54 -06:00
Andrzej Zaborowski 2443cdef49 stk: Make sure to reset respond_on_exit 
This fixes a crash spotted by Lasse Kunnasluoto documented at
http://lists.ofono.org/pipermail/ofono/2011-February/009211.html
 2011-02-28 16:14:50 -06:00
Andrzej Zaborowski f7d4643cc5 stk: Partially handle Refresh command 
Only the four "NAA initialisation" modes are handled at the moment.
 2011-02-17 15:16:34 -06:00
Aki Niemi 7d389054ac stk: Fix style issues 2011-02-02 11:03:21 +02:00
Jeevaka Badrappan 0be9e23a90 stk: Fix issue in stk_alpha_id_set 
Fixes the crash seen with the null alpha identifier.
Also removed the icon check since the decision of whether to inform the
user of the action is dependent entirely on whether the alpha identifier
is provided by the UICC.
 2011-01-26 15:24:50 -06:00
Jeevaka Badrappan f49f0ad0cd stk: change timeout from 10 to 3mintues 2011-01-24 16:22:33 -06:00
Jeevaka Badrappan c81c88e311 stk: Handle Launch Browser proactive command 2011-01-20 10:01:24 -06:00
Jeevaka Badrappan 355fa67742 stk: make use of ADD_ERROR_RESULT macro 2011-01-12 16:05:37 -06:00
Jeevaka Badrappan e5bd00fd80 stk: add additional info for terminal busy result 
As per the ETSI TS 102 223 specification 8.12.2, it is
mandatory to provide additional information for the
general result "ME currently unable to process command".
 2011-01-12 16:04:29 -06:00
Jeevaka Badrappan b9ead5e736 stk: Remove unwanted error check 
Possible return values of  __ofono_voicecall_tone_send
are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL.
 2011-01-06 10:29:24 -08:00
Denis Kenzior 3c0a32c102 stk: Remove unneeded assignment 2010-12-27 15:09:03 -06:00
Jeevaka Badrappan 1e5d29012b stk: fix issue in set up menu handling 2010-12-27 15:06:08 -06:00
Andrzej Zaborowski c0d584d160 stk: Send the AlphaId's to agent 
Terminate session if return signature doesn't match but allow
agent to return from the call if it does match.
 2010-12-23 18:30:45 -06:00
Guillaume Lucas 6058c800df stk: fix issue to avoid null pointer for alpha_id 
If a SET UP CALL proactive command with no alpha identifier
occurs, the alpha_id pointer will be set to NULL. This will
generate a crash in the stkagent with dbus function. To avoid
this we use an empty string if the alpha identifier is not
present in the command.
 2010-12-10 11:18:06 -06:00
Denis Kenzior 772bee27d4 stk: No need to check for null text 
For Set up idle mode text
 2010-12-10 10:46:56 -06:00
Yang Gu 5713d5e19f stk: Handle provide local info proactive command 2010-12-08 07:58:24 -06:00
Guillaume Lucas 8b0307a621 stk: Add busy error for the display text command 
According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.
 2010-11-30 08:20:42 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:27:15 -06:00
Andrzej Zaborowski 3d1a4ec239 stk: use bigger timeout in DisplayText 
When the wait for user confirmation bit is set.
 2010-11-25 16:46:33 -06:00
Denis Kenzior 5774e9fa53 stk: Minor style fix 2010-11-23 03:08:56 -06:00
Andrzej Zaborowski 55e1ca2e1c stk: Handle null Text field 
Add a NULL check in dbus_apply_text_attributes because in some places
(like DisplayText handler) we call it without checking and we just check
the return value once.
 2010-11-23 03:08:51 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Andrzej Zaborowski 65159c2f0b stk: API for SMS Point-to-Point download to UICC 
The callback returns the TP-User-Data element content of the RP-ACK or
RP-ERROR message, returned by the UICC.
 2010-11-08 13:36:23 -06:00
Denis Kenzior 3436c58fac sms: Refactor __ofono_sms_txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 5c6144f359 stk: Handle Send SS in handled_notify 2010-10-28 10:37:05 -05:00
Denis Kenzior 51aecde6cc stk: Remove ofono_stk_terminal_response_sent_notify 
Not needed for now.  We can always put this back in later if need be.
 2010-10-27 12:10:17 -05:00
Andrzej Zaborowski 77c20d8a27 stk: Handle more commands in handled_notify 2010-10-27 12:00:42 -05:00
Denis Kenzior d9ad66ab38 stk: Default to general beep if no tone is provided 
According to section 6.6.5 of 102.223
 2010-10-25 17:42:41 -05:00
Andrzej Zaborowski b15bcb4a40 stk: Handle the Play Tone proactive command. 2010-10-25 17:23:12 -05:00
Andrzej Zaborowski 47c3b3f52a stk: Add duration_to_msecs to reduce duplication. 2010-10-25 17:21:23 -05:00
Denis Kenzior e4a0ba26a0 stk: Nitpick some newline issues 2010-10-22 22:39:56 -05:00