Jonas Bonn
3beeff758d
treewide: Remove superfluous use of _GNU_SOURCE
...
There are a large number of files in the tree that define _GNU_SOURCE
despite not actually using features hidden behind this flag. This patch
removes all these definitions in one fell swoop...
2018-10-17 10:01:57 -05:00
Jonas Bonn
67701b1c40
drivers: constify vtables
...
The driver vtables are read-only structures. This patch declares them as
'const' allowing the compiler to (optionally) put them in the RELRO
section. RELRO pages may be marked as read-only by the linker after
the relocations have been done ensuring that they aren't inadvertently
or maliciously altered at runtime.
2018-10-17 09:56:27 -05:00
Bob Ham
1ebae47777
atmodem: Don't set AT+COLP=1 on SIMCom modems
...
On the SIMCom SIM7100E, setting AT+COLP=1 causes there to be no
response at all from "ATD...;" commands until the call is answered.
The results in oFono stalling rather than creating a new VoiceCall
object.
We fix this by adding SIMCOM to the list of vendors for whom we set
AT+COLP=0 rather than AT+COLP=1.
2018-05-14 11:11:14 -05:00
John Ernberg
6a07d059d1
atmodem: use g_slist_free_full
2016-04-22 15:20:11 -05:00
Denis Kenzior
0026ae3fb7
atmodem: Update parse_clcc utility function
2013-09-12 13:17:39 -05:00
Denis Kenzior
ebac438d93
voicecall: Fix strange GTA04 modem CLCC behavior
2012-03-06 10:12:31 -06:00
Marcel Holtmann
9e26e29f8d
atmodem: Add call state polling for Qualcomm MSM based modems
...
The voice call support of the Qualcomm MSM based modems does not report
NO CARRIER, NO ANSWER or BUSY unsolicited notifications. So keep polling
for call state changes via AT+CLCC even during an active call.
2012-01-06 14:08:35 -08:00
Marcel Holtmann
02cbee4955
atmodem: Disable AT+COLP for Qualcomm MSM based modems
...
In case of Qualcomm MSM based modems, AT+COLP=0 needs to be used to make
ATD<number>; return right away. Otherwise it only returns once the remote
party accepted or rejected the call.
2012-01-06 14:05:59 -08:00
Marcel Holtmann
4e77afffb3
drivers: Update copyright information
2011-10-10 13:39:48 -07:00
Denis Kenzior
266501b7f4
voicecall: Fix minor whitespace issue
2011-08-09 12:55:45 -05:00
Denis Kenzior
0f147e1cd5
voicecall: Minor nitpicks to previous commit
2011-03-11 13:50:31 -06:00
Andras Domokos
3370b45477
atmodem: implement SSN handling
2011-03-11 13:50:31 -06:00
Jeevaka Badrappan
4534b1c328
atmodem: M16 coding style fix
2011-02-05 07:04:02 -08:00
Jeevaka Badrappan
b9d24fc016
atmodem: use defined call_status enum
2011-02-05 05:07:18 -08:00
Lucas De Marchi
730891328c
atmodem: use ofono_call initializer
2011-02-01 18:31:02 +01:00
Jeevaka Badrappan
4258fb5915
atmodem: remove NULL check
2011-01-29 18:39:37 +01:00
Jeevaka Badrappan
12c3cf6969
voicecall: remove ofono_cug_option
2011-01-26 16:38:15 -06:00
Denis Kenzior
16929cc978
voicecall: Be more explicit when copying structs
2011-01-18 16:09:28 -06:00
Lucas De Marchi
2c79277073
atmodem: add cdip to voicecall
2011-01-18 16:09:28 -06:00
Jeevaka Badrappan
b97676acc3
atmodem: M15 coding style fix
2011-01-12 08:06:58 -08:00
Denis Kenzior
b68fb125b8
atmodem: Always poll clcc, even if cring + clip
...
Even in the case of CRING and CLIP being used, we should start a CLCC
poll. This is because we must still rely on polling CLCC to detect when
an incoming call has been terminated by the remote side.
2010-12-16 18:40:19 -06:00
Denis Kenzior
3254e5e99f
atmodem: Fix reporting of CLIP
...
When RING & CLCC polling is used, the CLIP will not be reported
correctly if the CLIP: notification does not arrive
2010-12-16 18:40:19 -06:00
Denis Kenzior
0597b3501a
atmodem: Do not re-parse CLIP / CNAP
...
These needs to be parsed once and not parsed unnecessarily once the
information has been recorded
2010-12-16 18:40:19 -06:00
Denis Kenzior
a1bf26f15d
atmodem: Set cnap validity to not provided
2010-12-16 18:40:19 -06:00
Gustavo F. Padovan
f28f0b3dea
atmodem: Add CNAP parsing to voicecall
2010-12-16 18:40:18 -06:00
Gustavo F. Padovan
5ca42255c5
atmodem: use macros for CLIP validity
2010-12-10 12:59:26 -06:00
Gustavo F. Padovan
169651314e
atmodem: fix DBG message
2010-12-02 08:15:04 -06:00
Lucas De Marchi
b82a7f8511
drivers: explicitly compare pointers to NULL
...
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/ )
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Andrzej Zaborowski
9e46e27932
atmodem: Delay return from send_dtmf
...
AT+VTS responds with an OK immediately, so add a wait in the driver
before returning so that core knows when the tone has finished. Note
that some modems actually do wait against 27.007, and other modems
use a manufacturer specific AT command and the drivers will need to
handle accordingly.
2010-10-22 22:28:50 -05:00
Marcel Holtmann
4cacd3a76c
atmodem: Send DTMF commands without quotes
...
The AT+VTS command takes a single character and should not use quotes.
2010-10-13 08:25:59 +03:00
Marcel Holtmann
590e154734
atmodem: Remove quirk for Huawei voice call support
...
The Huawei voice call support has its own driver now. So this quirk
is no longer needed.
2010-09-29 08:32:23 +09:00
Marcel Holtmann
6fbbd4ca3e
atmodem: Some cleanups in voice call driver
2010-09-27 08:07:02 +09:00
Denis Kenzior
09c0ae8478
atmodem: Update comment
2010-09-24 00:18:40 -05:00
Lucas De Marchi
74125ff5d4
Fix common misspellings in drivers
...
Fix common misspellings by using the list available at
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
From the list cited above, the substitution script found the following
misspellings:
subsidary(-ies)->subsidiary(-ies)
transfering->transferring
2010-09-14 16:00:16 +09:00
Marcel Holtmann
a0fe9cbdbd
atmodem: Add Huawei quirk for voice call handling
2010-09-04 23:44:30 +02:00
Denis Kenzior
bdc8d02bc8
atmodem: Default to +CHUP to hangup_all
2010-08-20 16:15:11 -05:00
Marcel Holtmann
a8d3e7433a
atmodem: Remove useless NULL checks before g_free
2010-08-16 22:02:01 +02:00
Denis Kenzior
ac524be99f
atmodem: Use g_at_chat_clone
2010-08-12 16:40:40 -05:00
Sjur Brændeland
dde0a4ccb5
voicecall: Rename hangup to hangup_active
2010-08-12 11:32:12 -05:00
Denis Kenzior
c98b951fe6
Refactor: Remove atutil dump_response
...
No longer needed now that we have nice AT command tracing using
OFONO_AT_DEBUG=1
2010-02-08 12:28:23 -06:00
Denis Kenzior
7f9a9b0cdc
Fix: Don't use ofono_debug directly in plugins
2010-02-08 12:09:01 -06:00
Denis Kenzior
1721f81fe9
Fix: Use snprintf instead of sprintf in atmodem
2010-02-05 11:59:24 -06:00
Denis Kenzior
d3c2535fae
Fix: Dead Assignments
2010-02-04 00:14:49 -06:00
Marcel Holtmann
144080e749
Update copyright information
2010-01-01 17:00:10 -08:00
Denis Kenzior
2297bc926d
Style: Fix some remaining style issues in atmodem
2009-12-09 02:46:33 -06:00
Zhenhua Zhang
62df556f28
Fix release clcc_source when voicecall is removed
...
Release the timer to avoid invoking the callback function after
voicecall driver is removed.
2009-12-04 16:52:32 -06:00
Denis Kenzior
0fbaed38aa
Refactor: Run CLCC when initializing
...
When voicecall atom is initialized, we should run a CLCC query to
populate our call list. This also notifies the core of the new calls
2009-12-04 16:52:31 -06:00
Denis Kenzior
770586bfb7
Update atmodem voicecall driver to new world order
2009-12-04 16:52:31 -06:00
Denis Kenzior
7fa99301a0
Fix: Style
2009-12-04 16:52:31 -06:00
Denis Kenzior
bfc9eb302f
Fix: Ignore repeated CCWAs in atmodem as well
2009-11-16 10:17:12 -06:00