Commit Graph

60 Commits

Author SHA1 Message Date
Jonas Bonn 3beeff758d treewide: Remove superfluous use of _GNU_SOURCE
There are a large number of files in the tree that define _GNU_SOURCE
despite not actually using features hidden behind this flag.  This patch
removes all these definitions in one fell swoop...
2018-10-17 10:01:57 -05:00
Jonas Bonn 67701b1c40 drivers: constify vtables
The driver vtables are read-only structures.  This patch declares them as
'const' allowing the compiler to (optionally) put them in the RELRO
section.  RELRO pages may be marked as read-only by the linker after
the relocations have been done ensuring that they aren't inadvertently
or maliciously altered at runtime.
2018-10-17 09:56:27 -05:00
Kuba Pawlak 2d80a04a05 drivers/isimodem: fix GCC 6.0 errors
-Werror=misleading-indentation
2016-04-18 09:52:56 -05:00
Denis Kenzior bddfb9bfc5 isimodem: Fix style issues in previous commit 2012-09-11 23:30:25 -05:00
Jarko Poutiainen dc2dc41bcf isimodem: voicecall answer fix for Nemo on N9
Voicecall answering in Mer/Nemomobile run on Nokia N9 will fail
unless call id is passed to modem.
2012-09-11 23:29:43 -05:00
Syam Sidhardhan 31db8836a6 isimodem: Remove extra bogus semicolon 2011-12-28 16:00:39 -06:00
Marcel Holtmann 4e77afffb3 drivers: Update copyright information 2011-10-10 13:39:48 -07:00
Arun Ravindran 870905a62a isimodem: Improper handling of missed call 2011-06-14 11:27:13 +03:00
Pekka Pessi 60918dd3f2 isimodem: fix call_create_resp handling
In case of call creation failure modem may return a valid call id in
order to send CALL_SERVICE_DENIED_IND which we do not handle.

Fixes MeeGo bug#15855.
2011-04-12 20:39:19 +03:00
Aki Niemi b62a01eae4 isimodem: Remove split voicecall driver
Only a single driver created, with two clients checked for
reachability in parallel.
2011-04-12 20:39:18 +03:00
Aki Niemi e17da972e2 isimodem: Rename resource debug macro 2011-04-12 20:39:18 +03:00
Arun Ravindran b8b03a2da6 isimodem: Fix hangup for hold initiated calls 2011-04-07 11:01:29 +03:00
Arun Ravindran c2b3d39566 isimodem: Fix false reporting of active call state 2011-04-07 10:59:18 +03:00
Mika Liljeberg c9a5b5143c isimodem: remove atoms that fail to probe 2011-03-31 10:22:22 -05:00
Denis Kenzior 35478aedf6 voicecall: Move notification_ind registration
Should be before ofono_voicecall_register to be consistent
2011-03-11 13:50:31 -06:00
Denis Kenzior a033b13388 voicecall: Remove pointless whitespace 2011-03-11 13:50:31 -06:00
Andras Domokos 912b128b97 isimodem: implement SSN handling 2011-03-11 13:50:31 -06:00
Aki Niemi 70ae70a74f isimodem: Remove empty line in voicecall driver 2011-03-03 17:43:30 +02:00
Aki Niemi 0e27a9bbae isimodem: Split voicecall into two drivers
These drivers share most of the modem ops, though, so they are still
in the same source file.
2011-03-03 17:43:29 +02:00
Jessica Nilsson cbf6713ed1 isimodem: wgmodem2.5 added to voicecall 2011-03-03 17:43:29 +02:00
Antoine Reversat 48388ae7d7 isi: Add CNAP support for isimodem 2011-02-25 14:21:11 -06:00
Antoine Reversat 257951a25f isi: Clean up isi_call_any_address_sb_proc 2011-02-25 14:21:07 -06:00
Pekka Pessi 1715ce85cb isimodem: fix problems in call state reporting
Do not report early incoming calls.

Report "disconnected" state separately.

Call ofono_voicecall_disconnected() only after call id is released.
2011-02-03 14:59:53 +02:00
Lucas De Marchi 51159b7610 drivers: fix misspellings 2011-02-01 18:37:34 +01:00
Lucas De Marchi 0ca07330f4 isimodem: use ofono_call initializer 2011-02-01 18:31:43 +01:00
Jeevaka Badrappan 12c3cf6969 voicecall: remove ofono_cug_option 2011-01-26 16:38:15 -06:00
Kai Vehmanen 0a5ef0a9c8 isimodem: fix sending DTMF
isi_call_dtmf_send_resp() handles the success case incorrectly, and
thus all send_tones attempts fail with bogus error codes.
2011-01-21 15:19:52 +02:00
Jeevaka Badrappan 2a7fa4de4e isimodem: fix issue with user busy release
when the user rejects the incoming call, hangup_active
will get called on the driver side whereas when the user
rejects the waiting call, set_udub will get called on the
driver side.
2011-01-21 15:18:40 +02:00
Pekka Pessi 6d23cd1957 isimodem: fix return from call control requests 2011-01-12 08:09:09 -08:00
Jeevaka Badrappan 9af25bceac isimodem: M15 coding style fix 2011-01-12 08:06:58 -08:00
Pekka Pessi e0b6a058a2 isimodem: use simplified client interface 2011-01-07 13:39:18 +02:00
Pekka Pessi e130d21be9 isimodem: fix style issues 2011-01-07 13:32:27 +02:00
Aki Niemi 98074fdb60 isimodem: Always compare to NULL explicitly 2010-12-22 17:13:48 +02:00
Aki Niemi 346ee5b051 isimodem: Adapt and refactor voicecall driver 2010-12-22 17:13:47 +02:00
Pekka Pessi a67c5cf4c5 isi/voicecall: fix handling of waiting calls
Also, do not retrieve calls after isi_release_all_active() because
retrieving is now only an unwanted side-effect .
2010-12-03 14:52:40 +02:00
Pekka Pessi be2778cb99 isi/voicecall: avoid side-effects of release
If a call was held automatically when an another call was dialed or
answered, it gets retrieved when the other call is released unless
auto change features is explicitly disabled.

Drop cause_type parameter because it is never used.

Use cause code for busy when releasing incoming or waiting calls.
2010-12-03 14:52:33 +02:00
Pekka Pessi eb3af79700 isi/voicecall: add call id to queued requests 2010-12-03 14:51:40 +02:00
Pekka Pessi fe28e6cd05 isi/voicecall: fix status reporting
Do not report incoming calls to the oFono core until they can be
answered.

Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(),
TERMINATED calls via ofono_voicecall_disconnected().
2010-12-03 14:50:05 +02:00
Lucas De Marchi b82a7f8511 drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Pekka Pessi f3c75c9285 isi/voicecall: release COMING calls with BUSY cause
Very early incoming calls were not released with BUSY cause.
2010-11-22 08:19:38 -06:00
Pekka Pessi 6861510e5e isi: fix hangup_active and set_udub methods
The concept of "active" call seems to be overloaded.
2010-10-20 12:52:44 -05:00
Aki Niemi 255782f8c2 isimodem: Fix request cleanup code
Adds a check for when the driver is being removed, in which case no
new ISI requests should be generated.
2010-10-19 15:06:35 +03:00
Aki Niemi 297b14ca8b isimodem: Fix copyright and license boilerplate 2010-10-14 15:22:16 +03:00
Pekka Pessi a5e13cb049 isimodem/voicecall: fix hangup_active 2010-10-06 12:07:27 +02:00
Sjur Brændeland dde0a4ccb5 voicecall: Rename hangup to hangup_active 2010-08-12 11:32:12 -05:00
Denis Kenzior a7d02fbf5c isimodem: More cleanup of bad style 2010-05-27 14:15:30 -05:00
Pekka Pessi 48041a0e60 Fixed style issues in isimodem voicecall. 2010-05-27 14:04:32 -05:00
Pekka Pessi 654c0ef73b Eliminated bool, true and false from isimodem. 2010-05-27 13:41:51 -05:00
Aki Niemi 85df7a952a Clean up style issues 2010-01-14 10:32:56 +02:00
Aki Niemi b412c1b3e7 Refactor voicecall driver 2010-01-11 10:51:01 +02:00