Commit Graph

56 Commits

Author SHA1 Message Date
Alfonso Sanchez-Beato 1b3302322a message-waiting: Fix reading EF_MWIS records 2015-07-16 20:22:38 -05:00
Alfonso Sanchez-Beato cd76f913f0 message-waiting: Update properly EF_MWIS SIM file 2015-07-16 20:17:27 -05:00
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector.
2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Denis Kenzior 3757fe01f2 message-waiting: Use __ofono_atom_find macro 2012-01-18 12:21:33 -06:00
Denis Kenzior 40db3b9528 message-waiting: Use new API for CPHS MBDN 2011-12-16 16:10:21 -06:00
Marcel Holtmann 7e6afe37bf core: Update copyright information 2011-10-10 13:39:42 -07:00
Frédéric Danis a79546eaf4 message-waiting: API to retrieve voicemail number 2011-06-21 12:07:23 -05:00
Andrzej Zaborowski 2211583953 message-waiting: Watch for sim file refreshes 2011-03-15 20:55:51 -05:00
Denis Kenzior 3f798c4741 core: Minor style tweaks 2011-02-03 13:15:29 -06:00
Andrzej Zaborowski a7a0cb1ed0 simfs: implement ofono_sim_context api 2011-02-03 13:13:37 -06:00
Aki Niemi 5d0f67e786 message-waiting: Fix indentation 2011-02-02 11:03:21 +02:00
Pekka Pessi 579a1ebef3 message-waiting: check for NULL argument 2011-01-26 16:47:15 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Jeevaka Badrappan 4196182770 Fix multi-line comment style issues 2010-09-21 21:16:01 -05:00
Denis Kenzior bbfd7db3cc Move mwi interface definition to dbus.h 2010-03-22 15:31:03 -05:00
Denis Kenzior 87ca1b0c8f Fix: Don't use ofono_debug directly in the core
Use DBG macro which is integrated with the new debug framework.
2010-02-08 11:54:03 -06:00
Denis Kenzior 506eb11b02 Make setting CPHS MWIS actually work 2010-01-12 18:20:51 -06:00
Denis Kenzior bb0dfd9b6d Fix: Make the CPHS MWIS version actually work 2010-01-12 17:54:18 -06:00
Denis Kenzior 0fb3873e6d Refactor: Move copy-pasted code into a function 2010-01-12 17:53:56 -06:00
Denis Kenzior 5206f9a9dc Fix: Refactor error conditions 2010-01-12 15:57:23 -06:00
Denis Kenzior deb9d88669 Reorder CPHS initializatin order
Two issues
  - CPHS MWIS file must always be read, the specification isn't clear
    whether it depends on the Mailbox service to be available
  - CPHS MBDN file must be read after we read EFmbdn, otherwise it will
    not be processed properly
2010-01-12 15:55:19 -06:00
Denis Kenzior 0d7f8933ff Fix: Create a dedicated callback for syncs
When synchronizing CPHS MBDN, create a separate callback that doesn't
try to emit signals, etc since the main work has already been done when
EFmbdn was set successfully.
2010-01-12 15:53:19 -06:00
Denis Kenzior 476bd84b98 Remove #if 0 2010-01-12 15:51:28 -06:00
Denis Kenzior e9b40dbe7a Fix: Don't recurse infinitely
We try to keep the CPHS MBDN elementary file in sync with EFmbdn,
unfortunately we share the same callback, which leads to infinite
recursive writes.

Also cleanup the set_mbdn_request structure if the write fails.
2010-01-12 15:45:30 -06:00
Denis Kenzior 0382f64353 Refactor: Rename & Restructure cphs_support
- Rename to cphs_service_table to be more inline with the specification.
- Since the spec allows arbitrary length service tables, use an unsigned
  char * return instead of a short.
- Use bit_field function instead of defining an enum
2010-01-12 11:27:31 -06:00
Andrzej Zaborowski 96a93b5829 If EF-MWIS is not available use the CPHS version. 2010-01-12 11:12:41 -06:00
Andrzej Zaborowski f97d203392 Use CPHS version of mailbox numbers on SIM if 3GPP version not available.
Otherwise just try to keep the CPHS version of the files in sync.
2010-01-12 11:12:01 -06:00
Marcel Holtmann 144080e749 Update copyright information 2010-01-01 17:00:10 -08:00
Denis Kenzior be55ba4ab3 Refactor: Move elementary file type checking
Every single EF read callback checks the file type reported out of the
SIM is what it expects.  Instead this should be done in one place and
the errors reported accordingly
2009-10-02 18:25:56 -05:00
Denis Kenzior 6914b11269 Assume cbs is registered after sim ready 2009-09-22 00:07:06 -05:00
Andrzej Zaborowski ac5603d225 Fix generation of Message Waiting PropertyChanged signals. 2009-09-10 16:29:55 -05:00
Andrzej Zaborowski a82c567f0c Fix parsing of Enhanced Voicemail notifications. 2009-09-10 16:29:55 -05:00
Andrzej Zaborowski f21930f04e Decode and encode alpha-identifier fields
Add identifier argument to sim_adn_parse and sim_adn_build.

Also fix the number length passed to extract_bcd_number in sim_adn_parse.
2009-08-31 15:12:37 -05:00
Denis Kenzior b8589c7cdf Fix unused variable modem 2009-08-20 15:39:13 -05:00
Denis Kenzior 99cf14efcf Refine errors returned by message-waiting
If we have not initialized fully yet, return sim_not_ready error.
If we couldn't read EFmbi or not able to stat EFmbdn size properly, then
set mbdn_not_present to TRUE and always return not_supported error
2009-08-19 18:35:07 -05:00
Denis Kenzior 5999b418e8 Evolve message waiting low level API 2009-08-19 18:35:07 -05:00
Denis Kenzior 2bf3e20d48 Update message waiting to the new SIM API 2009-08-19 18:35:06 -05:00
Denis Kenzior 89effa1723 Squash warning 2009-08-06 15:42:22 -05:00
Denis Kenzior d6c58caadc Squash warning 2009-08-06 15:42:22 -05:00
Denis Kenzior ee2a88c678 Squash warning 2009-08-06 15:42:22 -05:00
Andrzej Zaborowski d0b91bfbc8 Attempt to update MBDN based on Enhanced VM IEI 2009-08-05 13:33:35 -05:00
Andrzej Zaborowski 9a55de9cd0 Implement committing the EF-MBDN records to SIM 2009-08-05 13:32:49 -05:00
Denis Kenzior 965fc09e6a Don't emit signals for unexposed properties
Signals shouldn't be emitted, but we should still track the information
so it can be written to the SIM reliably
2009-08-05 12:45:55 -05:00
Denis Kenzior fdc129e3e2 Make method async 2009-08-05 12:33:57 -05:00
Denis Kenzior b7c51f9028 Remove unused declaration 2009-08-05 12:33:01 -05:00
Denis Kenzior e117f3112a Refactor how mwis updates are done 2009-08-04 15:10:50 -05:00
Denis Kenzior c7d29c44a8 Name the callback properly 2009-08-04 15:10:50 -05:00