Commit Graph

4636 Commits

Author SHA1 Message Date
Denis Kenzior 3a7164c0e7 Fix memory leak 2009-06-12 19:40:51 -05:00
Denis Kenzior 3c27dae5e8 Fixup style issues with previous MCC/MNC patch
- Breakup MCC/MNC LENGTH constant
- Don't hardcode numbers
- Fix >80 column length
- Fix test case to expect strings instead of shorts
2009-06-12 19:33:55 -05:00
Aki Niemi ba8828c095 Change MNC and MCC variable types to string
This is to make sure both 2 and 3-digit MNC values are correctly
handled. Both the modem plugin API as well as the D-Bus API are
affected.
2009-06-12 11:01:19 -05:00
Denis Kenzior 683b00de1b Fix another pointer cast to use GINT_TO_POINTER 2009-06-11 23:45:04 -05:00
Denis Kenzior 618cebe6c2 Add additional sanity check 2009-06-11 23:45:03 -05:00
Denis Kenzior 370318109c Make SMS UDH iterators const-correct 2009-06-11 23:45:01 -05:00
Rémi Denis-Courmont 0661810b01 Phonet/ISI client helper
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
2009-06-11 21:50:10 +03:00
Rémi Denis-Courmont 667655df79 Phonet datagram socket helpers
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
2009-06-11 21:50:09 +03:00
Rémi Denis-Courmont 8e79f89046 Phonet Netlink helpers
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
2009-06-11 21:50:09 +03:00
Rémi Denis-Courmont 4b9b46d25a Check for restrict keyword
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
2009-06-11 21:50:09 +03:00
Rémi Denis-Courmont 0774878772 configure: set compiler flags at the end
This fixes interferences with warning-unsafe autoconf macros.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
2009-06-11 21:50:09 +03:00
Denis Kenzior 50b9a3f375 Fix for multiparty_hangup
Due to the use of an invalid structure, release_all_active was being
called instead of release_all_held
2009-06-11 10:44:53 -05:00
Denis Kenzior f5f7fafc41 Fix typo 2009-06-11 10:44:51 -05:00
Denis Kenzior 621a99bcc7 Add TP-PID enumeration 2009-06-11 10:44:49 -05:00
Denis Kenzior 2222e1e38d Additional fixes to multiline responses
The previous fix did not take into account the logic in have_line
function, which takes care of certain modems that do not prefix
their responses by <cr><lf> at all.  This fix should take both
into consideration
2009-06-08 22:45:03 -05:00
Denis Kenzior fafdda30b9 Fix multiline responses in GAtChat
The standard is a bit fuzzy on how multiline responses are returned
GAtChat assumed that they will always start with <cr><lf>, however
this doesn't seem to be correct.  Add a new state which is entered
when a response is obtained.  If <cr> is encountered, then it
is processed regularly, otherwise the parser assumes that the
next line is part of the multiline response
2009-06-08 14:08:18 -05:00
Denis Kenzior f9f3080781 Add utility for parsing MWI SMS DCS types 2009-06-05 19:58:52 -05:00
Denis Kenzior 219a94a502 Only USSD needs the special <cr> handling
Apparently all Cell Broadcasts are always 88 bytes long, with a
6 byte header and 82 byte payload.  <cr> character is used as a
terminator and padding for the unused payload
2009-06-05 19:58:27 -05:00
Denis Kenzior 86f5712c27 Fixup header 2009-06-05 19:58:16 -05:00
Denis Kenzior ffb377d00d Reorder the header file a bit 2009-06-05 19:58:14 -05:00
Denis Kenzior bc6165ea8e Rename ud_len_in_octets to sms_udl_in_bytes 2009-06-05 19:58:11 -05:00
Denis Kenzior 5846688988 Rename sms utilities properly
Rename encode_sms to sms_encode
Rename decode_sms to sms_decode
2009-06-05 19:58:09 -05:00
Denis Kenzior 4f0c149162 Add SMS specific DCS decoding function 2009-06-05 19:58:06 -05:00
Denis Kenzior 41071737d0 Add utility to convert SCTS to local/remote time 2009-06-05 19:57:40 -05:00
Denis Kenzior b149dc166c Add proper handling for various messages
Handle Deliver / Status Report / Cell Broadcast messages and send the
appropriate acknowledgement PDUs (+CNMA) if required
2009-06-05 19:57:37 -05:00
Denis Kenzior f09683fc89 SMS-Command is also submitted with sc address 2009-06-05 19:57:03 -05:00
Denis Kenzior 973b33f47e Add colons to SMS prefixes 2009-06-05 19:57:01 -05:00
Denis Kenzior 3dcd15a4d8 Add SMS interface initialization code for atmodem 2009-06-03 21:08:47 -05:00
Denis Kenzior 6093b9b438 Add check for error path 2009-06-03 21:08:44 -05:00
Denis Kenzior 44bed555a5 Add check for error path 2009-06-03 21:08:41 -05:00
Denis Kenzior 7470393da7 Add UDH Iterator unit test 2009-06-03 21:08:39 -05:00
Denis Kenzior 0fbf2acb9d Break out VPF printing into separate function 2009-06-03 21:08:37 -05:00
Denis Kenzior 5e95802699 Add User-Data-Header iterator utilities 2009-06-03 21:08:35 -05:00
Denis Kenzior 356853983e Unit test for SMS-Submit encoding 2009-06-03 21:08:33 -05:00
Denis Kenzior 8a8dfced91 Calculation for UCS2 cases was wrong 2009-06-03 21:08:26 -05:00
Minjun Li e387488f02 Adding common unregister code in atmodem driver
Modem cleanup happens in two places: manager_free (ofono exit) and
manager_destroy (manually removing a specific modem).  Both need
to unregister the entire set of registered interfaces.

manager_destroy function did not unregister all interfaces.  Fixed
by adding a common function for both code paths.
2009-06-02 21:36:20 -05:00
Denis Kenzior 2271bca985 Squash another uninitialized warning
GCC detects that next_octet only sets oct if successful.  However,
we've already checked the length, so it should always succeed.
2009-06-01 14:05:50 -05:00
Denis Kenzior 05588ca59e Squash another uninitialized warning
GCC is smart enough to detect that oct is only set if the next_octet
function succeeds.  However, we've already checked that buf is big
enough, so it should always succeed.  Still, lets keep gcc happy
2009-06-01 14:05:48 -05:00
Denis Kenzior d0a569b9c0 Squish another uninitialized warning in CB 2009-06-01 14:05:45 -05:00
Denis Kenzior 7995258761 Squish another uninitialized warning 2009-06-01 14:05:43 -05:00
Denis Kenzior dc17c86a19 Change int type to enum for SS control callbacks 2009-06-01 14:05:41 -05:00
Denis Kenzior 8c75a0cdf1 Squash another uninitialized value warning 2009-06-01 14:05:39 -05:00
Denis Kenzior 373bf7e6bf Forgot this for SMS driver 2009-06-01 14:05:36 -05:00
Denis Kenzior 4f554c2cb7 Forgot to add this 2009-06-01 14:05:33 -05:00
Denis Kenzior e8421eea63 Add atmodem driver implementation for SMS 2009-05-29 18:37:44 -05:00
Denis Kenzior d6733e0746 Add basic skeleton for SmsManager interface 2009-05-29 18:37:41 -05:00
Denis Kenzior 5a4d750414 Do not use empty prefixes 2009-05-29 18:37:39 -05:00
Denis Kenzior 6fdc96cb73 Remove unnecessary define 2009-05-29 18:37:36 -05:00
Denis Kenzior 908670af5a Mention Minjun's contribution 2009-05-28 20:47:04 -05:00
Denis Kenzior bab9cd1f4c Remove unused function 2009-05-28 20:45:27 -05:00