Commit Graph

21 Commits

Author SHA1 Message Date
Lucas De Marchi b82a7f8511 drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Rémi Denis-Courmont 44c6918081 ste: Remove stray newlines in messages sent to log 2010-11-26 13:49:19 -06:00
Sjur Brændeland 2f9af8c105 stemodem: Fix for error handling, memleak and changed some defines
* renamed MAX_LEN to IP_ADDR_LEN
* removed memory leak from unneeded strdup when parsing xml response.
* better handling of AT error responses
* reduced number of caif interfaces to 4
2010-11-13 10:30:43 +09:00
Marcel Holtmann 1b920e4b57 stemodem: Fix broken coding style 2010-10-30 19:09:59 +02:00
Marcel Holtmann de221f87fa stemodem: Remove useless NULL checks before g_free 2010-08-16 22:11:21 +02:00
Denis Kenzior 361773f4d8 stemodem: Use g_at_chat_clone 2010-08-12 23:44:07 -05:00
Denis Kenzior 71d309ab50 stemodem: Fix minor whitespace issue 2010-08-12 23:41:19 -05:00
Sjur Brændeland 5a935a43fd stedriver: remove unsupported CAIF socket ioctls 2010-08-12 11:32:12 -05:00
Denis Kenzior c98b951fe6 Refactor: Remove atutil dump_response
No longer needed now that we have nice AT command tracing using
OFONO_AT_DEBUG=1
2010-02-08 12:28:23 -06:00
Denis Kenzior 7f9a9b0cdc Fix: Don't use ofono_debug directly in plugins 2010-02-08 12:09:01 -06:00
Denis Kenzior bfeef21a9d Fix: Send *EIAAUW after CGDCONT for STE and MBM
Otherwise the EIAAUW might fail.
2010-02-05 12:20:45 -06:00
Denis Kenzior ced9692361 Fix: Use snprintf instead of sprintf in stemodem 2010-02-05 12:01:13 -06:00
Denis Kenzior 7b2b548d8d Fix: Update copyright notice for 2010 2010-01-28 15:08:24 -06:00
Denis Kenzior 5e94e2bad8 Fix: Remove username/password elements
The reason for this is twofold.  First the current code actually leaks
memory since it uses g_strdup on username/password and never frees it
anywhere.  Second the username/password command can just be sent inside
activate_primary, no reason to do it in the callback.

The fix removes the username / password structure members and moves the
AT*EIAAUW handling to activate_primary.  This is almost exactly like the
username / password / context definition for MBM modems.
2010-01-27 13:59:05 -06:00
Denis Kenzior dda8b972ba Style: Couple more fixes 2010-01-27 13:46:12 -06:00
Denis Kenzior b52a6e60c7 Fix: Remove pointless error labels 2010-01-27 12:57:16 -06:00
Denis Kenzior 8e07c9c5d8 Style: Various indentation and spacing issues 2010-01-27 12:53:49 -06:00
Denis Kenzior 083e448fa5 Style: No space after function name 2010-01-27 12:41:49 -06:00
Denis Kenzior 09afdaa19e Style: Use proper comment formatting 2010-01-27 12:38:27 -06:00
Denis Kenzior 081c7a3138 Style: Don't use underscore 2010-01-27 12:33:11 -06:00
Sjur Brændeland b0106d1225 Add STE modem support for GPRS PDP Contexts 2010-01-27 12:16:43 -06:00