Commit Graph

27 Commits

Author SHA1 Message Date
Jonas Bonn 67701b1c40 drivers: constify vtables
The driver vtables are read-only structures.  This patch declares them as
'const' allowing the compiler to (optionally) put them in the RELRO
section.  RELRO pages may be marked as read-only by the linker after
the relocations have been done ensuring that they aren't inadvertently
or maliciously altered at runtime.
2018-10-17 09:56:27 -05:00
Marcel Holtmann 4e77afffb3 drivers: Update copyright information 2011-10-10 13:39:48 -07:00
Lucas De Marchi 0470319e72 calypsomodem: use ofono_call initializer 2011-02-01 18:31:11 +01:00
Jeevaka Badrappan b6331608c2 calypsomodem: remove NULL check 2011-01-29 18:39:37 +01:00
Jeevaka Badrappan 12c3cf6969 voicecall: remove ofono_cug_option 2011-01-26 16:38:15 -06:00
Marcel Holtmann 19b9ffdb44 calypso: Fix issue with name presentation and voice calls
The Calypso voice call driver uses an ofono_call object that is on the
stack. It is not automatically initilized to zero and thus causes to
have a name presentation that is not valid UTF-8. This in return makes
D-Bus fail and disconnect from the bus.

To fix this ensure that the ofono_call object is properly set to zero
first before populating it with values.
2011-01-21 13:07:04 +01:00
Jeevaka Badrappan bd782cfbf0 calypsomodem: M15 coding style fix 2011-01-12 08:06:58 -08:00
Lucas De Marchi b82a7f8511 drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Marcel Holtmann fcdd8b40b4 calypsomodem: Some cleanups in voice call driver 2010-09-27 08:11:04 +09:00
Denis Kenzior 01cfe43824 calypso: Provide hangup_all and hangup_active
On Calypso, ATH hangs up all calls except waiting calls and CHUP hangs
up only active calls, but not held or waiting.
2010-09-23 21:55:58 -05:00
Marcel Holtmann 70ce93a981 calypsomodem: Remove useless NULL checks before g_free 2010-08-16 22:12:08 +02:00
Denis Kenzior fa8f094a96 calypso: Use g_at_chat_clone 2010-08-12 23:34:44 -05:00
Sjur Brændeland dde0a4ccb5 voicecall: Rename hangup to hangup_active 2010-08-12 11:32:12 -05:00
Denis Kenzior 67c6a3a035 calypsomodem: dtmf chars do not need quotes 2010-07-15 09:41:04 -05:00
Denis Kenzior c98b951fe6 Refactor: Remove atutil dump_response
No longer needed now that we have nice AT command tracing using
OFONO_AT_DEBUG=1
2010-02-08 12:28:23 -06:00
Denis Kenzior 7f9a9b0cdc Fix: Don't use ofono_debug directly in plugins 2010-02-08 12:09:01 -06:00
Denis Kenzior 098bc04347 Fix: Use snprintf instead of sprintf in calypso 2010-02-05 12:01:27 -06:00
Marcel Holtmann 144080e749 Update copyright information 2010-01-01 17:00:10 -08:00
Denis Kenzior 3d3a9eee84 Get rid of list_calls in calypso driver 2009-12-04 16:52:31 -06:00
Denis Kenzior d91c61e621 Fix: None of this seems necessary for the Calypso 2009-11-26 07:44:25 -06:00
Denis Kenzior 6e0eb3cfd5 Fix: Change order of init commands
This seems to make the calypso return from ATD right away instead of
waiting for connect/busy to be returned.  It should now be possible to
hangup alerting calls.
2009-11-23 19:56:41 -06:00
Denis Kenzior ca025eb905 Fix: Make sure we don't gobble up unsolicited 2009-11-23 19:55:59 -06:00
Marcel Holtmann 5fe640858a Fix issue with missing masking of AT%CHLD
drivers/calypsomodem/voicecall.c: In function ‘calypso_release_specific’:
drivers/calypsomodem/voicecall.c:162: error: too few arguments for format
2009-11-13 04:33:29 +01:00
Denis Kenzior 72e0d2c578 Fix: On calypso use proprietory %CHLD=7X command 2009-11-12 19:16:32 -06:00
Denis Kenzior cbb36acee8 Rework DECLARE_FAILURE to be a bit nicer 2009-09-11 12:39:56 -05:00
Denis Kenzior d74d6c2e06 Fix unused variable warning 2009-09-04 20:37:50 -05:00
Denis Kenzior 7362878e6c Add calypso voicecalls driver 2009-09-04 20:37:50 -05:00