Commit Graph

1201 Commits

Author SHA1 Message Date
Denis Kenzior 6d91d84b28 sms: Tweak the logic to be more readable 2010-07-08 14:27:34 -05:00
Denis Kenzior db9b67e791 stk: Don't submit all pending envelopes at once 2010-07-08 14:27:34 -05:00
Denis Kenzior 5efd87fe63 stk: Fix copy / paste error 2010-07-08 14:27:34 -05:00
Denis Kenzior a6edf2c803 stk: Get rid of bin to hex converter
That much code for a debug message is pretty silly.  Perhaps an
ofono_debug_hexdump function is in order.
2010-07-08 14:27:34 -05:00
Denis Kenzior d2dc0480db stk: cancelled variable is not used 2010-07-08 14:27:34 -05:00
Andrzej Zaborowski bd33ab6a6f stk: Handle the Timer Management proactive command 2010-07-08 14:27:34 -05:00
Andrzej Zaborowski c0db55513d stk: Handle the Set Up Idle Text proactive command
This adds a SimToolkit dbus interface with just one property
(IdleModeText).
2010-07-08 14:27:34 -05:00
Andrzej Zaborowski 56d927b814 stk: Handle the Send SMS proactive command. 2010-07-08 14:27:34 -05:00
Andrzej Zaborowski 516a9b06c5 Add __ofono_sms_submit for other atoms to submit SMs. 2010-07-08 14:27:33 -05:00
Andrzej Zaborowski 6de5b7f5bb stkutil: Timer Value is conditional, not optional.
Make the parser check that the value is present when necessary,
so that stk.c doesn't have to check this.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski c451994139 sktutil: Use the Mandatory flag in parse_dataobj.
We need to look at the Mandatory flag and not at the Minimum flag
when parsing CTLVs.  The Minimum flag is important when encoding CTLVs
because CR bit is set according to it.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski de587870d2 stk: Handle ENVELOPEs in a queue, retry on sim busy.
Some envelope types need to be retried when sim reports busy status.
Then envelopes such as Event Download need to be returned in the
order of the event occurences, so need to be handled in a queue.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski 9d46dbc7a5 stk: Handle MoreTime command as a no-op 2010-07-08 14:27:33 -05:00
Andrzej Zaborowski cbdb7278ac stk: Utilities for proactive command/envelope handling. 2010-07-08 14:27:33 -05:00
Denis Kenzior e6d6f802a5 smsutil: Fix valgrind complaint
SMS cannot be split over GSM extension chars, however on the last
segment this code was causing us to overflow the buffer and resulted in
valgrind complaining.
2010-07-08 14:27:33 -05:00
Andrzej Zaborowski 365183d5a0 stkutil: Move scaddr field to gsm_sms 2010-07-02 14:13:45 -05:00
Denis Kenzior 20da18ca8b sms: Tweak the Bearer API 2010-06-25 17:49:36 -05:00
Denis Kenzior 8ff599c691 sms: Add support for SMS Bearer settings 2010-06-25 14:25:46 -05:00
Denis Kenzior f3e0e466c7 gprs: Fix to attachment race condition
Sometimes we get unsolicited attachment status before our query
finishes.  If the client is fast enough they can attempt to attach
and get the AttachInProgress error
2010-06-25 14:19:08 -05:00
Denis Kenzior 17de318c76 sms: minor style fix 2010-06-24 14:24:00 -05:00
Denis Kenzior 10e3ca440b sms: Don't bother setting SCA if we can't query 2010-06-24 14:13:04 -05:00
Andrzej Zaborowski 557f4cdb16 stkutil: Alpha Id is optional for Select Item. 2010-06-23 14:45:46 -05:00
Andrzej Zaborowski ab7f88233d stkutil: Refactor command parser error handling
When parsing the full command fails but Command Details has been parsed,
return a struct stk_command containing this information and the type of
parsing problem found.  We need the command details to be able to
even respond to the command.

This patch also makes the parser skip over unknown data objects found
in the BER-TLV, if they don't have Comprehension Required set.
2010-06-23 14:23:06 -05:00
Marcel Holtmann 1fedd096a0 Check sanity the MNC length value from the SIM card
In case the SIM entry is wrong or we force reading of it, nasty things
like this can happen:

ofonod[12456]: Control:> AT+CRSM=176,28589,0,0,4\r
ofonod[12456]: Control:< +CRSM: 144,0,"00FFFF"\r\n\r\nOK\r\n
*** buffer overflow detected ***: ./src/ofonod terminated
======= Backtrace: =========
/lib64/libc.so.6(__fortify_fail+0x37)[0x3e42efb417]
/lib64/libc.so.6[0x3e42ef9310]
/lib64/libc.so.6(__strncpy_chk+0x17b)[0x3e42ef85cb]
2010-06-22 17:21:03 +02:00
Denis Kenzior 9b6876ef25 storage: whitespace issue 2010-06-21 15:40:14 -05:00
Denis Kenzior 6bae7a2aa1 smsutil: Fix up some comment style 2010-06-21 15:33:13 -05:00
Andrzej Zaborowski b8f68a5ed3 stkutil: Remove obsolete comment. 2010-06-21 15:21:40 -05:00
Denis Kenzior 4d82b67ea1 sms: Only emit property if value actually differs 2010-06-21 15:21:40 -05:00
Denis Kenzior 5aa8841440 smsutil: Take ton_npi into account in sr assembly 2010-06-21 15:21:40 -05:00
Denis Kenzior 36bcae5ff1 smsutil: More code cleanup
- Change the flow of the code a bit, in the case that all fragments have
  been sent and an udelivered sr arrives, we can simply remove the node
  and signal undelivered up
- We ignore temporary and temporary final status reports
2010-06-21 15:21:40 -05:00
Denis Kenzior cbc27e06b3 smsutil: Make code flow easier to understand 2010-06-21 15:21:40 -05:00
Denis Kenzior a8bd87cda9 smsutil: multiline comments to preferred style 2010-06-21 15:21:40 -05:00
Denis Kenzior 65b8cab616 smsutil: Minor code style & indentation fixes 2010-06-21 15:21:39 -05:00
Denis Kenzior 74a8ce2e8b sms: Fixup minor style issues with status reports 2010-06-21 15:21:39 -05:00
Pasi Miettinen 84d095860f sms: Status report notify 2010-06-21 15:21:39 -05:00
Denis Kenzior d7dacd2fad smsutil: memcpy is preferable to struct assignment 2010-06-21 15:21:39 -05:00
Denis Kenzior c967766070 smsutil: Streamline flow of sr add_fragment 2010-06-21 15:21:39 -05:00
Denis Kenzior cf62a6e8d5 Fix: Make distcheck pass
No need to include history.h anyway
2010-06-21 15:21:39 -05:00
Pasi Miettinen a7372209f3 smsutil: Status report assembly 2010-06-21 10:52:27 -05:00
Andrzej Zaborowski 1b4dd4cd83 stkutil: Add More Time terminal response builder 2010-06-18 14:04:54 -05:00
Denis Kenzior 3b5d3fe1ef stkutil: USSD max len is 160 2010-06-18 13:59:15 -05:00
Yang Gu 6018d1fe82 stk: Add parser for timing advance objects 2010-06-18 13:57:55 -05:00
Yang Gu 179c14fe39 smsutil: Add a decoder for ussd pdus 2010-06-18 13:18:12 -05:00
Yang Gu 31d29608e0 stk: Add parser for send ussd commands 2010-06-18 13:15:31 -05:00
Denis Kenzior 97e62dffde stkutil: Make sure bc_repeat is used properly
The wrong structure was being used in the function & the has_bc_repeat
variable was not being set properly.
2010-06-16 17:43:12 -05:00
Denis Kenzior dc505be373 stkutil: Merge two versions of bcch_channel_list 2010-06-16 17:43:12 -05:00
Yang Gu ea41f3851d stk: Add parser for UTRAN meas qualifier objects 2010-06-16 17:43:12 -05:00
Yang Gu 521156c049 stk: Add parser for PDP activation param objects 2010-06-16 17:43:12 -05:00
Yang Gu 37afdf1ca5 stk: Add parser for bcch channel list objects 2010-06-16 17:43:11 -05:00
Yang Gu db941ff556 stk: Add parser for cell broadcast page objects 2010-06-16 17:43:11 -05:00