Commit Graph

50 Commits

Author SHA1 Message Date
Marit Henriksen fb60a96027 stemodem: Always run +CGACT? when we get +CGEV.
Remove checks for certain values of CGEV, and instead we will
always run CGACT? to check what contexts that are active.
2011-01-14 14:32:58 +01:00
Marit Henriksen 12b417f4e9 stemodem: Use macro for context status. 2011-01-14 14:32:16 +01:00
Marit Henriksen 1fe79aa8a5 stemodem: Return immediately if not voice call. 2011-01-14 14:30:14 +01:00
Marit Henriksen 84e942ace3 stemodem: Use macro for clip validity. 2011-01-14 14:29:38 +01:00
Marit Henriksen e732452eea stemodem: Removed defaults in switches.
Coding style guidline M12.
2011-01-14 14:29:00 +01:00
Helen Clemson ed67052411 stemodem: Incorrect string length in dtmf buf.
Strlen includes a NULL character.
2011-01-14 14:26:21 +01:00
Helen Clemson 5242716024 stemodem: Fix spelling mistake in error message. 2011-01-14 11:37:55 +01:00
Jeevaka Badrappan 15bf5be1a5 stemodem: M15 coding style fix 2011-01-12 08:06:58 -08:00
Marit Henriksen 42f3134802 stemodem: Fix for MT call not working when caller id is hidden.
In *ECAV, the number will not be included if caller id is hidden.
Set it to an empty string in that case, and set number type to
128, unknown number type.
2011-01-04 01:24:26 -08:00
Sjur Brændeland f5864cf31c stemodem: Use RTNL to create network interfaces. 2010-12-21 06:37:53 -08:00
Sjur Brændeland b108042e66 stemodem: Create network interfaces statically 2010-12-21 06:37:44 -08:00
Lucas De Marchi b82a7f8511 drivers: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:37:09 -06:00
Rémi Denis-Courmont 44c6918081 ste: Remove stray newlines in messages sent to log 2010-11-26 13:49:19 -06:00
Sjur Brændeland a32965de27 stemodem: Change use of types
Use the type __u32 for sequence counting rather than guint32,
and "void *" instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024,
as this should be sufficient to hold the NEWLINK message.
2010-11-23 03:06:34 -06:00
Sjur Brændeland 2f9af8c105 stemodem: Fix for error handling, memleak and changed some defines
* renamed MAX_LEN to IP_ADDR_LEN
* removed memory leak from unneeded strdup when parsing xml response.
* better handling of AT error responses
* reduced number of caif interfaces to 4
2010-11-13 10:30:43 +09:00
Marcel Holtmann 4a82cb0233 stemodem: Fix various coding style and logic issues with RTNL support 2010-11-13 10:26:07 +09:00
Sjur Brændeland 04479d8df7 stemodem: Add RTNL functionality managing CAIF Network Interfaces. 2010-11-13 10:16:18 +09:00
Marcel Holtmann 1b920e4b57 stemodem: Fix broken coding style 2010-10-30 19:09:59 +02:00
Marcel Holtmann d66e699a88 stemodem: Some cleanups in voice call driver 2010-09-27 08:09:38 +09:00
Lucas De Marchi 74125ff5d4 Fix common misspellings in drivers
Fix common misspellings by using the list available at
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

From the list cited above, the substitution script found the following
misspellings:

subsidary(-ies)->subsidiary(-ies)
transfering->transferring
2010-09-14 16:00:16 +09:00
Marcel Holtmann 841d770988 stemodem: Fix whitespace damage in radio settings driver 2010-08-20 14:13:07 +02:00
Sjur Brændeland e22c79af72 stemodem: Add Radio Settings to STE Modem 2010-08-17 14:40:44 +02:00
Marcel Holtmann de221f87fa stemodem: Remove useless NULL checks before g_free 2010-08-16 22:11:21 +02:00
Sjur Brændeland 72bc61976c stemodem: Copy if_caif.h from 2.6.36 RC 2010-08-13 14:00:43 -05:00
Denis Kenzior 9a00f06329 stemodem: register should not be called from probe 2010-08-12 23:46:02 -05:00
Denis Kenzior 361773f4d8 stemodem: Use g_at_chat_clone 2010-08-12 23:44:07 -05:00
Denis Kenzior 71d309ab50 stemodem: Fix minor whitespace issue 2010-08-12 23:41:19 -05:00
Sjur Brændeland f65ab1a9da stedriver: Copy caif_socket.h from 2.6.36 RC
Copied include/linux/caif/caif_socket.h and
added AF_CAIF, PF_CAIF and SOL_CAIF definitions
found in linux/include/socket.h.
2010-08-12 11:32:12 -05:00
Sjur Brændeland 5a935a43fd stedriver: remove unsupported CAIF socket ioctls 2010-08-12 11:32:12 -05:00
Sjur Brændeland dde0a4ccb5 voicecall: Rename hangup to hangup_active 2010-08-12 11:32:12 -05:00
Denis Kenzior c98b951fe6 Refactor: Remove atutil dump_response
No longer needed now that we have nice AT command tracing using
OFONO_AT_DEBUG=1
2010-02-08 12:28:23 -06:00
Denis Kenzior 7f9a9b0cdc Fix: Don't use ofono_debug directly in plugins 2010-02-08 12:09:01 -06:00
Denis Kenzior bfeef21a9d Fix: Send *EIAAUW after CGDCONT for STE and MBM
Otherwise the EIAAUW might fail.
2010-02-05 12:20:45 -06:00
Denis Kenzior ced9692361 Fix: Use snprintf instead of sprintf in stemodem 2010-02-05 12:01:13 -06:00
Denis Kenzior 7b2b548d8d Fix: Update copyright notice for 2010 2010-01-28 15:08:24 -06:00
Denis Kenzior 586003ba52 Style: Various whitespace issues 2010-01-28 15:08:24 -06:00
Denis Kenzior 337b0367ee Style: Put voicecall before gprs 2010-01-28 15:08:23 -06:00
Sjur Brændeland ddd5582a54 Add STE voice call support. 2010-01-28 15:08:23 -06:00
Marcel Holtmann 5431aeea0d The AF_CAIF constant is more like to be 37 than 28 2010-01-28 11:28:38 +01:00
Denis Kenzior 5e94e2bad8 Fix: Remove username/password elements
The reason for this is twofold.  First the current code actually leaks
memory since it uses g_strdup on username/password and never frees it
anywhere.  Second the username/password command can just be sent inside
activate_primary, no reason to do it in the callback.

The fix removes the username / password structure members and moves the
AT*EIAAUW handling to activate_primary.  This is almost exactly like the
username / password / context definition for MBM modems.
2010-01-27 13:59:05 -06:00
Denis Kenzior dda8b972ba Style: Couple more fixes 2010-01-27 13:46:12 -06:00
Denis Kenzior b52a6e60c7 Fix: Remove pointless error labels 2010-01-27 12:57:16 -06:00
Denis Kenzior 8e07c9c5d8 Style: Various indentation and spacing issues 2010-01-27 12:53:49 -06:00
Denis Kenzior 083e448fa5 Style: No space after function name 2010-01-27 12:41:49 -06:00
Denis Kenzior 09afdaa19e Style: Use proper comment formatting 2010-01-27 12:38:27 -06:00
Denis Kenzior 081c7a3138 Style: Don't use underscore 2010-01-27 12:33:11 -06:00
Sjur Brændeland b0106d1225 Add STE modem support for GPRS PDP Contexts 2010-01-27 12:16:43 -06:00
Marcel Holtmann b334372ef8 Remove unused declarations 2010-01-25 21:22:32 +01:00
Sjur Brændeland cb264e3b81 Add CAIF header files in drivers/stemodem/
These should go away when CAIF is part of Linux kernel.
2010-01-25 20:58:26 +01:00
Sjur Brændeland fd73261cd5 Add STE modem driver definition 2010-01-25 20:56:26 +01:00