Lucas De Marchi
b210838e87
core: explicitly compare pointers to NULL
...
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/ )
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Rémi Denis-Courmont
e7c4442c69
core: Remove stray newlines in messages sent to log
2010-11-26 13:50:15 -06:00
Jeevaka Badrappan
2d0cb92155
src: coding style fixes - rule M6
2010-11-22 05:07:52 -06:00
Andrzej Zaborowski
e0663bd0ed
voicecall: Limit tone string length per request.
...
Also change to avoid memcpying into a buffer.
2010-10-25 17:20:17 -05:00
Andrzej Zaborowski
0dd1e9ed07
voicecall: __ofono_voicecall_tone_send internal api
...
This provides a way for other atoms to send DTMF tones during a call.
It is assumed that vc->driver->send_tone returns only after the tones
have finished being emitted.
In this version Dbus DTMF requests are in the same queue as STK
requests.
2010-10-22 21:59:11 -05:00
Pekka Pessi
7a36cbfd70
voicecall: check g_try_new0 return value
2010-10-10 06:06:54 -05:00
Pekka Pessi
ea51479fcd
voicecall: remove dial_request_finish() cb param
...
There is no need for callback param anymore.
2010-10-10 06:06:09 -05:00
Pekka Pessi
e21ad3086f
voicecall: Check dial requests in voicecall_is_busy
...
Return true if a call is being dialed by stk.
Use __ofono_voicecall_is_busy() in __ofono_voicecall_dial().
2010-10-10 06:02:15 -05:00
Denis Kenzior
d70d422866
voicecall: Set single_call correctly
2010-09-28 16:59:15 -05:00
Jeevaka Badrappan
4196182770
Fix multi-line comment style issues
2010-09-21 21:16:01 -05:00
Denis Kenzior
b7f1733fe4
voicecall: Simplify logic
2010-09-09 21:57:15 -05:00
Andrzej Zaborowski
52161db428
stk: Fix User Cancel response to Set Up Call
...
One of the clean-up commits changed the semantics of the dial request
callback's parameter (NULL if call setup failed, non-NULL if success
or user cancelled).
2010-09-09 21:45:22 -05:00
Denis Kenzior
694847377d
voicecall: Remove unusued MULTI_RELEASE flag
2010-09-01 12:07:01 -05:00
Denis Kenzior
4292b2dbed
sim: Turn around the order of arguments
...
The void *user argument was first. It should be last instead to be
consistent with the other watch functions.
2010-08-30 14:29:34 -05:00
Denis Kenzior
afd0611ff8
voicecall: Fix crash during cleanup
2010-08-30 10:34:21 -05:00
Denis Kenzior
c92a31ac3a
voicecall: Cleanup dial request when removing atom
2010-08-27 19:06:38 -05:00
Denis Kenzior
605d720bd4
voicecall: Refactor ofono_voicecall_busy
2010-08-27 19:06:36 -05:00
Denis Kenzior
e760b59ce9
voicecall: Switch to unsigned
2010-08-27 19:01:44 -05:00
Denis Kenzior
ed562ba2b0
voicecall: Cleanup dial request init / finish
2010-08-27 19:01:41 -05:00
Andrzej Zaborowski
4a9a985c9d
voicecall: add __ofono_voicecall_dial internal api
...
The callback is only invoked when the call is CONNECTED (becomes
active). Cancel ensures that the callback will not be called and
does nothing more in this version, it's an open question if we
want to release the call.
2010-08-27 10:41:34 -05:00
Marcel Holtmann
1130fff405
voicecall: Remove unused variable
2010-08-20 23:17:33 +02:00
Denis Kenzior
f42e563c51
voicecall: Fix memory leak
2010-08-20 16:15:11 -05:00
Denis Kenzior
3edb2e90ab
voicecall: Remove Calls property
2010-08-20 16:15:11 -05:00
Denis Kenzior
b5b0627f7f
voicecall: emit CallAdded and CallRemoved signals
2010-08-20 16:15:11 -05:00
Denis Kenzior
230236ea25
voicecall: Add GetCalls method
2010-08-20 16:15:11 -05:00
Denis Kenzior
a4de14dab6
voicecall: Fix up some style issues
2010-08-20 16:15:11 -05:00
Denis Kenzior
bdbf0fef99
voicecall: Break out voicecall_append_properties
2010-08-20 16:15:11 -05:00
Denis Kenzior
96f74a1c04
voicecall: Get rid of MultipartyCalls attribute
...
Replaced by Multiparty attribute on the Voicecall object
2010-08-20 16:15:11 -05:00
Denis Kenzior
bab23b3976
voicecall: Make hangup_all work for 911 calls
2010-08-13 14:00:43 -05:00
Denis Kenzior
c7b13ec2fe
voicecall: Relax restriction for hangup_active
...
If hangup_active is present, then a single active call in a 3-way
situation is hung up using hangup_active.
2010-08-12 13:15:52 -05:00
Denis Kenzior
fa2c29c84f
voicecall: Move some stuff around
2010-08-12 13:13:53 -05:00
Denis Kenzior
2c9a2b8a99
voicecall: Don't hangup waiting calls
...
During hangup_all operation. For multiparty hangups, waiting calls are
not part of the mpty call.
2010-08-12 11:32:12 -05:00
Denis Kenzior
dcf1c32f4c
voicecall: Make logic bit cleaner
2010-08-12 11:32:12 -05:00
Denis Kenzior
516d1545a1
voicecall: Minor style issues
2010-08-12 11:32:12 -05:00
Denis Kenzior
10e9bdf4c1
voicecall: Reflow the logic of voicecall_hangup
2010-08-12 11:32:12 -05:00
Sjur Brændeland
9a24ece0fb
voicecall: Add support for function hangup_all
...
This patch fixes problem for modems that cannot terminate
DIALING/ALERTING calls with CHUP=1X. The main change is that
voicecall driver's hangup function is split into the functions
hangup_all and hangup_active.
Changes:
- In cases where hangup previously was used, hangup_all is used
if implemented otherwise hangup_active is used.
- Call in state DIALING/ALERTING is released with hangup_active if
implemented.
- manager_hangup_all will simply call hangup_all if implemented.
- manager_hangup_all will release calls in state
ALERTING/DIALING/INCOMING using hangup_active otherwise
release_specific.
2010-08-12 11:32:12 -05:00
Denis Kenzior
ab9d7cd2cb
style: No initialization needed here
2010-07-08 14:27:34 -05:00
Denis Kenzior
1786c17c3f
Refactor: Store the sim object inside voicecalls
...
Makes the logic a bit easier to follow. Also use a switch/case inside
the sim state watcher.
2010-04-15 16:49:42 -05:00
Denis Kenzior
fa37f158d1
Style: Proper indentation
2010-04-15 16:49:42 -05:00
Andrzej Zaborowski
1ca8671d11
Handle EFen list when SIM inserted / removed
2010-04-15 16:49:41 -05:00
Denis Kenzior
e1e036b5df
Move voicecall interface definitions to dbus.h
2010-03-22 15:27:08 -05:00
Denis Kenzior
4b81513d95
Style: if statement
2010-02-10 16:41:31 -06:00
Denis Kenzior
87ca1b0c8f
Fix: Don't use ofono_debug directly in the core
...
Use DBG macro which is integrated with the new debug framework.
2010-02-08 11:54:03 -06:00
Marcel Holtmann
144080e749
Update copyright information
2010-01-01 17:00:10 -08:00
Marcel Holtmann
0b359e89db
Use error label instead of err or err_out
2009-12-24 07:09:09 -08:00
Denis Kenzior
955e6a61ee
Style: Fix a few more occurences of if/else
...
See Linux coding style document for details
2009-12-17 21:45:39 -06:00
Andrzej Zaborowski
50d855d91f
Support 51.011 EFecc format.
...
EFecc has different formats in G2 and G3 UICC specs.
2009-12-16 11:10:33 -06:00
Denis Kenzior
e1ceeafe5f
Optimize: call list signal emission
2009-12-04 16:52:31 -06:00
Denis Kenzior
752c5af2f0
Update voicecall atom to use new callid api
2009-12-04 16:52:31 -06:00
Denis Kenzior
0b754835f5
Add utility to get the next free call id
2009-12-04 16:52:30 -06:00