Commit Graph

94 Commits

Author SHA1 Message Date
Lucas De Marchi 86aae128d3 gisi: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 11:53:14 -06:00
Mika Liljeberg 6fa4ee0237 gisi: return NULL instead of asserting 2010-11-11 09:23:33 +02:00
Mika Liljeberg 39823fee14 gisi: fix crash bug in g_isi_remove_subscription 2010-11-11 09:20:39 +02:00
Marcel Holtmann 27311fc4a8 gisi: Use of DBG macro is not allowed 2010-10-22 00:37:57 +02:00
Mika Liljeberg 8ebe96d996 gisi: Add method for verifying any resource
Add g_isi_verify_resource() function to GIsiClient for verifying
the reachability of an arbitrary resource.
2010-10-21 21:39:41 +03:00
Mika Liljeberg a4117e5411 gisi: store object handle for associated server 2010-10-21 21:39:41 +03:00
Mika Liljeberg 0e95bfd856 gisi: Allow subscribes towards any resources
Add methods to subscribe indications from an arbitrary resource.
Configured resource id is treated as the default. Also added separate
commit function for resource subscriptions in order to reduce the
number of subscription messages sent to the modem.
2010-10-21 21:39:41 +03:00
Mika Liljeberg 69fbe74276 gisi: make timeout optional 2010-10-21 21:39:41 +03:00
Mika Liljeberg 6462450059 gisi: Add sendto methods to GIsiClient
Add g_isi_vsendto() and g_isi_sendto() methods for sending messages to
an arbitrary Phonet address.
2010-10-21 21:39:41 +03:00
Aki Niemi 8698a0d4f2 gisi: Fix copyright and license boilerplate 2010-10-14 15:29:58 +03:00
Pekka Pessi 84888e9fa7 gisi/verify: check g_try_new0 return value 2010-10-06 17:26:26 +02:00
Aki Niemi a7879d4e0c gisi: Remove route adding API 2010-09-30 11:25:48 +03:00
Lucas De Marchi 9849f010ab Fix common misspelling in gisi
Fix common misspellings by using the list available at
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

From the list cited above, the substitution script found the following
misspelling:

fomr->from
2010-09-14 16:01:00 +09:00
Pekka Pessi 9385ba83ba gisi: added g_isi_send() and g_isi_vsend()
Include a finalize function in GIsiRequest
2010-09-02 07:50:58 +03:00
Pekka Pessi 3b95fe1d10 gisi: Retry version query in g_isi_verify()
For some mysterious reason, not all COMMON_MESSAGEs get sent to
modem. This patch adds a retry counter that tries to make sure an
answer is always received.
2010-08-30 17:55:15 +03:00
Aki Niemi d21c660ae2 gisi: Fix counter for indication subscriptions 2010-08-30 17:54:40 +03:00
Pekka Pessi a97a97147d Eliminated bool, true and false from gisi 2010-05-27 13:07:15 -05:00
Aki Niemi 1d7fe6aa5a gisi: Fix style issues 2010-05-17 14:28:39 +03:00
Aki Niemi 43aaf7c291 gisi: Fix netlink style issues 2010-05-17 13:50:50 +03:00
Pekka Pessi cb6c7972c0 gisi: Add phonet netlink functions
Adding g_pn_netlink_set_address() and g_pn_netlink_add_route().
Automatically configure phonet links without external software.
2010-05-17 13:50:27 +03:00
Pekka Pessi 5b288c17b9 gisi: Remove g_pn_netlink_by_name() 2010-05-17 13:43:34 +03:00
Aki Niemi 9ac5c596ed gisi: Add support for NTF requests
Notify requests are requests sent by ISA servers towards clients. They
are identical to indications in that no response is necessary, but
different in that subscription is done not using the mechanism used
for indications, but out-of-band. Typically routing for notify
requests is enabled using a request-response pair.
2010-05-14 16:51:30 +03:00
Aki Niemi 36bd998597 gisi: Return negative errnos 2010-05-14 16:51:25 +03:00
Aki Niemi 2d8762932a gisi: Fix typo in documentation 2010-05-14 16:51:21 +03:00
Aki Niemi 26fda05821 gisi: Add debugging support for requests 2010-05-14 16:50:00 +03:00
Aki Niemi 8aa82f0a4f gisi: remove misplaced define 2010-04-27 23:21:48 +03:00
Aki Niemi f89f11d2a2 gisi: refactor client implementation 2010-04-27 23:21:48 +03:00
Pekka Pessi 7bf2dc9707 Fix: transaction id usage in gisi/server.c 2010-04-24 14:09:58 -05:00
Aki Niemi 22103491a4 gisi: move g_isi_modem_by_name to separate file
This fixes build warnings that resulted from conflicts between
linux/if.h and net/if.h.
2010-04-21 10:48:29 +03:00
Aki Niemi 1a52b68573 Fix build warning on 64bit system 2010-04-20 17:47:17 +03:00
Pekka Pessi fa3501b8d2 Refactor isimodem and gisi/netlink
Now usbpnmodem plugin is used to register ISI modems.
2010-04-20 17:47:17 +03:00
Pekka Pessi 3ddc7ab7c3 gisi: add gisi server API 2010-04-20 17:47:16 +03:00
Pekka Pessi 66e87b42b3 gisi: fix cast-align warnings 2010-04-20 17:47:16 +03:00
Pekka Pessi 7c8fd12d9a gisi: check for NULL client and remove warnings 2010-04-20 17:47:16 +03:00
Pekka Pessi 12acb80e98 gisi: move GIsiDebugFunc into modem.h 2010-04-20 17:47:16 +03:00
Aki Niemi 19d9b37c58 gisi: fix pointer checking 2010-04-20 14:10:38 +03:00
Aki Niemi 5d7bf546ef gisi/pep: check for NULL callback 2010-04-20 14:10:33 +03:00
Denis Kenzior 8987fb696c Fix: Use g_try_malloc in gisi/pipe.c 2010-03-16 17:37:44 -05:00
Denis Kenzior 9b8d8218a5 Fix: Use g_try_malloc not g_malloc in isi/pep.c 2010-03-16 17:34:49 -05:00
Denis Kenzior d081e3910a Style: Use newlines to make the code more readable 2010-03-16 17:34:18 -05:00
Denis Kenzior db7e48d046 Style: Always use tab for indentation 2010-03-16 17:33:50 -05:00
Denis Kenzior 9b803223c6 Style: Various issues 2010-01-12 17:54:37 -06:00
Rémi Denis-Courmont 2b2a410deb gisi: support sending ISI request as a scatter-gather array 2009-12-18 15:59:17 +02:00
Rémi Denis-Courmont bc6c4adcac gisi: pass object handle to g_isi_verify() callback
This will be needed for GPDS.
2009-12-18 15:59:17 +02:00
Rémi Denis-Courmont 0081548fcf gisi: Fix g_isi_verify() type safety 2009-12-18 15:59:17 +02:00
Pekka Pessi 86b6cd91c9 isimodem/voicecall.c: initial version
Implementing all the voicecall methods. Tested with Nokia 2008 modems.

 - problems in call creation are probably not reported properly
 - deflect not implemented in modem, not properly tested

TODO: Clean up style issues and align with other drivers.
2009-10-16 11:18:52 +03:00
Aki Niemi 876943e2b4 gisi: Add getter for sub-block data
Also fix indentation and change int->unsigned in the API.
2009-10-14 22:46:26 +03:00
Pekka Pessi d1d870ba7a Refactor subblock iterators.
Always initialize iterators.

Try to avoid pointer arithmetics on NULL; in other words, move all pointer
arithmetics inside g_isi_sb_iter_init().

There are 4 different ways for representing sub blocks in ISI message:
- 8-bit sub_blocks count, 8-bit sub_block_id/sub_block_len
- 16-bit sub_blocks count, 8-bit sub_block_id/sub_block_len
- 8-bit sub_blocks count, 16-bit sub_block_id/sub_block_len
- 16-bit sub_blocks count, 16-bit sub_block_id/sub_block_len

The compact form g_isi_sb_iter_init() supports 8-bit sub_block count before
start of the sub blocks themselves and 8-bit sub_block_id and sub_block_len.
The full form g_isi_sb_iter_init_full() with explicit longhdr and sub_block
count supports all other cases.
2009-10-09 12:54:04 +03:00
Pekka Pessi bc8031e2d7 gisi: use const and restrict in iter 2009-10-07 23:21:15 +03:00
Aki Niemi 0b28b05678 gisi: Make reachability detection more robust 2009-09-16 23:37:23 +03:00