Commit Graph

129 Commits

Author SHA1 Message Date
Lucas De Marchi e0d6f9f0ce Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
2012-05-20 02:47:57 -07:00
Lucas De Marchi b3489f2ee8 Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector.
2012-05-20 02:47:57 -07:00
Henrique Dante de Almeida 924ee02ff7 Constify GDBus signal tables
Constify signal tables with the following command:

    find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Henrique Dante de Almeida 63bbdebdf2 Constify GDBus method tables
Constify method tables with the following command:

find . -name '*.[ch]' -exec \
             sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
2012-05-20 02:47:56 -07:00
Denis Kenzior 65393a2fb3 sms: Don't need the sim member now 2012-01-18 12:55:02 -06:00
Denis Kenzior 45402f797b sms: Use __ofono_atom_find 2012-01-18 12:21:34 -06:00
Gustavo F. Padovan 39f23f6fe1 sms: remove set but not used var 2011-05-20 15:03:49 -05:00
Bertrand Aygon 48e97447ab sms: Remove use of uninitialized variable
Remove a debug information, since the info is useless, and more,
it can display invalid info due to var not initialise in some case
2011-04-29 04:15:47 -05:00
Denis Kenzior d26a3fd67b sms: Fix typo 2011-04-14 17:02:22 -05:00
Mika Liljeberg 0eedf42921 core: remove redundant code 2011-03-30 12:33:54 -05:00
Denis Kenzior 15abdeee68 sms: Rework tx_state logic
Using the enum which has a value of zero (PENDING) by default created
some problems.  Use a slightly modified version of the logic and consume
less storage to boot.
2011-03-18 18:31:14 -05:00
Denis Kenzior 9a37a672bf sms: Move CancelMessage(o) method
Move this method to the Message Cancel() method instead and introduce
new __ofono_sms_txq_cancel API
2011-03-18 18:31:14 -05:00
Lucas De Marchi 458ef95e5d sms: remove check for impossible NULL condition
tx_next() must never be called with entry == NULL and currently it
was already being dereferenced before making this check. Thus just
remove it.
2011-03-18 18:31:14 -05:00
Lucas De Marchi 21da71d544 sms: allow message submission to be cancelled
Based on patch from Yang Gu <gyagp0@gmail.com>
2011-03-18 18:31:14 -05:00
Denis Kenzior 7dcae49cc5 sms: Don't leak memory, even in bizarre conditions 2011-03-18 18:31:14 -05:00
Lucas De Marchi 7a7c0717f5 sms: factor out 'remove entry' from tx_finished()
Refactor tx_finished() and create a function to remove an entry from the
tx queue. This function will be used also when a message is cancelled.
Thus, handle the case in which state is MESSAGE_STATE_CANCELLED as well.

Based on patch from Yang Gu <gyagp0@gmail.com>
2011-03-18 18:31:14 -05:00
Jeevaka Badrappan b5950e2391 sms: limit the sms sending retry
If sending of SMS fails, then oFono core will try to resend it after
n * 5 seconds(n = retry count). Due to this, conformance test case
27.22.8 sequence 1.4 fails(refer 31.124 spec). Plan is to limit the
failue codes for which the retry will be done. This patch allows the
retry if the failure is only due to network timeout. For all the
other failure cases, retry is not done.
2011-03-17 12:23:35 -05:00
Denis Kenzior 32b4298bfe sms: return immediately if cached flag is set 2011-02-10 11:08:47 -06:00
Denis Kenzior e0d777a655 core: free GError objects returned by glib 2011-02-08 16:48:52 -06:00
Denis Kenzior 0eed0db9fe sms: Minor style fix 2011-02-06 23:47:17 -06:00
Denis Kenzior 960310f8b1 sms: Be more paranoid when loading SMS settings 2011-02-06 23:47:17 -06:00
Denis Kenzior 9086328508 sms: Use a better pattern for bearer_from_string 2011-02-06 23:47:17 -06:00
Aki Niemi bef5e1773c sms: Add alphabet support to SMS atom 2011-02-06 23:47:16 -06:00
Aki Niemi 15428cc2df sms: Fix indentation 2011-02-02 11:03:21 +02:00
Lucas De Marchi bc0386cb23 sms: restore pending tx messages from backup
Based on patch from: Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-28 16:55:31 -06:00
Lucas De Marchi f55447a39e sms: delete sent sms messages from backup
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-28 16:14:41 -06:00
Lucas De Marchi 8305ddf321 sms: store pending tx pdus on disk
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
2011-01-28 16:14:12 -06:00
Faiyaz Baxamusa 76081700a9 sms: Break out message objects into message.[ch]
These can be used as is by the CDMA SMS manager atom
2011-01-20 14:58:31 -06:00
Pekka Pessi 2c7b1348aa sms: make sms atom offline-safe
Allow use of SMS atom both in online and offline (post_sim) states.

SMS atom now watches network registration atom and state.  Thmessages
are queued but not sent if not registered to a network.  Errors
occurring when a short message is being sent while transition from
online to offline or when network coverage is dropped are now handled
gracefully.
2011-01-18 22:09:07 -06:00
Marcel Holtmann c7963f1c00 sms: Add debug for SMS source and destination ports 2010-12-24 10:47:39 -08:00
Denis Kenzior ac72349017 sms: Use the right union member for DCS check 2010-12-02 07:49:49 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Denis Kenzior 5c9a03b480 sms: Fix up comment style and wording 2010-11-10 09:17:19 -06:00
Andrzej Zaborowski 45b944d84b sms: SMS-PP download must be enabled in sst / est 2010-11-10 09:09:55 -06:00
Andrzej Zaborowski 028c8c011b sms: Handle "USIM Download" SMS type. 2010-11-08 13:36:47 -06:00
Denis Kenzior 4815d84789 sms: Call the txq_submit queued callback 2010-11-04 10:25:42 -05:00
Denis Kenzior 857e2d046f sms: Separate history from dbus flags in txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 3436c58fac sms: Refactor __ofono_sms_txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 4a2111347f sms: Add __ofono_sms_message_path_from_uuid 2010-11-04 10:25:41 -05:00
Denis Kenzior 0edb5e3645 sms: add __ofono_sms_get_next_ref 2010-11-04 10:25:41 -05:00
Denis Kenzior 2a18afa994 sms: Fix unused variable warning 2010-11-02 15:56:22 -05:00
Denis Kenzior e29d1338b9 sms: Update to the new smsutil api 2010-11-02 14:58:21 -05:00
Denis Kenzior 348bdb7f1d sms: Don't crash when encoding fails 2010-11-02 12:15:53 -05:00
Denis Kenzior 8f5d8280b6 sms: Minor style fix 2010-11-02 12:15:53 -05:00
Denis Kenzior f5db7564e8 sms: Left shift 8-bit ports by 16
These are less commonly used so make them not interfere with 16 bit
ports
2010-11-02 12:15:53 -05:00
Aki Niemi 37d2edec1c Fix style problem 2010-10-14 15:37:37 +03:00
Aki Niemi 5a85a57cc3 sms: Implement text and datagram watch
Allow setting a watch for incoming text and datagram messages on the
sms atom.
2010-10-14 15:22:16 +03:00
Pekka Pessi 907e14e4ae sms: fix type error 2010-10-05 13:53:12 +02:00
Aki Niemi 0eee1c6727 sms: Fix 8bit port handling 2010-09-27 19:09:09 -05:00