From 0270c0e340a3d009eb0e5cf54a2908c81b9bd6b4 Mon Sep 17 00:00:00 2001 From: Sukchan Lee Date: Fri, 12 Mar 2021 23:25:58 +0900 Subject: [PATCH] ASN.1 encoding failure if no Request-NSSAI #844 --- src/amf/ngap-build.c | 5 + src/amf/nudm-handler.c | 49 +++++--- tests/slice/nssai-test.c | 263 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 300 insertions(+), 17 deletions(-) diff --git a/src/amf/ngap-build.c b/src/amf/ngap-build.c index aede4ae56..e24b581b9 100644 --- a/src/amf/ngap-build.c +++ b/src/amf/ngap-build.c @@ -326,6 +326,7 @@ ogs_pkbuf_t *ngap_build_downlink_nas_transport( AllowedNSSAI = &ie->value.choice.AllowedNSSAI; + ogs_assert(amf_ue->allowed_nssai.num_of_s_nssai); for (i = 0; i < amf_ue->allowed_nssai.num_of_s_nssai; i++) { NGAP_AllowedNSSAI_Item_t *NGAP_AllowedNSSAI_Item = NULL; NGAP_S_NSSAI_t *s_NSSAI = NULL; @@ -532,6 +533,7 @@ ogs_pkbuf_t *ngap_ue_build_initial_context_setup_request( ogs_ngap_uint8_to_AMFPointer(ogs_amf_pointer(&amf_ue->guami->amf_id), &GUAMI->aMFPointer); + ogs_assert(amf_ue->allowed_nssai.num_of_s_nssai); for (i = 0; i < amf_ue->allowed_nssai.num_of_s_nssai; i++) { NGAP_AllowedNSSAI_Item_t *NGAP_AllowedNSSAI_Item = NULL; NGAP_S_NSSAI_t *s_NSSAI = NULL; @@ -845,6 +847,7 @@ ogs_pkbuf_t *ngap_sess_build_initial_context_setup_request( ogs_ngap_uint8_to_AMFPointer(ogs_amf_pointer(&amf_ue->guami->amf_id), &GUAMI->aMFPointer); + ogs_assert(amf_ue->allowed_nssai.num_of_s_nssai); for (i = 0; i < amf_ue->allowed_nssai.num_of_s_nssai; i++) { NGAP_AllowedNSSAI_Item_t *NGAP_AllowedNSSAI_Item = NULL; NGAP_S_NSSAI_t *s_NSSAI = NULL; @@ -1857,6 +1860,7 @@ ogs_pkbuf_t *ngap_build_path_switch_ack(amf_ue_t *amf_ue) AllowedNSSAI = &ie->value.choice.AllowedNSSAI; + ogs_assert(amf_ue->allowed_nssai.num_of_s_nssai); for (i = 0; i < amf_ue->allowed_nssai.num_of_s_nssai; i++) { NGAP_AllowedNSSAI_Item_t *NGAP_AllowedNSSAI_Item = NULL; NGAP_S_NSSAI_t *s_NSSAI = NULL; @@ -2103,6 +2107,7 @@ ogs_pkbuf_t *ngap_build_handover_request(ran_ue_t *target_ue) AllowedNSSAI = &ie->value.choice.AllowedNSSAI; + ogs_assert(amf_ue->allowed_nssai.num_of_s_nssai); for (i = 0; i < amf_ue->allowed_nssai.num_of_s_nssai; i++) { NGAP_AllowedNSSAI_Item_t *NGAP_AllowedNSSAI_Item = NULL; NGAP_S_NSSAI_t *s_NSSAI = NULL; diff --git a/src/amf/nudm-handler.c b/src/amf/nudm-handler.c index fb4b515a9..9bf5d8548 100644 --- a/src/amf/nudm-handler.c +++ b/src/amf/nudm-handler.c @@ -134,9 +134,25 @@ int amf_nudm_sdm_handle_provisioned( } } - if (amf_ue->requested_nssai.num_of_s_nssai) { - amf_ue->allowed_nssai.num_of_s_nssai = 0; - amf_ue->rejected_nssai.num_of_s_nssai = 0; + amf_ue->allowed_nssai.num_of_s_nssai = 0; + amf_ue->rejected_nssai.num_of_s_nssai = 0; + + if (!amf_ue->requested_nssai.num_of_s_nssai) { + + for (i = 0; i < amf_ue->num_of_slice; i++) { + ogs_slice_data_t *slice = &amf_ue->slice[i]; + ogs_nas_s_nssai_ie_t *allowed = + &amf_ue->allowed_nssai.s_nssai[i]; + + allowed->sst = slice->s_nssai.sst; + allowed->sd.v = slice->s_nssai.sd.v; + allowed->mapped_hplmn_sst = 0; + allowed->mapped_hplmn_sd.v = OGS_S_NSSAI_NO_SD_VALUE; + } + amf_ue->allowed_nssai.num_of_s_nssai = amf_ue->num_of_slice; + + } else { + for (i = 0; i < amf_ue->requested_nssai.num_of_s_nssai; i++) { ogs_slice_data_t *slice = NULL; ogs_nas_s_nssai_ie_t *requested = @@ -172,23 +188,22 @@ int amf_nudm_sdm_handle_provisioned( amf_ue->rejected_nssai.num_of_s_nssai++; } - } + } - if (amf_ue->allowed_nssai.num_of_s_nssai) { - amf_ue->allowed_nssai_present = true; - } else { - ogs_error("CHECK DATABASE: Cannot find Requested NSSAI"); - for (i = 0; i < amf_ue->requested_nssai.num_of_s_nssai; i++) { - ogs_error(" PLMN_ID[MCC:%d MNC:%d]", - ogs_plmn_id_mcc(&amf_ue->nr_tai.plmn_id), - ogs_plmn_id_mnc(&amf_ue->nr_tai.plmn_id)); - ogs_error(" S_NSSAI[SST:%d SD:0x%x]", - amf_ue->requested_nssai.s_nssai[i].sst, - amf_ue->requested_nssai.s_nssai[i].sd.v); - } - return OGS_ERROR; + if (amf_ue->allowed_nssai.num_of_s_nssai) { + amf_ue->allowed_nssai_present = true; + } else { + ogs_error("CHECK DATABASE: Cannot create Allowed-NSSAI"); + for (i = 0; i < amf_ue->requested_nssai.num_of_s_nssai; i++) { + ogs_error(" PLMN_ID[MCC:%d MNC:%d]", + ogs_plmn_id_mcc(&amf_ue->nr_tai.plmn_id), + ogs_plmn_id_mnc(&amf_ue->nr_tai.plmn_id)); + ogs_error(" S_NSSAI[SST:%d SD:0x%x]", + amf_ue->requested_nssai.s_nssai[i].sst, + amf_ue->requested_nssai.s_nssai[i].sd.v); } + return OGS_ERROR; } amf_ue_sbi_discover_and_send(OpenAPI_nf_type_UDM, amf_ue, diff --git a/tests/slice/nssai-test.c b/tests/slice/nssai-test.c index f5d1885e5..84580171c 100644 --- a/tests/slice/nssai-test.c +++ b/tests/slice/nssai-test.c @@ -91,6 +91,246 @@ static void test1_func(abts_case *tc, void *data) ABTS_PTR_NOTNULL(tc, doc); ABTS_INT_EQUAL(tc, OGS_OK, test_db_insert_ue(test_ue, doc)); + /* Send Registration request */ + test_ue->registration_request_param.gmm_capability = 1; + test_ue->registration_request_param.requested_nssai = 0; + + gmmbuf = testgmm_build_registration_request(test_ue, NULL); + ABTS_PTR_NOTNULL(tc, gmmbuf); + sendbuf = testngap_build_initial_ue_message(test_ue, gmmbuf, false, true); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive Authentication request */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + + /* Send Authentication response */ + gmmbuf = testgmm_build_authentication_response(test_ue); + ABTS_PTR_NOTNULL(tc, gmmbuf); + sendbuf = testngap_build_uplink_nas_transport(test_ue, gmmbuf); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive Security mode command */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + + /* Send Security mode complete */ + nasbuf = testgmm_build_registration_request(test_ue, NULL); + ABTS_PTR_NOTNULL(tc, nasbuf); + gmmbuf = testgmm_build_security_mode_complete(test_ue, nasbuf); + ABTS_PTR_NOTNULL(tc, gmmbuf); + sendbuf = testngap_build_uplink_nas_transport(test_ue, gmmbuf); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive Initial context setup request + + * Registration accept */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + ABTS_INT_EQUAL(tc, + NGAP_ProcedureCode_id_InitialContextSetup, + test_ue->ngap_procedure_code); + + /* Send UE radio capability info indication */ + sendbuf = testngap_build_ue_radio_capability_info_indication(test_ue); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Send Initial context setup response */ + sendbuf = testngap_build_initial_context_setup_response(test_ue, false); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Send Registration complete */ + gmmbuf = testgmm_build_registration_complete(test_ue); + ABTS_PTR_NOTNULL(tc, gmmbuf); + sendbuf = testngap_build_uplink_nas_transport(test_ue, gmmbuf); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive Configuration update command */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + + /* Send PDU session establishment request */ + sess = test_sess_add_by_dnn_and_psi(test_ue, "internet", 10); + ogs_assert(sess); + + sess->pti = 0; + sess->pdu_session_type = OGS_PDU_SESSION_TYPE_IPV4; + + sess->ul_nas_transport_param.request_type = + OGS_NAS_5GS_REQUEST_TYPE_INITIAL; + sess->ul_nas_transport_param.dnn = 1; + sess->ul_nas_transport_param.s_nssai = 1; + + gsmbuf = testgsm_build_pdu_session_establishment_request(sess); + ABTS_PTR_NOTNULL(tc, gsmbuf); + gmmbuf = testgmm_build_ul_nas_transport(sess, + OGS_NAS_PAYLOAD_CONTAINER_N1_SM_INFORMATION, gsmbuf); + ABTS_PTR_NOTNULL(tc, gmmbuf); + sendbuf = testngap_build_uplink_nas_transport(test_ue, gmmbuf); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive PDUSessionResourceSetupRequest + + * DL NAS transport + + * PDU session establishment accept */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + ABTS_INT_EQUAL(tc, + NGAP_ProcedureCode_id_PDUSessionResourceSetup, + test_ue->ngap_procedure_code); + + /* Send GTP-U ICMP Packet */ + qos_flow = test_qos_flow_find_by_qfi(sess, 1); + ogs_assert(qos_flow); + rv = test_gtpu_send_ping(gtpu, qos_flow, TEST_PING_IPV4); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Send PDUSessionResourceSetupResponse */ + sendbuf = testngap_sess_build_pdu_session_resource_setup_response(sess); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive GTP-U ICMP Packet */ + recvbuf = testgnb_gtpu_read(gtpu); + ABTS_PTR_NOTNULL(tc, recvbuf); + ogs_pkbuf_free(recvbuf); + + /* Send GTP-U ICMP Packet */ + rv = test_gtpu_send_ping(gtpu, qos_flow, TEST_PING_IPV4); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive GTP-U ICMP Packet */ + recvbuf = testgnb_gtpu_read(gtpu); + ABTS_PTR_NOTNULL(tc, recvbuf); + ogs_pkbuf_free(recvbuf); + + /* Send UEContextReleaseRequest */ + sendbuf = testngap_build_ue_context_release_request(test_ue, + NGAP_Cause_PR_radioNetwork, NGAP_CauseRadioNetwork_user_inactivity, + true); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive UEContextReleaseCommand */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + ABTS_INT_EQUAL(tc, + NGAP_ProcedureCode_id_UEContextRelease, + test_ue->ngap_procedure_code); + + /* Send UEContextReleaseComplete */ + sendbuf = testngap_build_ue_context_release_complete(test_ue); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + ogs_msleep(300); + + /********** Remove Subscriber in Database */ + ABTS_INT_EQUAL(tc, OGS_OK, test_db_remove_ue(test_ue)); + + /* Clear Test UE Context */ + test_ue_remove(test_ue); + + /* gNB disonncect from UPF */ + testgnb_gtpu_close(gtpu); + + /* gNB disonncect from AMF */ + testgnb_ngap_close(ngap); +} + +static void test2_func(abts_case *tc, void *data) +{ + int rv; + ogs_socknode_t *ngap; + ogs_socknode_t *gtpu; + ogs_pkbuf_t *gmmbuf; + ogs_pkbuf_t *gsmbuf; + ogs_pkbuf_t *nasbuf; + ogs_pkbuf_t *sendbuf; + ogs_pkbuf_t *recvbuf; + ogs_ngap_message_t message; + int i; + + ogs_nas_5gs_mobile_identity_suci_t mobile_identity_suci; + test_ue_t *test_ue = NULL; + test_sess_t *sess = NULL; + test_bearer_t *qos_flow = NULL; + + bson_t *doc = NULL; + + /* Setup Test UE & Session Context */ + memset(&mobile_identity_suci, 0, sizeof(mobile_identity_suci)); + + mobile_identity_suci.h.supi_format = OGS_NAS_5GS_SUPI_FORMAT_IMSI; + mobile_identity_suci.h.type = OGS_NAS_5GS_MOBILE_IDENTITY_SUCI; + mobile_identity_suci.routing_indicator1 = 0; + mobile_identity_suci.routing_indicator2 = 0xf; + mobile_identity_suci.routing_indicator3 = 0xf; + mobile_identity_suci.routing_indicator4 = 0xf; + mobile_identity_suci.protection_scheme_id = OGS_NAS_5GS_NULL_SCHEME; + mobile_identity_suci.home_network_pki_value = 0; + mobile_identity_suci.scheme_output[0] = 0; + mobile_identity_suci.scheme_output[1] = 0; + mobile_identity_suci.scheme_output[2] = 0x47; + mobile_identity_suci.scheme_output[3] = 0x78; + + test_ue = test_ue_add_by_suci(&mobile_identity_suci, 12); + ogs_assert(test_ue); + + test_ue->nr_cgi.cell_id = 0x40001; + + test_ue->nas.registration.type = 0; + test_ue->nas.registration.follow_on_request = 1; + test_ue->nas.registration.value = OGS_NAS_5GS_REGISTRATION_TYPE_INITIAL; + + test_ue->k_string = "465b5ce8b199b49faa5f0a2ee238a6bc"; + test_ue->opc_string = "e8ed289deba952e4283b54e88e6183ca"; + + /* gNB connects to AMF */ + ngap = testngap_client(AF_INET); + ABTS_PTR_NOTNULL(tc, ngap); + + /* gNB connects to UPF */ + gtpu = test_gtpu_server(1, AF_INET); + ABTS_PTR_NOTNULL(tc, gtpu); + + /* Send NG-Setup Reqeust */ + sendbuf = testngap_build_ng_setup_request(0x102, 32); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive NG-Setup Response */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + + /********** Insert Subscriber in Database */ + doc = test_db_new_slice(test_ue); + ABTS_PTR_NOTNULL(tc, doc); + ABTS_INT_EQUAL(tc, OGS_OK, test_db_insert_ue(test_ue, doc)); + /* Send Registration request */ test_ue->registration_request_param.gmm_capability = 1; @@ -245,6 +485,28 @@ static void test1_func(abts_case *tc, void *data) ABTS_PTR_NOTNULL(tc, recvbuf); ogs_pkbuf_free(recvbuf); + /* Send UEContextReleaseRequest */ + sendbuf = testngap_build_ue_context_release_request(test_ue, + NGAP_Cause_PR_radioNetwork, NGAP_CauseRadioNetwork_user_inactivity, + true); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + + /* Receive UEContextReleaseCommand */ + recvbuf = testgnb_ngap_read(ngap); + ABTS_PTR_NOTNULL(tc, recvbuf); + testngap_recv(test_ue, recvbuf); + ABTS_INT_EQUAL(tc, + NGAP_ProcedureCode_id_UEContextRelease, + test_ue->ngap_procedure_code); + + /* Send UEContextReleaseComplete */ + sendbuf = testngap_build_ue_context_release_complete(test_ue); + ABTS_PTR_NOTNULL(tc, sendbuf); + rv = testgnb_ngap_send(ngap, sendbuf); + ABTS_INT_EQUAL(tc, OGS_OK, rv); + ogs_msleep(300); /********** Remove Subscriber in Database */ @@ -265,6 +527,7 @@ abts_suite *test_nssai(abts_suite *suite) suite = ADD_SUITE(suite) abts_run_test(suite, test1_func, NULL); + abts_run_test(suite, test2_func, NULL); return suite; }