From 3457435071481d81e8600241a0613015dc1dd843 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Fri, 5 Jan 2024 18:32:20 +0100 Subject: [PATCH] [MME] Fix potential null ptr dereference The assert is checking for sess->session->name, but afterwards there's a check to skip ses->session not being null, which means the assert can crash while dereferencing sess->session. --- src/mme/mme-context.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mme/mme-context.c b/src/mme/mme-context.c index 371a22902..55ec3293d 100644 --- a/src/mme/mme-context.c +++ b/src/mme/mme-context.c @@ -4082,10 +4082,11 @@ mme_sess_t *mme_sess_find_by_apn(mme_ue_t *mme_ue, char *apn) sess = mme_sess_first(mme_ue); while (sess) { - ogs_assert(sess->session->name); - if (sess->session && ogs_strcasecmp(sess->session->name, apn) == 0) - return sess; - + if (sess->session) { + ogs_assert(sess->session->name); + if (ogs_strcasecmp(sess->session->name, apn) == 0) + return sess; + } sess = mme_sess_next(sess); }