sysmocom
/
open5gs
forked from acouzens/open5gs
11
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lib/gtp: Fix xact logic for gtp1 messages with intermediate stage 

As per TS 29.060:
The Initial/request message is "SGSN Context Request", sent by peer A.
Peer B sends a response message "SGSN Context Response" with same SeqNr.
Peer A sends a response message "SGSN Context Acknowledge" with same
SeqNr.
If Peer B doesn't see a "SGSN Context Acknowlegde", it should keep
retransmitting "SGSN Context Response" as usual.
This commit is contained in:
Pau Espin 2023-12-20 20:09:31 +01:00 committed by Sukchan Lee
parent 14932a7254
commit ea7708bcfc
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/gtp/xact.c
View File

@ -838,7 +838,13 @@ int ogs_gtp1_xact_receive(
list = &gnode->local_list;
break;
case GTP_XACT_FINAL_STAGE:
list = &gnode->local_list; // FIXME: is this correct?
/* For types which are replies to replies, the xact is never locally
* created during transmit, but actually during rx of the initial req, hence
* it is never placed in the local_list, but in the remote_list. */
if (type == OGS_GTP1_SGSN_CONTEXT_ACKNOWLEDGE_TYPE)
list = &gnode->remote_list;
else
list = &gnode->local_list;
break;
default:
ogs_error("[%d] Unexpected type %u from GTPv1 peer [%s]:%d",
@ -998,6 +1004,9 @@ static ogs_gtp_xact_stage_t ogs_gtp1_xact_get_stage(uint8_t type, uint32_t xid)
case OGS_GTP1_RAN_INFORMATION_RELAY_TYPE:
stage = GTP_XACT_INITIAL_STAGE;
break;
case OGS_GTP1_SGSN_CONTEXT_RESPONSE_TYPE:
stage = GTP_XACT_INTERMEDIATE_STAGE;
break;
case OGS_GTP1_ECHO_RESPONSE_TYPE:
case OGS_GTP1_NODE_ALIVE_RESPONSE_TYPE:
case OGS_GTP1_REDIRECTION_RESPONSE_TYPE:
@ -1011,7 +1020,7 @@ static ogs_gtp_xact_stage_t ogs_gtp1_xact_get_stage(uint8_t type, uint32_t xid)
case OGS_GTP1_FAILURE_REPORT_RESPONSE_TYPE:
case OGS_GTP1_NOTE_MS_GPRS_PRESENT_RESPONSE_TYPE:
case OGS_GTP1_IDENTIFICATION_RESPONSE_TYPE:
case OGS_GTP1_SGSN_CONTEXT_RESPONSE_TYPE:
case OGS_GTP1_SGSN_CONTEXT_ACKNOWLEDGE_TYPE:
case OGS_GTP1_FORWARD_RELOCATION_RESPONSE_TYPE:
case OGS_GTP1_RELOCATION_CANCEL_RESPONSE_TYPE:
case OGS_GTP1_UE_REGISTRATION_QUERY_RESPONSE_TYPE: