Commit Graph

306 Commits

Author SHA1 Message Date
Riza Sulistyo 9fae8f43ac
Merge pull request from GHSA-p6g5-v97c-w5q4
* Prevent heap buffer overflow when parsing DNS packets

* Make sure packet parsing doesn't advance beyond max/end

* Update checks

* Remove  check

Co-authored-by: sauwming <ming@teluu.com>
2022-04-06 11:49:47 +08:00
Riza Sulistyo 856f87c2e9
Merge pull request from GHSA-5x45-qp78-g4p4
* Prevent infinite loop in scanning xml content

* Simplify scanning method

* Optimization
2022-03-29 14:59:03 +08:00
George Joseph 668a828631
Add additional unit test options (#2961) 2022-02-11 12:28:03 +08:00
sauwming 077b465c33
Merge pull request from GHSA-7fw8-54cv-r7pm 2022-01-26 13:28:57 +08:00
sauwming 88b8981817
End CLI telnet session upon data read error (#2939) 2022-01-18 13:35:31 +08:00
sauwming fbfad9fd22
End CLI session upon connection closure (#2917) 2021-12-15 17:52:28 +08:00
Riza Sulistyo 6ca06f63ec
Fix some doc warning (#2879) 2021-11-10 09:57:40 +07:00
Nanang Izzuddin 11ec771c90
Replace pj_ansi_strchr() with pj_memchr() in pj_scan_skip_line(). (#2839) 2021-10-11 10:35:53 +07:00
Riza Sulistyo 661a8cef67
Add support to windows on ARM build (#2807)
* Add support to ARM64 configuration for win32 build

* Add changes notes to webrtc and webrtc_aec3 third party sources

* Remove reference to libwebrtc_aec3 from libpjproject. Add reference it manually if libwebrtc_aec3 is needed.

* Fix build error on Release configuration.
2021-08-30 10:39:48 +07:00
Nanang Izzuddin 22b47a3673
Fix crash in starting CLI telnet when port is in already use (#2607) 2020-12-15 12:19:52 +07:00
Nanang Izzuddin d65cacddd3
Implement trickle ICE (#2588)
Squash & merge trickle-ice dev branch to master.
2020-12-11 09:40:57 +07:00
Sean Bright 86f3ea6059
Don't infinite loop when searching CLI history list (#2560)
- The easiest way to clean up the history list when moving an item is to just remove it and reinsert, so use pj_list_erase().
- Also in inserting entry to CLI history list (`insert_history()`): trim string before compare (as history entries are trimmed), replace pj_list_insert_nodes_after() with pj_list_erase(), avoid buffer overflow in string copy, and a bit optimization: only copy string when needed.
2020-12-10 13:48:14 +07:00
sauwming 95c29aa1d2
Avoid undefinition of standard macros s_addr and s6_addr (#2423) 2020-05-06 09:38:26 +08:00
Nanang Izzuddin b23633707c
More CI works (#2376)
* pjsua-test:
  - Update pjsua-test module call: wait ICE update before checking media
  - Attempt to fix all failed tests by sipp module: changed SIPp port from 6000 to 50070 (port used by recvfrom module)
  - Update call module: confirm codec priority after change, fix DTLS-SRTP expect may race with state CONFIRMED
  - Add timeout check in telnet-ing to pjsua
  - ICE nego may race with call state CONFIRMED, so mod call better just sleep instead of expecting 'ICE nego success'.

* Other unit tests:
  - Print stack trace on crash on Linux and DarwinOS via SIGSEGV signal handler.
  - Update resolver test: print log on callback error, replace assertion checks with error return, fix comments, sleep periods, fix received packet count may be > 1 if server ignore the request (for example when the test machine experiencing high CPU load).
  - Update ccpp.yml: add -g for jobs with unit-tests.
  - More lenient on tsx retransmission count check in pjsip-test.
  - Update tsx_uac/s_test.c: allow retransmission timing diff from 150 to 500ms to accommodate possible CPU spike on some test machines.
2020-04-30 11:25:19 +07:00
Nanang Izzuddin 5f689f5d23
Add option to exclude benchmark tests in unit tests (#2321)
* Add option to exclude benchmark tests in unit tests

* Loosen up resolver round-robin testcondition (percent difference allowance from 5% to 10%, the test result variance relies heavily on OS random number distribution).
2020-03-19 14:46:22 +07:00
sauwming 98f70c210f
Add more CI tests on Ubuntu and Mac (#2329) 2020-03-10 16:45:54 +08:00
Nanang Izzuddin c3456980ba Add option to exclude benchmark tests in unit tests 2020-03-03 09:53:07 +07:00
Riza Sulistyo e3d314f7d1 Close #2200: Ignore/discard DNS SRV response with truncated flag set.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@6000 74dad513-b988-da41-8d7b-12977e46ad98
2019-05-23 13:42:27 +00:00
Nanang Izzuddin aca93961ce Close #2199: Fixed assertion when DNS SRV resolver receives empty record in response.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5996 74dad513-b988-da41-8d7b-12977e46ad98
2019-05-21 03:17:11 +00:00
Nanang Izzuddin 432be93e4d Re #1298: Updated PJLIB-UTIL to use PJ_ERROR consistently.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5981 74dad513-b988-da41-8d7b-12977e46ad98
2019-05-09 04:54:38 +00:00
Nanang Izzuddin c31c095c49 Close #2127: Replaced DNS resolver mutex with group lock.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5826 74dad513-b988-da41-8d7b-12977e46ad98
2018-07-17 10:49:57 +00:00
Sauw Ming edf6b82fc1 Re #2059 (misc): Fixed typo in json.c (should be semicolon instead of comma).
Thanks to Sebastian Marek for the report.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5818 74dad513-b988-da41-8d7b-12977e46ad98
2018-07-03 09:31:27 +00:00
Riza Sulistyo 111322c0e1 Re #2059 (misc): Don't include test app (exe) when building for Android.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5761 74dad513-b988-da41-8d7b-12977e46ad98
2018-03-27 05:35:03 +00:00
Riza Sulistyo 054ae59549 Close #2067: Fix linker error when building as dll on VS2015.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5701 74dad513-b988-da41-8d7b-12977e46ad98
2017-11-22 06:59:47 +00:00
Sauw Ming 19686af25f Re #2063: Add more doc in other parts of the library
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5697 74dad513-b988-da41-8d7b-12977e46ad98
2017-11-17 04:07:43 +00:00
Sauw Ming 6dd508d4bf Re #2063: Temporarily disable the assertion
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5695 74dad513-b988-da41-8d7b-12977e46ad98
2017-11-14 13:05:42 +00:00
Sauw Ming fc9177cadd Fixed #2063: Add more documentation in PJSIP's parser to prevent stack buffer overflow
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5693 74dad513-b988-da41-8d7b-12977e46ad98
2017-11-14 08:20:15 +00:00
Sauw Ming 6ae662e215 Re #2059 (misc): Fixed possible function name clash with md5 due to non-static function.
Thanks to Luca Ceseroli for the report.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5688 74dad513-b988-da41-8d7b-12977e46ad98
2017-11-10 03:14:58 +00:00
Riza Sulistyo 76ea108e47 Re #1994(misc): Fixed unguarded 'if' which might lead to double locking. Thanks to Alexander Traud for the info.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5647 74dad513-b988-da41-8d7b-12977e46ad98
2017-09-11 10:31:03 +00:00
Sauw Ming e34fa7ed5e Fixed #2032: NAT64 support for IPv4 interoperability
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5636 74dad513-b988-da41-8d7b-12977e46ad98
2017-08-02 02:51:59 +00:00
Nanang Izzuddin 494f58b07d Misc (re #1994): Fixed compile warnings on MSVC 2005 & 2015.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5635 74dad513-b988-da41-8d7b-12977e46ad98
2017-08-01 07:49:34 +00:00
Sauw Ming 576a3c0ae9 Fixed #2024: Crash due to uncancelled timer if there's an error in resolver's query transmit
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5612 74dad513-b988-da41-8d7b-12977e46ad98
2017-07-04 00:06:22 +00:00
Sauw Ming a836f456a2 Re #1994 (misc): Fixed missing disabling pragma pack after structure definitions.
Thanks to Michael Scheiffler for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5605 74dad513-b988-da41-8d7b-12977e46ad98
2017-06-15 02:18:17 +00:00
Sauw Ming 568a1967ce Re #1994 (misc): Fixes bugs in base64
* move access to input parameter variable after the assertion to check the variable.
 * prevent invalid memory access for empty input string
 * allow using an output buffer of just the right size

Thanks to Adrien Béraud for the patch



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5589 74dad513-b988-da41-8d7b-12977e46ad98
2017-05-04 05:22:44 +00:00
Sauw Ming 8ed046143c Re #1882 (misc): Add check in xml_print_node() to prevent writing past the end of the buffer.
Thanks to Joshua Elson for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5570 74dad513-b988-da41-8d7b-12977e46ad98
2017-03-22 00:26:34 +00:00
Riza Sulistyo 1a18efe912 Re #1994 (misc): Don't try to resolve a DNS SRV query that is already considered resolved.
Thanks to Richard Mudgett for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5559 74dad513-b988-da41-8d7b-12977e46ad98
2017-02-20 02:11:46 +00:00
Nanang Izzuddin 84ad7a0244 Misc (re #1945): Fixed compile warnings on Android 64bit platforms, e.g: dereferencing type-punned pointer, using uninitialized var.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5544 74dad513-b988-da41-8d7b-12977e46ad98
2017-01-24 05:41:05 +00:00
Nanang Izzuddin 1b25ccaf76 Re #1900: Merged changes from trunk.
git-svn-id: https://svn.pjsip.org/repos/pjproject/branches/projects/uwp@5538 74dad513-b988-da41-8d7b-12977e46ad98
2017-01-23 04:18:59 +00:00
Riza Sulistyo 4ab1838d0b Re #1945 (misc): Don't trigger SRV complete callback when there is a parse error.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5536 74dad513-b988-da41-8d7b-12977e46ad98
2017-01-23 01:34:12 +00:00
Riza Sulistyo 1aadfca5bf Close #1919: Clear unused-variable warnings.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5535 74dad513-b988-da41-8d7b-12977e46ad98
2017-01-19 10:31:38 +00:00
Nanang Izzuddin 7d9a05c9a3 Re #1513: Applied the new API pj_pool_safe_release().
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5534 74dad513-b988-da41-8d7b-12977e46ad98
2017-01-19 07:41:25 +00:00
Nanang Izzuddin c551b147fc Re #1900: More merged from trunk (r5512 mistakenly contains merged changes in third-party dir only).
git-svn-id: https://svn.pjsip.org/repos/pjproject/branches/projects/uwp@5513 74dad513-b988-da41-8d7b-12977e46ad98
2016-12-28 03:40:07 +00:00
Nanang Izzuddin 6c47f59bc8 Re #1900: Updated project files for target platform version configuration, it is configurable via property sheet build/vs/pjproject-vs14-common-config.props.
git-svn-id: https://svn.pjsip.org/repos/pjproject/branches/projects/uwp@5497 74dad513-b988-da41-8d7b-12977e46ad98
2016-12-09 13:43:07 +00:00
Riza Sulistyo 434417e922 Re #1974: Fix DNS write on freed memory.
Thanks to Richard Mudgett for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5477 74dad513-b988-da41-8d7b-12977e46ad98
2016-11-01 04:10:17 +00:00
Sauw Ming 987f666914 Re #1974: Remove DNS cache entry from resolver's hash table when app callback has a reference.
Thanks to Richard Mudgett for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5475 74dad513-b988-da41-8d7b-12977e46ad98
2016-10-28 06:25:03 +00:00
Sauw Ming 303c352b1d Re #1974:
If there is a pending query, set the return value to that query (instead of NULL)

Thanks to Richard Mudgett for the patch.



git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5473 74dad513-b988-da41-8d7b-12977e46ad98
2016-10-28 03:17:54 +00:00
Sauw Ming e9091aa3b8 Fixed #1974: Various fixes for DNS IPv6
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5471 74dad513-b988-da41-8d7b-12977e46ad98
2016-10-27 05:47:06 +00:00
Nanang Izzuddin 3eb36844aa Misc (re #1945): Fixed assertion in resolver: on read error, source address may be invalid and printing source address will trigger assertion (due to invalid address family).
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5464 74dad513-b988-da41-8d7b-12977e46ad98
2016-10-21 02:46:32 +00:00
Nanang Izzuddin b479b3979e Misc (re #1945): Updated resolver behaviour to not mark nameserver as bad after responding with PJ_DNS_RCODE_SERVFAIL. Thanks George Joseph for the feedback and the patch.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5437 74dad513-b988-da41-8d7b-12977e46ad98
2016-09-15 07:03:37 +00:00
Nanang Izzuddin b977d2fdb0 Fixed #1953: Skip IPv6 socket in resolver on system without IPv6 support.
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5420 74dad513-b988-da41-8d7b-12977e46ad98
2016-08-17 04:29:17 +00:00