Compare commits

..

10 Commits

Author SHA1 Message Date
Philipp Maier bb4d30a81b sysmo_isim_sja2: convert #comments to python comments where possible
Related: SYS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier b5b0dc6fd4 sysmo_isim_sja2: rename classes SYSMO_ISIMSJA2_ to SYSMO_ISIMSJAX_
The classes that model the file layout are applicable on both card
models, so lets replace the 2 with an X
2023-06-23 09:53:47 +02:00
Philipp Maier 5f39c63861 sysmo_isim_sja2: Add comments to explain sysmo_isimsjax_algorithms
Related: OS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier aeafcc6e70 sysmo_isim_sja2: define return types for __str__ and encode methods
Related: OS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier 0b59551050 sysmo_isim_sja2: fix file naming in comment
Related: SYS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier 720aa1ac55 sysmo_isim_sja2: update copyright header
Related: SYS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier 026415636d sysmo_isim_sja2: cosmetic: remove unnecessary new lines
Related: SYS#6473
2023-06-23 09:53:47 +02:00
Philipp Maier 86a6bb6ea5 tests: restore incorrect ADM PIN
The test data, which was submitted with the previous patch also
contained incorrect ADM PIN data, which was not intended. This patch
fixes this.

Related: SYS#6473
2023-06-22 21:53:32 +02:00
Philipp Maier 4e196ceaf4 cosmetic: rename Ki to Key
sysmo-isim-sja2 and sysmo-isim-sjs1 support multiple different
authentication algorithms. The commandline options and the log output
always speaks of "Ki", this is only correct when COMP128 is used. So
lets be more generic and call it "Key" rather then "Ki".

Related: OS#6473
2023-06-22 21:46:24 +02:00
Philipp Maier 7209731730 utils: allow to use a safe default with str_to_id
The input to str_to_id may originate from user input. It may be that the
input is not found in the given table. In this case an exception is
raised. This may be impractical in some cases. Let's add an optional
safe default that is returned in case the string is not found, this can
be used to either select default settings or to detect an error.

Related: SYS#6473
2023-06-22 21:39:04 +02:00
2 changed files with 2 additions and 2 deletions

View File

@ -1,5 +1,5 @@
TOOL=../../sysmo-isim-tool.sja2.py
# data for the test scripts. The values have to match the SIM card inserted while executing the test
IMSI=901700000046734
ADMPIN=71365692 # <==== CHANGE THIS TO THE ADM1 KEY OF YOUR TEST CARD!
ADMPIN=67225880 # <==== CHANGE THIS TO THE ADM1 KEY OF YOUR TEST CARD!
KI=D7882EAE7CD14F06108C55F8E5CFFE93

View File

@ -2,5 +2,5 @@ TOOL=../../sysmo-usim-tool.sjs1.py
# data for the test scripts. The values have to match the SIM card inserted while executing the test
ICCID=8988211320300000028
IMSI=262423203000002
ADMPIN=05039324 # <==== CHANGE THIS TO THE ADM1 KEY OF YOUR TEST CARD!
ADMPIN=55538407 # <==== CHANGE THIS TO THE ADM1 KEY OF YOUR TEST CARD!
KI=94c7f52c8c7337fad1af3a73b17b56ac