odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[IMP] lxml doc recommends using .get/.set/.keys/.values/.items for attributes manipulation where possible 

bzr revid: xmo@openerp.com-20130809135141-114l6262wdts0i43
This commit is contained in:
Xavier Morel 2013-08-09 15:51:41 +02:00
parent 45d5d2f0e1
commit 2a2398eaf9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openerp/tools/convert.py
View File

@ -846,7 +846,7 @@ form: module.record_id""" % (xml_id,)
if '.' in tpl_id:
module, tpl_id = tpl_id.split('.', 1)
# set the full template name for qweb <module>.<id>
el.attrib['t-name'] = '%s.%s' % (module, tpl_id)
el.set('t-name', '%s.%s' % (module, tpl_id))
el.attrib.pop('id', None)
el.tag = 't'
@ -855,7 +855,7 @@ form: module.record_id""" % (xml_id,)
'model': 'ir.ui.view',
}
for att in ['forcecreate', 'context']:
if att in el.attrib:
if att in el.keys():
record_attrs[att] = el.attrib.pop(att)
record = etree.Element('record', attrib=record_attrs)