[FIX] code cleanup (addon account_asset)

simplify the method _entry_count by using search_count and by removing try/except/pass

bzr revid: ged@openerp.com-20140507134544-oi3y8hwf16nituki
This commit is contained in:
Gery Debongnie 2014-05-07 15:45:44 +02:00
parent c13b9a1262
commit 3be9d940f7
1 changed files with 5 additions and 7 deletions

View File

@ -238,13 +238,11 @@ class account_asset_asset(osv.osv):
val['value_residual'] = purchase_value - salvage_value val['value_residual'] = purchase_value - salvage_value
return {'value': val} return {'value': val}
def _entry_count(self, cr, uid, ids, field_name, arg, context=None): def _entry_count(self, cr, uid, ids, field_name, arg, context=None):
res = dict(map(lambda x: (x,0), ids)) MoveLine = self.pool('account.move.line')
try: return {
for entry in self.browse(cr, uid, ids, context=context): asset_id: MoveLine.search_count(cr, uid, [('asset_id', '=', asset_id)], context=context)
res[entry.id] = len(entry.account_move_line_ids) for asset_id in ids
except: }
pass
return res
_columns = { _columns = {
'account_move_line_ids': fields.one2many('account.move.line', 'asset_id', 'Entries', readonly=True, states={'draft':[('readonly',False)]}), 'account_move_line_ids': fields.one2many('account.move.line', 'asset_id', 'Entries', readonly=True, states={'draft':[('readonly',False)]}),
'entry_count': fields.function(_entry_count, string='# Asset Entries', type='integer'), 'entry_count': fields.function(_entry_count, string='# Asset Entries', type='integer'),