[IMP] auth_signup: use contextmanager to manage the cursor
bzr revid: chs@openerp.com-20120813150605-964tpaedgremjnoa
This commit is contained in:
parent
26efdb4b98
commit
661b4e0786
|
@ -2,7 +2,7 @@ import logging
|
||||||
|
|
||||||
import werkzeug.urls
|
import werkzeug.urls
|
||||||
|
|
||||||
import openerp.modules.registry
|
from openerp.modules.registry import RegistryManager
|
||||||
from openerp.addons.web.controllers.main import login_and_redirect
|
from openerp.addons.web.controllers.main import login_and_redirect
|
||||||
import openerp.addons.web.common.http as openerpweb
|
import openerp.addons.web.common.http as openerpweb
|
||||||
|
|
||||||
|
@ -13,10 +13,9 @@ class OpenIDController(openerpweb.Controller):
|
||||||
|
|
||||||
@openerpweb.httprequest
|
@openerpweb.httprequest
|
||||||
def signup(self, req, dbname, name, login, password):
|
def signup(self, req, dbname, name, login, password):
|
||||||
registry = openerp.modules.registry.RegistryManager.get(dbname)
|
|
||||||
cr = registry.db.cursor()
|
|
||||||
url = '/'
|
url = '/'
|
||||||
try:
|
registry = RegistryManager.get(dbname)
|
||||||
|
with registry.cursor() as cr:
|
||||||
try:
|
try:
|
||||||
Users = registry.get('res.users')
|
Users = registry.get('res.users')
|
||||||
credentials = Users.auth_signup(cr, 1, name, login, password)
|
credentials = Users.auth_signup(cr, 1, name, login, password)
|
||||||
|
@ -30,8 +29,6 @@ class OpenIDController(openerpweb.Controller):
|
||||||
# signup error
|
# signup error
|
||||||
_logger.exception('error when signup')
|
_logger.exception('error when signup')
|
||||||
url = "/#action=auth_signup&error=UE" # Unexcpected Error
|
url = "/#action=auth_signup&error=UE" # Unexcpected Error
|
||||||
finally:
|
|
||||||
cr.close()
|
|
||||||
return werkzeug.utils.redirect(url)
|
return werkzeug.utils.redirect(url)
|
||||||
|
|
||||||
# vim:expandtab:tabstop=4:softtabstop=4:shiftwidth=4:
|
# vim:expandtab:tabstop=4:softtabstop=4:shiftwidth=4:
|
||||||
|
|
Loading…
Reference in New Issue