Commit Graph

71892 Commits

Author SHA1 Message Date
Martin Trigaux 066fbb6613 [FIX] account_anglo_saxon: price difference, discount and taxes
When computing the price difference amount do not integrate the eventual discount and taxes included in the price.
Otherwise the total of the generated accounting enty would be higher than the total of the invoice. opw 611350
2014-10-03 12:19:01 +02:00
Denis Ledoux 9066da3369 [FIX] point_of_sale: do not display False as currency if symbol is not set 2014-10-03 12:10:16 +02:00
Denis Ledoux 7cbd524448 [FIX] ir_translation: apply tools.ustr on the trad itself
tools.ustr(None) returns u'None', res[0] can be None.
2014-10-03 12:08:49 +02:00
Denis Ledoux 6d4e1cc73e [FIX] ir_translation: remove control characters from translations
This is possible that control characters (such as line returns) are inserted wrongly in translations
These should not influence on the web interface
2014-10-03 11:20:19 +02:00
dhr-odoo b2cb31c0fb [FIX] account: return format of function field
When no result is found on the function field 'invoice' (account.move.line), instead of returning {move_id: (False, '')}, return {move_id: False} (expected for m2o fields)
Fixes #2138, opw 613096
2014-10-03 09:59:38 +02:00
Denis Ledoux eb9113c04d [FIX] ir_attachment: restrict access to orphan attachments to employees 2014-10-02 15:17:48 +02:00
Denis Ledoux f5cf5fd4eb [FIX] auth_oauth: fb and google oauth providers reset on general settings apply
- The res_config.xml file was missing in the manifest (so couldn't check the use of FB and Google OAuth from the general settings)
 - The default value for these oauth configuration were not set
2014-10-02 12:32:02 +02:00
Denis Ledoux 12df3fe5a0 [FIX] account_analytic_analysis: invoiced field takes customer invoices only
Besides, it subtracts customer invoices with customer refund invoices
2014-10-02 11:53:38 +02:00
Martin Trigaux 78144410a4 [IMP] product: name_get matching on commercial_partner_id for suppliers
The name_get of a product will use some information (e.g. default_code) based on the supplier.
The matching of the supplier should use the commercial_partner_id in case the supplier info are on the company and the partner_id in the context belongs to the company (e.g. creates quotation with a contact of the company).
Fixes #1219
2014-10-02 10:59:18 +02:00
Ravi Gohil e30a5a11a5 [FIX] account: avoid closing fiscalyear with unpost entries
As when closing fiscal periods, forbid to close a fiscal year with unposted entries.
Fixes #1194, opw 610784
2014-10-01 16:25:22 +02:00
Humberto Arocha 6d3855e9dc [FIX] account: remove orphan analytic lines
If the analytic account is not present on an entry, still removes the Analytic Journal Items linked to it.
Fixes #1194, opw 610784
2014-10-01 16:18:47 +02:00
Denis Ledoux 9cc54dcd2c [FIX] product: name_search handles negative operators 2014-10-01 12:39:59 +02:00
dhr-odoo 3c9df6a71f [FIX] purchase: minmum purchase quantity and float precision (opw 610557) 2014-09-30 17:04:04 +02:00
Martin Trigaux 7201bc0250 [FIX] hr_payroll_account: do not create entries with amount at 0
If the salary compuation gives a salary of zero, skip the creation of the account.move.line (not good to have lines at 0).
Fixes lp:1298116, opw 605816
2014-09-30 16:37:24 +02:00
Martin Trigaux 937fb4aa11 [FIX] hr_expense: computation of tax/base amount
When computing the amount for a tax (included) with children, accumulate the included taxes to avoid taking only the last one (opw 614867).
2014-09-30 16:06:07 +02:00
Denis Ledoux 419c439776 [FIX] account: sort partner ledger report by partner ref, name 2014-09-30 15:45:22 +02:00
Olivier Dony 9b1a9c9518 [FIX] tools: remove useless attributes 2014-09-29 17:39:01 +02:00
Denis Ledoux 333852e19d Revert "[FIX] product,float_utils: perform ceiling via float_round with new rounding_method UP"
This reverts commit d4972ffdb6.

Seems to break some cases, at least in _product_reserve from stock/stock.py

Actual use case:

SELECT product_uom, sum(product_qty) AS product_qty FROM stock_move WHERE location_dest_id=%s AND location_id<>%s AND product_id=3645 AND state='done' GROUP BY product_uom;
returning 1 | 6

SELECT product_uom,-sum(product_qty) AS product_qty FROM stock_move WHERE location_id=%s AND location_dest_id<>%s AND product_id=%s AND state in ('done', 'assigned') GROUP BY product_uom;
returning 1 | -6

results += cr.dictfetchall()
    total = 0.0
    results2 = 0.0
    for r in results:
        amount = uom_obj._compute_qty(cr, uid, r['product_uom'], r['product_qty'], context.get('uom', False))
        results2 += amount
        total += amount
Total = 1, amount = -5

It should actually be
Total = 0, amount = -6
2014-09-26 21:21:06 +02:00
Martin Trigaux ceff8ef899 [IMP] account: use float_compare for taxes
Avoiding some python float representation errors
2014-09-26 16:57:28 +02:00
Denis Ledoux cac6a261fe [FIX] project_mrp: task description duplicated + product name translation 2014-09-26 16:05:16 +02:00
Denis Ledoux af37b3022b [FIX] cron: doall false by default
As in most cases, we do not want this doall
2014-09-26 10:17:50 +02:00
Denis Ledoux 074c7b6c25 [FIX] res_users: do not copy login_date when duplicating users 2014-09-25 17:00:59 +02:00
Simon Lejeune 5f6d324db6 [FIX] crm: merge the phonecalls during an opportunities merge 2014-09-25 13:40:45 +02:00
Christophe Simonis 7b17133b53 [FIX] portal_sale: force empty context
The context was removed by 1933e926.
2014-09-25 11:51:15 +02:00
Cedric Snauwaert 311c77bb88 [FIX] product: _compute_qty: first round before ceiling, to avoid pathological cases
Fixes problem when we try to sell 12 units of a product and change it to 1 dozen,
the algorithm was then trying to recompute the original amount and was getting
12,0000048 as a result which was then passed to the ceiling method, getting 13.0!

See also previous commit and issue #1125, PR #1126
2014-09-24 17:11:26 +02:00
Cedric Snauwaert d4972ffdb6 [FIX] product,float_utils: perform ceiling via float_round with new rounding_method UP
Modified product ceiling() to use float_round() with special mode
for rounding UP (away from zero), avoiding pathological cases where
float representations errors were ceiling to the superior unit.

Also added correspding tests for rounding_method=UP

Fixes issue #1125, and replaces PR #1126.
2014-09-24 17:11:25 +02:00
Martin Trigaux 1933e926ff [INP] portal_sale: remove buggy context
Even if this should never be used in normal portal environment, if a user with enough access rights tries to create an invoice, this would crash. We don't need context here (opw 612591).
2014-09-24 17:00:24 +02:00
Guewen Baconnier b5c8ced8ec [IMP] stock: Optimize stock_move.setlast_tracking()
When setlast_tracking is called on a large number of moves in a picking
(e.g.  when splitting moves in a picking), the time to complete grows
exponentially.  The reason is that it loops over all the moves of
a picking, even if it keeps only the last tracking.

The method now uses a search() with a limit so it doesn't need to browse
all the moves.

Added test to check the behaviour of setlast_tracking
Fixes #2448
2014-09-24 16:41:29 +02:00
Ravi Gohil 126ba0a9a8 [FIX] crm: correct open lead or opportunity view from calls
When opening a lead/opportunity from the phonecalls view, we did not open the correct view (always the lead).
This will use the type of the crm.lead to determine which view should be used, opw 608493.
2014-09-24 15:54:44 +02:00
Martin Trigaux 933d098e7d [IMP] stock: do not generate empty backorders
If every line of a partial delivery is at zero, do not generate empty backorders (opw 608680)
2014-09-24 15:16:38 +02:00
Denis Ledoux 5c2fb121ca [FIX] web_calendar: reset dataset index if search result empty 2014-09-24 13:07:59 +02:00
Martin Trigaux 4a064b9374 [FIX] stock: error on stock.partial.move creation
The stock_partial_move wizard removes the required attribute for the field picking_id on a stock.partial.move. This means that we could get moves without picking_id and the previous line was failing ('NoneType' object has no attribute 'currency_id'). opw 614531
2014-09-24 10:30:44 +02:00
Denis Ledoux 9c77f794b4 [FIX] widget html: rendering issue in mail composer on Firefox
The cleditor width does not include the margins. Setting 100% will make the editable area too large (104%) on Firefox (opw 611700).
This issue was already fixed in newer releases, from commit 9247c37de7
Nevertheless, it introduced a new issue: while editing the form, the content of widgets html which were located in hidden notebook pages weren't displayed when displaying the page content.
opw-614448
2014-09-23 18:53:17 +02:00
Denis Ledoux faa04a43de [FIX] account_voucher: import invoices, sign according to transaction type 2014-09-22 15:58:55 +02:00
Denis Ledoux 1f5c6f16d9 [FIX] auth_ldap: remove unused sql column 2014-09-22 15:00:53 +02:00
Martin Trigaux ee4c67dc10 [FIX] account_voucher: convertion rate of purchase receipt
The conversion of currencies in vouchers are made based on payment_rate_currency_id field (instead of usual currency_id).
This field was not present in the purchase view and not correctly set when we change the journal (and thus the currency) which was leading to rates of 1. With a rate of 1, the amount is equal to the currency amount (which is rarely correct). opw 611254
2014-09-22 13:44:15 +02:00
Martin Trigaux 9b87d6f371 [FIX] purchase: keep fallback behaviour that was removed at rev 8973217
If no valid invocie is found on the purchase order line, use the price and currency of the line (coherent with help message)
2014-09-19 14:47:33 +02:00
Martin Trigaux 6b9b948a3c [IMP] stock: display translated selection value in message
When a user tried to delete a done or canceled picking, the error messages used to display the key of the selection field ('done' or 'cancel') which was surprising in other languages than English. This patch takes the string value of the selection field, keeping the context to get the translated value (opw 613068)
2014-09-19 11:34:47 +02:00
Martin Trigaux bcc08ee422 [FIX] event: translate templates into user language
When sending an email of the registration/confirmation, the context was lost and the tempate sticked in en_US.
With the patch, the template will use the current user's language.
2014-09-19 11:07:04 +02:00
Denis Ledoux a218a9ed3f [FIX] kanban: wrong condition to reset the dataset index
The dataset index should be reset either if the dataset is empty or the index is greater than the records size
2014-09-18 15:56:23 +02:00
rmu-odoo 16a969214f [FIX] hr_timesheet_sheet: avoid error when sort attendances
When an attendance line is edited, the tuple has no key 'name' which lead to a traceback.
Fixes #546
2014-09-17 18:25:08 +02:00
qdp-odoo 8973217ea7 [FIX] stock/purchase: dates and currency rates
Use the currency rate of the purchase date instead of the one of at the reception time (opw 610430)
2014-09-17 18:04:41 +02:00
Martin Trigaux 3a50d4b35b [FIX] account_anglo_saxon: correctly set the accounts for returns
The generated moves on a return should be the reverse of the outgoing move.
Fixes #1817, opw 604417
2014-09-17 17:10:55 +02:00
Olivier Dony 938502aa37 [FIX] loading: always process auto-installed modules for new databases
If the server was started without -i or -u and
happened to initialize a fresh database,
auto-installed modules that depend
on `base` only would stay in status "to install"
without actually being installed (until the next
installation round was triggered).
This was of little consequence in 7.0, but causes
a crash in 8.0.

Fixes #953
2014-09-17 15:11:01 +02:00
Denis Ledoux f5f76094a7 [FIX] orm write: do not try to store computed & stored fields for relational records deleted by *2many fields
opw-613772
2014-09-17 13:32:30 +02:00
Denis Ledoux 0a9c64c17d [FIX] auth_ldap: avoid to try twice the authentication to the ldap server
See #1982
2014-09-16 18:33:42 +02:00
Denis Ledoux ce84d6107f [FIX] point_of_sale: set journal as pos payment method on setting journal in the payment methods of a pos config when none is set. 2014-09-16 17:57:03 +02:00
Denis Ledoux 74072441cc [FIX] sale: backport of rev 709e22c32a
[FIX] sale: sale report view, wrong domain

Quotations are sale.order with state draft and sent
Sale orders are sale.order with state other than draft, sent and cancel
2014-09-15 16:57:51 +02:00
Martin Trigaux 32f5168974 [FIX] orm: do not drop foreign keys of transient models
During the update of a module, the existing foreign keys are dropped if they have a different ondelete_rule than the one specified on the field.
The foreign keys for many2one transiant -> non-transiant are created with cascade rule by default (see `m2o_add_foreign_key_checked` method) so the check needs to be realised in the same conditions.
2014-09-15 15:24:53 +02:00
Denis Ledoux 42680c9906 [FIX] web: backport of ebb826a and 2372d30
Fixing breadcrumb not being displayed after some action button (e.g. validate invoice, opw 612763)
2014-09-15 12:38:35 +02:00