9
0
Fork 0

UBI: Fix memory leak in ubi_attach_fastmap() error path

On error we have to free all three temporary lists.

Reported-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Richard Weinberger 2013-09-28 15:55:15 +02:00 committed by Sascha Hauer
parent dee73c54b0
commit 71791bd2cb
1 changed files with 13 additions and 0 deletions

View File

@ -830,6 +830,19 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
fail_bad:
ret = UBI_BAD_FASTMAP;
fail:
list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list) {
free(tmp_aeb);
list_del(&tmp_aeb->u.list);
}
list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &eba_orphans, u.list) {
free(tmp_aeb);
list_del(&tmp_aeb->u.list);
}
list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &lfree, u.list) {
free(tmp_aeb);
list_del(&tmp_aeb->u.list);
}
return ret;
}