2007-01-21 21:28:51 +00:00
# BB Class inspired by ebuild.sh
#
# This class will test files after installation for certain
# security issues and other kind of issues.
#
# Checks we do:
# -Check the ownership and permissions
# -Check the RUNTIME path for the $TMPDIR
# -Check if .la files wrongly point to workdir
# -Check if .pc files wrongly point to workdir
2008-03-19 15:53:07 +00:00
# -Check if packages contains .debug directories or .so files
# where they should be in -dev or -dbg
2007-09-02 09:46:35 +00:00
# -Check if config.log contains traces to broken autoconf tests
2015-08-17 07:10:12 +00:00
# -Check invalid characters (non-utf8) on some package metadata
2012-01-05 06:30:35 +00:00
# -Ensure that binaries in base_[bindir|sbindir|libdir] do not link
# into exec_prefix
# -Check that scripts in base_[bindir|sbindir|libdir] do not reference
# files under exec_prefix
2007-01-21 21:28:51 +00:00
2012-01-05 06:30:35 +00:00
# unsafe-references-in-binaries requires prelink-rtld from
# prelink-native, but we don't want this DEPENDS for -native builds
QADEPENDS = "prelink-native"
2012-10-27 08:48:17 +00:00
QADEPENDS_class-native = ""
QADEPENDS_class-nativesdk = ""
insane/package: let package.bbclass inherit insane.bbclass
RP's comment:
"What we're trying to do is move everything to use a standard mechanism
for reporting issues of this type (do_package). With insane.bbclass, you
can elect whether a given type of error is a warning or error and fails
the task."
* The package.bbclass had used package_qa_handle_error() which is from
insane.bbclass, and we will use it for handling other warnings and
errors, so let package.bbclass inherit insane.bbclass, this change will
make the insane as a requirement (always included).
* Change the "PACKAGEFUNCS ?=" to "+=", otherwise there would be an
error like:
Exception: variable SUMMARY references itself!
This is because we let package.bbclass inherit insane.bbclass, and
PACKAGEFUNCS has been set in insane.bbclass, so the "PACKAGEFUNCS ?="
will set nothing, then the "emit_pkgdata" doesn't run which will
cause this error.
* Add a QA_SANE variable in insane.bbclass, once the error type
is ERROR_QA, it will fail the task and stop the build.
[YOCTO #3190]
[YOCTO #4396]
(From OE-Core rev: 852dead71387c66ec0cba7c71e3814a74e409560)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-05-11 22:46:10 +00:00
QA_SANE = "True"
2007-09-02 09:46:35 +00:00
2013-05-11 22:46:10 +00:00
# Elect whether a given type of error is a warning or error, they may
# have been set by other files.
WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
textrel already-stripped incompatible-license files-invalid \
installed-vs-shipped compile-host-path install-host-path \
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
pn-overrides infodir build-deps file-rdeps \
2015-06-10 05:13:45 +00:00
unknown-configure-option symlink-to-sysroot multilib \
2015-10-21 13:18:50 +00:00
invalid-packageconfig host-user-contaminated \
2013-05-11 22:46:10 +00:00
"
2013-06-28 15:10:25 +00:00
ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
2013-05-11 22:46:10 +00:00
perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
split-strip packages-list pkgv-undefined var-undefined \
2015-08-17 07:10:12 +00:00
version-going-backwards expanded-d invalid-chars \
2016-02-01 16:21:24 +00:00
license-checksum dev-elf \
2013-05-11 22:46:10 +00:00
"
2015-09-01 22:23:03 +00:00
FAKEROOT_QA = "host-user-contaminated"
2015-09-01 22:23:02 +00:00
FAKEROOT_QA[doc] = "QA tests which need to run under fakeroot. If any \
enabled tests are listed here, the do_package_qa task will run under fakeroot."
2013-05-11 22:46:10 +00:00
ALL_QA = "${WARN_QA} ${ERROR_QA}"
2016-02-14 14:30:40 +00:00
UNKNOWN_CONFIGURE_WHITELIST ?= "--enable-nls --disable-nls --disable-silent-rules --disable-dependency-tracking --with-libtool-sysroot --disable-static"
2013-10-08 14:30:05 +00:00
2007-09-02 09:46:35 +00:00
#
# dictionary for elf headers
#
2008-03-19 15:53:07 +00:00
# feel free to add and correct.
2007-09-02 09:46:35 +00:00
#
# TARGET_OS TARGET_ARCH MACHINE, OSABI, ABIVERSION, Little Endian, 32bit?
insane: Add mechanism to extend QA machine information from BSP layer
In order to add a new architecture or sub-architecture to OE, you currently
need to tweak the table in insane.bbclass. This adds a mechanism so this
can be done from a BSP layer. It needs a function definition which needs
a class file but can then be done with something like:
def my_testfunc(machdata, d):
machdata["testmachine"] = {
"test64": ( 8, 0, 0, False, 32),
"testel": ( 8, 0, 0, True, 32),
}
return machdata
PACKAGEQA_EXTRA_MACHDEFFUNCS = "my_testfunc"
[YOCTO #8554]
(From OE-Core rev: c57550c9cca598315ba4408e44b138cecc22b8a0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-07-22 14:25:00 +00:00
def package_qa_get_machine_dict(d):
machdata = {
2010-07-08 09:23:17 +00:00
"darwin9" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
},
2015-03-31 15:23:14 +00:00
"eabi" : {
"arm" : (40, 0, 0, True, 32),
},
"elf" : {
2016-11-23 13:03:49 +00:00
"aarch64" : (183, 0, 0, True, 64),
"aarch64_be" :(183, 0, 0, False, 64),
2015-03-31 15:23:14 +00:00
"i586" : (3, 0, 0, True, 32),
"x86_64": (62, 0, 0, True, 64),
2015-04-12 17:27:38 +00:00
"epiphany": (4643, 0, 0, True, 32),
2016-10-11 16:56:24 +00:00
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
2015-03-31 15:23:14 +00:00
},
2007-09-02 09:46:35 +00:00
"linux" : {
2012-09-27 13:13:08 +00:00
"aarch64" : (183, 0, 0, True, 64),
2013-10-10 10:16:51 +00:00
"aarch64_be" :(183, 0, 0, False, 64),
2011-03-01 18:42:28 +00:00
"arm" : (40, 97, 0, True, 32),
"armeb": (40, 97, 0, False, 32),
"powerpc": (20, 0, 0, False, 32),
2011-07-22 09:24:52 +00:00
"powerpc64": (21, 0, 0, False, 64),
2011-03-01 18:42:28 +00:00
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": (62, 0, 0, True, 64),
"ia64": (50, 0, 0, True, 64),
"alpha": (36902, 0, 0, True, 64),
"hppa": (15, 3, 0, False, 32),
"m68k": ( 4, 0, 0, False, 32),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
2012-04-25 22:32:12 +00:00
"mips64": ( 8, 0, 0, False, 64),
"mips64el": ( 8, 0, 0, True, 64),
2016-10-04 11:31:13 +00:00
"mipsisa32r6": ( 8, 0, 0, False, 32),
"mipsisa32r6el": ( 8, 0, 0, True, 32),
"mipsisa64r6": ( 8, 0, 0, False, 64),
"mipsisa64r6el": ( 8, 0, 0, True, 64),
2015-09-19 22:43:10 +00:00
"nios2": (113, 0, 0, True, 32),
2011-03-01 18:42:28 +00:00
"s390": (22, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
"sparc": ( 2, 0, 0, False, 32),
2013-04-08 06:28:38 +00:00
"microblaze": (189, 0, 0, False, 32),
2015-05-05 04:27:54 +00:00
"microblazeeb":(189, 0, 0, False, 32),
2013-04-08 06:28:38 +00:00
"microblazeel":(189, 0, 0, True, 32),
2007-09-02 09:46:35 +00:00
},
"linux-uclibc" : {
2011-03-01 18:42:28 +00:00
"arm" : ( 40, 97, 0, True, 32),
"armeb": ( 40, 97, 0, False, 32),
"powerpc": ( 20, 0, 0, False, 32),
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": ( 62, 0, 0, True, 64),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
2012-04-25 22:32:12 +00:00
"mips64": ( 8, 0, 0, False, 64),
"mips64el": ( 8, 0, 0, True, 64),
2011-03-01 18:42:28 +00:00
"avr32": (6317, 0, 0, False, 32),
2014-02-03 15:15:29 +00:00
"sh4": (42, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
2007-09-02 09:46:35 +00:00
},
2014-05-29 07:01:01 +00:00
"linux-musl" : {
2015-05-06 07:04:56 +00:00
"aarch64" : (183, 0, 0, True, 64),
"aarch64_be" :(183, 0, 0, False, 64),
2014-05-29 07:01:01 +00:00
"arm" : ( 40, 97, 0, True, 32),
"armeb": ( 40, 97, 0, False, 32),
"powerpc": ( 20, 0, 0, False, 32),
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": ( 62, 0, 0, True, 64),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
"mips64": ( 8, 0, 0, False, 64),
"mips64el": ( 8, 0, 0, True, 64),
2016-02-09 14:33:14 +00:00
"microblaze": (189, 0, 0, False, 32),
"microblazeeb":(189, 0, 0, False, 32),
"microblazeel":(189, 0, 0, True, 32),
2016-12-06 15:17:18 +00:00
"sh4": ( 42, 0, 0, True, 32),
2014-05-29 07:01:01 +00:00
},
2007-09-02 09:46:35 +00:00
"uclinux-uclibc" : {
2011-03-01 18:42:28 +00:00
"bfin": ( 106, 0, 0, True, 32),
2007-09-02 09:46:35 +00:00
},
"linux-gnueabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2014-05-29 07:01:01 +00:00
"linux-musleabi" : {
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
},
2011-04-01 03:07:44 +00:00
"linux-uclibceabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2010-07-08 09:23:17 +00:00
"linux-gnuspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
2014-05-29 07:01:01 +00:00
"linux-muslspe" : {
"powerpc": (20, 0, 0, False, 32),
},
2010-07-08 09:23:17 +00:00
"linux-uclibcspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
2011-05-05 16:26:28 +00:00
"linux-gnu" : {
2013-02-27 18:20:30 +00:00
"powerpc": (20, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
2011-05-05 16:26:28 +00:00
},
2011-07-26 09:19:41 +00:00
"linux-gnux32" : {
"x86_64": (62, 0, 0, True, 32),
},
insane.bbclass and friends: Fix sanity checks and multlib headers for n32
The n32 architecture is odd, in that it's a mips64 ABI which happens
to be 32-bit. To handle this, we need something in the environment
which can be used to distinguish it. The obvious place to stash this
is the ABI suffix, so we use "n32" as an ABI suffix. This allows
a couple of improved checks:
1. In insane.bbclass, we can use "linux-gnun32" to discern that it's
okay for a mips64 binary to be a 32-bit binary in some cases.
2. In multilib_header, we can check for the n32 ABI, and use a distinct
value.
3. In siteinfo, add linux-gnun32 as a synonym for linux, similar to
what's done for linux-gnux32, and tell the mips*-linux-gnun32 variants
to pick up the corresponding mips-linux site configs.
Note that the multilib header wrapper already has n32 hooks in it, there
was just nothing creating -n32 header variants.
(From OE-Core rev: c8e8e8ba22eaa335ac72f0e5b317f804035133e2)
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-23 22:56:00 +00:00
"linux-gnun32" : {
"mips64": ( 8, 0, 0, False, 32),
siteinfo/insane: More n32 fixups
For perfectly sound reasons, n32 MIPS is a mips64 subset denoted by an
ABI change, thus, "mips64-vendor-linux-gnun32" rather than
"mips-vendor-linux-gnu". A previous change had fixed up insane.bbclass
to recognize these, which mostly worked, but left SITEINFO_BITS set to
64.
Since bit-32 is processed first, and there are specific checks for
linux-gnun32, modify the mips64-linux-gnun32 lines to specify "bit-32",
so things that check SITEINFO_BITS get the right answer. Also, drop
the mips{,el}-linux-gnun32 lines, because that's not a valid combination;
n32 only makes sense for mips64.
Also, the insane.bbclass change spelled "mips64el" as "mipsel64", which
no one noticed because no one's using little-endian n32, apparently.
(From OE-Core rev: 0c243a550f5a0e539823fe168bcc7b2bbb9f19e1)
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-02-21 17:40:22 +00:00
"mips64el": ( 8, 0, 0, True, 32),
2016-12-16 15:14:37 +00:00
"mipsisa64r6": ( 8, 0, 0, False, 32),
"mipsisa64r6el":( 8, 0, 0, True, 32),
insane.bbclass and friends: Fix sanity checks and multlib headers for n32
The n32 architecture is odd, in that it's a mips64 ABI which happens
to be 32-bit. To handle this, we need something in the environment
which can be used to distinguish it. The obvious place to stash this
is the ABI suffix, so we use "n32" as an ABI suffix. This allows
a couple of improved checks:
1. In insane.bbclass, we can use "linux-gnun32" to discern that it's
okay for a mips64 binary to be a 32-bit binary in some cases.
2. In multilib_header, we can check for the n32 ABI, and use a distinct
value.
3. In siteinfo, add linux-gnun32 as a synonym for linux, similar to
what's done for linux-gnux32, and tell the mips*-linux-gnun32 variants
to pick up the corresponding mips-linux site configs.
Note that the multilib header wrapper already has n32 hooks in it, there
was just nothing creating -n32 header variants.
(From OE-Core rev: c8e8e8ba22eaa335ac72f0e5b317f804035133e2)
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-23 22:56:00 +00:00
},
2012-08-20 16:52:21 +00:00
}
2007-09-02 09:46:35 +00:00
insane: Add mechanism to extend QA machine information from BSP layer
In order to add a new architecture or sub-architecture to OE, you currently
need to tweak the table in insane.bbclass. This adds a mechanism so this
can be done from a BSP layer. It needs a function definition which needs
a class file but can then be done with something like:
def my_testfunc(machdata, d):
machdata["testmachine"] = {
"test64": ( 8, 0, 0, False, 32),
"testel": ( 8, 0, 0, True, 32),
}
return machdata
PACKAGEQA_EXTRA_MACHDEFFUNCS = "my_testfunc"
[YOCTO #8554]
(From OE-Core rev: c57550c9cca598315ba4408e44b138cecc22b8a0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-07-22 14:25:00 +00:00
# Add in any extra user supplied data which may come from a BSP layer, removing the
# need to always change this class directly
2016-12-14 21:13:04 +00:00
extra_machdata = (d.getVar("PACKAGEQA_EXTRA_MACHDEFFUNCS") or "").split()
insane: Add mechanism to extend QA machine information from BSP layer
In order to add a new architecture or sub-architecture to OE, you currently
need to tweak the table in insane.bbclass. This adds a mechanism so this
can be done from a BSP layer. It needs a function definition which needs
a class file but can then be done with something like:
def my_testfunc(machdata, d):
machdata["testmachine"] = {
"test64": ( 8, 0, 0, False, 32),
"testel": ( 8, 0, 0, True, 32),
}
return machdata
PACKAGEQA_EXTRA_MACHDEFFUNCS = "my_testfunc"
[YOCTO #8554]
(From OE-Core rev: c57550c9cca598315ba4408e44b138cecc22b8a0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-07-22 14:25:00 +00:00
for m in extra_machdata:
call = m + "(machdata, d)"
locs = { "machdata" : machdata, "d" : d}
machdata = bb.utils.better_eval(call, locs)
return machdata
2010-07-08 09:23:17 +00:00
2016-08-18 16:33:31 +00:00
def package_qa_clean_path(path, d, pkg=None):
"""
Remove redundant paths from the path for display. If pkg isn't set then
TMPDIR is stripped, otherwise PKGDEST/pkg is stripped.
"""
if pkg:
2016-12-14 21:13:04 +00:00
path = path.replace(os.path.join(d.getVar("PKGDEST"), pkg), "/")
return path.replace(d.getVar("TMPDIR"), "/").replace("//", "/")
2007-09-02 09:46:35 +00:00
2014-07-14 08:31:50 +00:00
def package_qa_write_error(type, error, d):
2016-12-14 21:13:04 +00:00
logfile = d.getVar('QA_LOGFILE')
2008-04-22 21:22:11 +00:00
if logfile:
2016-12-14 21:13:04 +00:00
p = d.getVar('P')
2016-05-21 11:26:45 +00:00
with open(logfile, "a+") as f:
2016-05-30 10:20:28 +00:00
f.write("%s: %s [%s]\n" % (p, error, type))
2008-04-22 21:22:11 +00:00
2011-07-01 14:47:12 +00:00
def package_qa_handle_error(error_class, error_msg, d):
2014-07-14 08:31:50 +00:00
package_qa_write_error(error_class, error_msg, d)
2016-12-14 21:13:04 +00:00
if error_class in (d.getVar("ERROR_QA") or "").split():
2014-07-14 08:31:50 +00:00
bb.error("QA Issue: %s [%s]" % (error_msg, error_class))
insane/package: let package.bbclass inherit insane.bbclass
RP's comment:
"What we're trying to do is move everything to use a standard mechanism
for reporting issues of this type (do_package). With insane.bbclass, you
can elect whether a given type of error is a warning or error and fails
the task."
* The package.bbclass had used package_qa_handle_error() which is from
insane.bbclass, and we will use it for handling other warnings and
errors, so let package.bbclass inherit insane.bbclass, this change will
make the insane as a requirement (always included).
* Change the "PACKAGEFUNCS ?=" to "+=", otherwise there would be an
error like:
Exception: variable SUMMARY references itself!
This is because we let package.bbclass inherit insane.bbclass, and
PACKAGEFUNCS has been set in insane.bbclass, so the "PACKAGEFUNCS ?="
will set nothing, then the "emit_pkgdata" doesn't run which will
cause this error.
* Add a QA_SANE variable in insane.bbclass, once the error type
is ERROR_QA, it will fail the task and stop the build.
[YOCTO #3190]
[YOCTO #4396]
(From OE-Core rev: 852dead71387c66ec0cba7c71e3814a74e409560)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-05-11 22:46:10 +00:00
d.setVar("QA_SANE", False)
2011-07-07 17:32:47 +00:00
return False
2016-12-14 21:13:04 +00:00
elif error_class in (d.getVar("WARN_QA") or "").split():
2014-07-14 08:31:50 +00:00
bb.warn("QA Issue: %s [%s]" % (error_msg, error_class))
2013-06-10 20:47:07 +00:00
else:
2014-07-14 08:31:50 +00:00
bb.note("QA Issue: %s [%s]" % (error_msg, error_class))
2013-06-10 20:47:07 +00:00
return True
2007-09-02 09:46:35 +00:00
2016-01-20 08:34:23 +00:00
def package_qa_add_message(messages, section, new_msg):
if section not in messages:
messages[section] = new_msg
else:
messages[section] = messages[section] + "\n" + new_msg
2012-09-13 00:54:00 +00:00
QAPATHTEST[libexec] = "package_qa_check_libexec"
def package_qa_check_libexec(path,name, d, elf, messages):
# Skip the case where the default is explicitly /usr/libexec
2016-12-14 21:13:04 +00:00
libexec = d.getVar('libexecdir')
2012-09-13 00:54:00 +00:00
if libexec == "/usr/libexec":
return True
if 'libexec' in path.split(os.path.sep):
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "libexec", "%s: %s is using libexec please relocate to %s" % (name, package_qa_clean_path(path, d), libexec))
2012-09-13 00:54:00 +00:00
return False
return True
2011-07-01 14:47:12 +00:00
QAPATHTEST[rpaths] = "package_qa_check_rpath"
def package_qa_check_rpath(file,name, d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check for dangerous RPATHs
"""
2010-07-08 09:23:17 +00:00
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
2012-10-15 10:28:00 +00:00
if os.path.islink(file):
return
2016-12-14 21:13:04 +00:00
bad_dirs = [d.getVar('BASE_WORKDIR'), d.getVar('STAGING_DIR_TARGET')]
2007-01-21 21:28:51 +00:00
2012-10-01 17:29:23 +00:00
phdrs = elf.run_objdump("-p", d)
import re
rpath_re = re.compile("\s+RPATH\s+(.*)")
for line in phdrs.split("\n"):
2013-05-07 12:55:53 +00:00
m = rpath_re.match(line)
if m:
rpath = m.group(1)
for dir in bad_dirs:
2012-10-01 17:29:23 +00:00
if dir in rpath:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "rpaths", "package %s contains bad RPATH %s in file %s" % (name, rpath, file))
2008-03-19 15:53:07 +00:00
2011-07-14 09:02:11 +00:00
QAPATHTEST[useless-rpaths] = "package_qa_check_useless_rpaths"
2011-07-15 11:19:35 +00:00
def package_qa_check_useless_rpaths(file, name, d, elf, messages):
2011-07-14 09:02:11 +00:00
"""
Check for RPATHs that are useless but not dangerous
"""
2012-08-20 21:05:58 +00:00
def rpath_eq(a, b):
return os.path.normpath(a) == os.path.normpath(b)
2011-07-14 09:02:11 +00:00
if not elf:
return
2012-10-15 10:28:00 +00:00
if os.path.islink(file):
return
2016-12-14 21:13:04 +00:00
libdir = d.getVar("libdir")
base_libdir = d.getVar("base_libdir")
2011-07-14 09:02:11 +00:00
2012-10-01 17:29:23 +00:00
phdrs = elf.run_objdump("-p", d)
2011-07-14 09:02:11 +00:00
import re
rpath_re = re.compile("\s+RPATH\s+(.*)")
2012-10-01 17:29:23 +00:00
for line in phdrs.split("\n"):
2013-05-07 12:55:53 +00:00
m = rpath_re.match(line)
if m:
rpath = m.group(1)
if rpath_eq(rpath, libdir) or rpath_eq(rpath, base_libdir):
# The dynamic linker searches both these places anyway. There is no point in
# looking there again.
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "useless-rpaths", "%s: %s contains probably-redundant RPATH %s" % (name, package_qa_clean_path(file, d), rpath))
2011-07-14 09:02:11 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[dev-so] = "package_qa_check_dev"
def package_qa_check_dev(path, name, d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
2010-07-08 09:23:17 +00:00
Check for ".so" library symlinks in non-dev packages
2007-01-21 21:28:51 +00:00
"""
2013-04-10 13:34:56 +00:00
if not name.endswith("-dev") and not name.endswith("-dbg") and not name.endswith("-ptest") and not name.startswith("nativesdk-") and path.endswith(".so") and os.path.islink(path):
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "dev-so", "non -dev/-dbg/nativesdk- package contains symlink .so: %s path '%s'" % \
(name, package_qa_clean_path(path,d)))
2010-07-08 09:23:17 +00:00
2016-02-01 16:21:24 +00:00
QAPATHTEST[dev-elf] = "package_qa_check_dev_elf"
def package_qa_check_dev_elf(path, name, d, elf, messages):
"""
Check that -dev doesn't contain real shared libraries. The test has to
check that the file is not a link and is an ELF object as some recipes
install link-time .so files that are linker scripts.
"""
if name.endswith("-dev") and path.endswith(".so") and not os.path.islink(path) and elf:
package_qa_add_message(messages, "dev-elf", "-dev package contains non-symlink .so: %s path '%s'" % \
(name, package_qa_clean_path(path,d)))
2012-01-25 19:29:38 +00:00
QAPATHTEST[staticdev] = "package_qa_check_staticdev"
def package_qa_check_staticdev(path, name, d, elf, messages):
"""
Check for ".a" library in non-staticdev packages
There are a number of exceptions to this rule, -pic packages can contain
static libraries, the _nonshared.a belong with their -dev packages and
libgcc.a, libgcov.a will be skipped in their packages
"""
2013-04-10 13:34:56 +00:00
if not name.endswith("-pic") and not name.endswith("-staticdev") and not name.endswith("-ptest") and path.endswith(".a") and not path.endswith("_nonshared.a"):
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "staticdev", "non -staticdev package contains static .a library: %s path '%s'" % \
(name, package_qa_clean_path(path,d)))
2012-01-25 19:29:38 +00:00
2012-09-19 09:32:39 +00:00
def package_qa_check_libdir(d):
"""
Check for wrong library installation paths. For instance, catch
recipes installing /lib/bar.so when ${base_libdir}="lib32" or
installing in /usr/lib64 when ${libdir}="/usr/lib"
"""
import re
2016-12-14 21:13:04 +00:00
pkgdest = d.getVar('PKGDEST')
2012-09-19 09:32:39 +00:00
base_libdir = d.getVar("base_libdir",True) + os.sep
2016-12-14 21:13:04 +00:00
libdir = d.getVar("libdir") + os.sep
libexecdir = d.getVar("libexecdir") + os.sep
exec_prefix = d.getVar("exec_prefix") + os.sep
2012-09-19 09:32:39 +00:00
messages = []
2016-04-01 16:49:12 +00:00
# The re's are purposely fuzzy, as some there are some .so.x.y.z files
# that don't follow the standard naming convention. It checks later
# that they are actual ELF files
2013-07-15 18:17:43 +00:00
lib_re = re.compile("^/lib.+\.so(\..+)?$")
2013-07-03 15:09:32 +00:00
exec_re = re.compile("^%s.*/lib.+\.so(\..+)?$" % exec_prefix)
2012-09-19 09:32:39 +00:00
2013-07-15 18:17:44 +00:00
for root, dirs, files in os.walk(pkgdest):
if root == pkgdest:
# Skip subdirectories for any packages with libdir in INSANE_SKIP
skippackages = []
for package in dirs:
2016-12-14 21:13:04 +00:00
if 'libdir' in (d.getVar('INSANE_SKIP_' + package) or "").split():
2013-07-15 18:17:44 +00:00
bb.note("Package %s skipping libdir QA test" % (package))
skippackages.append(package)
2016-12-14 21:13:04 +00:00
elif d.getVar('PACKAGE_DEBUG_SPLIT_STYLE') == 'debug-file-directory' and package.endswith("-dbg"):
2015-11-02 02:07:54 +00:00
bb.note("Package %s skipping libdir QA test for PACKAGE_DEBUG_SPLIT_STYLE equals debug-file-directory" % (package))
skippackages.append(package)
2013-07-15 18:17:44 +00:00
for package in skippackages:
dirs.remove(package)
for file in files:
full_path = os.path.join(root, file)
rel_path = os.path.relpath(full_path, pkgdest)
if os.sep in rel_path:
package, rel_path = rel_path.split(os.sep, 1)
rel_path = os.sep + rel_path
if lib_re.match(rel_path):
if base_libdir not in rel_path:
2016-04-01 16:49:12 +00:00
# make sure it's an actual ELF file
elf = oe.qa.ELFFile(full_path)
try:
elf.open()
messages.append("%s: found library in wrong location: %s" % (package, rel_path))
except (oe.qa.NotELFFileError):
pass
2013-07-15 18:17:44 +00:00
if exec_re.match(rel_path):
2015-12-08 10:51:39 +00:00
if libdir not in rel_path and libexecdir not in rel_path:
2016-04-01 16:49:12 +00:00
# make sure it's an actual ELF file
elf = oe.qa.ELFFile(full_path)
try:
elf.open()
messages.append("%s: found library in wrong location: %s" % (package, rel_path))
except (oe.qa.NotELFFileError):
pass
2013-07-15 18:17:44 +00:00
2012-09-19 09:32:39 +00:00
if messages:
package_qa_handle_error("libdir", "\n".join(messages), d)
2011-07-01 14:47:12 +00:00
QAPATHTEST[debug-files] = "package_qa_check_dbg"
def package_qa_check_dbg(path, name, d, elf, messages):
2010-07-08 09:23:17 +00:00
"""
Check for ".debug" files or directories outside of the dbg package
"""
2013-04-10 13:34:56 +00:00
if not "-dbg" in name and not "-ptest" in name:
2010-07-08 09:23:17 +00:00
if '.debug' in path.split(os.path.sep):
2016-01-20 08:34:23 +00:00
messages("debug-files", "non debug package contains .debug directory: %s path %s" % \
(name, package_qa_clean_path(path,d)))
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[perms] = "package_qa_check_perm"
def package_qa_check_perm(path,name,d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check the permission of files
"""
2011-07-01 14:47:12 +00:00
return
2007-01-21 21:28:51 +00:00
2012-01-05 06:30:35 +00:00
QAPATHTEST[unsafe-references-in-binaries] = "package_qa_check_unsafe_references_in_binaries"
def package_qa_check_unsafe_references_in_binaries(path, name, d, elf, messages):
2014-02-03 15:15:29 +00:00
"""
Ensure binaries in base_[bindir|sbindir|libdir] do not link to files under exec_prefix
"""
if unsafe_references_skippable(path, name, d):
return
if elf:
import subprocess as sub
2016-12-14 21:13:04 +00:00
pn = d.getVar('PN')
2014-02-03 15:15:29 +00:00
2016-12-14 21:13:04 +00:00
exec_prefix = d.getVar('exec_prefix')
sysroot_path = d.getVar('STAGING_DIR_TARGET')
2014-02-03 15:15:29 +00:00
sysroot_path_usr = sysroot_path + exec_prefix
try:
2016-05-20 10:17:05 +00:00
ldd_output = bb.process.Popen(["prelink-rtld", "--root", sysroot_path, path], stdout=sub.PIPE).stdout.read().decode("utf-8")
2014-02-03 15:15:29 +00:00
except bb.process.CmdError:
error_msg = pn + ": prelink-rtld aborted when processing %s" % path
package_qa_handle_error("unsafe-references-in-binaries", error_msg, d)
return False
if sysroot_path_usr in ldd_output:
ldd_output = ldd_output.replace(sysroot_path, "")
2016-12-14 21:13:04 +00:00
pkgdest = d.getVar('PKGDEST')
packages = d.getVar('PACKAGES')
2014-02-03 15:15:29 +00:00
for package in packages.split():
short_path = path.replace('%s/%s' % (pkgdest, package), "", 1)
if (short_path != path):
break
base_err = pn + ": %s, installed in the base_prefix, requires a shared library under exec_prefix (%s)" % (short_path, exec_prefix)
for line in ldd_output.split('\n'):
if exec_prefix in line:
error_msg = "%s: %s" % (base_err, line.strip())
package_qa_handle_error("unsafe-references-in-binaries", error_msg, d)
return False
2012-01-05 06:30:35 +00:00
QAPATHTEST[unsafe-references-in-scripts] = "package_qa_check_unsafe_references_in_scripts"
def package_qa_check_unsafe_references_in_scripts(path, name, d, elf, messages):
2014-02-03 15:15:29 +00:00
"""
Warn if scripts in base_[bindir|sbindir|libdir] reference files under exec_prefix
"""
if unsafe_references_skippable(path, name, d):
return
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
if not elf:
import stat
import subprocess
2016-12-14 21:13:04 +00:00
pn = d.getVar('PN')
2014-02-03 15:15:29 +00:00
# Ensure we're checking an executable script
statinfo = os.stat(path)
if bool(statinfo.st_mode & stat.S_IXUSR):
# grep shell scripts for possible references to /exec_prefix/
2016-12-14 21:13:04 +00:00
exec_prefix = d.getVar('exec_prefix')
2016-02-19 02:38:39 +00:00
statement = "grep -e '%s/[^ :]\{1,\}/[^ :]\{1,\}' %s > /dev/null" % (exec_prefix, path)
2014-02-03 15:15:29 +00:00
if subprocess.call(statement, shell=True) == 0:
error_msg = pn + ": Found a reference to %s/ in %s" % (exec_prefix, path)
package_qa_handle_error("unsafe-references-in-scripts", error_msg, d)
error_msg = "Shell scripts in base_bindir and base_sbindir should not reference anything in exec_prefix"
package_qa_handle_error("unsafe-references-in-scripts", error_msg, d)
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
def unsafe_references_skippable(path, name, d):
if bb.data.inherits_class('native', d) or bb.data.inherits_class('nativesdk', d):
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
if "-dbg" in name or "-dev" in name:
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
# Other package names to skip:
if name.startswith("kernel-module-"):
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
# Skip symlinks
if os.path.islink(path):
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
# Skip unusual rootfs layouts which make these tests irrelevant
2016-12-14 21:13:04 +00:00
exec_prefix = d.getVar('exec_prefix')
2014-02-03 15:15:29 +00:00
if exec_prefix == "":
return True
2012-01-05 06:30:35 +00:00
2016-12-14 21:13:04 +00:00
pkgdest = d.getVar('PKGDEST')
2014-02-03 15:15:29 +00:00
pkgdest = pkgdest + "/" + name
pkgdest = os.path.abspath(pkgdest)
2016-12-14 21:13:04 +00:00
base_bindir = pkgdest + d.getVar('base_bindir')
base_sbindir = pkgdest + d.getVar('base_sbindir')
base_libdir = pkgdest + d.getVar('base_libdir')
bindir = pkgdest + d.getVar('bindir')
sbindir = pkgdest + d.getVar('sbindir')
libdir = pkgdest + d.getVar('libdir')
2014-02-03 15:15:29 +00:00
if base_bindir == bindir and base_sbindir == sbindir and base_libdir == libdir:
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
# Skip files not in base_[bindir|sbindir|libdir]
path = os.path.abspath(path)
if not (base_bindir in path or base_sbindir in path or base_libdir in path):
return True
2012-01-05 06:30:35 +00:00
2014-02-03 15:15:29 +00:00
return False
2012-01-05 06:30:35 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[arch] = "package_qa_check_arch"
def package_qa_check_arch(path,name,d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check if archs are compatible
"""
2016-10-14 10:08:37 +00:00
import re
2010-07-08 09:23:17 +00:00
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
2016-12-14 21:13:04 +00:00
target_os = d.getVar('TARGET_OS')
target_arch = d.getVar('TARGET_ARCH')
provides = d.getVar('PROVIDES')
bpn = d.getVar('BPN')
2008-03-19 15:53:07 +00:00
2015-06-08 10:53:07 +00:00
if target_arch == "allarch":
2016-12-14 21:13:04 +00:00
pn = d.getVar('PN')
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "arch", pn + ": Recipe inherits the allarch class, but has packaged architecture-specific binaries")
2015-06-08 10:53:07 +00:00
return
2007-09-02 09:46:35 +00:00
# FIXME: Cross package confuse this check, so just skip them
2010-07-08 09:23:17 +00:00
for s in ['cross', 'nativesdk', 'cross-canadian']:
if bb.data.inherits_class(s, d):
2011-07-01 14:47:12 +00:00
return
2007-09-02 09:46:35 +00:00
# avoid following links to /usr/bin (e.g. on udev builds)
# we will check the files pointed to anyway...
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2007-09-02 09:46:35 +00:00
#if this will throw an exception, then fix the dict above
2011-03-01 18:42:28 +00:00
(machine, osabi, abiversion, littleendian, bits) \
insane: Add mechanism to extend QA machine information from BSP layer
In order to add a new architecture or sub-architecture to OE, you currently
need to tweak the table in insane.bbclass. This adds a mechanism so this
can be done from a BSP layer. It needs a function definition which needs
a class file but can then be done with something like:
def my_testfunc(machdata, d):
machdata["testmachine"] = {
"test64": ( 8, 0, 0, False, 32),
"testel": ( 8, 0, 0, True, 32),
}
return machdata
PACKAGEQA_EXTRA_MACHDEFFUNCS = "my_testfunc"
[YOCTO #8554]
(From OE-Core rev: c57550c9cca598315ba4408e44b138cecc22b8a0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-07-22 14:25:00 +00:00
= package_qa_get_machine_dict(d)[target_os][target_arch]
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
# Check the architecture and endiannes of the binary
2016-10-14 10:08:37 +00:00
is_32 = (("virtual/kernel" in provides) or bb.data.inherits_class("module", d)) and \
2016-12-14 21:13:04 +00:00
(target_os == "linux-gnux32" or re.match('mips64.*32', d.getVar('DEFAULTTUNE')))
2016-10-14 10:08:37 +00:00
if not ((machine == elf.machine()) or is_32):
2016-10-11 12:19:44 +00:00
package_qa_add_message(messages, "arch", "Architecture did not match (%s, expected %s) on %s" % \
(oe.qa.elf_machine_to_string(elf.machine()), oe.qa.elf_machine_to_string(machine), package_qa_clean_path(path,d)))
2016-10-14 10:08:37 +00:00
elif not ((bits == elf.abiSize()) or is_32):
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "arch", "Bit size did not match (%d to %d) %s on %s" % \
(bits, elf.abiSize(), bpn, package_qa_clean_path(path,d)))
2007-09-02 09:46:35 +00:00
elif not littleendian == elf.isLittleEndian():
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "arch", "Endiannes did not match (%d to %d) on %s" % \
(littleendian, elf.isLittleEndian(), package_qa_clean_path(path,d)))
2007-01-21 21:28:51 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[desktop] = "package_qa_check_desktop"
def package_qa_check_desktop(path, name, d, elf, messages):
2007-11-14 09:36:55 +00:00
"""
Run all desktop files through desktop-file-validate.
"""
if path.endswith(".desktop"):
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
desktop_file_validate = os.path.join(d.getVar('STAGING_BINDIR_NATIVE',True),'desktop-file-validate')
2012-05-30 13:20:04 +00:00
output = os.popen("%s %s" % (desktop_file_validate, path))
2007-11-14 09:48:17 +00:00
# This only produces output on errors
for l in output:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "desktop", "Desktop file issue: " + l.strip())
2008-03-19 15:53:07 +00:00
2012-10-03 10:24:12 +00:00
QAPATHTEST[textrel] = "package_qa_textrel"
def package_qa_textrel(path, name, d, elf, messages):
"""
Check if the binary contains relocations in .text
"""
if not elf:
return
if os.path.islink(path):
return
phdrs = elf.run_objdump("-p", d)
sane = True
import re
textrel_re = re.compile("\s+TEXTREL\s+")
for line in phdrs.split("\n"):
if textrel_re.match(line):
2013-05-07 12:55:53 +00:00
sane = False
2012-10-03 10:24:12 +00:00
if not sane:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "textrel", "ELF binary '%s' has relocations in .text" % path)
2012-10-03 10:24:12 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[ldflags] = "package_qa_hash_style"
def package_qa_hash_style(path, name, d, elf, messages):
2010-07-08 09:23:17 +00:00
"""
Check if the binary has the right hash style...
"""
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
2016-12-14 21:13:04 +00:00
gnu_hash = "--hash-style=gnu" in d.getVar('LDFLAGS')
2010-07-08 09:23:17 +00:00
if not gnu_hash:
2016-12-14 21:13:04 +00:00
gnu_hash = "--hash-style=both" in d.getVar('LDFLAGS')
2010-07-08 09:23:17 +00:00
if not gnu_hash:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
2011-07-14 09:02:11 +00:00
sane = False
has_syms = False
2012-10-01 17:29:23 +00:00
phdrs = elf.run_objdump("-p", d)
2011-07-14 09:02:11 +00:00
# If this binary has symbols, we expect it to have GNU_HASH too.
2012-10-01 17:29:23 +00:00
for line in phdrs.split("\n"):
2011-07-14 09:02:11 +00:00
if "SYMTAB" in line:
has_syms = True
2010-07-08 09:23:17 +00:00
if "GNU_HASH" in line:
sane = True
if "[mips32]" in line or "[mips64]" in line:
2013-05-07 12:55:53 +00:00
sane = True
2010-07-08 09:23:17 +00:00
2011-07-14 09:02:11 +00:00
if has_syms and not sane:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "ldflags", "No GNU_HASH in the elf binary: '%s'" % path)
2010-07-08 09:23:17 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"
def package_qa_check_buildpaths(path, name, d, elf, messages):
2008-04-22 21:22:11 +00:00
"""
Check for build paths inside target files and error if not found in the whitelist
"""
# Ignore .debug files, not interesting
if path.find(".debug") != -1:
2011-07-01 14:47:12 +00:00
return
2008-04-22 21:22:11 +00:00
# Ignore symlinks
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2008-04-22 21:22:11 +00:00
2016-01-19 08:13:39 +00:00
# Ignore ipk and deb's CONTROL dir
if path.find(name + "/CONTROL/") != -1 or path.find(name + "/DEBIAN/") != -1:
return
2016-12-14 21:13:04 +00:00
tmpdir = d.getVar('TMPDIR')
2016-11-01 12:44:46 +00:00
with open(path, 'rb') as f:
file_content = f.read().decode('utf-8', errors='ignore')
2013-05-09 16:05:58 +00:00
if tmpdir in file_content:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "buildpaths", "File %s in package contained reference to tmpdir" % package_qa_clean_path(path,d))
2008-04-22 21:22:11 +00:00
2012-10-22 09:37:26 +00:00
QAPATHTEST[xorg-driver-abi] = "package_qa_check_xorg_driver_abi"
def package_qa_check_xorg_driver_abi(path, name, d, elf, messages):
"""
Check that all packages containing Xorg drivers have ABI dependencies
"""
# Skip dev, dbg or nativesdk packages
if name.endswith("-dev") or name.endswith("-dbg") or name.startswith("nativesdk-"):
return
driverdir = d.expand("${libdir}/xorg/modules/drivers/")
if driverdir in path and path.endswith(".so"):
2016-12-14 21:13:04 +00:00
mlprefix = d.getVar('MLPREFIX') or ''
for rdep in bb.utils.explode_deps(d.getVar('RDEPENDS_' + name) or ""):
2013-11-15 02:31:56 +00:00
if rdep.startswith("%sxorg-abi-" % mlprefix):
2012-10-22 09:37:26 +00:00
return
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "xorg-driver-abi", "Package %s contains Xorg driver (%s) but no xorg-abi- dependencies" % (name, os.path.basename(path)))
2012-10-22 09:37:26 +00:00
2013-07-01 10:31:00 +00:00
QAPATHTEST[infodir] = "package_qa_check_infodir"
def package_qa_check_infodir(path, name, d, elf, messages):
"""
Check that /usr/share/info/dir isn't shipped in a particular package
"""
infodir = d.expand("${infodir}/dir")
if infodir in path:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "infodir", "The /usr/share/info/dir file is not meant to be shipped in a particular package.")
2013-07-01 10:31:00 +00:00
2014-03-03 20:23:33 +00:00
QAPATHTEST[symlink-to-sysroot] = "package_qa_check_symlink_to_sysroot"
def package_qa_check_symlink_to_sysroot(path, name, d, elf, messages):
"""
Check that the package doesn't contain any absolute symlinks to the sysroot.
"""
if os.path.islink(path):
target = os.readlink(path)
if os.path.isabs(target):
2016-12-14 21:13:04 +00:00
tmpdir = d.getVar('TMPDIR')
2014-03-03 20:23:33 +00:00
if target.startswith(tmpdir):
2016-12-14 21:13:04 +00:00
trimmed = path.replace(os.path.join (d.getVar("PKGDEST"), name), "")
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "symlink-to-sysroot", "Symlink %s in %s points to TMPDIR" % (trimmed, name))
2016-01-15 12:55:30 +00:00
2016-04-27 02:20:26 +00:00
# Check license variables
do_populate_lic[postfuncs] += "populate_lic_qa_checksum"
python populate_lic_qa_checksum() {
2010-05-11 23:25:39 +00:00
"""
2016-09-14 23:08:01 +00:00
Check for changes in the license files.
2010-05-11 23:25:39 +00:00
"""
import tempfile
sane = True
2016-12-14 21:13:04 +00:00
lic_files = d.getVar('LIC_FILES_CHKSUM') or ''
lic = d.getVar('LICENSE')
pn = d.getVar('PN')
2010-05-11 23:25:39 +00:00
2011-05-08 02:50:43 +00:00
if lic == "CLOSED":
2016-01-15 12:55:30 +00:00
return
2011-05-08 02:50:43 +00:00
2016-12-14 21:13:04 +00:00
if not lic_files and d.getVar('SRC_URI'):
2016-09-14 23:08:01 +00:00
sane = package_qa_handle_error("license-checksum", pn + ": Recipe file fetches files and does not have license file information (LIC_FILES_CHKSUM)", d)
2010-05-11 23:25:39 +00:00
2016-12-14 21:13:04 +00:00
srcdir = d.getVar('S')
2010-05-11 23:25:39 +00:00
for url in lic_files.split():
2013-11-12 13:29:24 +00:00
try:
(type, host, path, user, pswd, parm) = bb.fetch.decodeurl(url)
except bb.fetch.MalformedUrl:
2016-09-14 23:08:01 +00:00
sane = package_qa_handle_error("license-checksum", pn + ": LIC_FILES_CHKSUM contains an invalid URL: " + url, d)
2016-01-15 12:55:30 +00:00
continue
2010-05-11 23:25:39 +00:00
srclicfile = os.path.join(srcdir, path)
2010-06-04 04:48:16 +00:00
if not os.path.isfile(srclicfile):
2016-01-15 12:55:30 +00:00
package_qa_handle_error("license-checksum", pn + ": LIC_FILES_CHKSUM points to an invalid file: " + srclicfile, d)
continue
2010-05-11 23:25:39 +00:00
2013-11-13 14:32:39 +00:00
recipemd5 = parm.get('md5', '')
2010-05-11 23:25:39 +00:00
beginline, endline = 0, 0
if 'beginline' in parm:
beginline = int(parm['beginline'])
if 'endline' in parm:
endline = int(parm['endline'])
if (not beginline) and (not endline):
md5chksum = bb.utils.md5_file(srclicfile)
else:
2013-05-07 12:56:03 +00:00
fi = open(srclicfile, 'rb')
2010-05-11 23:25:39 +00:00
fo = tempfile.NamedTemporaryFile(mode='wb', prefix='poky.', suffix='.tmp', delete=False)
tmplicfile = fo.name;
lineno = 0
linesout = 0
for line in fi:
lineno += 1
2016-09-14 23:08:01 +00:00
if (lineno >= beginline):
2010-05-11 23:25:39 +00:00
if ((lineno <= endline) or not endline):
fo.write(line)
linesout += 1
else:
break
fo.flush()
fo.close()
fi.close()
md5chksum = bb.utils.md5_file(tmplicfile)
os.unlink(tmplicfile)
2013-11-13 14:32:39 +00:00
if recipemd5 == md5chksum:
2011-01-06 02:18:55 +00:00
bb.note (pn + ": md5 checksum matched for ", url)
2010-05-11 23:25:39 +00:00
else:
2013-12-20 14:55:10 +00:00
if recipemd5:
2016-01-15 12:55:30 +00:00
msg = pn + ": The LIC_FILES_CHKSUM does not match for " + url
msg = msg + "\n" + pn + ": The new md5 checksum is " + md5chksum
2013-12-20 14:55:10 +00:00
if beginline:
if endline:
srcfiledesc = "%s (lines %d through to %d)" % (srclicfile, beginline, endline)
else:
srcfiledesc = "%s (beginning on line %d)" % (srclicfile, beginline)
elif endline:
srcfiledesc = "%s (ending on line %d)" % (srclicfile, endline)
2013-11-13 14:32:39 +00:00
else:
2013-12-20 14:55:10 +00:00
srcfiledesc = srclicfile
2016-01-15 12:55:30 +00:00
msg = msg + "\n" + pn + ": Check if the license information has changed in %s to verify that the LICENSE value \"%s\" remains valid" % (srcfiledesc, lic)
2010-05-11 23:25:39 +00:00
2016-01-15 12:55:30 +00:00
else:
msg = pn + ": LIC_FILES_CHKSUM is not specified for " + url
msg = msg + "\n" + pn + ": The md5 checksum is " + md5chksum
2016-09-14 23:08:01 +00:00
sane = package_qa_handle_error("license-checksum", msg, d)
if not sane:
bb.fatal("Fatal QA errors found, failing task.")
2016-04-27 02:20:26 +00:00
}
2010-05-11 23:25:39 +00:00
2007-01-21 21:28:51 +00:00
def package_qa_check_staged(path,d):
"""
2016-01-26 12:52:21 +00:00
Check staged la and pc files for common problems like references to the work
directory.
2007-09-02 09:46:35 +00:00
2016-01-26 12:52:21 +00:00
As this is run after every stage we should be able to find the one
responsible for the errors easily even if we look at every .pc and .la file.
2007-01-21 21:28:51 +00:00
"""
2007-09-02 09:46:35 +00:00
sane = True
2016-12-14 21:13:04 +00:00
tmpdir = d.getVar('TMPDIR')
2008-03-19 15:53:07 +00:00
workdir = os.path.join(tmpdir, "work")
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
if bb.data.inherits_class("native", d) or bb.data.inherits_class("cross", d):
pkgconfigcheck = workdir
2007-09-02 09:46:35 +00:00
else:
2008-03-19 15:53:07 +00:00
pkgconfigcheck = tmpdir
2007-09-02 09:46:35 +00:00
# find all .la and .pc files
# read the content
# and check for stuff that looks wrong
for root, dirs, files in os.walk(path):
for file in files:
path = os.path.join(root,file)
2010-07-08 09:23:17 +00:00
if file.endswith(".la"):
2013-05-09 16:05:58 +00:00
with open(path) as f:
file_content = f.read()
if workdir in file_content:
error_msg = "%s failed sanity test (workdir) in path %s" % (file,root)
sane = package_qa_handle_error("la", error_msg, d)
2010-07-08 09:23:17 +00:00
elif file.endswith(".pc"):
2013-05-09 16:05:58 +00:00
with open(path) as f:
file_content = f.read()
if pkgconfigcheck in file_content:
error_msg = "%s failed sanity test (tmpdir) in path %s" % (file,root)
sane = package_qa_handle_error("pkgconfig", error_msg, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
2016-11-24 20:26:44 +00:00
# Run all package-wide warnfuncs and errorfuncs
def package_qa_package(warnfuncs, errorfuncs, skip, package, d):
warnings = {}
errors = {}
for func in warnfuncs:
func(package, d, warnings)
for func in errorfuncs:
func(package, d, errors)
for w in warnings:
package_qa_handle_error(w, warnings[w], d)
for e in errors:
package_qa_handle_error(e, errors[e], d)
return len(errors) == 0
2007-01-21 21:28:51 +00:00
# Walk over all files in a directory and call func
2016-01-20 08:34:24 +00:00
def package_qa_walk(warnfuncs, errorfuncs, skip, package, d):
2010-07-08 09:23:17 +00:00
import oe.qa
2007-09-02 09:46:35 +00:00
2010-07-08 09:23:17 +00:00
#if this will throw an exception, then fix the dict above
2016-12-14 21:13:04 +00:00
target_os = d.getVar('TARGET_OS')
target_arch = d.getVar('TARGET_ARCH')
2010-07-08 09:23:17 +00:00
2014-07-14 08:31:50 +00:00
warnings = {}
errors = {}
2013-01-29 14:10:30 +00:00
for path in pkgfiles[package]:
2011-03-01 18:42:28 +00:00
elf = oe.qa.ELFFile(path)
2010-07-08 09:23:17 +00:00
try:
elf.open()
2016-02-24 13:31:40 +00:00
except (IOError, oe.qa.NotELFFileError):
2016-02-15 17:48:25 +00:00
# IOError can happen if the packaging control files disappear,
2010-07-08 09:23:17 +00:00
elf = None
2011-07-01 14:47:12 +00:00
for func in warnfuncs:
func(path, package, d, elf, warnings)
for func in errorfuncs:
func(path, package, d, elf, errors)
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
for w in warnings:
2014-07-14 08:31:50 +00:00
package_qa_handle_error(w, warnings[w], d)
2011-07-01 14:47:12 +00:00
for e in errors:
2014-07-14 08:31:50 +00:00
package_qa_handle_error(e, errors[e], d)
2011-07-01 14:47:12 +00:00
2014-07-09 20:26:56 +00:00
def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
2011-07-12 13:29:28 +00:00
# Don't do this check for kernel/module recipes, there aren't too many debug/development
# packages and you can get false positives e.g. on kernel-module-lirc-dev
if bb.data.inherits_class("kernel", d) or bb.data.inherits_class("module-base", d):
2016-01-15 12:44:10 +00:00
return
2011-07-12 13:29:28 +00:00
2012-08-29 10:38:34 +00:00
if not "-dbg" in pkg and not "packagegroup-" in pkg and not "-image" in pkg:
2007-01-21 21:28:51 +00:00
localdata = bb.data.createCopy(d)
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
localdata.setVar('OVERRIDES', pkg)
2007-01-21 21:28:51 +00:00
bb.data.update_data(localdata)
# Now check the RDEPENDS
2016-12-14 21:13:04 +00:00
rdepends = bb.utils.explode_deps(localdata.getVar('RDEPENDS') or "")
2007-01-21 21:28:51 +00:00
# Now do the sanity check!!!
2014-10-31 09:15:45 +00:00
if "build-deps" not in skip:
for rdepend in rdepends:
if "-dbg" in rdepend and "debug-deps" not in skip:
error_msg = "%s rdepends on %s" % (pkg,rdepend)
2016-01-15 12:44:10 +00:00
package_qa_handle_error("debug-deps", error_msg, d)
2014-10-31 09:15:45 +00:00
if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev") and "dev-deps" not in skip:
error_msg = "%s rdepends on %s" % (pkg, rdepend)
2016-01-15 12:44:10 +00:00
package_qa_handle_error("dev-deps", error_msg, d)
2014-10-31 09:15:45 +00:00
if rdepend not in packages:
rdep_data = oe.packagedata.read_subpkgdata(rdepend, d)
if rdep_data and 'PN' in rdep_data and rdep_data['PN'] in taskdeps:
continue
if not rdep_data or not 'PN' in rdep_data:
2016-12-14 21:13:04 +00:00
pkgdata_dir = d.getVar("PKGDATA_DIR")
2014-10-31 09:15:45 +00:00
try:
possibles = os.listdir("%s/runtime-rprovides/%s/" % (pkgdata_dir, rdepend))
except OSError:
possibles = []
for p in possibles:
rdep_data = oe.packagedata.read_subpkgdata(p, d)
if rdep_data and 'PN' in rdep_data and rdep_data['PN'] in taskdeps:
break
if rdep_data and 'PN' in rdep_data and rdep_data['PN'] in taskdeps:
continue
2016-01-21 07:57:30 +00:00
if rdep_data and 'PN' in rdep_data:
error_msg = "%s rdepends on %s, but it isn't a build dependency, missing %s in DEPENDS or PACKAGECONFIG?" % (pkg, rdepend, rdep_data['PN'])
else:
error_msg = "%s rdepends on %s, but it isn't a build dependency?" % (pkg, rdepend)
2016-01-15 12:44:10 +00:00
package_qa_handle_error("build-deps", error_msg, d)
2007-09-02 09:46:35 +00:00
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
if "file-rdeps" not in skip:
ignored_file_rdeps = set(['/bin/sh', '/usr/bin/env', 'rtld(GNU_HASH)'])
if bb.data.inherits_class('nativesdk', d):
ignored_file_rdeps |= set(['/bin/bash', '/usr/bin/perl'])
# For Saving the FILERDEPENDS
2015-04-09 21:55:58 +00:00
filerdepends = {}
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
rdep_data = oe.packagedata.read_subpkgdata(pkg, d)
for key in rdep_data:
if key.startswith("FILERDEPENDS_"):
for subkey in rdep_data[key].split():
2015-04-09 21:55:58 +00:00
if subkey not in ignored_file_rdeps:
# We already know it starts with FILERDEPENDS_
filerdepends[subkey] = key[13:]
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
if filerdepends:
next = rdepends
done = rdepends[:]
# Find all the rdepends on the dependency chain
while next:
new = []
for rdep in next:
rdep_data = oe.packagedata.read_subpkgdata(rdep, d)
sub_rdeps = rdep_data.get("RDEPENDS_" + rdep)
if not sub_rdeps:
continue
for sub_rdep in sub_rdeps.split():
if sub_rdep in done:
continue
if not sub_rdep.startswith('(') and \
oe.packagedata.has_subpkgdata(sub_rdep, d):
# It's a new rdep
done.append(sub_rdep)
new.append(sub_rdep)
next = new
# Add the rprovides of itself
if pkg not in done:
done.insert(0, pkg)
# The python is not a package, but python-core provides it, so
# skip checking /usr/bin/python if python is in the rdeps, in
# case there is a RDEPENDS_pkg = "python" in the recipe.
2016-12-14 21:13:04 +00:00
for py in [ d.getVar('MLPREFIX') + "python", "python" ]:
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
if py in done:
2015-04-09 21:55:58 +00:00
filerdepends.pop("/usr/bin/python",None)
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
done.remove(py)
for rdep in done:
# For Saving the FILERPROVIDES, RPROVIDES and FILES_INFO
rdep_data = oe.packagedata.read_subpkgdata(rdep, d)
for key in rdep_data:
if key.startswith("FILERPROVIDES_") or key.startswith("RPROVIDES_"):
for subkey in rdep_data[key].split():
2015-04-09 21:55:58 +00:00
filerdepends.pop(subkey,None)
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
# Add the files list to the rprovides
if key == "FILES_INFO":
# Use eval() to make it as a dict
for subkey in eval(rdep_data[key]):
2015-04-09 21:55:58 +00:00
filerdepends.pop(subkey,None)
insane.bbclass: add QA check: file-rdeps
The ipk or deb can't depend on file such as "/bin/bash" or
"/usr/bin/perl", so it knows nothing about the pkg depends bash or perl,
thus there would be dependencies problems when we run "apt-get
install/remove <pkg>" on the target, this check can help us find the
issues and then fix them manually.
* Benefits:
- Help to fix file rdepends issues for ipk and deb
- Help to fix abnormal rdepends.
- Help to check whether the rdepends is OK or not after build each
recipe (don't have to install to the image), for example, a recipe may
generate 10 binary packages, only a part of them will be installed to
the image by default, we can know whether the rdepends are OK or
not for the ones which are installed, but can't know the ones which
are not installed, this patch can help check all the 10 binary
packages' rdepends.
* Basic designs:
- Get all the RDEPENDS on the chain.
- Get the pkg's FILERPROVIDES from oe.packagedata.read_subpkgdata()
and save to set filerdepends.
- Get each RPDEPENDS' FILERPROVIDES, RPROVIDES and FILERPROVIDESFLIST,
and save to set rdep_rprovides.
- Do the set "filerdepends -= rdep_rprovides" and QA issue if
filerdepends is not null.
[YOCTO #1662]
(From OE-Core rev: cd5e0f01cdb4e7c759c01cf3f87952a20253737c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-09-08 11:58:21 +00:00
if not filerdepends:
# Break if all the file rdepends are met
break
if filerdepends:
2015-04-09 21:55:58 +00:00
for key in filerdepends:
2016-01-21 07:57:30 +00:00
error_msg = "%s contained in package %s requires %s, but no providers found in RDEPENDS_%s?" % \
(filerdepends[key].replace("_%s" % pkg, "").replace("@underscore@", "_"), pkg, key, pkg)
2016-01-15 12:44:10 +00:00
package_qa_handle_error("file-rdeps", error_msg, d)
2007-01-21 21:28:51 +00:00
2012-10-02 10:37:07 +00:00
def package_qa_check_deps(pkg, pkgdest, skip, d):
localdata = bb.data.createCopy(d)
localdata.setVar('OVERRIDES', pkg)
bb.data.update_data(localdata)
def check_valid_deps(var):
try:
2016-12-14 21:13:04 +00:00
rvar = bb.utils.explode_dep_versions2(localdata.getVar(var) or "")
2012-10-02 10:37:07 +00:00
except ValueError as e:
bb.fatal("%s_%s: %s" % (var, pkg, e))
for dep in rvar:
for v in rvar[dep]:
if v and not v.startswith(('< ', '= ', '> ', '<= ', '>=')):
error_msg = "%s_%s is invalid: %s (%s) only comparisons <, =, >, <=, and >= are allowed" % (var, pkg, dep, v)
2016-01-15 12:44:10 +00:00
package_qa_handle_error("dep-cmp", error_msg, d)
2012-10-02 10:37:07 +00:00
2016-01-15 12:44:10 +00:00
check_valid_deps('RDEPENDS')
check_valid_deps('RRECOMMENDS')
check_valid_deps('RSUGGESTS')
check_valid_deps('RPROVIDES')
check_valid_deps('RREPLACES')
check_valid_deps('RCONFLICTS')
2012-10-02 10:37:07 +00:00
2016-11-24 20:37:48 +00:00
QAPKGTEST[expanded-d] = "package_qa_check_expanded_d"
def package_qa_check_expanded_d(package, d, messages):
2015-01-13 23:00:40 +00:00
"""
Check for the expanded D (${D}) value in pkg_* and FILES
variables, warn the user to use it correctly.
"""
sane = True
2016-12-14 21:13:04 +00:00
expanded_d = d.getVar('D')
2016-11-24 20:37:48 +00:00
for var in 'FILES','pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm':
2016-12-14 21:13:04 +00:00
bbvar = d.getVar(var + "_" + package) or ""
2016-11-24 20:37:48 +00:00
if expanded_d in bbvar:
if var == 'FILES':
package_qa_add_message(messages, "expanded-d", "FILES in %s recipe should not contain the ${D} variable as it references the local build directory not the target filesystem, best solution is to remove the ${D} reference" % package)
sane = False
else:
package_qa_add_message(messages, "expanded-d", "%s in %s recipe contains ${D}, it should be replaced by $D instead" % (var, package))
sane = False
2015-01-13 23:00:40 +00:00
return sane
2015-08-17 07:10:12 +00:00
def package_qa_check_encoding(keys, encode, d):
2016-05-20 10:17:05 +00:00
def check_encoding(key, enc):
2015-08-17 07:10:12 +00:00
sane = True
2016-12-14 21:13:04 +00:00
value = d.getVar(key)
2015-08-17 07:10:12 +00:00
if value:
try:
2016-05-20 10:17:05 +00:00
s = value.encode(enc)
2015-08-17 07:10:12 +00:00
except UnicodeDecodeError as e:
error_msg = "%s has non %s characters" % (key,enc)
sane = False
package_qa_handle_error("invalid-chars", error_msg, d)
return sane
for key in keys:
sane = check_encoding(key, encode)
if not sane:
break
2015-09-01 22:23:03 +00:00
HOST_USER_UID := "${@os.getuid()}"
HOST_USER_GID := "${@os.getgid()}"
QAPATHTEST[host-user-contaminated] = "package_qa_check_host_user"
def package_qa_check_host_user(path, name, d, elf, messages):
"""Check for paths outside of /home which are owned by the user running bitbake."""
if not os.path.lexists(path):
return
2016-12-14 21:13:04 +00:00
dest = d.getVar('PKGDEST')
pn = d.getVar('PN')
2015-09-01 22:23:03 +00:00
home = os.path.join(dest, 'home')
if path == home or path.startswith(home + os.sep):
return
try:
stat = os.lstat(path)
except OSError as exc:
import errno
if exc.errno != errno.ENOENT:
raise
else:
2015-09-18 15:15:22 +00:00
rootfs_path = path[len(dest):]
2016-12-14 21:13:04 +00:00
check_uid = int(d.getVar('HOST_USER_UID'))
2015-09-01 22:23:03 +00:00
if stat.st_uid == check_uid:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "host-user-contaminated", "%s: %s is owned by uid %d, which is the same as the user running bitbake. This may be due to host contamination" % (pn, rootfs_path, check_uid))
2015-09-01 22:23:03 +00:00
return False
2016-12-14 21:13:04 +00:00
check_gid = int(d.getVar('HOST_USER_GID'))
2015-09-01 22:23:03 +00:00
if stat.st_gid == check_gid:
2016-01-20 08:34:23 +00:00
package_qa_add_message(messages, "host-user-contaminated", "%s: %s is owned by gid %d, which is the same as the user running bitbake. This may be due to host contamination" % (pn, rootfs_path, check_gid))
2015-09-01 22:23:03 +00:00
return False
return True
2007-01-21 21:28:51 +00:00
# The PACKAGE FUNC to scan each package
python do_package_qa () {
2012-05-29 14:53:06 +00:00
import subprocess
2014-07-09 20:26:56 +00:00
import oe.packagedata
2012-05-29 14:53:06 +00:00
2007-01-21 21:28:51 +00:00
bb.note("DO PACKAGE QA")
2010-09-30 20:50:42 +00:00
2014-07-09 20:15:34 +00:00
bb.build.exec_func("read_subpackage_metadata", d)
2015-08-17 07:10:12 +00:00
# Check non UTF-8 characters on recipe's metadata
package_qa_check_encoding(['DESCRIPTION', 'SUMMARY', 'LICENSE', 'SECTION'], 'utf-8', d)
2016-12-14 21:13:04 +00:00
logdir = d.getVar('T')
pkg = d.getVar('PN')
2010-09-30 20:50:42 +00:00
# Check the compile log for host contamination
compilelog = os.path.join(logdir,"log.do_compile")
2012-03-22 09:55:34 +00:00
if os.path.exists(compilelog):
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % compilelog
2012-05-29 14:53:06 +00:00
if subprocess.call(statement, shell=True) == 0:
2013-05-11 22:46:10 +00:00
msg = "%s: The compile log indicates that host include and/or library paths were used.\n \
Please check the log '%s' for more information." % (pkg, compilelog)
package_qa_handle_error("compile-host-path", msg, d)
2010-09-30 20:50:42 +00:00
# Check the install log for host contamination
installlog = os.path.join(logdir,"log.do_install")
2012-03-22 09:55:34 +00:00
if os.path.exists(installlog):
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % installlog
2012-05-29 14:53:06 +00:00
if subprocess.call(statement, shell=True) == 0:
2013-05-11 22:46:10 +00:00
msg = "%s: The install log indicates that host include and/or library paths were used.\n \
Please check the log '%s' for more information." % (pkg, installlog)
package_qa_handle_error("install-host-path", msg, d)
2010-09-30 20:50:42 +00:00
# Scan the packages...
2016-12-14 21:13:04 +00:00
pkgdest = d.getVar('PKGDEST')
packages = set((d.getVar('PACKAGES') or '').split())
2007-01-21 21:28:51 +00:00
2014-07-09 20:15:34 +00:00
cpath = oe.cachedpath.CachedPath()
global pkgfiles
pkgfiles = {}
2015-06-15 16:05:13 +00:00
for pkg in packages:
2014-07-09 20:15:34 +00:00
pkgfiles[pkg] = []
for walkroot, dirs, files in cpath.walk(pkgdest + "/" + pkg):
for file in files:
pkgfiles[pkg].append(walkroot + os.sep + file)
2007-01-21 21:28:51 +00:00
# no packages should be scanned
if not packages:
return
2012-11-13 15:51:00 +00:00
import re
# The package name matches the [a-z0-9.+-]+ regular expression
pkgname_pattern = re.compile("^[a-z0-9.+-]+$")
2011-07-01 14:47:12 +00:00
2014-07-09 20:26:56 +00:00
taskdepdata = d.getVar("BB_TASKDEPDATA", False)
taskdeps = set()
for dep in taskdepdata:
taskdeps.add(taskdepdata[dep][0])
2015-06-15 16:05:13 +00:00
for package in packages:
2016-11-24 18:02:40 +00:00
def parse_test_matrix(matrix_name):
testmatrix = d.getVarFlags(matrix_name) or {}
g = globals()
warnchecks = []
2016-12-14 21:13:04 +00:00
for w in (d.getVar("WARN_QA") or "").split():
2016-11-24 18:02:40 +00:00
if w in skip:
continue
if w in testmatrix and testmatrix[w] in g:
warnchecks.append(g[testmatrix[w]])
if w == 'unsafe-references-in-binaries':
oe.utils.write_ld_so_conf(d)
errorchecks = []
2016-12-14 21:13:04 +00:00
for e in (d.getVar("ERROR_QA") or "").split():
2016-11-24 18:02:40 +00:00
if e in skip:
continue
if e in testmatrix and testmatrix[e] in g:
errorchecks.append(g[testmatrix[e]])
if e == 'unsafe-references-in-binaries':
oe.utils.write_ld_so_conf(d)
return warnchecks, errorchecks
2016-12-14 21:13:04 +00:00
skip = (d.getVar('INSANE_SKIP_' + package) or "").split()
2011-07-04 16:12:32 +00:00
if skip:
bb.note("Package %s skipping QA tests: %s" % (package, str(skip)))
2016-11-24 18:02:40 +00:00
2007-09-02 09:46:35 +00:00
bb.note("Checking Package: %s" % package)
2012-11-13 15:51:00 +00:00
# Check package name
if not pkgname_pattern.match(package):
package_qa_handle_error("pkgname",
2015-09-18 13:14:08 +00:00
"%s doesn't match the [a-z0-9.+-]+ regex" % package, d)
2012-11-13 15:51:00 +00:00
2016-11-24 18:02:40 +00:00
warn_checks, error_checks = parse_test_matrix("QAPATHTEST")
package_qa_walk(warn_checks, error_checks, skip, package, d)
2007-09-02 09:46:35 +00:00
2016-11-24 20:26:44 +00:00
warn_checks, error_checks = parse_test_matrix("QAPKGTEST")
package_qa_package(warn_checks, error_checks, skip, package, d)
2016-01-15 12:44:10 +00:00
package_qa_check_rdepends(package, pkgdest, skip, taskdeps, packages, d)
package_qa_check_deps(package, pkgdest, skip, d)
2010-05-11 23:25:39 +00:00
2016-12-14 21:13:04 +00:00
if 'libdir' in d.getVar("ALL_QA").split():
2012-09-19 09:32:39 +00:00
package_qa_check_libdir(d)
2016-12-14 21:13:04 +00:00
qa_sane = d.getVar("QA_SANE")
2016-01-15 12:44:10 +00:00
if not qa_sane:
2007-09-02 09:46:35 +00:00
bb.fatal("QA run found fatal errors. Please consider fixing them.")
bb.note("DONE with PACKAGE QA")
2007-01-21 21:28:51 +00:00
}
2015-11-10 09:58:25 +00:00
do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
2014-07-09 20:26:56 +00:00
do_package_qa[rdeptask] = "do_packagedata"
2014-07-11 22:17:40 +00:00
addtask do_package_qa after do_packagedata do_package before do_build
2014-07-09 20:15:34 +00:00
SSTATETASKS += "do_package_qa"
do_package_qa[sstate-inputdirs] = ""
do_package_qa[sstate-outputdirs] = ""
python do_package_qa_setscene () {
sstate_setscene(d)
}
addtask do_package_qa_setscene
2007-01-21 21:28:51 +00:00
python do_qa_staging() {
2007-09-02 09:46:35 +00:00
bb.note("QA checking staging")
2007-01-21 21:28:51 +00:00
2016-02-04 12:38:50 +00:00
if not package_qa_check_staged(d.expand('${SYSROOT_DESTDIR}${libdir}'), d):
2007-09-02 09:46:35 +00:00
bb.fatal("QA staging was broken by the package built above")
}
python do_qa_configure() {
2012-05-29 14:53:06 +00:00
import subprocess
2013-02-03 16:58:02 +00:00
###########################################################################
# Check config.log for cross compile issues
###########################################################################
2009-12-19 12:29:14 +00:00
configs = []
2016-12-14 21:13:04 +00:00
workdir = d.getVar('WORKDIR')
2016-02-16 16:27:20 +00:00
if bb.data.inherits_class('autotools', d):
bb.note("Checking autotools environment for common misconfiguration")
for root, dirs, files in os.walk(workdir):
statement = "grep -q -F -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s" % \
os.path.join(root,"config.log")
if "config.log" in files:
if subprocess.call(statement, shell=True) == 0:
bb.fatal("""This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities.
2015-10-05 06:09:34 +00:00
Rerun configure task after fixing this.""")
2009-12-19 12:29:14 +00:00
2016-02-16 16:27:20 +00:00
if "configure.ac" in files:
configs.append(os.path.join(root,"configure.ac"))
if "configure.in" in files:
configs.append(os.path.join(root, "configure.in"))
2009-12-19 12:29:14 +00:00
2013-02-03 16:58:02 +00:00
###########################################################################
# Check gettext configuration and dependencies are correct
###########################################################################
2016-12-14 21:13:04 +00:00
cnf = d.getVar('EXTRA_OECONF') or ""
if "gettext" not in d.getVar('P') and "gcc-runtime" not in d.getVar('P') and "--disable-nls" not in cnf:
ml = d.getVar("MLPREFIX") or ""
2012-08-20 16:52:21 +00:00
if bb.data.inherits_class('native', d) or bb.data.inherits_class('cross', d) or bb.data.inherits_class('crosssdk', d) or bb.data.inherits_class('nativesdk', d):
gt = "gettext-native"
elif bb.data.inherits_class('cross-canadian', d):
2011-12-22 17:43:33 +00:00
gt = "nativesdk-gettext"
2012-08-20 16:52:21 +00:00
else:
gt = "virtual/" + ml + "gettext"
2016-12-14 21:13:04 +00:00
deps = bb.utils.explode_deps(d.getVar('DEPENDS') or "")
2012-08-20 16:52:21 +00:00
if gt not in deps:
for config in configs:
gnu = "grep \"^[[:space:]]*AM_GNU_GETTEXT\" %s >/dev/null" % config
if subprocess.call(gnu, shell=True) == 0:
bb.fatal("""%s required but not in DEPENDS for file %s.
2011-04-22 18:28:08 +00:00
Missing inherit gettext?""" % (gt, config))
2010-07-15 08:35:53 +00:00
2013-10-08 14:30:05 +00:00
###########################################################################
# Check unrecognised configure options (with a white list)
###########################################################################
if bb.data.inherits_class("autotools", d):
bb.note("Checking configure output for unrecognised options")
try:
flag = "WARNING: unrecognized options:"
2016-12-14 21:13:04 +00:00
log = os.path.join(d.getVar('B'), 'config.log')
2016-05-20 10:17:05 +00:00
output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ')
2013-12-10 19:38:26 +00:00
options = set()
for line in output.splitlines():
options |= set(line.partition(flag)[2].split())
2016-12-14 21:13:04 +00:00
whitelist = set(d.getVar("UNKNOWN_CONFIGURE_WHITELIST").split())
2013-10-08 14:30:05 +00:00
options -= whitelist
if options:
2016-12-14 21:13:04 +00:00
pn = d.getVar('PN')
2013-10-08 14:30:05 +00:00
error_msg = pn + ": configure was passed unrecognised options: " + " ".join(options)
package_qa_handle_error("unknown-configure-option", error_msg, d)
except subprocess.CalledProcessError:
pass
2015-07-30 15:18:09 +00:00
# Check invalid PACKAGECONFIG
2016-12-14 21:13:04 +00:00
pkgconfig = (d.getVar("PACKAGECONFIG") or "").split()
2015-07-30 15:18:09 +00:00
if pkgconfig:
pkgconfigflags = d.getVarFlags("PACKAGECONFIG") or {}
for pconfig in pkgconfig:
if pconfig not in pkgconfigflags:
2016-12-14 21:13:04 +00:00
pn = d.getVar('PN')
2015-07-30 15:18:09 +00:00
error_msg = "%s: invalid PACKAGECONFIG: %s" % (pn, pconfig)
2015-10-21 13:18:50 +00:00
package_qa_handle_error("invalid-packageconfig", error_msg, d)
2016-01-15 12:55:30 +00:00
2016-12-14 21:13:04 +00:00
qa_sane = d.getVar("QA_SANE")
2016-01-15 12:55:30 +00:00
if not qa_sane:
bb.fatal("Fatal QA errors found, failing task.")
2007-01-21 21:28:51 +00:00
}
2015-07-03 03:47:47 +00:00
python do_qa_unpack() {
2016-12-14 21:13:04 +00:00
src_uri = d.getVar('SRC_URI')
s_dir = d.getVar('S')
2016-07-21 19:29:27 +00:00
if src_uri and not os.path.exists(s_dir):
2016-12-14 21:13:04 +00:00
bb.warn('%s: the directory %s (%s) pointed to by the S variable doesn\'t exist - please set S within the recipe to point to where the source has been unpacked to' % (d.getVar('PN'), d.getVar('S', False), s_dir))
2015-07-03 03:47:47 +00:00
}
2011-04-22 18:23:20 +00:00
# The Staging Func, to check all staging
#addtask qa_staging after do_populate_sysroot before do_build
do_populate_sysroot[postfuncs] += "do_qa_staging "
2016-04-27 02:20:26 +00:00
# Check broken config.log files, for packages requiring Gettext which
# don't have it in DEPENDS.
2011-04-22 18:23:20 +00:00
#addtask qa_configure after do_configure before do_compile
do_configure[postfuncs] += "do_qa_configure "
2012-02-23 12:40:36 +00:00
2015-07-03 03:47:47 +00:00
# Check does S exist.
do_unpack[postfuncs] += "do_qa_unpack"
2012-02-23 12:40:36 +00:00
python () {
2016-12-14 21:13:04 +00:00
tests = d.getVar('ALL_QA').split()
2012-09-21 10:16:24 +00:00
if "desktop" in tests:
2015-01-07 14:44:01 +00:00
d.appendVar("PACKAGE_DEPENDS", " desktop-file-utils-native")
2013-02-03 16:54:00 +00:00
2013-02-03 16:58:02 +00:00
###########################################################################
# Check various variables
###########################################################################
2014-07-23 03:33:01 +00:00
# Checking ${FILESEXTRAPATHS}
2016-12-14 21:13:04 +00:00
extrapaths = (d.getVar("FILESEXTRAPATHS") or "")
2014-07-23 03:33:01 +00:00
if '__default' not in extrapaths.split(":"):
msg = "FILESEXTRAPATHS-variable, must always use _prepend (or _append)\n"
msg += "type of assignment, and don't forget the colon.\n"
msg += "Please assign it with the format of:\n"
msg += " FILESEXTRAPATHS_append := \":${THISDIR}/Your_Files_Path\" or\n"
msg += " FILESEXTRAPATHS_prepend := \"${THISDIR}/Your_Files_Path:\"\n"
msg += "in your bbappend file\n\n"
msg += "Your incorrect assignment is:\n"
msg += "%s\n" % extrapaths
2014-07-25 18:36:45 +00:00
bb.warn(msg)
2014-07-23 03:33:01 +00:00
2016-12-14 21:13:04 +00:00
overrides = d.getVar('OVERRIDES').split(':')
pn = d.getVar('PN')
2013-05-09 16:26:17 +00:00
if pn in overrides:
2016-12-14 21:13:04 +00:00
msg = 'Recipe %s has PN of "%s" which is in OVERRIDES, this can result in unexpected behaviour.' % (d.getVar("FILE"), pn)
2013-05-11 22:46:10 +00:00
package_qa_handle_error("pn-overrides", msg, d)
2013-05-09 16:26:17 +00:00
2013-02-03 16:54:00 +00:00
issues = []
2016-12-14 21:13:04 +00:00
if (d.getVar('PACKAGES') or "").split():
for dep in (d.getVar('QADEPENDS') or "").split():
2014-07-09 20:15:34 +00:00
d.appendVarFlag('do_package_qa', 'depends', " %s:do_populate_sysroot" % dep)
2013-03-04 10:07:14 +00:00
for var in 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RCONFLICTS', 'RPROVIDES', 'RREPLACES', 'FILES', 'pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm', 'ALLOW_EMPTY':
2015-06-18 14:14:16 +00:00
if d.getVar(var, False):
2013-02-03 16:54:00 +00:00
issues.append(var)
2015-09-01 22:23:02 +00:00
2016-12-14 21:13:04 +00:00
fakeroot_tests = d.getVar('FAKEROOT_QA').split()
2015-09-01 22:23:02 +00:00
if set(tests) & set(fakeroot_tests):
d.setVarFlag('do_package_qa', 'fakeroot', '1')
d.appendVarFlag('do_package_qa', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')
2014-07-09 20:26:56 +00:00
else:
d.setVarFlag('do_package_qa', 'rdeptask', '')
2013-02-03 16:54:00 +00:00
for i in issues:
2016-12-14 21:13:04 +00:00
package_qa_handle_error("pkgvarcheck", "%s: Variable %s is set as not being package specific, please fix this." % (d.getVar("FILE"), i), d)
qa_sane = d.getVar("QA_SANE")
2016-01-12 18:00:13 +00:00
if not qa_sane:
bb.fatal("Fatal QA errors found, failing task.")
2012-02-23 12:40:36 +00:00
}