2007-01-21 21:28:51 +00:00
# BB Class inspired by ebuild.sh
#
# This class will test files after installation for certain
# security issues and other kind of issues.
#
# Checks we do:
# -Check the ownership and permissions
# -Check the RUNTIME path for the $TMPDIR
# -Check if .la files wrongly point to workdir
# -Check if .pc files wrongly point to workdir
2008-03-19 15:53:07 +00:00
# -Check if packages contains .debug directories or .so files
# where they should be in -dev or -dbg
2007-09-02 09:46:35 +00:00
# -Check if config.log contains traces to broken autoconf tests
2012-01-05 06:30:35 +00:00
# -Ensure that binaries in base_[bindir|sbindir|libdir] do not link
# into exec_prefix
# -Check that scripts in base_[bindir|sbindir|libdir] do not reference
# files under exec_prefix
2007-01-21 21:28:51 +00:00
#
# We need to have the scanelf utility as soon as
2008-03-19 15:53:07 +00:00
# possible and this is contained within the pax-utils-native.
# The package.bbclass can help us here.
2007-01-21 21:28:51 +00:00
#
inherit package
2012-02-23 12:40:36 +00:00
PACKAGE_DEPENDS += "pax-utils-native ${QADEPENDS}"
2007-01-21 21:28:51 +00:00
PACKAGEFUNCS += " do_package_qa "
2012-01-05 06:30:35 +00:00
# unsafe-references-in-binaries requires prelink-rtld from
# prelink-native, but we don't want this DEPENDS for -native builds
QADEPENDS = "prelink-native"
QADEPENDS_virtclass-native = ""
QADEPENDS_virtclass-nativesdk = ""
2007-09-02 09:46:35 +00:00
#
# dictionary for elf headers
#
2008-03-19 15:53:07 +00:00
# feel free to add and correct.
2007-09-02 09:46:35 +00:00
#
# TARGET_OS TARGET_ARCH MACHINE, OSABI, ABIVERSION, Little Endian, 32bit?
def package_qa_get_machine_dict():
return {
2010-07-08 09:23:17 +00:00
"darwin9" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
},
2007-09-02 09:46:35 +00:00
"linux" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 97, 0, True, 32),
"armeb": (40, 97, 0, False, 32),
"powerpc": (20, 0, 0, False, 32),
2011-07-22 09:24:52 +00:00
"powerpc64": (21, 0, 0, False, 64),
2011-03-01 18:42:28 +00:00
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": (62, 0, 0, True, 64),
"ia64": (50, 0, 0, True, 64),
"alpha": (36902, 0, 0, True, 64),
"hppa": (15, 3, 0, False, 32),
"m68k": ( 4, 0, 0, False, 32),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
"s390": (22, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
"sparc": ( 2, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
"linux-uclibc" : {
2011-03-01 18:42:28 +00:00
"arm" : ( 40, 97, 0, True, 32),
"armeb": ( 40, 97, 0, False, 32),
"powerpc": ( 20, 0, 0, False, 32),
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": ( 62, 0, 0, True, 64),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
"avr32": (6317, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
2007-09-02 09:46:35 +00:00
},
"uclinux-uclibc" : {
2011-03-01 18:42:28 +00:00
"bfin": ( 106, 0, 0, True, 32),
2007-09-02 09:46:35 +00:00
},
"linux-gnueabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2011-04-01 03:07:44 +00:00
"linux-uclibceabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2011-06-02 19:27:02 +00:00
"linux-gnu" : {
"powerpc": (20, 0, 0, False, 32),
},
2010-07-08 09:23:17 +00:00
"linux-gnuspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
"linux-uclibcspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
2011-05-05 16:26:28 +00:00
"linux-gnu" : {
2011-07-05 19:38:09 +00:00
"microblaze": (47787, 0, 0, False, 32),
"microblazeel": (47787, 0, 0, True, 32),
2011-05-05 16:26:28 +00:00
},
2011-07-26 09:19:41 +00:00
"linux-gnux32" : {
"x86_64": (62, 0, 0, True, 32),
},
2007-09-02 09:46:35 +00:00
}
2010-07-08 09:23:17 +00:00
2011-09-29 22:35:16 +00:00
# Currently not being used by default "desktop"
2012-01-25 19:29:38 +00:00
WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev"
2011-09-29 22:35:16 +00:00
ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
2007-09-02 09:46:35 +00:00
def package_qa_clean_path(path,d):
2008-03-19 15:53:07 +00:00
""" Remove the common prefix from the path. In this case it is the TMPDIR"""
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
return path.replace(d.getVar('TMPDIR',True),"")
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
def package_qa_write_error(error, d):
logfile = d.getVar('QA_LOGFILE', True)
2008-04-22 21:22:11 +00:00
if logfile:
2011-07-01 14:47:12 +00:00
p = d.getVar('P', True)
2008-04-22 21:22:11 +00:00
f = file( logfile, "a+")
2011-07-01 14:47:12 +00:00
print >> f, "%s: %s" % (p, error)
2008-04-22 21:22:11 +00:00
f.close()
2011-07-01 14:47:12 +00:00
def package_qa_handle_error(error_class, error_msg, d):
package_qa_write_error(error_msg, d)
if error_class in (d.getVar("ERROR_QA", True) or "").split():
2008-04-22 21:22:11 +00:00
bb.error("QA Issue: %s" % error_msg)
2011-07-07 17:32:47 +00:00
return False
2008-04-22 21:22:11 +00:00
else:
2011-01-13 15:47:14 +00:00
bb.warn("QA Issue: %s" % error_msg)
2011-07-07 17:32:47 +00:00
return True
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[rpaths] = "package_qa_check_rpath"
def package_qa_check_rpath(file,name, d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check for dangerous RPATHs
"""
2010-07-08 09:23:17 +00:00
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
scanelf = os.path.join(d.getVar('STAGING_BINDIR_NATIVE',True),'scanelf')
bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)]
bad_dir_test = d.getVar('TMPDIR', True)
2007-01-21 21:28:51 +00:00
if not os.path.exists(scanelf):
2007-09-02 09:46:35 +00:00
bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")
2008-03-19 15:53:07 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
if not bad_dirs[0] in d.getVar('WORKDIR', True):
2007-01-21 21:28:51 +00:00
bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")
2007-09-02 09:46:35 +00:00
output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
txt = output.readline().split()
for line in txt:
2010-07-08 09:23:17 +00:00
for dir in bad_dirs:
if dir in line:
2011-07-01 14:47:12 +00:00
messages.append("package %s contains bad RPATH %s in file %s" % (name, line, file))
2008-03-19 15:53:07 +00:00
2011-07-14 09:02:11 +00:00
QAPATHTEST[useless-rpaths] = "package_qa_check_useless_rpaths"
2011-07-15 11:19:35 +00:00
def package_qa_check_useless_rpaths(file, name, d, elf, messages):
2011-07-14 09:02:11 +00:00
"""
Check for RPATHs that are useless but not dangerous
"""
if not elf:
return
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
objdump = d.getVar('OBJDUMP', True)
env_path = d.getVar('PATH', True)
2011-07-14 09:02:11 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
libdir = d.getVar("libdir", True)
base_libdir = d.getVar("base_libdir", True)
2011-07-14 09:02:11 +00:00
import re
rpath_re = re.compile("\s+RPATH\s+(.*)")
for line in os.popen("LC_ALL=C PATH=%s %s -p '%s' 2> /dev/null" % (env_path, objdump, file), "r"):
m = rpath_re.match(line)
if m:
rpath = m.group(1)
if rpath == libdir or rpath == base_libdir:
# The dynamic linker searches both these places anyway. There is no point in
# looking there again.
2011-07-15 11:19:35 +00:00
messages.append("%s: %s contains probably-redundant RPATH %s" % (name, package_qa_clean_path(file, d), rpath))
2011-07-14 09:02:11 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[dev-so] = "package_qa_check_dev"
def package_qa_check_dev(path, name, d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
2010-07-08 09:23:17 +00:00
Check for ".so" library symlinks in non-dev packages
2007-01-21 21:28:51 +00:00
"""
2011-09-21 18:39:50 +00:00
if not name.endswith("-dev") and not name.endswith("-dbg") and not name.endswith("-nativesdk") and path.endswith(".so") and os.path.islink(path):
messages.append("non -dev/-dbg/-nativesdk package contains symlink .so: %s path '%s'" % \
2011-07-01 14:47:12 +00:00
(name, package_qa_clean_path(path,d)))
2010-07-08 09:23:17 +00:00
2012-01-25 19:29:38 +00:00
QAPATHTEST[staticdev] = "package_qa_check_staticdev"
def package_qa_check_staticdev(path, name, d, elf, messages):
"""
Check for ".a" library in non-staticdev packages
There are a number of exceptions to this rule, -pic packages can contain
static libraries, the _nonshared.a belong with their -dev packages and
libgcc.a, libgcov.a will be skipped in their packages
"""
if not name.endswith("-pic") and not name.endswith("-staticdev") and path.endswith(".a") and not path.endswith("_nonshared.a"):
messages.append("non -staticdev package contains static .a library: %s path '%s'" % \
(name, package_qa_clean_path(path,d)))
2011-07-01 14:47:12 +00:00
QAPATHTEST[debug-files] = "package_qa_check_dbg"
def package_qa_check_dbg(path, name, d, elf, messages):
2010-07-08 09:23:17 +00:00
"""
Check for ".debug" files or directories outside of the dbg package
"""
2007-01-21 21:28:51 +00:00
if not "-dbg" in name:
2010-07-08 09:23:17 +00:00
if '.debug' in path.split(os.path.sep):
2011-07-01 14:47:12 +00:00
messages.append("non debug package contains .debug directory: %s path %s" % \
(name, package_qa_clean_path(path,d)))
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[perms] = "package_qa_check_perm"
def package_qa_check_perm(path,name,d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check the permission of files
"""
2011-07-01 14:47:12 +00:00
return
2007-01-21 21:28:51 +00:00
2012-01-05 06:30:35 +00:00
QAPATHTEST[unsafe-references-in-binaries] = "package_qa_check_unsafe_references_in_binaries"
def package_qa_check_unsafe_references_in_binaries(path, name, d, elf, messages):
"""
Ensure binaries in base_[bindir|sbindir|libdir] do not link to files under exec_prefix
"""
if unsafe_references_skippable(path, name, d):
return
if elf:
import subprocess as sub
pn = d.getVar('PN', True)
exec_prefix = d.getVar('exec_prefix', True)
sysroot_path = d.getVar('STAGING_DIR_TARGET', True)
sysroot_path_usr = sysroot_path + exec_prefix
try:
2012-01-05 21:12:50 +00:00
ldd_output = bb.process.Popen(["prelink-rtld", "--root", sysroot_path, path], stdout=sub.PIPE).stdout.read()
except bb.process.CmdError:
error_msg = pn + ": prelink-rtld aborted when processing %s" % path
package_qa_handle_error("unsafe-references-in-binaries", error_msg, d)
return False
2012-01-05 06:30:35 +00:00
if sysroot_path_usr in ldd_output:
error_msg = pn + ": %s links to something under exec_prefix" % path
package_qa_handle_error("unsafe-references-in-binaries", error_msg, d)
error_msg = "ldd reports: %s" % ldd_output
package_qa_handle_error("unsafe-references-in-binaries", error_msg, d)
return False
QAPATHTEST[unsafe-references-in-scripts] = "package_qa_check_unsafe_references_in_scripts"
def package_qa_check_unsafe_references_in_scripts(path, name, d, elf, messages):
"""
Warn if scripts in base_[bindir|sbindir|libdir] reference files under exec_prefix
"""
if unsafe_references_skippable(path, name, d):
return
if not elf:
import stat
pn = d.getVar('PN', True)
# Ensure we're checking an executable script
statinfo = os.stat(path)
if bool(statinfo.st_mode & stat.S_IXUSR):
# grep shell scripts for possible references to /exec_prefix/
exec_prefix = d.getVar('exec_prefix', True)
statement = "grep -e '%s/' %s > /dev/null" % (exec_prefix, path)
if os.system(statement) == 0:
error_msg = pn + ": Found a reference to %s/ in %s" % (exec_prefix, path)
package_qa_handle_error("unsafe-references-in-scripts", error_msg, d)
error_msg = "Shell scripts in base_bindir and base_sbindir should not reference anything in exec_prefix"
package_qa_handle_error("unsafe-references-in-scripts", error_msg, d)
def unsafe_references_skippable(path, name, d):
if bb.data.inherits_class('native', d) or bb.data.inherits_class('nativesdk', d):
return True
if "-dbg" in name or "-dev" in name:
return True
# Other package names to skip:
if name.startswith("kernel-module-"):
return True
# Skip symlinks
if os.path.islink(path):
return True
# Skip unusual rootfs layouts which make these tests irrelevant
exec_prefix = d.getVar('exec_prefix', True)
if exec_prefix == "":
return True
pkgdest = d.getVar('PKGDEST', True)
pkgdest = pkgdest + "/" + name
pkgdest = os.path.abspath(pkgdest)
base_bindir = pkgdest + d.getVar('base_bindir', True)
base_sbindir = pkgdest + d.getVar('base_sbindir', True)
base_libdir = pkgdest + d.getVar('base_libdir', True)
bindir = pkgdest + d.getVar('bindir', True)
sbindir = pkgdest + d.getVar('sbindir', True)
libdir = pkgdest + d.getVar('libdir', True)
if base_bindir == bindir and base_sbindir == sbindir and base_libdir == libdir:
return True
# Skip files not in base_[bindir|sbindir|libdir]
path = os.path.abspath(path)
if not (base_bindir in path or base_sbindir in path or base_libdir in path):
return True
return False
2011-07-01 14:47:12 +00:00
QAPATHTEST[arch] = "package_qa_check_arch"
def package_qa_check_arch(path,name,d, elf, messages):
2007-01-21 21:28:51 +00:00
"""
Check if archs are compatible
"""
2010-07-08 09:23:17 +00:00
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
target_os = d.getVar('TARGET_OS', True)
target_arch = d.getVar('TARGET_ARCH', True)
2011-11-16 19:14:43 +00:00
provides = d.getVar('PROVIDES', d, True)
2008-03-19 15:53:07 +00:00
2007-09-02 09:46:35 +00:00
# FIXME: Cross package confuse this check, so just skip them
2010-07-08 09:23:17 +00:00
for s in ['cross', 'nativesdk', 'cross-canadian']:
if bb.data.inherits_class(s, d):
2011-07-01 14:47:12 +00:00
return
2007-09-02 09:46:35 +00:00
# avoid following links to /usr/bin (e.g. on udev builds)
# we will check the files pointed to anyway...
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2007-09-02 09:46:35 +00:00
#if this will throw an exception, then fix the dict above
2011-03-01 18:42:28 +00:00
(machine, osabi, abiversion, littleendian, bits) \
2008-03-19 15:53:07 +00:00
= package_qa_get_machine_dict()[target_os][target_arch]
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
# Check the architecture and endiannes of the binary
2012-01-11 01:33:31 +00:00
if not ((machine == elf.machine()) or \
("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
2011-07-01 14:47:12 +00:00
messages.append("Architecture did not match (%d to %d) on %s" % \
(machine, elf.machine(), package_qa_clean_path(path,d)))
2011-11-16 19:14:43 +00:00
elif not ((bits == elf.abiSize()) or \
("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
messages.append("Bit size did not match (%d to %d) %s on %s" % \
(bits, elf.abiSize(), bpn, package_qa_clean_path(path,d)))
2007-09-02 09:46:35 +00:00
elif not littleendian == elf.isLittleEndian():
2011-07-01 14:47:12 +00:00
messages.append("Endiannes did not match (%d to %d) on %s" % \
(littleendian, elf.isLittleEndian(), package_qa_clean_path(path,d)))
2007-01-21 21:28:51 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[desktop] = "package_qa_check_desktop"
def package_qa_check_desktop(path, name, d, elf, messages):
2007-11-14 09:36:55 +00:00
"""
Run all desktop files through desktop-file-validate.
"""
if path.endswith(".desktop"):
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
desktop_file_validate = os.path.join(d.getVar('STAGING_BINDIR_NATIVE',True),'desktop-file-validate')
2008-04-03 05:17:32 +00:00
output = os.popen("%s %s" % (desktop_file_validate, path))
2007-11-14 09:48:17 +00:00
# This only produces output on errors
for l in output:
2011-07-01 14:47:12 +00:00
messages.append("Desktop file issue: " + l.strip())
2008-03-19 15:53:07 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[ldflags] = "package_qa_hash_style"
def package_qa_hash_style(path, name, d, elf, messages):
2010-07-08 09:23:17 +00:00
"""
Check if the binary has the right hash style...
"""
if not elf:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
gnu_hash = "--hash-style=gnu" in d.getVar('LDFLAGS', True)
2010-07-08 09:23:17 +00:00
if not gnu_hash:
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
gnu_hash = "--hash-style=both" in d.getVar('LDFLAGS', True)
2010-07-08 09:23:17 +00:00
if not gnu_hash:
2011-07-01 14:47:12 +00:00
return
2010-07-08 09:23:17 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
objdump = d.getVar('OBJDUMP', True)
env_path = d.getVar('PATH', True)
2010-07-08 09:23:17 +00:00
2011-07-14 09:02:11 +00:00
sane = False
has_syms = False
# If this binary has symbols, we expect it to have GNU_HASH too.
2010-07-08 09:23:17 +00:00
for line in os.popen("LC_ALL=C PATH=%s %s -p '%s' 2> /dev/null" % (env_path, objdump, path), "r"):
2011-07-14 09:02:11 +00:00
if "SYMTAB" in line:
has_syms = True
2010-07-08 09:23:17 +00:00
if "GNU_HASH" in line:
sane = True
if "[mips32]" in line or "[mips64]" in line:
sane = True
2011-07-14 09:02:11 +00:00
if has_syms and not sane:
2011-07-01 14:47:12 +00:00
messages.append("No GNU_HASH in the elf binary: '%s'" % path)
2010-07-08 09:23:17 +00:00
2011-07-01 14:47:12 +00:00
QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"
def package_qa_check_buildpaths(path, name, d, elf, messages):
2008-04-22 21:22:11 +00:00
"""
Check for build paths inside target files and error if not found in the whitelist
"""
# Ignore .debug files, not interesting
if path.find(".debug") != -1:
2011-07-01 14:47:12 +00:00
return
2008-04-22 21:22:11 +00:00
# Ignore symlinks
if os.path.islink(path):
2011-07-01 14:47:12 +00:00
return
2008-04-22 21:22:11 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
tmpdir = d.getVar('TMPDIR', True)
2008-04-22 21:22:11 +00:00
file_content = open(path).read()
if tmpdir in file_content:
2011-07-01 14:47:12 +00:00
messages.append("File %s in package contained reference to tmpdir" % package_qa_clean_path(path,d))
2008-04-22 21:22:11 +00:00
2010-05-11 23:25:39 +00:00
def package_qa_check_license(workdir, d):
"""
Check for changes in the license files
"""
import tempfile
sane = True
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
lic_files = d.getVar('LIC_FILES_CHKSUM', True)
lic = d.getVar('LICENSE', True)
pn = d.getVar('PN', True)
2010-05-11 23:25:39 +00:00
2011-05-08 02:50:43 +00:00
if lic == "CLOSED":
return True
2010-05-11 23:25:39 +00:00
if not lic_files:
2010-05-12 17:54:05 +00:00
# just throw a warning now. Once licensing data in entered for enough of the recipes,
# this will be converted into error and False will be returned.
2010-12-22 23:50:12 +00:00
bb.error(pn + ": Recipe file does not have license file information (LIC_FILES_CHKSUM)")
2011-01-06 02:18:55 +00:00
return False
2010-05-11 23:25:39 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
srcdir = d.getVar('S', True)
2010-05-11 23:25:39 +00:00
for url in lic_files.split():
(type, host, path, user, pswd, parm) = bb.decodeurl(url)
srclicfile = os.path.join(srcdir, path)
2010-06-04 04:48:16 +00:00
if not os.path.isfile(srclicfile):
2011-10-18 19:00:56 +00:00
raise bb.build.FuncFailed( pn + ": LIC_FILES_CHKSUM points to an invalid file: " + srclicfile)
2010-05-11 23:25:39 +00:00
if 'md5' not in parm:
2011-01-06 02:18:55 +00:00
bb.error(pn + ": md5 checksum is not specified for ", url)
2010-05-11 23:25:39 +00:00
return False
beginline, endline = 0, 0
if 'beginline' in parm:
beginline = int(parm['beginline'])
if 'endline' in parm:
endline = int(parm['endline'])
if (not beginline) and (not endline):
md5chksum = bb.utils.md5_file(srclicfile)
else:
fi = open(srclicfile, 'r')
fo = tempfile.NamedTemporaryFile(mode='wb', prefix='poky.', suffix='.tmp', delete=False)
tmplicfile = fo.name;
lineno = 0
linesout = 0
for line in fi:
lineno += 1
if (lineno >= beginline):
if ((lineno <= endline) or not endline):
fo.write(line)
linesout += 1
else:
break
fo.flush()
fo.close()
fi.close()
md5chksum = bb.utils.md5_file(tmplicfile)
os.unlink(tmplicfile)
if parm['md5'] == md5chksum:
2011-01-06 02:18:55 +00:00
bb.note (pn + ": md5 checksum matched for ", url)
2010-05-11 23:25:39 +00:00
else:
2011-01-06 02:18:55 +00:00
bb.error (pn + ": md5 data is not matching for ", url)
bb.error (pn + ": The new md5 checksum is ", md5chksum)
bb.error (pn + ": Check if the license information has changed in")
2010-06-28 03:02:45 +00:00
sane = False
2010-05-11 23:25:39 +00:00
return sane
2007-01-21 21:28:51 +00:00
def package_qa_check_staged(path,d):
"""
Check staged la and pc files for sanity
-e.g. installed being false
2007-09-02 09:46:35 +00:00
As this is run after every stage we should be able
to find the one responsible for the errors easily even
if we look at every .pc and .la file
2007-01-21 21:28:51 +00:00
"""
2007-09-02 09:46:35 +00:00
sane = True
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
tmpdir = d.getVar('TMPDIR', True)
2008-03-19 15:53:07 +00:00
workdir = os.path.join(tmpdir, "work")
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
installed = "installed=yes"
if bb.data.inherits_class("native", d) or bb.data.inherits_class("cross", d):
pkgconfigcheck = workdir
2007-09-02 09:46:35 +00:00
else:
2008-03-19 15:53:07 +00:00
pkgconfigcheck = tmpdir
2007-09-02 09:46:35 +00:00
# find all .la and .pc files
# read the content
# and check for stuff that looks wrong
for root, dirs, files in os.walk(path):
for file in files:
path = os.path.join(root,file)
2010-07-08 09:23:17 +00:00
if file.endswith(".la"):
2007-09-02 09:46:35 +00:00
file_content = open(path).read()
2008-01-13 16:58:42 +00:00
if workdir in file_content:
2008-03-19 15:53:07 +00:00
error_msg = "%s failed sanity test (workdir) in path %s" % (file,root)
2011-07-01 14:47:12 +00:00
sane = package_qa_handle_error("la", error_msg, d)
2010-07-08 09:23:17 +00:00
elif file.endswith(".pc"):
2007-09-02 09:46:35 +00:00
file_content = open(path).read()
2008-03-19 15:53:07 +00:00
if pkgconfigcheck in file_content:
error_msg = "%s failed sanity test (tmpdir) in path %s" % (file,root)
2011-07-01 14:47:12 +00:00
sane = package_qa_handle_error("pkgconfig", error_msg, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
# Walk over all files in a directory and call func
2011-07-04 16:12:32 +00:00
def package_qa_walk(path, warnfuncs, errorfuncs, skip, package, d):
2010-07-08 09:23:17 +00:00
import oe.qa
2007-09-02 09:46:35 +00:00
2010-07-08 09:23:17 +00:00
#if this will throw an exception, then fix the dict above
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
target_os = d.getVar('TARGET_OS', True)
target_arch = d.getVar('TARGET_ARCH', True)
2010-07-08 09:23:17 +00:00
2011-07-01 14:47:12 +00:00
warnings = []
errors = []
2007-01-21 21:28:51 +00:00
for root, dirs, files in os.walk(path):
for file in files:
path = os.path.join(root,file)
2011-03-01 18:42:28 +00:00
elf = oe.qa.ELFFile(path)
2010-07-08 09:23:17 +00:00
try:
elf.open()
except:
elf = None
2011-07-01 14:47:12 +00:00
for func in warnfuncs:
func(path, package, d, elf, warnings)
for func in errorfuncs:
func(path, package, d, elf, errors)
2007-09-02 09:46:35 +00:00
2011-07-01 14:47:12 +00:00
for w in warnings:
bb.warn("QA Issue: %s" % w)
package_qa_write_error(w, d)
for e in errors:
bb.error("QA Issue: %s" % e)
package_qa_write_error(e, d)
return len(errors) == 0
2007-01-21 21:28:51 +00:00
2011-07-04 16:12:32 +00:00
def package_qa_check_rdepends(pkg, pkgdest, skip, d):
2011-07-12 13:29:28 +00:00
# Don't do this check for kernel/module recipes, there aren't too many debug/development
# packages and you can get false positives e.g. on kernel-module-lirc-dev
if bb.data.inherits_class("kernel", d) or bb.data.inherits_class("module-base", d):
return True
2007-09-02 09:46:35 +00:00
sane = True
2007-01-21 21:28:51 +00:00
if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg:
# Copied from package_ipk.bbclass
# boiler plate to update the data
localdata = bb.data.createCopy(d)
2010-07-08 09:23:17 +00:00
root = "%s/%s" % (pkgdest, pkg)
2007-01-21 21:28:51 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
localdata.setVar('ROOT', '')
localdata.setVar('ROOT_%s' % pkg, root)
pkgname = localdata.getVar('PKG_%s' % pkg, True)
2007-01-21 21:28:51 +00:00
if not pkgname:
pkgname = pkg
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
localdata.setVar('PKG', pkgname)
2007-01-21 21:28:51 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
localdata.setVar('OVERRIDES', pkg)
2007-01-21 21:28:51 +00:00
bb.data.update_data(localdata)
# Now check the RDEPENDS
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
rdepends = bb.utils.explode_deps(localdata.getVar('RDEPENDS', True) or "")
2007-01-21 21:28:51 +00:00
# Now do the sanity check!!!
for rdepend in rdepends:
2011-07-04 16:12:32 +00:00
if "-dbg" in rdepend and "debug-deps" not in skip:
2008-03-19 15:53:07 +00:00
error_msg = "%s rdepends on %s" % (pkgname,rdepend)
2011-07-01 14:47:12 +00:00
sane = package_qa_handle_error("debug-deps", error_msg, d)
2011-07-07 17:32:46 +00:00
if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev") and "dev-deps" not in skip:
2011-07-05 13:04:25 +00:00
error_msg = "%s rdepends on %s" % (pkgname, rdepend)
2011-07-05 13:00:26 +00:00
sane = package_qa_handle_error("dev-deps", error_msg, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
# The PACKAGE FUNC to scan each package
python do_package_qa () {
bb.note("DO PACKAGE QA")
2010-09-30 20:50:42 +00:00
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
logdir = d.getVar('T', True)
pkg = d.getVar('PN', True)
2010-09-30 20:50:42 +00:00
# Check the compile log for host contamination
compilelog = os.path.join(logdir,"log.do_compile")
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % compilelog
if os.system(statement) == 0:
bb.warn("%s: The compile log indicates that host include and/or library paths were used. Please check the log '%s' for more information." % \
(pkg, compilelog))
# Check the install log for host contamination
installlog = os.path.join(logdir,"log.do_install")
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % installlog
if os.system(statement) == 0:
bb.warn("%s: The install log indicates that host include and/or library paths were used. Please check the log '%s' for more information." % \
(pkg, installlog))
# Scan the packages...
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
pkgdest = d.getVar('PKGDEST', True)
packages = d.getVar('PACKAGES', True)
2007-01-21 21:28:51 +00:00
# no packages should be scanned
if not packages:
return
2011-07-01 14:47:12 +00:00
testmatrix = d.getVarFlags("QAPATHTEST")
g = globals()
2007-09-02 09:46:35 +00:00
walk_sane = True
rdepends_sane = True
2007-01-21 21:28:51 +00:00
for package in packages.split():
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
skip = (d.getVar('INSANE_SKIP_' + package, True) or "").split()
2011-07-04 16:12:32 +00:00
if skip:
bb.note("Package %s skipping QA tests: %s" % (package, str(skip)))
warnchecks = []
for w in (d.getVar("WARN_QA", True) or "").split():
if w in skip:
continue
if w in testmatrix and testmatrix[w] in g:
warnchecks.append(g[testmatrix[w]])
errorchecks = []
for e in (d.getVar("ERROR_QA", True) or "").split():
if e in skip:
continue
if e in testmatrix and testmatrix[e] in g:
errorchecks.append(g[testmatrix[e]])
2007-09-02 09:46:35 +00:00
bb.note("Checking Package: %s" % package)
2010-07-08 09:23:17 +00:00
path = "%s/%s" % (pkgdest, package)
2011-07-04 16:12:32 +00:00
if not package_qa_walk(path, warnchecks, errorchecks, skip, package, d):
2007-09-02 09:46:35 +00:00
walk_sane = False
2011-07-04 16:12:32 +00:00
if not package_qa_check_rdepends(package, pkgdest, skip, d):
2007-09-02 09:46:35 +00:00
rdepends_sane = False
2010-05-11 23:25:39 +00:00
2010-07-15 08:35:53 +00:00
if not walk_sane or not rdepends_sane:
2007-09-02 09:46:35 +00:00
bb.fatal("QA run found fatal errors. Please consider fixing them.")
bb.note("DONE with PACKAGE QA")
2007-01-21 21:28:51 +00:00
}
python do_qa_staging() {
2007-09-02 09:46:35 +00:00
bb.note("QA checking staging")
2007-01-21 21:28:51 +00:00
2012-03-03 11:21:22 +00:00
if not package_qa_check_staged(d.expand('${SYSROOT_DESTDIR}/${STAGING_LIBDIR}'), d):
2007-09-02 09:46:35 +00:00
bb.fatal("QA staging was broken by the package built above")
}
python do_qa_configure() {
2009-12-19 12:29:14 +00:00
configs = []
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
workdir = d.getVar('WORKDIR', True)
2009-12-19 12:29:14 +00:00
bb.note("Checking autotools environment for common misconfiguration")
2010-07-15 08:35:53 +00:00
for root, dirs, files in os.walk(workdir):
2010-09-30 20:50:42 +00:00
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % \
2008-03-19 15:53:07 +00:00
os.path.join(root,"config.log")
2007-09-02 09:46:35 +00:00
if "config.log" in files:
2008-03-19 15:53:07 +00:00
if os.system(statement) == 0:
2011-02-08 16:05:46 +00:00
bb.fatal("""This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities.
2008-03-19 15:53:07 +00:00
Rerun configure task after fixing this. The path was '%s'""" % root)
2009-12-19 12:29:14 +00:00
if "configure.ac" in files:
configs.append(os.path.join(root,"configure.ac"))
if "configure.in" in files:
configs.append(os.path.join(root, "configure.in"))
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
cnf = d.getVar('EXTRA_OECONF', True) or ""
if "gettext" not in d.getVar('P', True) and "gcc-runtime" not in d.getVar('P', True) and "--disable-nls" not in cnf:
2011-06-07 09:27:03 +00:00
ml = d.getVar("MLPREFIX", True) or ""
2009-12-22 17:17:55 +00:00
if bb.data.inherits_class('native', d) or bb.data.inherits_class('cross', d) or bb.data.inherits_class('crosssdk', d) or bb.data.inherits_class('nativesdk', d):
gt = "gettext-native"
2010-01-14 11:37:56 +00:00
elif bb.data.inherits_class('cross-canadian', d):
2010-01-14 11:25:42 +00:00
gt = "gettext-nativesdk"
2009-12-22 17:17:55 +00:00
else:
2011-06-07 09:27:03 +00:00
gt = "virtual/" + ml + "gettext"
Convert to use direct access to the data store (instead of bb.data.*Var*())
This is the result of running the following over the metadata:
sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`
(From OE-Core rev: b22831fd63164c4db9c0b72934d7d734a6585251)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-09 15:00:01 +00:00
deps = bb.utils.explode_deps(d.getVar('DEPENDS', True) or "")
2009-12-22 17:17:55 +00:00
if gt not in deps:
for config in configs:
gnu = "grep \"^[[:space:]]*AM_GNU_GETTEXT\" %s >/dev/null" % config
if os.system(gnu) == 0:
2011-04-22 18:28:08 +00:00
bb.fatal("""%s required but not in DEPENDS for file %s.
Missing inherit gettext?""" % (gt, config))
2010-07-15 08:35:53 +00:00
if not package_qa_check_license(workdir, d):
2011-01-06 02:18:55 +00:00
bb.fatal("Licensing Error: LIC_FILES_CHKSUM does not match, please fix")
2007-01-21 21:28:51 +00:00
}
2011-04-22 18:23:20 +00:00
# The Staging Func, to check all staging
#addtask qa_staging after do_populate_sysroot before do_build
do_populate_sysroot[postfuncs] += "do_qa_staging "
# Check broken config.log files, for packages requiring Gettext which don't
# have it in DEPENDS and for correct LIC_FILES_CHKSUM
#addtask qa_configure after do_configure before do_compile
do_configure[postfuncs] += "do_qa_configure "
2012-02-23 12:40:36 +00:00
python () {
tests = d.getVar('WARN_QA', True) + " " + d.getVar('ERROR_QA', True)
if tests.find("desktop") != -1:
d.appendVar("PACKAGE_DEPENDS", "desktop-file-utils-native")
}