gpsd: upgrade to 3.24
Mergedosmith merged 3 commits from
laforge/nightly3 months ago
Reference in new issue
There is no content yet.
Delete Branch 'osmith/nightly'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Marked as WIP as it depends on sysmocom/gpsdate#1 and contains a debug commit to build gpsdate from my branch currently. But it can be reviewed and tested already.
In the "gpsd: upgrade to 3.24" patch I fail to see where did you import the new recipe from.
Because usually that recipe may exist in some poky or meta-* layer and we simply copy it over here. Did you look at that? That's usually the way, since it means upstream poky already took care of applying new needed patch fixes, etc.
I've compared the upstream packaging with ours:
There are several differences. First we have the following patches. The 0002 patch can probably be safely dropped, and maybe also 0001, but 0003 looked pretty important. So I forward ported all of them to ensure the functionallity stays the same.
Then we have a pretty old toolchain with old gcc, old python etc. I had to add the following fix to make it build:
We also have other customizations in our package that we probably can't just throw away, like the udev rules or specific gpsd-default files per product.
So it was not possible to just use the upstream package.
My point is precisely that the submitted commits should be made from the point of view of:
1- importing a given well-known upstream recipe from poky/meta-* and providing info about the repo and hash it was imported from in the commit decription.
2- Make whatever change are needed in top of it to have it work for us
So ideally you should be submitting 2 patches, each doing one of the points above, even if "1" alone doesnt compiler and both need to be merged.
This allows in the future finding out what did we change on our side.
6ad5bab56a3 months ago
as discussed in chat, improved the commit message
5bd261b12a3 months ago
WIP: gpsd: upgrade to 3.24to gpsd: upgrade to 3.24 3 months ago
Now that sysmocom/gpsdate#1 is merged, I've changed the last patch to properly use the latest commit from gpsdate master. I've verified again that it builds. The change is trivial, I don't think it needs another review round. Merging to laforge/nightly as discussed.
5bd261b12ainto laforge/nightly 3 months ago