u-boot/board/evb64260
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
64260.h Initial revision 2001-12-28 14:03:48 +00:00
bootseq.txt rename CFG_ENV_IS_IN_EEPROM in CONFIG_ENV_IS_IN_EEPROM 2008-09-10 21:09:38 +02:00
config.mk Initial revision 2001-06-14 23:44:51 +00:00
ecctest.c * Some code cleanup 2004-02-12 00:47:09 +00:00
eth.c Moved initialization of GT6426x Ethernet controller to board_eth_init() 2008-09-02 21:18:17 -07:00
eth.h Cleanup for GCC-4.x 2005-10-13 16:45:02 +02:00
eth_addrtbl.c Code cleanup, especially MIPS for GCC 4.x 2005-12-04 00:40:34 +01:00
eth_addrtbl.h * Code cleanup: 2003-06-27 21:31:46 +00:00
evb64260.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
flash.c Fix build errors after making flash_get_info() non-static 2009-02-18 22:40:08 +01:00
i2c.c Cleanup for GCC-4.x 2005-10-13 16:45:02 +02:00
i2c.h Initial revision 2001-12-28 14:03:48 +00:00
intel_flash.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
intel_flash.h rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
local.h rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
Makefile Move "ar" flags to config.mk to allow for silent "make -s" 2006-10-09 01:02:05 +02:00
memory.c * Code cleanup: 2003-06-27 21:31:46 +00:00
misc.S rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
mpsc.c Merge branch 'master' into next 2010-06-30 01:02:11 +02:00
mpsc.h Big white-space cleanup. 2008-05-21 00:14:08 +02:00
pci.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
sdram_init.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
serial.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
serial.h Initial revision 2002-03-08 21:31:05 +00:00
u-boot.lds Move arch/ppc to arch/powerpc 2010-04-21 23:42:38 +02:00
zuma_pbb.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
zuma_pbb.h * Code cleanup: 2003-06-27 21:31:46 +00:00
zuma_pbb_mbox.c evb64260: fix "cast to pointer from integer of different size" warnings 2008-12-09 23:13:51 +01:00
zuma_pbb_mbox.h * Some code cleanup 2004-02-12 00:47:09 +00:00