Commit Graph

9553 Commits

Author SHA1 Message Date
Joshua Colp 0b93665a71 Code cleaning/updates/potential bug fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 19:50:59 +00:00
Joshua Colp dd0b891e57 Minor cleanup and make sure the tmp variable is clean
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 18:54:36 +00:00
Joshua Colp 34eb4f54ba Use lower case 'x' instead of a UTF-8 character (issue #7888 reported by flefoll)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42284 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 17:09:55 +00:00
Matt O'Gorman 36935ffc42 protect curhst and curusr
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 17:05:51 +00:00
Joshua Colp 53cf63c33a Convert some warnings into debug messages since they can exist under perfectly normal circumstances that the user shouldn't care about (issue #7894 reported by stephen_dredge)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:51:11 +00:00
Kevin P. Fleming e8ca23608d minor wording fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:42:04 +00:00
Joshua Colp bc5dd43635 Set the variable even if the caller disconnects (issue #7896 reported by jsmith)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:40:15 +00:00
Joshua Colp 8a2dd45283 Merged revisions 42260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r42260 | file | 2006-09-07 12:30:44 -0400 (Thu, 07 Sep 2006) | 2 lines

Let's use the same thing we use in other places to calculate our time for ast_cond_timedwait (issue #7697 reported by bn999)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:33:02 +00:00
Matt O'Gorman 1dc7c62ed4 patch to fix several things wrong with voicemail
imap storage.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42259 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:14:53 +00:00
Mark Spencer 47d8e14871 Comment out default from extensions.ael
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42244 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 15:35:52 +00:00
Steve Murphy a7b5ef30e7 With respect to bug 7862, the syntax and description are misleading to users. the syntax included a space after the double quotes between the regex and the data to match. I removed this from the function doc, and added some verbage to make this crystal clear, I hope.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42224 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 04:23:00 +00:00
Steve Murphy 11a7e38930 Made changes corresponding to those in 1.2 here in main/logger.c for bug 7544.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 03:35:42 +00:00
Kevin P. Fleming d5f812e0b1 don't try to get the length of the string in the ast_dynamic_str object unless we know there is actually one there
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 00:41:27 +00:00
Jason Parker f0e0963b2e Fix a small typo, to make app_followme.c show properly in "show version files"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42170 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 21:37:12 +00:00
Jason Parker e3bc4c81f9 This one's for you, mog
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 21:00:37 +00:00
Joshua Colp 31cc08295c Merged revisions 42148 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r42148 | file | 2006-09-06 16:02:59 -0400 (Wed, 06 Sep 2006) | 2 lines

Don't close the second file descriptor if it's the same as the first one, as it will have already been closed elsewhere and could cause massive panic. (issue #7699 reported by bn999)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 20:04:17 +00:00
Christian Richter b1fca65c77 fixed pipe consuming bug when using chanIsAvail (#7878), also moved a debug log to the very begining of misdn_hangup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 18:02:25 +00:00
Steve Murphy 7c9b6e1d29 These small app documentation changes to app_dial and app_read will hopefully avert any more 7544 type bug reports\!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 17:14:50 +00:00
Joshua Colp ca2b4d407a Make this module fit the guidelines better
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42109 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 17:05:48 +00:00
Joshua Colp e77c51f5c6 Merged revisions 42086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r42086 | file | 2006-09-06 11:55:20 -0400 (Wed, 06 Sep 2006) | 2 lines

Make realtime regseconds work as people expected (0 on registration expiration or release, and actual on normal state) (issue #7684 reported by kshumard)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 15:58:21 +00:00
Olle Johansson 228d50806c - Free allocated memory before returning from function
- Fix bad formatting
- Add some comments (more needed to understand what's going on)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42058 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:36:27 +00:00
Joshua Colp 826da1d7b1 Blocked revisions 42054 via svnmerge
........
r42054 | file | 2006-09-05 16:02:48 -0400 (Tue, 05 Sep 2006) | 2 lines

Merge in last round of spy fixes. This should hopefully eliminate all the issues people have been seeing by distinctly separating what each component (core/spy) is responsible for. Core is responsible for adding a spy to a channel, feeding frames to the spy, removing the spy from a channel, and telling the spy to stop. Spy is responsible for reading frames in, and cleaning up after itself.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42055 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:03:53 +00:00
Tilghman Lesher bfef0a23ff Missing field terminator
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42034 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 17:23:50 +00:00
Joshua Colp 4a7947501e Minor tweak - we need to lock the channel when we are removing the spy from it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42021 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 17:01:02 +00:00
Jason Parker 4ba458e352 Merged revisions 42014 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r42014 | qwell | 2006-09-05 09:27:46 -0700 (Tue, 05 Sep 2006) | 4 lines

Small typo in zapata.conf.sample

Reported by ppyy in 7881

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@42015 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 16:38:22 +00:00
Olle Johansson bd4e57a873 Make sure we handle CANCEL/ACK properly (imported with mods from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-04 15:57:26 +00:00
Joshua Colp bc5924120d Remove old unused functions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-04 03:18:12 +00:00
Joshua Colp 49cfc19f0a Use tabs instead of spaces (I <3 tabs -- this is for you Qwell)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 23:45:03 +00:00
Joshua Colp 55d594e9da Make the difference clear about what the responsibilities of the core and a spy are when it comes to spying on a channel. The core is responsible for adding a spy to a channel, feeding frames into the spy, removing the spy from the channel, and notifying the spy that is has been detached. The spy is responsible for reading frames in, and cleaning itself up. Each side will not try to do the other's job.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 23:30:37 +00:00
Russell Bryant 4de3c0e447 Add the ability to specify that a frame should not be considered for caching
for uses in cases where you *know* that it will do no good.  This patch was
inspired by file for use in some work of his on mixmonitor/chanspy.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 23:14:54 +00:00
Russell Bryant 3057660a79 when calling this function to append to a dynamic string and the buffer was not
large enough and had to be reallocated, cut off the partially appended data.
Otherwise, the function will get called over and over again appending to the
end every time and never thinking it has enough room.

Thanks to jmls for access to his machine for debugging!

(issue #7691)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 22:56:01 +00:00
BJ Weschke ffd9281db9 Provide a little more protection to make sure that a MOH class is specified when using the 'm' option with WaitExten, and prevent a segfault in the process.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 21:26:04 +00:00
BJ Weschke bbc9c049ab Fix enum indexing problem with m() in WaitExten. Reported by Pavel J, in asterisk-dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 20:44:14 +00:00
BJ Weschke 7057035ae0 Changes/fixes to the app_waitforsilence app to make it behave more the way the author originally intended for it
to function along with an option to keep backward compatible with "old-style" functionality in 1.2. 
 (#6595 - davetroy reported and patched w/some very minor mods/corrections)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41915 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 20:23:41 +00:00
BJ Weschke c5c1d4579f This was added to app_dial a while back, and now it's in app_queue as well. Provide an option to prevent members of the queue from forwarding calls from the queue to somewhere else.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 19:32:51 +00:00
BJ Weschke f1b43be465 Some changes/fixes for func_curl. curl_global_init is only supposed to be called once, and if it returns non-zero, we need to give up on further executions with that instance. Additionally, let's set absolute timeout values for the CURL connections to try and prevent possible Zap (and possibly other channel tech) channel lockouts.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 19:07:58 +00:00
BJ Weschke 06b98dcc77 Merged revisions 41882 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r41882 | bweschke | 2006-09-03 13:38:22 -0400 (Sun, 03 Sep 2006) | 3 lines

 Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. (#7867 - raarts reported and patched)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:40:08 +00:00
BJ Weschke 775288c74b Blocking 41880 from coming into /trunk since I already patched it in /trunk first. Ooops!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:15:07 +00:00
BJ Weschke 91f4aa93bb Don't keep trying the same member in certain strategies when members of the queue are unavailable (#7278 - diLLec reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:12:30 +00:00
Joshua Colp 6fdd2ef790 Tweak the if statement a bit
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 16:44:49 +00:00
Russell Bryant e576ac0930 Don't use ast_frdup() in the AST_LIST_INSERT_TAIL macro directly. That was a
very stupid thing to do.  It ends up duplicating the frame twice, linking in
one of them and setting the tail pointer to the other one.  Sorry ...

Thanks to file for pointing out the breakage!!!  file rocks.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 16:41:02 +00:00
BJ Weschke c4dac0c1e5 We don't spy on Zap/psuedo channels. Not at all. Never. (#7871 - sxpert reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 15:21:12 +00:00
Russell Bryant cf5a226c4b remove leading space in Packet manager event header
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 15:04:26 +00:00
BJ Weschke a17cdb94c0 r41830 isn't going to merge cleanly into /trunk so it is blocked.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41831 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:54:02 +00:00
BJ Weschke b6ccca7566 Merged revisions 41827 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r41827 | bweschke | 2006-09-03 10:16:08 -0400 (Sun, 03 Sep 2006) | 3 lines

 Setting a retry of 0 is generally not a good idea and shouldn't be allowed. (#7574 - reported by regin)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:28:25 +00:00
BJ Weschke a9da7b62cb Block 30546 from coming into /trunk. Some old cleanup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:26:44 +00:00
BJ Weschke e736c8a27b With the somewhat recent addition (from one of the Astridevcon Europe sessions) of more detailed device states, we need to change strategy in app_queue in how we determine whether a queue member is "in use" or not. Basically, instead of specifically looking for that device state as we did previously, now we're going to observe any other device state aside from the two that we know for sure are "not in use" as "in use". This will cause some other states to fall through that we know will never be available (eg - "INVALID","UNAVAILABLE",etc) but there's other code already within to handle those conditions. (#7433 - tgrman reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41810 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-02 18:36:53 +00:00
Jason Parker ce35c33353 It was pointed out to me, that using two frames is silly.
Thanks Josh.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-02 01:44:50 +00:00
Jason Parker 1d9bf5b1e8 fix some module loader breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-02 01:39:42 +00:00
Jason Parker 696465a002 Fix VLDTMF issues.
It still isn't variable length, but it does let you dial again.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-02 01:39:15 +00:00