Commit Graph

13527 Commits

Author SHA1 Message Date
Russell Bryant 0df5e50e97 Use BEGIN_OPTIONS / END_OPTIONS to make the syntax highlighting in my editor happy
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 01:40:47 +00:00
Russell Bryant 31512895ae Instead of reserving 800 bytes for periodic announcements, use an array of
ast_str pointers and only alloate space for the strings as needed.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 01:35:28 +00:00
Joshua Colp 7d561b994c Merged revisions 89260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89260 | file | 2007-11-13 21:15:12 -0400 (Tue, 13 Nov 2007) | 4 lines

Return the proper value when the srv_callback function executes properly.
(closes issue #11240)
Reported by: jtodd

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 01:16:50 +00:00
Russell Bryant 76696ac65f Convert most of the strings in the call_queue struct to use stringfields.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 01:15:26 +00:00
Kevin P. Fleming a34bbab643 use simpler technique for removing known entries from lists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89259 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 00:54:38 +00:00
Russell Bryant b30b1bc46f - Simplify removing an item from a list
- move a verbose message to after the item is added to the list
- make use of the ARRAY_LEN macro in one spot


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 00:33:52 +00:00
Steve Murphy fd1f6df25f This hopefully will fix the re-opened 11233. Hadn't covered the case of a context with no patterns. (blush)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89257 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 23:43:41 +00:00
Steve Murphy f0a7e86177 closes issue #11233 -- where some fine points in the algorithm to build the tree needed to be corrected. Many thanks for the test case, jtodd
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89256 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 21:19:11 +00:00
Jason Parker 3846390d00 Blocked revisions 89254 via svnmerge
(closes issue #11238)
........
r89254 | qwell | 2007-11-13 15:07:08 -0600 (Tue, 13 Nov 2007) | 4 lines

Fix building on newer systems which require a third arg to open() when using O_CREAT.

Issue 11238, reported by puzzled.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 21:08:23 +00:00
Russell Bryant 9eff81dad9 This fixes a build error on my mac. It also works on my linux box. Let me
know if it breaks any other platform ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 21:01:14 +00:00
Russell Bryant 799fc3b99f Fix a typo pointed out by outtolunc, thanks :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:56:32 +00:00
Russell Bryant 50426062b7 - Convert initialization of a struct to C99 style instead of GNU style
- Fix a minor spelling error in a comment


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:53:49 +00:00
Russell Bryant fa39f74761 Update the ParkedCall application to grab the first available parked call if no
parked extension is provided as an argument.

(closes issue #10803)
Reported by: outtolunc
Patches: 
      res_features-parkedcall-any.diff4 uploaded by outtolunc (license 237)
	  - modified by me to work a bit differently ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:30:13 +00:00
Jason Parker d24cee9a81 Merged revisions 89248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11237)
........
r89248 | qwell | 2007-11-13 13:47:45 -0600 (Tue, 13 Nov 2007) | 7 lines

Revert change from revision 67064.
It is documented behavior that if a parking extension already exists while using PARKINGEXTEN,
 dialplan execution will continue.  If blind transferring to a Park with PARKINGEXTEN, you
 must keep this in mind, and handle the failure yourself.

Issue 11237, reported by jon.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 19:48:41 +00:00
Tilghman Lesher f821071748 Merged revisions 89246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines

If we set a value for qualify, we should actually pay attention to it, instead of overriding the value

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 17:41:02 +00:00
Mark Michelson e4bb565530 Merged revisions 89241 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89241 | mmichelson | 2007-11-13 10:02:02 -0600 (Tue, 13 Nov 2007) | 5 lines

Reverting commit made in revision 89205 since it is unnecessary.

Thanks to Kevin for pointing this out


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 16:03:10 +00:00
Tilghman Lesher 9cd09c5214 Merged revisions 89239 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89239 | tilghman | 2007-11-13 07:51:53 -0600 (Tue, 13 Nov 2007) | 4 lines

Debugging is running into the 16-lock limit.  Increase to avoid.
(This define is only effective when debugging is turned on, so there's
no effect for most installations.)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 14:03:34 +00:00
Mark Michelson 13c49f6cce There is the potential to copy uninitialized memory into the mixmonitor->post_process
string. This fix prevents that.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 01:19:53 +00:00
Mark Michelson 1d4c579422 Merged revisions 89205 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89205 | mmichelson | 2007-11-12 18:56:46 -0600 (Mon, 12 Nov 2007) | 5 lines

Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options
and args.post_process strings are uninitialized and could contain garbage. This change
handles this situation properly by only using arguments that we have parsed.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 00:57:34 +00:00
Jason Parker 94f0144eca oops, somebody left out the directory here...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89203 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 00:19:50 +00:00
Jason Parker cfbc4f5fb8 Doxygen fixes.
Also fix a common typo I kept seeing (arguement) in various files.

Closes issue #11222, patch by snuffy (with arguement > argument by me).


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89202 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 23:44:20 +00:00
Steve Murphy f033e50a15 Don't forget the ASTERISK_VERSION for the sake of the mtx_prof stuff.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 23:33:55 +00:00
Steve Murphy db1000b803 Thanks to snuffy for this doxygen update to hashtab.h; closes issue #11223
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 21:50:02 +00:00
Steve Murphy fd1fbb0223 Thanks to snuff-work, who brought up that these fixes might need to be made.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:49:27 +00:00
Jason Parker 50879dcb1d Merged revisions 89194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89194 | qwell | 2007-11-12 14:46:52 -0600 (Mon, 12 Nov 2007) | 1 line

Fix a typo pointed out by De_Mon on #asterisk-dev
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:48:57 +00:00
Tilghman Lesher c69bbd2dcf Blocked revisions 89191 via svnmerge
........
r89191 | tilghman | 2007-11-12 14:16:18 -0600 (Mon, 12 Nov 2007) | 5 lines

If two config writes collide, file corruption could result.  Use a mkstemp() file, instead.
Reported by: paravoid
Patch by: tilghman
Closes issue #10781

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89193 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:29:38 +00:00
Kevin P. Fleming c7773aa206 (closes issue #11221)
Reported by: eliel
Patches:
      utils.Makefile.patch uploaded by eliel (modified by me) (license 64)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:16:13 +00:00
Steve Murphy 98429d37b2 Based on a note in asterisk-dev by Brian Capouch, I determined I too agressive in not initializing arrays passed to pbx_substitute_variables_xxxx; I reviewed the code (again) and hopefully found every possible spot where substitute_variables is called conditionally, and made sure the char array involved was set to a null string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 18:44:36 +00:00
Tilghman Lesher 061e5a1674 Merged revisions 89184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines

Fix two cases of memory corruption caused by background threads.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 17:44:04 +00:00
Christian Richter 2a0b16b663 Merged revisions 89173 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89173 | crichter | 2007-11-12 12:26:48 +0100 (Mo, 12 Nov 2007) | 1 line

if we're NT and no number was dialed and overlapdial is set, we wait for the ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:36:45 +00:00
Christian Richter 753f223a69 Merged revisions 89172 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89172 | crichter | 2007-11-12 12:23:57 +0100 (Mo, 12 Nov 2007) | 1 line

added restart all interfaces Restart_Indicator, to automatically send a RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89178 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:33:13 +00:00
Joshua Colp 098728eb64 Fix building on FreeBSD by including/not including some headers.
(closes issue #11218)
Reported by: ys
Patches:
      trunk89169.diff uploaded by ys (license 281)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89177 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:26:45 +00:00
Christian Richter 4f289131e6 Merged revisions 89171 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89171 | crichter | 2007-11-12 12:13:13 +0100 (Mo, 12 Nov 2007) | 1 line

fixed a state/event issue with overlapdial=yes when no extension matched. removed the general sending of a RELEASE_COMPLETE when we receive a RELEASE, this is done by mISDNuser/mISDN. This makes it possible to use asterisk-1.4 with mISDN trunk, but requires users of mISDN/mISDNuser-1.1.X to upgrade to at least mISDNuser-1.1.6 (when using the NT mode at all)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:22:17 +00:00
Christian Richter b2f3d1203c Merged revisions 89170 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89170 | crichter | 2007-11-12 10:57:23 +0100 (Mo, 12 Nov 2007) | 1 line

fixed the support for CW and therefore for the reject_cause option.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 13:03:00 +00:00
Christian Richter c9b8afb447 Merged revisions 89169 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89169 | crichter | 2007-11-12 10:45:36 +0100 (Mo, 12 Nov 2007) | 1 line

aded ntkeepcalls option, to avoid droÃpping calls when the L2 goes down on a PTP link. There are some pbx which do turn off the L1 for a very short while and restart it immediately. normally T310 should be started and after 10 seconds or so the calls should be dropped, this is a simple fix wihtout this timer.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89174 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 12:49:19 +00:00
Jason Parker a442780a75 Add usbradio.conf.sample from branches/1.4/configs - r84162.
It was mistakenly deleted in 1.4 without ever being merged to trunk.

Reported by eliel on #asterisk-dev.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-09 18:57:21 +00:00
Jason Parker b436362b19 Fix a few potential deadlocks in cdr_sqlite3_custom.
(also rename sample config to .sample)

Closes issue #11208, patch by Laureano.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89130 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-09 16:32:01 +00:00
Steve Murphy a897556f7f This is the perhaps the biggest, boldest, most daring change I've ever committed to trunk. Forgive me in advance any disruption this may cause, and please, report any problems via the bugtracker. The upside is that this can speed up large dialplans by 20 times (or more). Context, extension, and priority matching are all fairly constant-time searches. I introduce here my hashtables (hashtabs), and a regression for them. I would have used the ast_obj2 tables, but mine are resizeable, and don't need the object destruction capability. The hashtab stuff is well tested and stable. I introduce a data structure, a trie, for extension pattern matching, in which knowledge of all patterns is accumulated, and all matches can be found via a single traversal of the tree. This is per-context. The trie is formed on the first lookup attempt, and stored in the context for future lookups. Destruction routines are in place for hashtabs and the pattern match trie. You can see the contents of the pattern match trie by using the 'dialplan show' cli command when 'core set debug' has been done to put it in debug mode. The pattern tree traversal only traverses those parts of the tree that are interesting. It uses a scoreboard sort of approach to find the best match. The speed of the traversal is more a function of the length of the pattern than the number of patterns in the tree. The tree also contains the CID matching patterns. See the source code comments for details on how everything works. I believe the approach general enough that any issues that might come up involving fine points in the pattern matching algorithm, can be solved by just tweaking things. We shall see. The current pattern matcher is fairly involved, and replicating every nuance of it is difficult. If you find and report problems, I will try to resolve than as quickly as I can. The trie and hashtabs are added to the existing context and exten structs, and none of the old machinery has been removed for the sake of the multitude of functions that use them. In the future, we can (maybe) weed out the linked lists and save some space.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-09 16:00:22 +00:00
Jason Parker ec8497c58f Merged revisions 89125 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11203)
........
r89125 | qwell | 2007-11-08 17:52:35 -0600 (Thu, 08 Nov 2007) | 4 lines

Properly say the seconds here..

Issue 11203, fix described by vma.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 23:53:00 +00:00
Jason Parker 267e829cbd Add check_hangup() method to pbx_lua, which can be used to check whether it is time to hangup a channel.
Closes issue #11202, patch by mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 23:38:30 +00:00
Mark Michelson 35d7946cda app_voicemail failed to build when compiling with IMAP_STORAGE
Now it does not.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89123 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 22:33:59 +00:00
Mark Michelson 0881f07aed AST_LIST_REMOVE_CURRENT takes only one argument.
Thanks to snuffy for pointing this out on IRC



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 21:31:06 +00:00
Joshua Colp e4187a7a26 Make func_env build again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 21:27:37 +00:00
Mark Michelson beef61b718 Merged revisions 89119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89119 | mmichelson | 2007-11-08 15:00:08 -0600 (Thu, 08 Nov 2007) | 7 lines

Rework of the commit I made yesterday to use the already built-in
ast_uri_decode function as opposed to my home-rolled one. Also added
comments.

Thanks to oej for pointing me in the right direction


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 21:01:02 +00:00
Kevin P. Fleming f806dea3dd convert this code to a more efficient idiom
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89118 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 20:39:41 +00:00
Jason Parker 8b6c511200 Change a warning to a notice. Issue #11195, patch by eliel
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89117 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 18:49:08 +00:00
Jason Parker e03cb6a721 Merged revisions 89115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11195)
........
r89115 | qwell | 2007-11-08 12:45:15 -0600 (Thu, 08 Nov 2007) | 4 lines

Avoid warnings on load when using sample configuration files.

Issue 11195, patch by eliel.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89116 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 18:48:15 +00:00
Tilghman Lesher 3a70afbc3e Add the FILE() dialplan function and deprecate ReadFile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89114 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 17:32:15 +00:00
Tilghman Lesher 86e5e39198 Fix missed conversion to linkedlists macro change
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 17:28:45 +00:00
Mark Michelson 314238d9cb Blocking changes from previous 1.4 commit
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 16:51:08 +00:00