Commit Graph

30396 Commits

Author SHA1 Message Date
Jenkins2 11a1e07ad2 Merge "netsock: Remove from Asterisk core." 2017-12-18 17:40:22 -06:00
Jenkins2 7b127e2d20 Merge "CLI: Fix 'core set debug channel' completion bug." 2017-12-18 16:01:11 -06:00
George Joseph 08440fd1d9 Merge "CLI: Remove special handling of 'core set verbose' from rasterisk." 2017-12-18 14:42:39 -06:00
Joshua Colp 5224fd3ab4 Merge changes from topic 'faster-aco'
* changes:
  aco: Minimize use of regex.
  aco: Create ways to minimize use of regex.
2017-12-18 14:41:41 -06:00
Corey Farrell 064c74e4af netsock: Remove from Asterisk core.
This moves netsock.c / netsock.h to the chan_iax2 module.  netsock.h has
been marked deprecated since 13.0.0, chan_iax2 is the only remaining
user.

Change-Id: I28c6578043bac18de5ea608e136acec4f83d5dd3
2017-12-18 15:00:35 -05:00
Joshua Colp 7909e372f8 Merge "confbridge: Clarify mute sound documentation." 2017-12-18 12:25:37 -06:00
Corey Farrell 731a23fba7 CLI: Fix 'core set debug channel' completion bug.
The completion generator is missing a return so typing "core set debug
all off <tab>" causes the command to actually execute.

Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b
2017-12-18 13:23:46 -05:00
George Joseph c56c4312ad Merge changes from topic 'loader-work'
* changes:
  loader: Use vector to build apha sorted module lists.
  loader: Replace priority heap with vector.
2017-12-18 10:24:28 -06:00
Jenkins2 e79f0c0709 Merge "chan_pjsip.c: Improve ast_request() diagnostic msgs." 2017-12-18 09:37:19 -06:00
Jenkins2 f2d23e86d7 Merge "chan_sip: Add security event for calls to invalid extension." 2017-12-18 09:15:19 -06:00
Jenkins2 5346c290e0 Merge "cdr: Minor optimizations." 2017-12-18 08:54:28 -06:00
Jenkins2 7ffe5aba24 Merge "loader: Rework of load_dynamic_module." 2017-12-18 08:29:08 -06:00
Joshua Colp 1769d4a5c6 confbridge: Clarify mute sound documentation.
The mute/unmute sounds are only played when the
action is initiated using the DTMF menu.

ASTERISK-24756

Change-Id: I55b3dd5bc166096bf5e2f547ddd0ce355f36e3dc
2017-12-18 08:27:36 -06:00
Joshua Colp b40c00c97b app_transfer: Remove LOCAL from documentation.
The Local channel has never supported app_transfer
from what I can see so remove it from the documentation.

ASTERISK-25649

Change-Id: Icbcfe297f6f866285a26b3e9fd5c6d00fa22e0e9
2017-12-18 06:37:03 -06:00
Richard Mudgett 4a461bcde4 chan_pjsip.c: Improve ast_request() diagnostic msgs.
Attempting to dial PJSIP/endpoint when the endpoint doesn't exist and
disable_multi_domain=no results in a misleading empty endpoint name
message.  The message should say the endpoint was not found.

* Added missing endpoint not found message.

* Added more information to the empty endpoint name msgs if available.

* Eliminated RAII_VAR in request().

Change-Id: I21da85ebd62dcc32115b2ffcb5157416ebae51e4
2017-12-15 19:59:50 -06:00
Corey Farrell 6f8b34f9c1 chan_sip: Add security event for calls to invalid extension.
Log a message to security events when an INVITE is received to an
invalid extension.

ASTERISK-25869 #close

Change-Id: I0da40cd7c2206c825c2f0d4e172275df331fcc8f
2017-12-15 12:43:38 -06:00
Jenkins2 eb23919e69 Merge "res_smdi: Fix shutdown ref." 2017-12-15 12:24:43 -06:00
Jenkins2 c9bcd888a2 Merge "res_rtp_asterisk.c: Disable packet flood detection for video streams." 2017-12-15 12:15:42 -06:00
Jenkins2 6a0505eee0 Merge "res_hep: hepv3_is_loaded() should check if we are enabled" 2017-12-15 11:52:37 -06:00
Joshua Colp 73bd9d6488 Merge "res_clialiases: Fix completion pass-through." 2017-12-15 11:17:02 -06:00
Jenkins2 26e8de9453 Merge "coverity: Fix warnings in res_smdi" 2017-12-15 11:11:59 -06:00
Joshua Colp b223f0e108 Merge "loader: Minor fix to module registration." 2017-12-15 10:48:02 -06:00
Jenkins2 bcb4e6e608 Merge "res_musiconhold: Start playlist after initial announcement" 2017-12-15 10:31:21 -06:00
Corey Farrell e6768c0f81 cdr: Minor optimizations.
* bridge_candidate_process: remove SCOPED_AO2LOCK and return value.
* handle_standard_bridge_enter_message: replace recursive call with goto
  statement.

ASTERISK-24297

Change-Id: Id2eaa0822fb8dc799f63422bb3aa89de9d4ee2a2
2017-12-15 10:30:36 -06:00
Joshua Colp b0f054cb2d Merge "app_queue: Fix extension state subscriptions removed on dialplan reload" 2017-12-15 09:55:12 -06:00
Jenkins2 dff0415b1e Merge "pjsip_options: wrongly applied "UNKNOWN" status" 2017-12-15 09:49:50 -06:00
Corey Farrell bf2d35931d aco: Minimize use of regex.
Remove nearly all use of regex from ACO users.  Still remaining:
* app_confbridge has a legitamate use of option name regex.
* ast_sorcery_object_fields_register is implemented with regex, all
  callers use simple prefix based regex.  I haven't decided the best
  way to fix this in both 13/15 and master.

Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b
2017-12-15 10:14:31 -05:00
Corey Farrell a455e18320 aco: Create ways to minimize use of regex.
ACO uses regex in many situations where it is completely unneeded.  In
some cases this doubles the total processing performed by
aco_process_config.

* Create ACO_IGNORE category type for use in place of skip_category
  regex source string.
* Create additional aco_category_op values to allow specifying category
  filter using either a single plain string or a NULL terminated array
  of plain strings.
* Create ACO_PREFIX to allow matching option names to case insensitive
  prefixes.

Change-Id: I66a920dcd8e2b0301f73f968016440a985e72821
2017-12-15 10:14:20 -05:00
Corey Farrell 03c25a869f res_smdi: Fix shutdown ref.
When adding shutdown refs for OPTIONAL_API components I accidentally
added it to the unload_module function in res_smdi.  Move it to
load_module.

Change-Id: I2b9da38fbc11ef78ea23dbb2df92b684be7f647c
2017-12-15 08:56:13 -05:00
Corey Farrell 9d5797616c loader: Use vector to build apha sorted module lists.
Change-Id: I9c519f4dec3cda98b2f34d314255a31d49a6a467
2017-12-14 21:24:19 -05:00
Corey Farrell 7b54903313 loader: Replace priority heap with vector.
This is needed for future changes which will require being able to
process the load priority out of order.

Change-Id: Ia23421197f09789940510b03ebbbf3bf24d51bea
2017-12-14 20:53:25 -05:00
Sean Bright 9755eff46f res_hep: hepv3_is_loaded() should check if we are enabled
res_hep_pjsip.so and res_hep_rtcp.so will still load and do a lot of
unnecessary work even if 'enabled' is set to 'no' in hep.conf.

Change-Id: I3eddfeea09c6b5bc7c641952ee0ae487fd09b64b
2017-12-14 18:56:45 -06:00
Jenkins2 e7a6e64039 Merge "pjsip: Ignore state changes from old transactions." 2017-12-14 18:39:24 -06:00
Corey Farrell 3505cc88e8 loader: Rework of load_dynamic_module.
* Split off load_dlopen to perform actual dlopen, check results and log
  warnings when needed.
* Always use RTLD_NOW.
* Use flags which minimize number of calls to dlopen required.  First
  attempt always uses RTLD_GLOBAL when global_symbols_only is enabled,
  RTLD_LOCAL when it is not.

This patch significantly reduces the number of dlopen's performed.  With
299 modules my system ran dlopen 857 times before this patch, 655 times
after this patch.

Change-Id: Ib2c9903cfddcc01aed3e01c1e7fe4a3fb9af0f8b
2017-12-14 18:49:51 -05:00
Corey Farrell 80bf0ee99a loader: Minor fix to module registration.
This protects the module loader itself against crashing if dlopen is
called on a module from outside loader.c.

* Expand scope of lock inside ast_module_register to include reading of
  resource_being_loaded.
* NULL check resource_being_loaded.
* Set resource_being_loaded NULL as soon as dlopen returns.  This fixes
  some error paths where it was not NULL'ed.
* Create module_destroy function to deduplicate code from
  ast_module_unregister and modules_shutdown.
* Resolve leak that occured if a module did not successfully register.
* Simplify checking for successful registration.

Change-Id: I40f07a315e55b92df4fc7faf525ed6d4f396e7d2
2017-12-14 18:44:48 -05:00
Jenkins2 30658e7143 Merge "configs: Comment out and change IP of iax.conf [demo]" 2017-12-14 15:57:33 -06:00
Corey Farrell a8aa209901 res_clialiases: Fix completion pass-through.
Never ignore contents of line when generating completion options.

Change-Id: I74389efdfea154019d3b56a9f381610614c044c8
2017-12-14 16:27:45 -05:00
Jenkins2 a33207a91f Merge "res_pjsip_session: Reinvite using active stream topology if none requested." 2017-12-14 15:22:21 -06:00
Richard Mudgett 98f7e9251f res_rtp_asterisk.c: Disable packet flood detection for video streams.
We should not do flood detection on video RTP streams.  Video RTP streams
are very bursty by nature.  They send out a burst of packets to update the
video frame then wait for the next video frame update.  Really only audio
streams can be checked for flooding.  The others are either bursty or
don't have a set rate.

* Added code to selectively disable packet flood detection for video RTP
streams.

ASTERISK-27440

Change-Id: I78031491a6e75c2d4b1e9c2462dc498fe9880a70
2017-12-14 14:40:34 -06:00
George Joseph 283d2df680 res_pjsip_sdp_rtp: Add NULL check in add_crypto_to_stream
add_crypto_to_stream wasn't checking for a NULL
session->inv_session->neg before calling pjmedia_sdp_neg_get_state.
This was causing a crash if the negotiation hadn't already been
completed and asterisk was compiled with --enable-dev-mode.

Change-Id: I57c6229954a38145da9810fc18657bfcc4d9d0c9
2017-12-14 13:05:23 -07:00
Sean Bright c387beb456 res_musiconhold: Start playlist after initial announcement
Reset the samples counter to zero when we are done playing an
announcement so that we don't skip into the middle of the first file in
the playlist.

Also add the selected annoucement to the output of 'moh show classes.'

ASTERISK-24329 #close
Reported by: Thomas Frederiksen

Change-Id: I2a5f986a31279c981592f49391409ebf38d6f6d0
2017-12-14 12:17:19 -06:00
Sean Bright 7a8a187a56 coverity: Fix warnings in res_smdi
ASTERISK-19657 #close
Reported by: Matt Jordan III, Esq.

Change-Id: I59a5e6ef3e7d9e848bec1f4b40cb73321bc7956a
2017-12-14 10:52:25 -06:00
Sean Bright dac5e3a0df configs: Comment out and change IP of iax.conf [demo]
This no longer appears to exist, so no sense in causing confusion.

ASTERISK-27175 #close
Reported by: Tzafrir Cohen

Change-Id: Idde967924c69f6a741dc9a5ab7dacb44d22cf100
2017-12-14 10:22:54 -06:00
Joshua Colp ec984870b0 Merge "menuselect: Tweak check for recently run configure." 2017-12-14 07:08:57 -06:00
Joshua Colp 49f2ff37bd Merge "README: Remove outdated references to tex docs" 2017-12-14 06:48:17 -06:00
Joshua Colp 7a837ece97 Merge "Add new AMI action for app_voicemail" 2017-12-14 06:14:32 -06:00
Joshua Colp e411b7d112 Merge "chan_sip: 3PCC patch for AMI "SIPnotify"" 2017-12-14 06:14:16 -06:00
Kevin Harwell 30954337a0 Merge "pjsip_options: contacts sometimes not being updated on reload" 2017-12-13 16:50:56 -06:00
Jenkins2 588be919cb Merge "res_pjsip: Assign support levels to a few modules" 2017-12-13 15:33:41 -06:00
George Joseph a51bfe5a79 README: Remove outdated references to tex docs
Added links to the wiki to replace references to outdated
tex docs.

ASTERISK-27430
Reported by: Corey Farrell

Change-Id: I5007e732b30bc7b63d124c530ae8857c89991209
2017-12-13 14:30:38 -06:00