Commit Graph

30418 Commits

Author SHA1 Message Date
Jenkins2 204dd027dd Merge "core: Fix multiple trivial issues in the core." 2017-12-19 14:46:02 -06:00
George Joseph 33213a5220 Merge "chan_console: Use correct parameter for 'set active'" 2017-12-19 14:20:19 -06:00
George Joseph 88f7f4ebb6 Merge "main/app: Fix leaks." 2017-12-19 14:19:42 -06:00
George Joseph 5554bc6b53 Merge "app_queue: Add feature to set wrapuptime on the queue member" 2017-12-19 14:15:48 -06:00
Jenkins2 a100baccb5 Merge "func_callerid: Initialize app argument structures." 2017-12-19 11:49:51 -06:00
Jenkins2 7384abc5c1 Merge "bridge_softmix.c: Don't match dead streams." 2017-12-19 11:12:22 -06:00
Jenkins2 6bd25cad86 Merge "rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage." 2017-12-19 10:51:07 -06:00
Jenkins2 ece673f0f6 Merge "bridge_softmix.c: Change remove_destination_streams() return meaning." 2017-12-19 10:37:53 -06:00
Jenkins2 758b321f4c Merge "ast_json_pack(): Use safer json ref mechanism." 2017-12-19 10:23:41 -06:00
Jenkins2 a788e2e796 Merge "app_voicemail: Fix memory management issues." 2017-12-19 10:08:18 -06:00
George Joseph d68482fce2 Merge "bridge_softmix: Fix memory leaks." 2017-12-19 09:51:25 -06:00
Oron Peled c02e256407 chan_console: Use correct parameter for 'set active'
chan_console supports multiple devices but the CLI only works on a
single device. 'console set active' selects this device.

Sadly that CLI picks the wrong command-line parameter and will only
work for a device called 'active'.

ASTERISK-27490 #close

Change-Id: I2f0e5fe63db19845bee862575b739360797dc73d
2017-12-19 14:12:57 +02:00
Corey Farrell bf33a09c37 core: Fix multiple trivial issues in the core.
* Fix small leaks in from error conditions in sdp.c and translate.c.
* Check new file descriptor is less than 0, not less than or equal.

Change-Id: Id7782775486175c739e0c4bf3ea5e17e3f452a99
2017-12-19 00:36:24 -05:00
Corey Farrell 8dfc973d64 main/app: Fix leaks.
* ast_linear_stream would leak a file descriptor if it failed to allocate
  lin.
* ast_control_tone leaked zone and ts if ast_playtones_start failed.

Additionally added whitespace to ast_linear_stream, pulled assignments
out of conditionals for improved readability.

Change-Id: I6d1a10cf9161b1529d939b9b2d63ea36d395b657
2017-12-18 21:04:31 -05:00
Corey Farrell a790ced2e8 func_callerid: Initialize app argument structures.
This module uses AST_DEFINE_APP_ARGS_TYPE to define struct's instead of
directly using AST_DECLARE_APP_ARGS.  Initialize the variables declared
in this way.

Change-Id: If97fbdd8d63a204e2efd498a192effc14e90fb31
2017-12-18 20:35:12 -05:00
Richard Mudgett 4c04e13783 bridge_softmix.c: Change remove_destination_streams() return meaning.
The return value of remove_destination_streams() now means we removed a
stream from the topology by making it a dead stream.  Now we won't try to
request a topology change if we didn't remove any streams.

Change-Id: Icd91571d856a1d04299a24c411e325c1d9d5c61d
2017-12-18 18:55:13 -06:00
Richard Mudgett ea4179599f bridge_softmix.c: Don't match dead streams.
* Made is_video_source() and is_video_dest() not match dead streams.

* Optimized is_video_dest() to reduce duplicated code.

Change-Id: I4e7ab762c7ee98395e78e6516399f57a2609b9a1
2017-12-18 18:51:23 -06:00
Corey Farrell 91d9eae79b bridge_softmix: Fix memory leaks.
Change-Id: Ifaf3e93b398595d21d07f535330fef77ff15a80c
2017-12-18 19:40:08 -05:00
Richard Mudgett f6393b59af ast_json_pack(): Use safer json ref mechanism.
Change-Id: I49204db2e57ae96eee43909c18ed007c09ac817e
2017-12-18 18:05:29 -06:00
Corey Farrell dc04d1ec93 app_voicemail: Fix memory management issues.
* mwi_sub_event_cb: mwist leaked on separate_mailbox failure.
* add_email_attachment: A reference to sox_gain_tmpdir was used
  after the storage was out of scope.

Change-Id: I6282c542ff7b82fa091177a912d11234a8b00a30
2017-12-18 19:04:56 -05:00
Richard Mudgett 7054fb8756 rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage.
Change-Id: I58a22c2ca82e91d7537409b7b3af2d735827a54d
2017-12-18 18:02:09 -06:00
Jenkins2 11a1e07ad2 Merge "netsock: Remove from Asterisk core." 2017-12-18 17:40:22 -06:00
Rodrigo Ramírez Norambuena 5335ad117d app_queue: Add feature to set wrapuptime on the queue member
This patch adds the ability to set the wrapuptime on the queue member
config.

When the option is set the wrapuptime on the queue member is used instead
of the queue's wrapuptime.

ASTERISK-27483 #close

Change-Id: I11c85809537f974eb44dc5bbf82bcedd8a458902
2017-12-18 17:29:21 -06:00
Jenkins2 7b127e2d20 Merge "CLI: Fix 'core set debug channel' completion bug." 2017-12-18 16:01:11 -06:00
George Joseph 08440fd1d9 Merge "CLI: Remove special handling of 'core set verbose' from rasterisk." 2017-12-18 14:42:39 -06:00
Joshua Colp 5224fd3ab4 Merge changes from topic 'faster-aco'
* changes:
  aco: Minimize use of regex.
  aco: Create ways to minimize use of regex.
2017-12-18 14:41:41 -06:00
Corey Farrell 064c74e4af netsock: Remove from Asterisk core.
This moves netsock.c / netsock.h to the chan_iax2 module.  netsock.h has
been marked deprecated since 13.0.0, chan_iax2 is the only remaining
user.

Change-Id: I28c6578043bac18de5ea608e136acec4f83d5dd3
2017-12-18 15:00:35 -05:00
Joshua Colp 7909e372f8 Merge "confbridge: Clarify mute sound documentation." 2017-12-18 12:25:37 -06:00
Corey Farrell 731a23fba7 CLI: Fix 'core set debug channel' completion bug.
The completion generator is missing a return so typing "core set debug
all off <tab>" causes the command to actually execute.

Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b
2017-12-18 13:23:46 -05:00
George Joseph c56c4312ad Merge changes from topic 'loader-work'
* changes:
  loader: Use vector to build apha sorted module lists.
  loader: Replace priority heap with vector.
2017-12-18 10:24:28 -06:00
Jenkins2 e79f0c0709 Merge "chan_pjsip.c: Improve ast_request() diagnostic msgs." 2017-12-18 09:37:19 -06:00
Jenkins2 f2d23e86d7 Merge "chan_sip: Add security event for calls to invalid extension." 2017-12-18 09:15:19 -06:00
Jenkins2 5346c290e0 Merge "cdr: Minor optimizations." 2017-12-18 08:54:28 -06:00
Jenkins2 7ffe5aba24 Merge "loader: Rework of load_dynamic_module." 2017-12-18 08:29:08 -06:00
Joshua Colp 1769d4a5c6 confbridge: Clarify mute sound documentation.
The mute/unmute sounds are only played when the
action is initiated using the DTMF menu.

ASTERISK-24756

Change-Id: I55b3dd5bc166096bf5e2f547ddd0ce355f36e3dc
2017-12-18 08:27:36 -06:00
Joshua Colp b40c00c97b app_transfer: Remove LOCAL from documentation.
The Local channel has never supported app_transfer
from what I can see so remove it from the documentation.

ASTERISK-25649

Change-Id: Icbcfe297f6f866285a26b3e9fd5c6d00fa22e0e9
2017-12-18 06:37:03 -06:00
Richard Mudgett 4a461bcde4 chan_pjsip.c: Improve ast_request() diagnostic msgs.
Attempting to dial PJSIP/endpoint when the endpoint doesn't exist and
disable_multi_domain=no results in a misleading empty endpoint name
message.  The message should say the endpoint was not found.

* Added missing endpoint not found message.

* Added more information to the empty endpoint name msgs if available.

* Eliminated RAII_VAR in request().

Change-Id: I21da85ebd62dcc32115b2ffcb5157416ebae51e4
2017-12-15 19:59:50 -06:00
Corey Farrell 6f8b34f9c1 chan_sip: Add security event for calls to invalid extension.
Log a message to security events when an INVITE is received to an
invalid extension.

ASTERISK-25869 #close

Change-Id: I0da40cd7c2206c825c2f0d4e172275df331fcc8f
2017-12-15 12:43:38 -06:00
Jenkins2 eb23919e69 Merge "res_smdi: Fix shutdown ref." 2017-12-15 12:24:43 -06:00
Jenkins2 c9bcd888a2 Merge "res_rtp_asterisk.c: Disable packet flood detection for video streams." 2017-12-15 12:15:42 -06:00
Jenkins2 6a0505eee0 Merge "res_hep: hepv3_is_loaded() should check if we are enabled" 2017-12-15 11:52:37 -06:00
Joshua Colp 73bd9d6488 Merge "res_clialiases: Fix completion pass-through." 2017-12-15 11:17:02 -06:00
Jenkins2 26e8de9453 Merge "coverity: Fix warnings in res_smdi" 2017-12-15 11:11:59 -06:00
Joshua Colp b223f0e108 Merge "loader: Minor fix to module registration." 2017-12-15 10:48:02 -06:00
Jenkins2 bcb4e6e608 Merge "res_musiconhold: Start playlist after initial announcement" 2017-12-15 10:31:21 -06:00
Corey Farrell e6768c0f81 cdr: Minor optimizations.
* bridge_candidate_process: remove SCOPED_AO2LOCK and return value.
* handle_standard_bridge_enter_message: replace recursive call with goto
  statement.

ASTERISK-24297

Change-Id: Id2eaa0822fb8dc799f63422bb3aa89de9d4ee2a2
2017-12-15 10:30:36 -06:00
Joshua Colp b0f054cb2d Merge "app_queue: Fix extension state subscriptions removed on dialplan reload" 2017-12-15 09:55:12 -06:00
Jenkins2 dff0415b1e Merge "pjsip_options: wrongly applied "UNKNOWN" status" 2017-12-15 09:49:50 -06:00
Corey Farrell bf2d35931d aco: Minimize use of regex.
Remove nearly all use of regex from ACO users.  Still remaining:
* app_confbridge has a legitamate use of option name regex.
* ast_sorcery_object_fields_register is implemented with regex, all
  callers use simple prefix based regex.  I haven't decided the best
  way to fix this in both 13/15 and master.

Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b
2017-12-15 10:14:31 -05:00
Corey Farrell a455e18320 aco: Create ways to minimize use of regex.
ACO uses regex in many situations where it is completely unneeded.  In
some cases this doubles the total processing performed by
aco_process_config.

* Create ACO_IGNORE category type for use in place of skip_category
  regex source string.
* Create additional aco_category_op values to allow specifying category
  filter using either a single plain string or a NULL terminated array
  of plain strings.
* Create ACO_PREFIX to allow matching option names to case insensitive
  prefixes.

Change-Id: I66a920dcd8e2b0301f73f968016440a985e72821
2017-12-15 10:14:20 -05:00