Commit graph

14110 commits

Author SHA1 Message Date
Russell Bryant
21e057e79d Fix a bug in peer handling that caused multiple instances of a peer to end up
in the peers container after a reload.  Somehow, this bug doesn't exist in 1.4 ...
(closes issue #11626)
(reported by pnlarsson, additional info from mvanbaak, fixed by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-26 16:51:16 +00:00
Russell Bryant
3c5b0443ef update svn:ignore for astcanary
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-26 16:31:43 +00:00
Mark Michelson
00d848c94e Adding support for storing the queue log entries in a realtime backend.
(closes issue #11625, reported and patched by sergee)

Thank you very much to sergee for adding this new feature!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-26 15:58:17 +00:00
Luigi Rizzo
add967dccf Split console_video.c so that video codecs and gui functions
are in separate files (still #include'd because of tangling in the data
structures, but this is going to be cleaned up).

The video grabbing functions still need to be moved to a separate file.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-26 10:14:11 +00:00
Tilghman Lesher
32289c32f5 Add pickup by channel
(Closes issue #11161)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-25 04:10:57 +00:00
Tilghman Lesher
27f8b5bc2d Change the abbreviated TON from 'A' to 'V', since 'A' is a legitimate DTMF
character.  Also, fix the documentation to match the code.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-25 03:34:09 +00:00
Tilghman Lesher
ba57c36bbb Add channel thread ID to the information passed to AGI.
Reported by: dror99
Patch by: tilghman
(Closes issue #11162)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94771 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-25 02:57:58 +00:00
Joshua Colp
0028e5a9fc Blocked revisions 94769 via svnmerge
........
r94769 | file | 2007-12-24 22:27:08 -0400 (Mon, 24 Dec 2007) | 2 lines

file says... build on the builders.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-25 02:28:01 +00:00
Tilghman Lesher
9c1dcfea5a Merged revisions 94767 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94767 | tilghman | 2007-12-24 13:36:59 -0600 (Mon, 24 Dec 2007) | 5 lines

Race: we need to wait to queue a NewChannel event until after the channel is
inserted into the channel list.  The reason is because some manager users
immediately queue requests from the channel when they see that event and are
confused when Asterisk reports no such channel. (Closes issue #11632)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-24 19:43:36 +00:00
Tilghman Lesher
f17cafdb6a Blocked revisions 94765 via svnmerge
........
r94765 | tilghman | 2007-12-24 10:17:01 -0600 (Mon, 24 Dec 2007) | 5 lines

More deadlock avoidance code (this time between sip_monitor and sip_hangup)
Reported by: apsaras
Patch by: tilghman
(Closes issue #11413)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94766 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-24 16:26:17 +00:00
Tilghman Lesher
bede5d878e Merged revisions 94763 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94763 | tilghman | 2007-12-24 09:39:56 -0600 (Mon, 24 Dec 2007) | 5 lines

Another bit of bad logic in realtime_peer
Reported by: dimas
Patch by: dimas
(Closes issue #11631)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-24 15:45:01 +00:00
Luigi Rizzo
d508cf1a07 support sdl_videodriver to send output to x11/aalib/console
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94741 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-23 14:51:00 +00:00
Luigi Rizzo
c5e36e822e move reading info from the keypad to a separate function.
Remove an unused keypad field and some debugging messages.
Adjust formatting on config file parsing


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-23 14:34:17 +00:00
Luigi Rizzo
2f592c52bd make sure the minimum surface depth is 16bpp so we can create YUVoverlays.
With this change we can do

	setenv SDL_VIDEODRIVER aalib

and output to an ascii window (which is still in an X11 window).
If you also do

	unsetenv DISPLAY

then the output goes into the main asterisk window, unfortunately
it interferes with the normal output so you don't see much.

In any case, i don't think we are very far away from having a working
xterm videophone!




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-23 12:36:32 +00:00
Luigi Rizzo
31dcae3ae0 avoid rebuilding dependent files if the generated busy.h and ringtone.h
do not change.

Ths masks (but does not solve) a but that i am seeing in doing a
'gmake install' without donig a 'gmake all' first.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-23 12:29:48 +00:00
Tilghman Lesher
5a6759885f Merged revisions 94660 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94660 | tilghman | 2007-12-22 19:21:03 -0600 (Sat, 22 Dec 2007) | 2 lines

Argh... I suppose third time's the charm.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-23 01:38:46 +00:00
Luigi Rizzo
67a704503b Change the name of config file entries for keypad regions
from 'keypad_entry' to 'region'. Fix the example file accordingly.
Also make some fixes in the code do reset entries on reload of the keypad.

The recently committed kpad2.jpg has the correct names.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94638 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-22 22:44:31 +00:00
Luigi Rizzo
4cf855f2de add a sample keypad (with annotations) for console video
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-22 22:39:55 +00:00
Luigi Rizzo
7a1dcff6a6 Build console_video support by linking in, as opposed to including,
console_video.c

This will ease the task of splitting console_video.c into its components
(V4L and X11 grabbers, various video codecs and packetizers, SDL),
as well as ease future extensions (e.g. additional video sources,
codecs and rendering engines).

For the time being nothing changes for users: video support is off by
default, and requires -DHAVE_VIDEO_CONSOLE on the command line to be included
(if SDL and FFMPEG are available).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94615 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-22 18:28:40 +00:00
Mark Michelson
eb10026dba Something I've been itching to do for a while now. A minor optimization in app_voicemail.
Since the dtable in base_encode always gets populated with the same values every time and never
changes, make it static and const and only initialize it once. Also, there's no reason to 
define BASEMAXINLINE twice, so remove the redundant #define.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 21:19:19 +00:00
Matthew Fredrickson
a3b9e3e791 We should only clear this value if we have to
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:50:26 +00:00
Matthew Fredrickson
3ce9ec2e56 Commit non TCP transport part of #11506. Includes numerous additional parameters, as well as RLT support for DMS type switches
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94549 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:48:15 +00:00
Mark Michelson
269db42c02 Store dates using local time instead of UTC
(closes issue #11610, reported and patched by rbraun_performatique)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94548 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:38:18 +00:00
Mark Michelson
e0b9943818 Fix a memory leak when reloading queue rules.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94547 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:30:05 +00:00
Mark Michelson
b6eab6d084 The one documentation source I forgot to update after the merge of the queue-penalty branch
was the CHANGES file. No longer!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:28:04 +00:00
Mark Michelson
4c8ad19825 Lots of coding guidelines cleanup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:24:24 +00:00
Mark Michelson
57afb6971e Blocked revisions 94543 via svnmerge
........
r94543 | mmichelson | 2007-12-21 14:21:59 -0600 (Fri, 21 Dec 2007) | 3 lines

Bunch of coding guidelines cleanup


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:22:52 +00:00
Mark Michelson
42803ef6e4 Merged revisions 94540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94540 | mmichelson | 2007-12-21 14:11:34 -0600 (Fri, 21 Dec 2007) | 8 lines

Better quota support for using IMAP storage voicemail

(closes issue #11415, reported by jaroth)
(closes issue #11152, reported by selsky)

Patch provided by jaroth


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:18:26 +00:00
Jason Parker
4710e2b6da codecs.conf really shouldn't be mandatory.. it never had been before, so let's go back to being optional.
A big "thank you" to pnlarsson on IRC for allowing me access to his system to debug this.

Closes issue #11584.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:12:50 +00:00
Mark Michelson
590a70a9cd Merged revisions 94538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94538 | mmichelson | 2007-12-21 13:59:45 -0600 (Fri, 21 Dec 2007) | 5 lines

The mail_copy c-client function does not expect a full imap mailbox string, just the name of the mailbox.

(closes issue #11419, reported and patched by jaroth, with additional patchwork from me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 20:01:10 +00:00
Mark Michelson
bf64785f1e AST_LIST_REMOVE_CURRENT only takes one argument in trunk
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 17:40:44 +00:00
Mark Michelson
804d90368a Merged revisions 94468 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94468 | mmichelson | 2007-12-21 10:49:35 -0600 (Fri, 21 Dec 2007) | 6 lines

Since we are freeing list elements within a list traversal, we need to use the safe
traversal and remove the item from the list before freeing it.

(closes issue 11612, reported by dtyoo)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 16:52:04 +00:00
Russell Bryant
bec8762a52 Blocked revisions 94466 via svnmerge
........
r94466 | russell | 2007-12-21 10:37:47 -0600 (Fri, 21 Dec 2007) | 6 lines

Convert the contexts lock to a read/write lock to resolve a deadlock.  This
has a nice side benefit of improving performance.  :)

(closes issue #11609)
(closes issue #11080)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 16:42:52 +00:00
Mark Michelson
c1fac2d834 Merged revisions 94464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94464 | mmichelson | 2007-12-21 10:11:44 -0600 (Fri, 21 Dec 2007) | 3 lines

Removing a debug message I accidentally just committed


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 16:12:14 +00:00
Mark Michelson
2e6431c42a Merged revisions 94420 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94420 | mmichelson | 2007-12-21 09:45:14 -0600 (Fri, 21 Dec 2007) | 5 lines

Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup.

(closes issue #11599, reported and patched by caio1982, coding guidelines cleanup by me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 16:10:21 +00:00
Tilghman Lesher
bca1033817 Merged revisions 94418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94418 | tilghman | 2007-12-21 09:07:42 -0600 (Fri, 21 Dec 2007) | 2 lines

Fix for restart-as-user problem reported via the -dev list

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 15:14:52 +00:00
Mark Michelson
88f27c8279 Moved the update of the queue_ent's rule list to just before we try to call
queue members. This allows for the change in penalty levels to be executed at
the most logical time frame.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 01:14:32 +00:00
Mark Michelson
b489558138 Merging the queue-penalty branch. In short, this allows one to dynamically adjust
the QUEUE_MAX_PENALTY and the newly introduced QUEUE_MIN_PENALTY during a call depending
on the amount of time passed. The purpose is to allow the call to open up to more (or maybe
just different) members without the caller's losing his place in the queue. See 
configs/queuerules.conf.sample for an example of how to set up queue rules and configs/queues.conf.sample
for how to associate a rule with a queue.

Along with the functional changes, new CLI and manager commands exist to show the rules defined and
there is an additional CLI command to reload the queue rules.

Future enhancements that may be made: support for realtime queue rules and support for dynamically adding
a rule through the manager or CLI. Also a manager command to reload the queue rules (I'll probably write
this myself very soon).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-21 00:44:17 +00:00
Mark Michelson
51a48a2ed9 The changes to header inclusion in trunk broke compilation of app_voicemail when using
IMAP storage. The reason is that c-client has its own definitions for LOG_WARNING
and LOG_DEBUG, so we need to be sure to include asterisk's definitions last so that
we use the proper values in app_voicemail.

(closes issue #11437, reported by blitzrage, patch suggested by blitzrage)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 23:43:24 +00:00
Russell Bryant
a9616a7153 Add a bit more to the description of the "mwimonitor" option.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 22:39:39 +00:00
Steve Murphy
2679575473 closes issue #11287; thanks to snuffy for this fix, which will surely make all solaris owners shout praises to his name.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94319 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 22:28:35 +00:00
Russell Bryant
3de7bc9ae3 Merged revisions 94256 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r94256 | russell | 2007-12-20 14:22:22 -0600 (Thu, 20 Dec 2007) | 13 lines

Merged revisions 94255 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r94255 | russell | 2007-12-20 14:21:41 -0600 (Thu, 20 Dec 2007) | 5 lines

Fix another potential seg fault ...

(closes issue #11606)
Reported by: dimas

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94257 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 20:25:05 +00:00
Russell Bryant
d607a29ddf Merged revisions 94251 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94251 | russell | 2007-12-20 14:08:42 -0600 (Thu, 20 Dec 2007) | 10 lines

Fix a deadlock in d-channel handling in chan_zap.

This deadlock was introduced by the fix to ensure that channels are properly
locked when handling channel variables.  There were sections of this code where
the channel pvt was locked before the channel lock, when in fact it _must_ be
the other way around.

(closes issue #11582)
Reported by: bugi

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 20:16:21 +00:00
Luigi Rizzo
b7adaa023c add some macros to simplify parsing the config file,
see description in config.h .

They are a variant of the set of macros i used in chan_oss.c,
structured in a way to be more robust to the presence of
spurious ';' - basically, they define wrappers for 'do {'
and '} while (0)', plus some helper functions to deal with simple
cases such as ast_copy_string, ast_malloc, strtoul, ast_true ...

The prefix (CV_ as 'Config Variable') tries to be easy to remember
and has been chosen to not conflict with other existing macros in the tree.

For the time being, I have only updated the three source files in the
tree that used the old M_* macros. Hopefully, more files will be
converted.

NOTE:

    I understand that inventing my own dialect of C is generally wrong;
    however, the lack of adequate support in the language encourages
    lazy programming practices (such as ignoring errors, bounds, etc.)
    and this increases the chance of vulnerability in the code, especially
    because we are parsing user input here.
    Hopefully, these macros and the use of ast_parse_arg (in config.h)
    should encourage the programmer to write more robust code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 12:56:07 +00:00
Luigi Rizzo
5e24835995 modify http://svn.digium.com/view/asterisk?view=rev&rev=93603
so that paths and filename are writable by asterisk.c without
causing segfaults.

This involves defining the variables as const char *,
and having them point to as static, writable buffer
defined in asterisk.c

On passing, fix some errors in using these variables
in some files in utils/ , and in res/snmp/agent.c
which was redefining a variable without using paths.h

(not applicable to 1.4)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-20 09:55:05 +00:00
Mark Michelson
c848e480c9 1. Unify the check for a penalty < 0 into the set_member_penalty code.
2. Fix an error when checking the CLI command for setting a member's penalty.
3. Fix a logging error if the incorrect parameter was the queue name or interface.

(closes issue #11544, reported and patched by Laureano)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 23:17:42 +00:00
Mark Michelson
16df336a72 Merged revisions 94122 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94122 | mmichelson | 2007-12-19 17:02:22 -0600 (Wed, 19 Dec 2007) | 6 lines

Sox versions 13.0.0 and newer do not have "soxmix" and instead use sox -m. res_monitor
needs to use this if the user does not have soxmix.

(closes issue #11589, reported by amessina, patch inspired by amessina but with a flourish from me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94123 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 23:04:32 +00:00
Russell Bryant
0e08d5e7dc Merged revisions 94077 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94077 | russell | 2007-12-19 16:48:48 -0600 (Wed, 19 Dec 2007) | 4 lines

Check for the existence of the soxmix application on the target platform and have
the result available in autoconfig.h.
(part of issue #11589)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 22:51:03 +00:00
Tilghman Lesher
d36381e629 Add 'voicemail reload' command.
Reported by: eliel
Patch by: eliel
(Closes issue #11365)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 20:20:55 +00:00
Tilghman Lesher
f97dfd2278 Add contributed WaitUntil app.
Original code by pprindeville, updated for trunk by tilghman.
(Closes issue #11487)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-19 20:06:23 +00:00