Commit graph

840 commits

Author SHA1 Message Date
Jason Parker
ed101a5319 Fix a segfault when trying to tab complete the "core show uptime" command.
Reported in #asterisk-dev on IRC by jcmoore, fixed by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72326 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:27:09 +00:00
Jason Parker
e48dbce674 Add support for Thai language in say.c
Issue 9417, patch by dome, with some cleanup done by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72325 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:17:59 +00:00
Brett Bryant
dee58f2531 Merged revisions 72260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r72260 | bbryant | 2007-06-27 15:46:12 -0500 (Wed, 27 Jun 2007) | 12 lines

Merged revisions 72259 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r72259 | bbryant | 2007-06-27 15:43:53 -0500 (Wed, 27 Jun 2007) | 4 lines

Fixes 100% load when controlling terminal disappears.

Issue #9654, #10010

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 20:47:45 +00:00
Joshua Colp
809c1398d7 Merged revisions 72257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r72257 | file | 2007-06-27 16:25:24 -0400 (Wed, 27 Jun 2007) | 10 lines

Merged revisions 72256 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r72256 | file | 2007-06-27 16:23:24 -0400 (Wed, 27 Jun 2007) | 2 lines

I may possibly get shot for doing this... but... defer CDR processing until after the channel has been dealt with. This should eliminate all of the issues with channels going funky (SIP/PRI) when you are posting CDRs to a database that is either slow or unavailable and do not want to enable batching.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 20:26:53 +00:00
Joshua Colp
2c52ab7afb Fix -T option. (issue #10073 reported by xylome)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 19:57:36 +00:00
Joshua Colp
7feaaaaf04 Merged revisions 72148 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r72148 | file | 2007-06-27 13:31:50 -0400 (Wed, 27 Jun 2007) | 2 lines

Make the ast_read_noaudio API call behave better under circumstances where DTMF emulation was happening and a generator was setup. (issue #10065 reported by stevefeinstein)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 17:34:26 +00:00
Russell Bryant
36b0448bc1 Merged revisions 72112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r72112 | russell | 2007-06-27 11:34:24 -0500 (Wed, 27 Jun 2007) | 3 lines

Only output debug information related to RTCP timestamps when RTCP debug
is turned on (issue #10066, patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 16:38:12 +00:00
Jason Parker
792beb4686 Merged revisions 71915 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r71915 | qwell | 2007-06-26 15:36:09 -0500 (Tue, 26 Jun 2007) | 4 lines

Don't dereference a pointer that may be NULL here.

Issue 10017.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 20:36:50 +00:00
Steve Murphy
af42e2ca7b Luigi's suggestion to move the llfrom decl was a good one. Done.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 16:43:33 +00:00
Russell Bryant
5590f67f58 Convert so more logging to ast_debug (issue #10045, dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71557 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 13:42:51 +00:00
Joshua Colp
694088e06f Merged revisions 71422 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r71422 | file | 2007-06-24 21:07:31 -0400 (Sun, 24 Jun 2007) | 2 lines

Fix it so 1.4 actually compiles on my box.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71425 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 01:08:22 +00:00
Russell Bryant
8f2d952945 Merged revisions 71362 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r71362 | russell | 2007-06-24 15:06:31 -0500 (Sun, 24 Jun 2007) | 10 lines

Merged revisions 71358 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71358 | russell | 2007-06-24 15:04:21 -0500 (Sun, 24 Jun 2007) | 2 lines

Revert the patch from issue 9654 due to an unexpected side effect

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 20:07:15 +00:00
Russell Bryant
80166c6de8 Conversions to ast_debug()
(issue #9984, patches from eliel and dimas)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 18:51:41 +00:00
Tilghman Lesher
d6c0627c4f Merged revisions 71289 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r71289 | tilghman | 2007-06-24 12:39:34 -0500 (Sun, 24 Jun 2007) | 10 lines

Merged revisions 71288 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71288 | tilghman | 2007-06-24 12:32:21 -0500 (Sun, 24 Jun 2007) | 2 lines

Issue 10043 - There is a legitimate need to be able to set variables to the empty string.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 17:42:39 +00:00
Steve Murphy
d17beedd5a Merged revisions 71230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r71230 | murf | 2007-06-22 21:29:48 -0600 (Fri, 22 Jun 2007) | 1 line

This patch is meant to fix 8433; where clid and src are lost via bridging.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-23 03:32:59 +00:00
Joshua Colp
6f98665672 Behold the magic of casting!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 16:14:00 +00:00
Steve Murphy
6a2af3c983 Merged revisions 71063 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r71063 | murf | 2007-06-22 08:10:24 -0600 (Fri, 22 Jun 2007) | 1 line

My conditions for merging amaflags info was naive; DOCUMENTATION is the default, although null is possible; theft of user-settable fields is not good. Just copy them, leave them alone.
This is for bug 10016. (plus a small fix to rtp, to elim a compiler warning (dev mode))
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 15:15:35 +00:00
Jason Parker
68ac7f7633 Merged revisions 71068 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r71068 | qwell | 2007-06-22 10:00:30 -0500 (Fri, 22 Jun 2007) | 12 lines

Merged revisions 71065 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71065 | qwell | 2007-06-22 09:52:18 -0500 (Fri, 22 Jun 2007) | 4 lines

Fix a few silly usages of ast_playstream() - it only ever returns 0...

Issue 10035

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 15:03:32 +00:00
Brett Bryant
aff5425dea Merged revisions 71066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r71066 | bbryant | 2007-06-22 09:53:08 -0500 (Fri, 22 Jun 2007) | 18 lines

Merged revisions 71064 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71064 | bbryant | 2007-06-22 09:39:34 -0500 (Fri, 22 Jun 2007) | 10 lines

Fixed infinite loop when controlling terminal was lost
and return value of input function wasn't checked for
errors. This would cause 100% cpu to be taken up.

(closes issue #9654, issue #10010)
Reported by: mnicholson, and eserra

Idea for the patch from mnicholson, patched by me


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71067 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 14:56:36 +00:00
Tilghman Lesher
a1bc823136 Issue 9990 - New API ast_mkdir, which creates parent directories as necessary (and is faster than an outcall to mkdir -p)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 04:35:12 +00:00
Jason Parker
0b98b2a659 Nothing to see here.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 04:13:08 +00:00
Jason Parker
7a1c2d94bb Add manager events for RTCP statistics.
Also adds a new "reporting" permission for manager, since it can be incredibly spammy.
  This permission was discussed on the -dev mailing list some months back.

Issue 8613, patch by johann8384, with some minor changes by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 23:07:20 +00:00
Steve Murphy
3327e532fa Merged revisions 70949 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r70949 | murf | 2007-06-21 16:34:41 -0600 (Thu, 21 Jun 2007) | 9 lines

Merged revisions 70948 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r70948 | murf | 2007-06-21 16:29:50 -0600 (Thu, 21 Jun 2007) | 1 line

This little fix is in response to bug 10016, but may not cure it. The code is wrong, clearly. In a situation where you set the CDR's amaflags, and then ForkCDR, and then set the new CDR's amaflags to some other value, you will see that all CDRs have had their amaflags changed. This is not good. So I fixed it.
........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 22:41:05 +00:00
Joshua Colp
80cdeaef55 Merged revisions 70727 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70727 | file | 2007-06-21 11:22:39 -0400 (Thu, 21 Jun 2007) | 2 lines

Do not Packet2Packet bridge if packetization settings do not allow it. (issue #9117 reported by phsultan)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70729 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 15:25:13 +00:00
Steve Murphy
a1e9cb4aca Merged revisions 70656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70656 | murf | 2007-06-21 07:00:39 -0600 (Thu, 21 Jun 2007) | 1 line

Via complaints aired in asterisk-users, I submit these changes, which allow cdr updates to see macro context/exten, whether hung up or not
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 13:18:12 +00:00
Tilghman Lesher
396a37eba8 Fix trunk brokenness; also, optimize application registration
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:31:08 +00:00
Steve Murphy
2462d5ab4f Cleaning up a small disaster I created earlier
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:26:07 +00:00
Jason Parker
37e66fd859 Revert the change made in revision 45474, since this causes other issues.
Issue 10021.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 20:41:06 +00:00
Joshua Colp
a2b3357a9d Merged revisions 70360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70360 | file | 2007-06-20 13:52:57 -0400 (Wed, 20 Jun 2007) | 2 lines

Put the speex packetization values back in but disable it when setting up the smoother.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 17:55:09 +00:00
Joshua Colp
61544c5019 Merged revisions 70198 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70198 | file | 2007-06-19 20:24:36 -0400 (Tue, 19 Jun 2007) | 2 lines

Don't do packetization/smoother stuff with speex, it doesn't work.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 00:26:18 +00:00
Steve Murphy
cd97d6a687 Merged revisions 70062 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r70062 | murf | 2007-06-19 12:23:23 -0600 (Tue, 19 Jun 2007) | 9 lines

Merged revisions 70053 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r70053 | murf | 2007-06-19 12:07:59 -0600 (Tue, 19 Jun 2007) | 1 line

This fixes 9246, where channel variables are not available in the 'h' exten, on a 'ZOMBIE' channel. The fix is to consolidate the channel variables during a masquerade, and then copy the merged variables back onto the clone, so the zombie has the same vars that the 'original' has.
........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 18:31:29 +00:00
Joshua Colp
9bec4f4b58 Merged revisions 70003 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r70003 | file | 2007-06-19 13:07:40 -0400 (Tue, 19 Jun 2007) | 10 lines

Merged revisions 69992 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r69992 | file | 2007-06-19 13:00:58 -0400 (Tue, 19 Jun 2007) | 2 lines

Handle the CC field in the RTP header. (issue #9384 reported by DoodleHu)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 17:09:20 +00:00
Joshua Colp
afe63aec33 Merged revisions 69987 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r69987 | file | 2007-06-19 12:24:31 -0400 (Tue, 19 Jun 2007) | 10 lines

Merged revisions 69986 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r69986 | file | 2007-06-19 12:21:29 -0400 (Tue, 19 Jun 2007) | 2 lines

Update BRIDGEPEER variable if set to the new channel name when a masquerade happens. (issue #9699 reported by dimas)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 16:25:57 +00:00
Joshua Colp
4cca0a6a8e Merged revisions 69805 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69805 | file | 2007-06-18 17:57:10 -0400 (Mon, 18 Jun 2007) | 2 lines

Fix for building on PowerPC under Linux.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 21:58:37 +00:00
Joshua Colp
f8c7174fee Merged revisions 69708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69708 | file | 2007-06-18 12:51:36 -0400 (Mon, 18 Jun 2007) | 2 lines

Remember the DNS lookup done when dnsmgr is called for the first time so that it does not needlessly spit out changed messages when the host really didn't change.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:56:06 +00:00
Joshua Colp
55c6ce92ce Few more rwlist conversions... why not.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:37:14 +00:00
Jason Parker
a5bdba6074 Merged revisions 69470 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r69470 | qwell | 2007-06-14 18:22:51 -0500 (Thu, 14 Jun 2007) | 12 lines

Merged revisions 69469 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r69469 | qwell | 2007-06-14 18:21:45 -0500 (Thu, 14 Jun 2007) | 4 lines

Fix an issue where the line number in an unterminated comment block error message would show the wrong line number.

"Reported" to me on #asterisk (somebody posted an error message, and I happened to catch it)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 23:23:35 +00:00
Russell Bryant
b179e2155f Convert uses of strdup() to ast_strdup()
(issue #9983, eliel)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 23:01:01 +00:00
Kevin P. Fleming
5fdba27ea2 Merged revisions 69392 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69392 | kpfleming | 2007-06-14 16:50:40 -0500 (Thu, 14 Jun 2007) | 2 lines

use ast_localtime() in every place localtime_r() was being used

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 22:09:20 +00:00
Russell Bryant
b266ca3aed Merged revisions 69358 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69358 | russell | 2007-06-14 16:08:23 -0500 (Thu, 14 Jun 2007) | 3 lines

Fix some problems with saying dates and times for the "tw" langauge
(issue #9964, ljmid)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:09:22 +00:00
Russell Bryant
055d82cbce Add a massive set of changes for converting to use the ast_debug() macro.
(issue #9957, patches from mvanbaak, caio1982, critch, and dimas)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 19:39:12 +00:00
Brett Bryant
bbefe59e9d Couple of manager ssl options weren't loading because of a typo.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 15:43:50 +00:00
Joshua Colp
679733c52a Use read/write lock based lists for group counting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69130 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 18:23:12 +00:00
Joshua Colp
c4c732578f Merged revisions 69128 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r69128 | file | 2007-06-13 14:16:00 -0400 (Wed, 13 Jun 2007) | 10 lines

Merged revisions 69127 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r69127 | file | 2007-06-13 14:12:48 -0400 (Wed, 13 Jun 2007) | 2 lines

Return group counting to previous behavior where you could only have one group per category. (issue #9711 reported by irroot)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 18:18:51 +00:00
Jason Parker
63535ada60 Fixes for ast_strlen_zero() janitor project.
Issue 9968, patch by eliel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69081 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 17:06:53 +00:00
Russell Bryant
cf06bdb312 Merged revisions 69010 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69010 | russell | 2007-06-12 14:13:41 -0500 (Tue, 12 Jun 2007) | 12 lines

In ast_channel_make_compatible(), just return if the channels' read and write
formats already match up.  There are code paths that call this function on a
pair of channels multiple times.  This made calls fail that were using g729
in some cases.  The reason is that codec_g729a will unregister itself from the
list of available translators will all licenses are in use.  So, the first
time the function got called, the right translation path was allocated.
However, the second time it got called, the code would not find a translation
path to/from g729 and make the call fail, even if the channel actually already
had a g729 translation path allocated.

(SPD-32)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:19:09 +00:00
Russell Bryant
ff4fc97911 Convert pbx.c to use ast_debug() for debug logging.
(issue #9925, dimas)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 16:13:45 +00:00
Joshua Colp
d0eaf1e389 Merged revisions 68922 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r68922 | file | 2007-06-12 10:23:11 -0400 (Tue, 12 Jun 2007) | 10 lines

Merged revisions 68921 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68921 | file | 2007-06-12 10:18:57 -0400 (Tue, 12 Jun 2007) | 2 lines

Bring RTP back to Asterisk at the end of a native bridge no matter what.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 14:26:12 +00:00
Joshua Colp
556ea9f554 Even more minor code cleanup!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 14:16:37 +00:00
Joshua Colp
b3475e429a Minor code cleanup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 13:58:13 +00:00
Dwayne M. Hubbard
897418858d corrected CLI 'core show codecs' syntax for issue 9945, thanks eserra.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68855 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 22:31:51 +00:00
Jason Parker
bd3de6d0f1 Change displayconnects option in manager.conf to be per-user.
Issue 9932, patch by eliel


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68831 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 22:07:50 +00:00
Joshua Colp
a9043635ed Change channel list to read/write list... I'm crazy.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 14:41:39 +00:00
Joshua Colp
eb56cb6b92 Merged revisions 68683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r68683 | file | 2007-06-11 10:33:12 -0400 (Mon, 11 Jun 2007) | 10 lines

Merged revisions 68682 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68682 | file | 2007-06-11 10:29:58 -0400 (Mon, 11 Jun 2007) | 2 lines

Improve deadlock handling of the channel list. (issue #8376 reported by one47)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 14:35:02 +00:00
Joshua Colp
21f5078843 Add username completion for manager show user CLI command. (issue #9929 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 11:59:53 +00:00
Russell Bryant
68492b239c Add an option for ControlPlayback to be able to start at an offset from
the beginning of the file.  Also, add a channel variable that indicates
the location in the file where the Playback was stopped.
(closes issue #7655, patch from sharkey)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 21:02:46 +00:00
Russell Bryant
334d8d9dc4 Add channel variable manager event
(issue #7291, patch from tonyh and jontow)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 16:14:06 +00:00
Russell Bryant
bd11057367 Minor formatting change to test changes to mantis auto-closing issues
(closes issue #6000)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 15:32:46 +00:00
Joshua Colp
154c1a7af5 Merged revisions 68401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r68401 | file | 2007-06-07 20:17:04 -0400 (Thu, 07 Jun 2007) | 10 lines

Merged revisions 68397 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68397 | file | 2007-06-07 20:15:33 -0400 (Thu, 07 Jun 2007) | 2 lines

Don't call ast_waitstream_full when the control file descriptor and audio file descriptor are not set, simply call ast_waitstream! (issue #8530 reported by rickead2000)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:18:58 +00:00
Joshua Colp
1d1566903e Merged revisions 68370 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r68370 | file | 2007-06-07 20:02:34 -0400 (Thu, 07 Jun 2007) | 10 lines

Merged revisions 68368 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68368 | file | 2007-06-07 19:59:04 -0400 (Thu, 07 Jun 2007) | 2 lines

Do a DNS lookup immediately upon calling the dnsmgr function, don't wait until a refresh happens. (issue #9097 reported by plack)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:03:49 +00:00
Russell Bryant
1093e63553 Merged revisions 68354 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r68354 | russell | 2007-06-07 18:14:45 -0500 (Thu, 07 Jun 2007) | 11 lines

Merged revisions 68351 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68351 | russell | 2007-06-07 18:13:33 -0500 (Thu, 07 Jun 2007) | 3 lines

Fix a problem where saying a character wouldn't properly break out when the caller pressed '#'
(issue #8113, reported by patbaker82, patch from jamesgolovich (hey, long time no see!) and patbaker82)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:17:01 +00:00
Russell Bryant
1d57ccb6f7 Fix a bunch of doxygen errors and document more things
(issue #9842, snuffy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:07:25 +00:00
Russell Bryant
c29ac50c57 Merged revisions 68192 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r68192 | russell | 2007-06-07 14:30:30 -0500 (Thu, 07 Jun 2007) | 3 lines

Include stdarg.h for build issues on Solaris
(issue #9381)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68193 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:31:05 +00:00
Joshua Colp
ef7b38e065 Merged revisions 68157 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r68157 | file | 2007-06-07 14:39:52 -0400 (Thu, 07 Jun 2007) | 2 lines

Fix logic when doing a name based channel search for a structure when you want to start from a specific point in the channel list. (issue #9324 reported by slavon)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@68158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 18:41:17 +00:00
Olle Johansson
7e68cd14f4 Reverting part of #67864 to be able to compile agi/eagi-test that relies on this without having
ast_log and other asterisk api functions available - I could not compile on OS/X without reverting
this.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 08:43:59 +00:00
Joshua Colp
d777d9a850 Merged revisions 67924 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67924 | file | 2007-06-06 19:38:15 -0400 (Wed, 06 Jun 2007) | 2 lines

Properly handle cases where a stream can't be written to. (issue #9757 reported by junky)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 23:41:37 +00:00
Tilghman Lesher
9d05ff8ed5 Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 21:20:11 +00:00
Russell Bryant
7b75537684 Minor formatting change to test closing mantis issues through commit tags
(closes issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67843 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 20:35:05 +00:00
Russell Bryant
3cc39e0fd0 Minor formatting change to test closing mantis issues through commit tags
(closes issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 20:21:31 +00:00
Russell Bryant
7ba22102ad Yet another minor change to test mantis/svn
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67805 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:35:49 +00:00
Russell Bryant
0ddb853244 minor formatting change ... testing mantis/svn
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67803 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:21:13 +00:00
Russell Bryant
f97cdc52f4 minor formatting change ... testing mantis/svn
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67799 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:10:03 +00:00
Russell Bryant
37816c5dd0 Formatting change ... testing
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:03:14 +00:00
Russell Bryant
9ede561378 Make another formatting change ... testing mantis/svn stuff
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:00:40 +00:00
Russell Bryant
ea2068d0ad Another minor formatting change ... testing mantis/svn
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 18:55:45 +00:00
Russell Bryant
330880b909 Minor formatting change ... testing mantis/svn
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 18:51:42 +00:00
Russell Bryant
b43599da32 More random formatting changes to test Mantis/SVN integration
(issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 17:10:52 +00:00
Russell Bryant
e727eef77f Make a completely arbitrary formatting change to test out some Mantis/SVN
integration stuff.  (issue #9828)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67730 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 17:08:00 +00:00
Russell Bryant
18101ff0e3 Merged revisions 67716 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r67716 | russell | 2007-06-06 11:55:59 -0500 (Wed, 06 Jun 2007) | 13 lines

Merged revisions 67715 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67715 | russell | 2007-06-06 11:40:51 -0500 (Wed, 06 Jun 2007) | 5 lines

We have some bug reports showing crashes due to a double free of a channel.
Add a sanity check to ast_channel_free() to make sure we don't go on trying
to free a channel that wasn't found in the channel list.
(issue #8850, and others...)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 16:58:28 +00:00
Joshua Colp
40df1fb464 Merged revisions 67650 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r67650 | file | 2007-06-06 09:30:25 -0400 (Wed, 06 Jun 2007) | 10 lines

Merged revisions 67649 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67649 | file | 2007-06-06 09:28:34 -0400 (Wed, 06 Jun 2007) | 2 lines

Reinvite the RTP back to the Asterisk machine when the timeout happens. (issue #9888 reported by gasparz)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:32:11 +00:00
Joshua Colp
a07d04cc02 Merged revisions 67631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67631 | file | 2007-06-06 09:18:39 -0400 (Wed, 06 Jun 2007) | 2 lines

Fix plc_samples warning when registering a translator. (issue #9897 reported by xylome)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67636 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:20:38 +00:00
Joshua Colp
3f671bb11d Merged revisions 67594 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r67594 | file | 2007-06-06 08:20:27 -0400 (Wed, 06 Jun 2007) | 10 lines

Merged revisions 67593 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67593 | file | 2007-06-06 08:18:36 -0400 (Wed, 06 Jun 2007) | 2 lines

Revert channel name splitting fix for Zap. The moral of the story is don't use - in your user/peer names. (issue #9668 reported by stevedavies)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:21:33 +00:00
Mark Michelson
ca4ca779a9 Found a bug where when "core set debug #" is used, the verbosity is read as the
old value instead of the old debug value, leading to an erroneous status message
after setting. This was purely a cosmetic issue and had no other underlying problems.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67557 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 22:59:36 +00:00
Jason Parker
ac8fc3ad2d Make sure we default allowmultiplelogin to on/yes, per the default stated in the config.
Issue 9885, patch by eliel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67398 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 17:47:37 +00:00
Russell Bryant
508d36f5ad Merged revisions 67308 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67308 | russell | 2007-06-05 10:51:53 -0500 (Tue, 05 Jun 2007) | 5 lines

When shutting down "gracefully", go through and run the unload() callbacks for
all of the modules.  "stop now" is considered a non-graceful shutdown and will
not go through this process.
(issue #9804, reported by chrisost, patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:54:36 +00:00
Steve Murphy
ef132e25e1 Merged revisions 67073 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67073 | murf | 2007-06-04 15:59:34 -0600 (Mon, 04 Jun 2007) | 1 line

This typo has been here since 1.4 forked. It has been the source of heartburn to many a dialplan/CDR programmer.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:15:38 +00:00
Russell Bryant
b5089b4a58 Merged revisions 67071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67071 | russell | 2007-06-04 16:47:36 -0500 (Mon, 04 Jun 2007) | 2 lines

Add a missing \n.  (pointed out by jcmoore on IRC)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 21:48:15 +00:00
Russell Bryant
e1375b96c2 Change javadoc style code documentation to the same format we use elsewhere.
(issue #9864, patch from snuffy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:56:13 +00:00
Russell Bryant
93f2be2675 Fix a couple of places where "tos" was used instead of "cos".
(issue #9540, patch by IgorG)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:14:52 +00:00
Russell Bryant
b1490716f6 remove a bogus comment that came from copy/paste
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 23:39:18 +00:00
Russell Bryant
605368649e Merge major changes to the way device state is passed around Asterisk. The two
places that cared about device states were app_queue and the hint code in pbx.c.
The changes include converting it to use the Asterisk event system, as well as
other efficiency improvements.
 * app_queue: This module used to register a callback into devicestate.c to
   monitor device state changes.  Now, it is just a subscriber to Asterisk
   events with the type, device state.
 * pbx.c hints: Previously, the device state processing thread in devicestate.c
   would call ast_hint_state_changed() each time the state of a device changed.
   Then, that code would go looking for all the hints that monitor that device,
   and call their callbacks.  All of this blocked the device state processing
   thread.  Now, the hint code is a subscriber of Asterisk events with the
   type, device state.  Furthermore, when this code receives a device state
   change event, it queues it up to be processed by another thread so that it
   doesn't block one of the event processing threads.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 23:34:43 +00:00
Doug Bailey
d3e9141345 Changed the dtmf detection to integer based goertzel algorithm.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:00:40 +00:00
Joshua Colp
ed4726769a Merged revisions 66437 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66437 | file | 2007-05-29 12:44:34 -0400 (Tue, 29 May 2007) | 2 lines

Handle cases where a frame may have no data. (issue #9519 reported by dmb)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 16:46:49 +00:00
Tilghman Lesher
ffe08532a4 Merged revisions 66159 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r66159 | tilghman | 2007-05-25 09:41:27 -0500 (Fri, 25 May 2007) | 10 lines

Merged revisions 66127 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66127 | tilghman | 2007-05-25 08:46:35 -0500 (Fri, 25 May 2007) | 2 lines

Issue 9791 - Fix pronunciation of seconds in Dutch

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 14:49:20 +00:00
Joshua Colp
f65934a517 Minor tweak... drop translation path if one exists when we get an already signed linear frame in. Chances are the stream has then switched to signed linear and we no longer need the path.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 13:26:52 +00:00
Joshua Colp
844394c495 Merged revisions 66074 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66074 | file | 2007-05-24 18:16:58 -0400 (Thu, 24 May 2007) | 2 lines

Fix slinfactory logic when dealing with frames coming in that may already be in the signed linear format.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66109 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 01:37:50 +00:00
Russell Bryant
2b25070414 Merged revisions 66076 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66076 | russell | 2007-05-24 17:23:59 -0500 (Thu, 24 May 2007) | 1 line

if the string field init fails, clean up the stuff that was allocated already
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 22:25:55 +00:00
Russell Bryant
9065eb1054 Merged revisions 66070 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66070 | russell | 2007-05-24 17:07:39 -0500 (Thu, 24 May 2007) | 2 lines

Check the result of ast_string_field_init() in ast_channel_alloc()

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 22:08:33 +00:00
Kevin P. Fleming
4573b36af1 use the OpenSSL AES implementation if it's available (unless configured not to)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 22:07:50 +00:00
Russell Bryant
4b3a3fb14c Add a new API call for creating detached threads. Then, go replace all of the
places in the code where the same block of code for creating detached threads
was replicated.  (patch from bbryant)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@65968 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 18:30:19 +00:00