Commit Graph

18928 Commits

Author SHA1 Message Date
Matthew Nicholson 317435a932 Added the 'a' option to app dial and modified app_dial to set the answertime when the called channel answers.
This change causes answertime to be correct even if the called channel hangs up during an announcement triggered by the A() option.

(closes issue #15936)
Reported by: falves11
Patches:
      dial-macro-billsec-fix1.diff uploaded by mnicholson (license 96)
      dial-caller-answer1.diff uploaded by mnicholson (license 96)
Tested by: falves11, mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 21:39:33 +00:00
Matthew Nicholson ed2ed2717a Merged revisions 227827 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r227827 | mnicholson | 2009-11-04 14:52:27 -0600 (Wed, 04 Nov 2009) | 10 lines
  
  This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.
  
  (closes issue #16005)
  Reported by: falves11
  Patches:
        dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)
  Tested by: mnicholson, falves11
  
  Review: https://reviewboard.asterisk.org/r/407/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 21:03:33 +00:00
Tilghman Lesher d5fa4289d0 Fixes for gcc 4.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227824 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 20:35:24 +00:00
Matthew Nicholson b3bd43366f Modify the SDP parsing code to parse session and media level items separately.
With the new code, media level proprieties should no longer be confused with session level proprieties. This change also reorganizes some of the SDP parsing code which should make it easier to manage in the future.

(closes issue #14994)
Reported by: frawd
Tested by: frawd, mnicholson, file

Review: https://reviewboard.asterisk.org/r/414/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227759 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 20:13:50 +00:00
Joshua Colp 1f3d75b369 Merged revisions 227735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r227735 | file | 2009-11-04 15:25:37 -0400 (Wed, 04 Nov 2009) | 5 lines
  
  Fix a security issue where it may be possible for someone to execute a cross-site
  AJAX request exploit.
  
  (AST-2009-009)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227739 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 19:26:19 +00:00
Joshua Colp 45f0f0cfef Merged revisions 227700 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r227700 | file | 2009-11-04 15:17:39 -0400 (Wed, 04 Nov 2009) | 5 lines
  
  Fix a security issue where sending a REGISTER with a differing username in the From
  URI and Authorization header would reveal whether it was valid or not.
  
  (AST-2009-008)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 19:20:46 +00:00
Mark Michelson 2f4b5c8bb5 Add a couple more casts so that code compiles correctly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:41:02 +00:00
Tilghman Lesher 8d1befcbe8 mmichelson reported a compilation error related to codec bit expansion that should be resolved with a simple include of frame_defs.h
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:35:27 +00:00
Jeff Peeler 562a18f533 fix trunk building
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227643 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:25:15 +00:00
Tilghman Lesher 2bbda7a7c8 Two other trunk build fixes (reported by seanbright on #asterisk-dev)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227615 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:17:18 +00:00
Tilghman Lesher 8f336e3d01 Fix trunk building
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 16:13:50 +00:00
Tilghman Lesher d8e0c58437 Expand codec bitfield from 32 bits to 64 bits.
Reviewboard: https://reviewboard.asterisk.org/r/416/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 14:05:12 +00:00
Tilghman Lesher 6a50e7a031 chan_misdn will fail to compile if the redirect_dn member is missing
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 13:57:09 +00:00
Olle Johansson 037a6d287b Add destruction of iterators to avoid problems with refcounters
(per Russell's review of another patch)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 08:22:00 +00:00
Tilghman Lesher 206d2cbc16 Don't crash when state_interface is NULL.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 03:15:10 +00:00
Russell Bryant 3313924572 Resolve another warning.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 22:13:25 +00:00
Russell Bryant b0778107c7 Resolve a warning from gcc 4.4.1.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 22:08:46 +00:00
Russell Bryant a0198fc3ee Resolve some dev-mode warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227462 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 22:05:31 +00:00
David Brooks d87006ca1c AMI hook interface
This patch, originally submitted by jozza, enables custom modules to send actions to AMI
and receive messages from AMI via a hook interface. Included is a simple test module to
illustrate the interface.

(closes issue #14635)
Reported by: jozza

Review: https://reviewboard.asterisk.org/r/412/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 21:26:28 +00:00
Matthew Nicholson 7ed425ec80 This patch adds a sequence field to CDRs that can be combined with the linkedid or uniqueid field to uniquely identify a CDR.
(closes issue #15180)
Reported by: Nick_Lewis
Patches:
      cdr-sequence10.diff uploaded by mnicholson (license 96)
Tested by: mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 21:21:09 +00:00
Joshua Colp 2263ced9dd Add support for using a hint when configuring a state interface using the format hint:<extension>@<context>.
(closes issue #15168)
Reported by: p_lindheimer
Patches:
      queue_extenstate5_1.4.svn.patch uploaded by GameGamer43 (license 894)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 21:16:14 +00:00
Jason Parker 85e2c6d7fb Fix some build issues on Solaris.
(closes issue #14517)
(SWP-109)
Reported by: asgaroth
Patches:
      bug_14517.diff uploaded by snuffy (license 35)
Tested by: asgaroth, snuffy, dougm, qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 19:59:46 +00:00
Leif Madsen f457dfecd1 Change warning message to debug message.
app_controlplayback outputs a warning, when in fact it is normal.

(closes issue #16071)
Reported by: atis
Patches:
      controlplayback_warning.patch uploaded by atis (license 242)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 19:48:53 +00:00
Leif Madsen db78eeb7c7 Additional fixes to the extensions.conf.sample file.
Update the extensions.conf.sample [stdexten] context so that we use the 
variable instead of requiring it to be passed explicitly. Also updated uses of
the [stdexten] context throughout.

(closes issue #15858)
Reported by: pprindeville
Patches:
      stdexten-context-update.txt uploaded by lmadsen (license 10)
Tested by: pprindeville

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 19:25:18 +00:00
Matthew Nicholson 4b69c3af69 Fixed a spelling error in the q850 reason header option in the output of sip show settings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 18:22:28 +00:00
Richard Mudgett d7f27d8887 Recorded merge of revisions 227275 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r227275 | rmudgett | 2009-11-03 11:55:47 -0600 (Tue, 03 Nov 2009) | 4 lines
  
  Make sure the outgoing flag is cleared if a new channel fails to get created for outgoing calls.
  
  This is the relevant portion of asterisk/trunk -r226648
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 17:58:38 +00:00
Tilghman Lesher b9ee743610 Code guidelines fixes only
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 17:56:41 +00:00
David Vossel 8cd25fc043 user.conf entries in SIP were not having their peer type set.
(closes issue #16120)
Reported by: jsmith


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227238 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 17:12:52 +00:00
Olle Johansson 8021cf48d8 Adding some clarifications to func_speex doxygen docs.
The functions needed doesn't exist in Speex 1.05 which is what a lot of distros use.
1.2 seems to have been in beta status for years, and does include the sexy functions needed for func_speex to work.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 16:56:48 +00:00
Joshua Colp c900eaa733 Merged revisions 227166 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r227166 | file | 2009-11-03 11:36:16 -0400 (Tue, 03 Nov 2009) | 5 lines
  
  Fix a bug where an RPID header could be generated with a blank username in the URI.
  
  (closes issue #15909)
  Reported by: kobaz
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 15:37:08 +00:00
Leif Madsen f6827928b0 Update extensions.conf.sample file to fix incorrect extensions.
(closes issue #15857)
Reported by: pprindeville
Patches:
      stdexten.patch#2 uploaded by pprindeville (license 347)
Tested by: pprindeville

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 15:19:47 +00:00
Olle Johansson ede3699c6e Merged revisions 227088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r227088 | oej | 2009-11-03 11:29:59 +0100 (Tis, 03 Nov 2009) | 7 lines

Use proper response code when violating Contact ACL's.

https://reviewboard.asterisk.org/r/415/

Thanks kpfleming for a quick review.
(EDVX-003)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-03 11:11:15 +00:00
Tilghman Lesher 66579d9d49 Add PacketCable NCS 1.0 support for Docsis/Eurodocsis networks
(closes issue #12950)
 Reported by: alea-soluciones
 Patches: 
       ncs-pktccops-12950-r206803.patch uploaded by alea-soluciones (license 514)
 Tested by: alea-soluciones, adomjan, urtho, nahuelgreco


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 22:29:19 +00:00
David Brooks 2c4d3b3168 SIP channel name uniqueness
SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue #15152)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 20:59:37 +00:00
David Brooks d279260f51 SIP channel name uniqueness
SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue #15152)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226973 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 20:57:45 +00:00
Olle Johansson 8d64231c62 Adding external reference for doxygen
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226970 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 20:43:52 +00:00
Joshua Colp 7a17d87740 Merged revisions 226889 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226889 | file | 2009-11-02 14:08:11 -0400 (Mon, 02 Nov 2009) | 11 lines
  
  Fix a bug where the recorded privacy introduction file would not get removed if the caller hung up
  while the called party had not yet answered.
  
  This was fixed by introducing an argument to the 'n' option which, when enabled, removes the introduction
  file under all scenarios. This was done to preserve the behavior that has existed for quite some time.
  
  (closes issue #14674)
  Reported by: ulogic
  Patches:
        bug14674.patch uploaded by jpeeler (license 325)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226890 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 18:08:54 +00:00
Richard Mudgett 6406f39594 DAHDI ISDN channel names will not allow device state to work. (Interim solution.)
Since ISDN works like SIP and not analog ports in regard to devices, the
device state based on the ISDN channel number could not work.  This has
not been an issue until the advent of PTMP NT mode.  Previously, ISDN
lines were used as trunks and did not have to keep track of specific
devices.

As an interim solution until device states are properly implemented, the
channel name is being changed to the following format to use the generic
device state support:
DAHDI/i<span>/<number>[:<subaddress>]-<sequence-number>

Dialplan hints would thus be:
exten => xxx,hint,DAHDI/i2/5551212

This will work with the following restrictions:
*  The number of devices/phones cannot exceed the number of B channels.
(i.e., BRI has 2)
*  Each device/phone can only have one number.  No shared MSN's.
*  The phones/devices probably should not use subaddressing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 17:34:22 +00:00
Tilghman Lesher 14a8c042cd Merged revisions 226811 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226811 | tilghman | 2009-11-02 11:14:20 -0600 (Mon, 02 Nov 2009) | 8 lines
  
  Don't allow two separate instances of safe_asterisk when restarting from the init script.
  (closes issue #14562)
   Reported by: davidw
   Patches: 
         Initially 20091022__issue14562.diff.txt uploaded by tilghman (license 14)
         Modified to 20091030__Issue14562_diff.txt uploaded by davidw (license 780)
   Tested by: davidw
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 17:15:31 +00:00
David Vossel d107a0e3cf Blocked revisions 226736 via svnmerge
........
  r226736 | dvossel | 2009-11-02 09:31:02 -0600 (Mon, 02 Nov 2009) | 5 lines
  
  fixes crash on iterator_destroy on uninitialized iterator
  
  (closes issue #16162)
  Reported by: krn
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 15:34:37 +00:00
David Vossel 49fc72fc7c Blocked revisions 226688 via svnmerge
........
  r226688 | dvossel | 2009-11-02 09:16:30 -0600 (Mon, 02 Nov 2009) | 5 lines
  
  changes calltoken debug messages from LOG_NOTICE to LOG_DEBUG like they are supposed to be
  
  (closes issue #16144)
  Reported by: aragon
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 15:17:04 +00:00
Matthew Nicholson 93e43578ec This patch adds support for a draft proposal for adding Q.850 reason headers to sip messages.
(closes issue #13385)
Reported by: adomjan
Patches:
      sip.conf.sample-trunk20090929-reason_q850.patch uploaded by adomjan (license 487)
      CHANGES-trunk20090929-reason_q850.patch uploaded by adomjan (license 487)
      chan_sip.c-trunk20090929-reason_q850_atoi_fix.patch uploaded by adomjan (license 487)
      sip-q850-hangupcause1.diff uploaded by mnicholson (license 96)
Tested by: adomjan



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226687 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 14:57:11 +00:00
Richard Mudgett 7fbd314a88 Cleanup some flags on DAHDI PRI channel hangup.
*  Cleanup some flags on DAHDI PRI channel hangup. (sig_pri split)
*  Make sure the outgoing flag is cleared if a new channel fails to get
created for outgoing calls.
*  Remove some unused flags since sig_pri was split.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-30 23:26:41 +00:00
Russell Bryant 844a01b27e Add an "Asterisk Architecture Overview" section to the doxygen documentation.
This is a side project I've been poking at this week.  The intent is to discuss
Asterisk architecture in a top down fashion to help new developers understand how
Asterisk is put together.  There is a ton of stuff to write about, so this will
just continue to evolve over time.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-30 04:08:39 +00:00
Joshua Colp b9c370da86 Merged revisions 226531 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226531 | file | 2009-10-29 15:11:26 -0300 (Thu, 29 Oct 2009) | 6 lines
  
  Add an option to enabling passing music on hold start and stop requests through instead of
  acting on them in chan_local.
  
  (closes issue #14709)
  Reported by: dimas
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-29 18:13:42 +00:00
Olle Johansson 64e8fb465b Doxygen documentation update
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-29 12:20:16 +00:00
Tzafrir Cohen 5bd895b24b remove empty awk pattern (//)
Solaris 10 nawk doesn't lthe empty pattern ike '//' for 'always'.
Just remove that. No pattern at all always matches.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-28 20:50:52 +00:00
Leif Madsen 5524f0ab11 Merged revisions 226382 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226382 | lmadsen | 2009-10-28 15:06:13 -0500 (Wed, 28 Oct 2009) | 9 lines
  
  Update documentation in sip.conf.sample.
  
  Update the documentation in sip.conf.sample in order to make it more clear
  that directmedia/canreinvite do not cause Asterisk to ignore reINVITEs. It
  is only used to stop Asterisk from generating a reINVITE, but does not stop
  it from accepting them if necessary.
  
  (closes issue #15644)
  Reported by: lmadsen
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-28 20:11:07 +00:00
Leif Madsen 6b6fee6c95 Merged revisions 226377 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226377 | lmadsen | 2009-10-28 14:48:29 -0500 (Wed, 28 Oct 2009) | 7 lines
  
  Update CALLINGSUBADDR channel variable documentation.
  
  (closes issue #15734)
  Reported by: alecdavis
  Patches:
        channelvariables.tex.diff.txt uploaded by alecdavis (license 585)
  Tested by: alecdavis
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-28 19:50:00 +00:00
Tilghman Lesher 3afd1409d1 Merged revisions 226304 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r226304 | tilghman | 2009-10-28 13:02:25 -0500 (Wed, 28 Oct 2009) | 2 lines
  
  Fix documentation (pointed out by TheDavidFactor on #-dev)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@226305 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-28 18:04:05 +00:00