Commit graph

18928 commits

Author SHA1 Message Date
Olle Johansson
0cebb5047b Fixing formatting
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216956 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 20:23:19 +00:00
Olle Johansson
fd736b1b8f Add new actions under "new actions" and not in the top of the document
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 20:19:37 +00:00
Olle Johansson
730715337e Moving another function declared in the middle of forward declarations.
Please follow the structure of the source code, thanks. Chan_sip is messy enough as it is :-)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216917 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 18:29:45 +00:00
Olle Johansson
dce193357f Move "deprecated_username" to a flag like the others - unsigned int blah:1
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216912 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 18:26:37 +00:00
Olle Johansson
8e37e119f8 - Doxygen additions
- Remove unused string in sip_registry -- "random"
- Someone added a function in the middle of all forward declarations... Weird. Moved it out of that
  section.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216905 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 18:24:04 +00:00
Olle Johansson
c55469da80 Clean up the "offered_media" code
- Add variable for number of known media streams instead of hardcoding in definition of sip_pvt
- Rename "text" to "codecs" - beacuse it's what it is
- Add documentation for future developers so that we make sure that we define new sdp media types
  for SRTP-variants


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 18:00:48 +00:00
Tilghman Lesher
75d8960740 Allow multiple rows to be fetched within the normal mode of operation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 17:15:37 +00:00
Olle Johansson
42a4b05811 Make sure we reset global_exclude_static at channel reload
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:35:12 +00:00
Olle Johansson
b890815521 Move capability into sip_cfg. While at it, make sure we reset it at channel reload.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216841 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:31:36 +00:00
Olle Johansson
3b8cec9d32 Move global_regcontext into the sip_cfg structure
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:26:04 +00:00
Olle Johansson
320b514b18 Move contact_ha to sip_cfg structure
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216826 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:23:39 +00:00
Olle Johansson
c20324021d Doxygen updates
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:16:58 +00:00
Olle Johansson
11574bcfcf Since it's possible to have more than 999 calls, I'm changing the call counter roof to something higher.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216805 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:08:08 +00:00
Olle Johansson
246e0852a7 add doxygen and remove duplicate declaration of variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 16:00:41 +00:00
Olle Johansson
2e1d7378be After many years, remove VOCAL_DATA_HACK definition
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216803 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 15:48:41 +00:00
Olle Johansson
9c63a09344 Remove unneeded header files (tested on Linux and OS/X)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 15:47:40 +00:00
Olle Johansson
5afc513ae3 Don't send MESSAGE with sendtext() if recepient doesn't allow MESSAGE requests
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216769 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 14:54:14 +00:00
Olle Johansson
008b7a4ab8 Add some doxygen
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 14:21:01 +00:00
Olle Johansson
e242e1b2ad Fix typo
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216735 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 14:04:40 +00:00
Olle Johansson
e1c711b7de If there is no session timer in the INVITE, set it to default value (not unset minimum = -1)
Patch by oej

closes issue #15621
Reported by: fnordian
Tested by: atis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 13:06:19 +00:00
Olle Johansson
8af3a908a9 Update sip.conf.sample documentation, reorganize a bit
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 12:41:08 +00:00
Olle Johansson
109cab6862 Simplify the code in this function
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-07 11:31:19 +00:00
David Vossel
4596fdb788 sip peer matching by address only with TCP/TLS
This patch removes the contact header matching logic and
adds logic to match all tcp/tls connections by ip only.
Thanks to oej for finding the issue and suggesting solutions.

Review: https://reviewboard.asterisk.org/r/354/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 19:32:07 +00:00
Sean Bright
40d83cf748 Use ast_free() instead of free().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 19:29:02 +00:00
Tilghman Lesher
5dfaf5c8b7 Fix trunk breakage.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 17:50:21 +00:00
Tilghman Lesher
ad69df830d Enable turning off the application delimiter warning with the 'dontwarn' option.
Suggested on the -dev list, and implemented in an alternate way by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216547 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 17:31:44 +00:00
Michiel van Baak
7348bacf05 Merged revisions 216435 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r216435 | mvanbaak | 2009-09-04 15:56:10 +0200 (Fri, 04 Sep 2009) | 2 lines
  
  make asterisk compile under devmode with DEBUG_THREADS enabled on OpenBSD
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 15:05:05 +00:00
Olle Johansson
98f18d56b8 Merged revisions 216430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r216430 | oej | 2009-09-04 15:45:48 +0200 (Fre, 04 Sep 2009) | 27 lines

Make apps send PROGRESS control frame for early media and fix too early media issue in SIP

The issue at hand is that some legacy (dying) PBX systems send empty media frames on PRI
links *before* any call progress. The SIP channel receives these frames and by default
signals 183 Session progress and starts sending media. This will cause phones to 
play silence and ignore the later 180 ringing message. A bad user experience.

The fix is twofold:
- We discovered that asterisk apps that support early media ("noanswer") did not send
  any PROGRESS frame to indicate early media. Fixed.
- We introduce a setting in chan_sip so that users can disable any relay of media frames
  before the outbound channel actually indicates any sort of call progress.
  In 1.4, 1.6.0 and 1.6.1, this will be disabled for backward compatibility. In later versions
  of Asterisk, this will be enabled. We don't assume that it will change your Asterisk
  phone experience - only for the better.

We encourage third-party application developers to make sure that if they have applications
that wants to send early media, add a PROGRESS control frame transmission to make sure that
all channel drivers actually will start sending early media. This has not been the default
in Asterisk previous to this patch, so if you got inspiration from our code, you need to
update accordingly. Sorry for the trouble and thanks for your support.

This code has been running for a few months in a large scale installation (over 250
servers with PRI and/or BRI links to old PBX systems). 
That's no proof that this is an excellent patch, but, well, it's tested :-)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 14:02:34 +00:00
Michiel van Baak
43f36d9582 make sure canlog is set so we can compile with DEBUG_THREADS enabled on OpenBSD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 14:00:38 +00:00
Michiel van Baak
d466658968 Recorded merge of revisions 216432 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r216432 | mvanbaak | 2009-09-04 15:53:09 +0200 (Fri, 04 Sep 2009) | 2 lines
  
  make chan_sip compile under devmode again
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 13:54:25 +00:00
Michiel van Baak
77bcf21cd7 Recorded merge of revisions 216369 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r216369 | mvanbaak | 2009-09-04 15:16:29 +0200 (Fri, 04 Sep 2009) | 4 lines
  
  Make sure 'start' is always initialized.
  
  This is the same as rev 216222 in trunk but 1.4 is affected as well
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 13:46:59 +00:00
Russell Bryant
ca23afaf2d Do not treat every SIP peer as if they were configured with insecure=port.
There was a problem in the function responsible for doing peer matching by
IP address and port number such that during the second pass for checking for
a peer configured with insecure=port, it would end up treating every peer as
if it had been configured that way.  These changes fix the logic in the peer
IP and port comparison callback to handle insecure=port checking properly.

This problem was introduced when SIP peers were converted to astobj2.  Many
thanks to dvossel for noticing this while working on another peer matching
issue.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 13:14:25 +00:00
Olle Johansson
773e22596a Adding to the janitor list.
For new readers: The janitor list is a list of tasks we need help with in the Asterisk project. Taking up 
one of these is often a good way to get into Asterisk development and getting a lot of developers in 
the project to be grateful. It's stuff we could spend time on when the bug tracker is empty, when our
employers hasn't filled our task lists and our servers is running bugfree and happily without any issues.

If you want to start working on one of these small projects, feel free to ask for help in the #asterisk-dev
channel on IRC or asterisk-dev mailing list. We'll be more than happy to help you to start and reach
goal.

Thank you for your help.

</end of long commit message>


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 12:05:46 +00:00
Russell Bryant
3bad695fed Merged revisions 216263 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r216263 | russell | 2009-09-04 05:48:00 -0500 (Fri, 04 Sep 2009) | 9 lines
  
  Merged revisions 216262 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.2
  
  ........
    r216262 | russell | 2009-09-04 05:47:37 -0500 (Fri, 04 Sep 2009) | 2 lines
    
    Add a plain text version of the IAX2 security document.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 10:48:44 +00:00
Michiel van Baak
6f32731568 make sure 'start' is always initialized.
Makes asterisk compile with --enable-dev-mode


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 06:08:33 +00:00
Richard Mudgett
c2930434f6 Lets try not to use C++ keywords for variable names.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 21:09:46 +00:00
Doug Bailey
8430c87faa Added detection DTMF CID without polarity change alert.
Added detection of DTMF tone energy levels on FXO channels in chan_dahdi
monitoring loop so DTMF CID can be detected without the need of a polarity
change precursor.  

(closes issue #9096)
Reported by: fleed
Patches:
      9096-chan_dahdi-trunk.diff uploaded by dbailey (license 819)
Tested by: cyberplant, sum, maturs


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 19:40:37 +00:00
Russell Bryant
148552de24 Merged revisions 216085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r216085 | russell | 2009-09-03 14:36:46 -0500 (Thu, 03 Sep 2009) | 9 lines
  
  Merged revisions 216080 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.2
  
  ........
    r216080 | russell | 2009-09-03 14:35:23 -0500 (Thu, 03 Sep 2009) | 2 lines
    
    Add a note about IAX2 to UPGRADE.txt.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216092 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 19:38:35 +00:00
Russell Bryant
5fdc6292a3 Merged revisions 216008 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r216008 | russell | 2009-09-03 13:44:58 -0500 (Thu, 03 Sep 2009) | 9 lines
  
  Merged revisions 216005 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.2
  
  ........
    r216005 | russell | 2009-09-03 13:42:24 -0500 (Thu, 03 Sep 2009) | 2 lines
    
    Add IAX2 security document related to AST-2009-006.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 18:45:54 +00:00
Kevin P. Fleming
7f745ecd73 Document language prompt submission process.
This patch adds a document describing the language prompt submission process,
licensing terms and other issues related to that process. In addition, it
modifies the sound file searching process to support language codes with
any number of suffices (not limited to just "xx" or "xx_YY"), so that prompts
can be named with gender, customer/company, etc. suffices as well.

(closes issue #15771)
Reported by: jtodd
Patches:
      language-criteria.txt uploaded by jtodd



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 18:42:38 +00:00
David Vossel
43be8f9f07 Blocked revisions 216000 via svnmerge
........
  r216000 | dvossel | 2009-09-03 13:32:32 -0500 (Thu, 03 Sep 2009) | 7 lines
  
  Merge code associated with AST-2009-006
  
  (closes issue #12912)
  Reported by: rathaus
  Tested by: tilghman, russell, dvossel, dbrooks
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@216001 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 18:33:52 +00:00
David Vossel
d09f9fd00a Merge code associated with AST-2009-006
(closes issue #12912)
Reported by: rathaus
Tested by: tilghman, russell, dvossel, dbrooks


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 16:31:54 +00:00
Olle Johansson
6d6ce303cb Add known internal IP address when autodomain=yes
(closes issue #14573)
Reported by: pj
Patches: 
      sip-internip-autodomain1.diff uploaded by mnicholson (license 96)
	modified by oej
Tested by: pj



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 13:02:41 +00:00
Michiel van Baak
b3e97dc95c Document that SIPshowpeer and SKINNYshowline now include
the configured parkinglot in their response.

Prodded by snuff-work on #asterisk-dev IRC channel


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215838 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 05:57:23 +00:00
Tilghman Lesher
a6ba2b64b1 Default the callback extension to "s". This is a regression.
(closes issue #15764)
 Reported by: elguero
 Change-type: bugfix


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 03:43:51 +00:00
Tilghman Lesher
80973cb97f Revert attempt to standardize with _POSIX_C_SOURCE.
This did not function in the way that was intended, causing more compatibility
issues than it solved.  It is best, therefore, that it be simply removed.
(Discussed with kpfleming; agreement to remove was reached.)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 03:30:42 +00:00
Terry Wilson
f9816a6265 Merged revisions 215682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r215682 | twilson | 2009-09-02 16:41:22 -0500 (Wed, 02 Sep 2009) | 18 lines
  
  Re-send non-100 provisional responses to prevent cancellation
  
  From section 13.3.1.1 of RFC 3261:
  
     If the UAS desires an extended period of time to answer the INVITE,
     it will need to ask for an "extension" in order to prevent proxies
     from canceling the transaction. A proxy has the option of canceling
     a transaction when there is a gap of 3 minutes between responses in a
     transaction. To prevent cancellation, the UAS MUST send a non-100
     provisional response at every minute, to handle the possibility of
     lost provisional responses.
  
  (closes issue #11157)
  Reported by: rjain
  Tested by: twilson
  
  Review: https://reviewboard.asterisk.org/r/315/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 23:31:04 +00:00
Richard Mudgett
595ab444af Made chan_dahdi able to ignore incoming calls that are not in a MSN list for ISDN PTMP CPE spans.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 23:25:33 +00:00
David Vossel
a83cf36204 port string to int conversion using sscanf
There are several instances where a port is parsed
from a uri or some other source and converted to
an int value using atoi(), if for some reason the
port string is empty, then a standard port is used.
This logic is used over and over, so I created a function
to handle it in a safer way using sscanf().



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215681 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 21:39:31 +00:00
Michiel van Baak
0a67bc6610 add Parkinglot info to sip show peer <foo> and skinny show line <foo>
If we had this from the start, debugging the 'parking not using configured parkinglot'
bug would have been easier.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@215665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 21:23:17 +00:00