Commit Graph

19959 Commits

Author SHA1 Message Date
Tilghman Lesher 523e4e50bf Release list lock before returning on error.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-08 06:57:24 +00:00
Tilghman Lesher 8872926df7 Fix trunk build on Mac OS X.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268896 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-08 06:16:43 +00:00
Terry Wilson 857814f435 Add SRTP support for Asterisk
After 5 years in mantis and over a year on reviewboard, SRTP support is finally
being comitted. This includes generic CHANNEL dialplan functions that work for
getting the status of whether a call has secure media or signaling as defined
by the underlying channel technology and for setting whether or not a new
channel being bridged to a calling channel should have secure signaling or
media. See doc/tex/secure-calls.tex for examples.

Original patch by mikma, updated for trunk and revised by me.

(closes issue #5413)
Reported by: mikma
Tested by: twilson, notthematrix, hemanshurpatel

Review: https://reviewboard.asterisk.org/r/191/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268894 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-08 05:29:08 +00:00
Richard Mudgett ebbf166c2d Make SIP tests compile again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-08 00:45:13 +00:00
Tilghman Lesher bfdb973191 Use the mailbox destructor function, instead.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 22:56:53 +00:00
Tilghman Lesher 8b790e4f06 Mailbox list would previously grow at each reload, containing duplicates.
Also, optimize the allocation of mailboxes to avoid additional memory structures.

(closes issue #16320)
 Reported by: Marquis
 Patches: 
       20100525__issue16320.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 22:47:13 +00:00
Richard Mudgett 0122ccd29c Extract sig_ss7 out of chan_dahdi.
Extract the SS7 specific code out of chan_dahdi like what was done to
ISDN/PRI and analog signaling.  The new SS7 structures were modeled on
sig_pri.

The changes to sig_pri are an enhancement and a bug fix made possible
because SS7 was extracted.

1) The sig_pri TRANSFERCAPABILITY channel variable should have been set
unconditionally in sig_pri_new_ast_channel().

2) SS7/PRI transfer capability interaction in dahdi_new() fixed because of
SS7 extraction.

3) Module ref count error in dahdi_new() if startpbx failed to start the
PBX for some reason.

Review:	https://reviewboard.asterisk.org/r/661/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 20:04:42 +00:00
Tilghman Lesher 17bd11b8aa Seems strange (and the code backs up) that if the max and min of a statistic is expressed as a double, the last value would not also need to be a double.
(closes issue #15807)
 Reported by: klaus3000


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 19:52:39 +00:00
Richard Mudgett 0c5bce53ad Moved AOC request code out of the middle of code parsing the dialed number.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268734 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 19:06:55 +00:00
Tilghman Lesher de625d9c08 Event well was going dry.
(issue #17234)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 18:59:27 +00:00
Paul Belanger 1bc478656e Set threshold for silence detection defaults to 256
(closes issue #15685)
Reported by: david_s5
Patches:
      dsp-silence-threshold-init.diff uploaded by dant (license 670)
      issue15685.patch.v5 uploaded by pabelanger (license 224)
Tested by: danti

Review: https://reviewboard.asterisk.org/r/670/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 17:34:45 +00:00
Tilghman Lesher 6279bf10c4 Avoid unloading res_smdi twice.
(closes issue #17237)
Reported by: pabelanger


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 17:14:40 +00:00
Richard Mudgett a8b0a415fc Suppress warning in waitstream_core().
Suppress the warning about unexpected control subclass frames for
AST_CONTROL_CONNECTED_LINE, AST_CONTROL_REDIRECTING, and AST_CONTROL_AOC
in file.c:waitstream_core().


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-07 15:51:39 +00:00
Tilghman Lesher ef8940efca Take advantage of variable substitution already in the Makefile to specify the correct location for files in init.d.
(closes issue #16979)
 Reported by: jw-asterisk
 
(issue #15691)
 Reported by: itamarjp


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268534 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-06 05:29:50 +00:00
Tilghman Lesher 7d18dd5394 Finally track down and eliminate the "FRACK! warnings from chan_iax2".
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-06 00:37:30 +00:00
Tilghman Lesher 47ad8c27f5 Fix crash in DTMF detection.
What I did not originally see in my previous commit was that even though the
next digit could be detected before the previous was considered ended, the
detection of the next digit effectively ends the detection of the previous.
Therefore, the length moves in lockstep with the digit, and no separate counter
is needed for the length alone.

(closes issue #17371)
 Reported by: alecdavis

(closes issue #17474)
 Reported by: kenner


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-05 17:55:28 +00:00
Tilghman Lesher 0807833f8d Verify event is not NULL before attempting to lower its usecount.
(closes issue #17234)
 Reported by: mav3rick


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-05 17:27:12 +00:00
Kevin P. Fleming ade79c6671 Typo fix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-05 05:23:02 +00:00
Kevin P. Fleming e853c0d978 Grammatical error fix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268395 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-05 05:12:34 +00:00
Tilghman Lesher 63643fea18 Merged revisions 268320 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r268320 | tilghman | 2010-06-04 21:49:52 -0500 (Fri, 04 Jun 2010) | 3 lines
  
  Rest In Peace
  http://www.outandaboutnewspaper.com/article/4061
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-05 02:51:34 +00:00
David Vossel e32d9a1303 fixes compile error from uninitialized variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 22:37:13 +00:00
David Vossel 19d1cd04ba RFC3261 compliant sip unreliable retransmit timing + 'registerattempts' option tweak
Changes.
1. RFC 3261 states in section 17.1.2.2 and 17.1.1.2 that retransmission
timers should initially be set to timer T1.   T1 by default is 500ms.
Asterisk was starting the retransmission timers at T1*2 which shouldn't
cause any problems, but is not RFC compliant.

2. RFC 3261 states in section 17.1.2.2 that for a non-INVITE client transaction,
if the retransmit timer fires while in the proceeding state that
the request must be retransmitted.  Asterisk currently ack's
requests for both INVITE and non-INVITE transactions when a
1XX response is received, this patch changes this for non-INVITE requests.

3. The 'registerattempts' option in sip.conf is supposed to set
how many registry attempts will be made before giving up.  When
this option is set to 1, I would expect only one registry attempt
to be made before stopping because of a failure, but instead two are
made.  In my opinion this is not expected behavior.  This option does
not indicate that these are re-attempts.  The logic behind this option
has been changed to only attempt registers the exact number of times
this option is set to.  If this option is 0, it still continues to
re-attempt the registration forever.

Review: https://reviewboard.asterisk.org/r/687/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268205 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 21:55:14 +00:00
Tilghman Lesher 1ea8c8c1d5 Merged revisions 268126 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r268126 | tilghman | 2010-06-04 15:41:24 -0500 (Fri, 04 Jun 2010) | 2 lines
  
  AC_CONFIG_SUBDIRS has a bad side-effect on cross-compiles.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 20:42:27 +00:00
Tilghman Lesher a0baefec79 Merged revisions 268050 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r268050 | tilghman | 2010-06-04 14:38:57 -0500 (Fri, 04 Jun 2010) | 6 lines
  
  Build menuselect with the build environment's compiler, not the host (target)'s compiler.
  
  (closes issue #17464)
   Reported by: pprindeville
   Tested by: tilghman
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 19:40:00 +00:00
Tilghman Lesher 24b7455979 Merged revisions 267971 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r267971 | tilghman | 2010-06-04 11:27:02 -0500 (Fri, 04 Jun 2010) | 2 lines
  
  As-fixiate the build process
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 16:31:25 +00:00
Richard Mudgett 10e2c47c75 Incoming overlap dialing no longer works after sig_pri extraction.
The problem would manifest itself if your dialplan matching could accept
more digits to match than were actually dialed.  The time out waiting for
overlap digits disconnected the call instead of matching any accumulated
digits to the dialplan.

Accidental conversion of a break out of loop as a break out of switch.

(closes issue #17401)
Reported by: avalentin
Patches:
      issue17401_digit_timeout.patch uploaded by rmudgett (license 664)
Tested by: avalentin, rmudgett


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 14:45:03 +00:00
Tilghman Lesher 8b3cf71896 As signed linear audio data is accessed as 16-bit values, certain processors require the values to be aligned in memory.
(closes issue #16912)
 Reported by: michaelevdokimov
 Patches: 
       asterisk.patch uploaded by michaelevdokimov (license 997)
 Tested by: michaelevdokimov


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 03:20:47 +00:00
Terry Wilson f06302755a Send an ACK for every final response received for an INVITE
From issue ABE-2247. RFC 3261 compliance for sections 13.2.24 and 17.1.1.2.

Review: https://reviewboard.asterisk.org/r/692/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 03:11:31 +00:00
Tilghman Lesher 58fc11c15d As signed linear audio data is accessed as 16-bit values, certain processors require the values to be aligned in memory.
(closes issue #16912)
 Reported by: michaelevdokimov


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 02:58:55 +00:00
Tilghman Lesher 4beb87bc29 If there's a default, turn it on, even when the option isn't specified.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 01:36:46 +00:00
Tilghman Lesher 3c3d054ef2 Merged revisions 267759 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r267759 | tilghman | 2010-06-03 20:16:26 -0500 (Thu, 03 Jun 2010) | 7 lines
  
  Make the default install path appear to be /usr on Linux, instead of /usr/local.
  
  Also, reorganize the options, so that they're more alphabetical.
  
  (closes issue #17013)
   Reported by: klaus3000
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-04 01:20:17 +00:00
Russell Bryant 4e77fc3c58 Remove a LOG_WARNING.
This came up when using the sample configs, and just indicates expected behavior.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 20:41:24 +00:00
Tilghman Lesher da0138932e Handle OOM errors more gracefully.
(closes issue #17084)
 Reported by: falves11
 Patches: 
       issue17084_162_A.diff uploaded by falves11 (license 374)
 Tested by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 19:46:42 +00:00
Leif Madsen dfa82e0852 Update UPGRADE.txt and CHANGE for CDR functionality changes.
Updated the UPGRADE.txt and CHANGES file stating that CDR records will not be explicity
written unless cdr.conf exists and is configured.

(closes issue #17373)
Reported by: wdoekes
Tested by: pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 18:53:24 +00:00
Richard Mudgett 6ab2173c97 Make compile again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 18:38:00 +00:00
Russell Bryant 64e2c86426 Don't stop Asterisk if chan_usbradio isn't configured.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 17:31:41 +00:00
Mark Michelson a68f5b96bc Remove unnecessary code relating to PLC.
The logic for handling generic PLC is now handled in ast_write in
channel.c instead of in translation code.

Review: https://reviewboard.asterisk.org/r/683/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 17:09:11 +00:00
Russell Bryant d1aacea4e3 Remove a line that was killing Asterisk on startup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 17:05:30 +00:00
Russell Bryant 63d10a1b1c Comment out a rule that likes to run implicitly unnecessarily, breaking builds
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 14:48:09 +00:00
Richard Mudgett 1c67f208a7 Add ETSI Message Waiting Indication (MWI) support.
Add the ability to report waiting messages to ISDN endpoints (phones).

Relevant specification: EN 300 650 and EN 300 745

Review:	https://reviewboard.asterisk.org/r/599/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267399 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 00:02:14 +00:00
Russell Bryant bb4c55c347 try to fix some random chan_h323 compilation failures
After some debugging, the random chan_h323 build failures appear to be due
to complications introduced by some chan_h323 specific build stuff getting
triggered during a clean.  Simplify this by moving the h323 clean commands
down into channels/makefile.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267352 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 22:46:37 +00:00
Richard Mudgett 0760f4e70a Add ETSI Malicious Call ID support.
Add the ability to report malicious callers as an AMI event in the call
event class.

Relevant specification: EN 300 180

Review:	https://reviewboard.asterisk.org/r/576/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 22:28:58 +00:00
Russell Bryant 84e150f1bb Fix a build error on mac.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267305 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 21:44:06 +00:00
Russell Bryant 6aa4002270 Ensure the -Wno-strict-aliasing flag makes it, even if ASTCFLAGS has been specified.
When ASTCFLAGS was specified with the make command, Makefile.rules was using
the specified value from the command line and not the one here, making it so this
flag would go missing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 21:41:54 +00:00
Richard Mudgett afcbc93dae Add ETSI Call Waiting support.
Add the ability to announce a call to an endpoint when there are no B
channels available.  A call waiting call is a SETUP message with no B
channel selected.

Relevant specification: EN 300 056, EN 300 057, EN 300 058

For DAHDI/ISDN channels, the CHANNEL() dialplan function now supports the
"no_media_path" option.
* Returns "0" if there is a B channel associated with the call.
* Returns "1" if no B channel is associated with the call.  The call is
either on hold or is a call waiting call.

If you are going to allow incoming call waiting calls then you need to use
CHANNEL(no_media_path) do determine if you must drop a call to accept the
new call.

Review:	https://reviewboard.asterisk.org/r/568/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 21:05:32 +00:00
David Vossel 3280a5c0af Update CHANGES and aoc help doc to reflect AOC additions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 19:33:56 +00:00
Russell Bryant 98ef8df1ab Add a CLI command that blocks until Asterisk has fully booted.
Review: https://reviewboard.asterisk.org/r/684/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267138 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 18:53:38 +00:00
Mark Michelson b8d39db94d Prevent use of uninitialized values.
Two struct sockaddr_ins are created when applying directmedia
host access rules. The addresses of these are passed to the RTP
engine to be filled in. However, the RTP engine inspects the fields
of the structs before actually taking action. This inspection caused
valgrind to be a bit unhappy.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267097 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 18:13:18 +00:00
Richard Mudgett afd4454c44 Generic Advice of Charge.
Asterisk Generic AOC Representation
- Generic AOC encode/decode routines.
  (Generic AOC must be encoded to be passed on the wire in the AST_CONTROL_AOC frame)
- AST_CONTROL_AOC frame type to represent generic encoded AOC data
- Manager events for AOC-S, AOC-D, and AOC-E messages

Asterisk App Support
- app_dial AOC-S pass-through support on call setup
- app_queue AOC-S pass-through support on call setup

AOC Unit Tests
- AOC Unit Tests for encode/decode routines
- AOC Unit Test for manager event representation.

SIP AOC Support
- Pass-through of generic AOC-D and AOC-E messages to snom phones via the
  snom AOC specification.
- Creation of chan_sip page3 flags for the addition of the new
  'snom_aoc_enabled' sip.conf option.

IAX AOC Support
- Natively supports AOC pass-through through the use of the new
  AST_CONTROL_AOC frame type

DAHDI AOC Support
- ETSI PRI full AOC Pass-through support
- 'aoc_enable' chan_dahdi.conf option for independently enabling
  pass-through of AOC-S, AOC-D, AOC-E.
- 'aoce_delayhangup' option for retrieving AOC-E on disconnect.
- DAHDI A() dial string option for requesting AOC services.
  example usage:
  ;requests AOC-S, AOC-D, and AOC-E on call setup
  exten=>1111,1,Dial(DAHDI/g1/1112/A(s,d,e))

Review:	https://reviewboard.asterisk.org/r/552/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267096 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 18:10:15 +00:00
Russell Bryant 266db9fa8c Silence a compiler warning.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 17:57:39 +00:00