Commit graph

16168 commits

Author SHA1 Message Date
Sean Bright
54d9ba7671 Bring in the configure and makeopts jazz for -Wshadow, but don't add it to the
Makefile yet.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 18:19:33 +00:00
Dwayne M. Hubbard
c096a6bee0 use ARRAY_LEN
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 15:58:38 +00:00
Mark Michelson
4e2406fda4 Fix compilation for ODBC voicemail
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 15:31:31 +00:00
Tilghman Lesher
7330024a14 Removing bad properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136751 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 02:34:17 +00:00
Steve Murphy
a40f1cc1c5 Merged revisions 136726 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r136726 | murf | 2008-08-07 18:15:34 -0600 (Thu, 07 Aug 2008) | 32 lines


(closes issue #13236)
Reported by: korihor

Wow, this one was a challenge!

I regrouped and ran a new strategy for
setting the ~~MACRO~~ value; I set it once
per extension, up near the top. It is only
set if there is a switch in the extension.

So, I had to put in a chunk of code to detect
a switch in the pval tree.

I moved the code to insert the set of ~~exten~~
up to the beginning of the gen_prios routine, 
instead of down in the switch code.

I learned that I have to push the detection
of the switches down into the code, so everywhere
I create a new exten in gen_prios, I make sure
to pass onto it the values of the mother_exten
first, and the exten next.

I had to add a couple fields to the exten
struct to accomplish this, in the ael_structs.h
file. The checked field makes it so we don't
repeat the switch search if it's been done.

I also updated the regressions.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-08 00:48:35 +00:00
Mark Michelson
64a06c0298 Remove one last batch of debug messages
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 23:39:50 +00:00
Mark Michelson
3917a7d65d Fix build for non-IMAP storage and get rid of some
debug messages.
Thanks to eliel for alerting me.
No thanks to buildbot.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 23:38:08 +00:00
Mark Michelson
5e27c1be24 Merging the imap_consistency_trunk branch to
trunk.

For an explanation of what "imap_consistency" is,
please see svn revision 134223 to the 1.4 branch.

Coincidentally, this also fixes a recent bug report
regarding the inability to save messages to the new
folder when using IMAP storage since they will would
be flagged as "seen" and not be recognized as new
messages.


(closes issue #13234)
Reported by: jaroth




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136715 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 22:25:50 +00:00
Michiel van Baak
78a93bc386 show correct called party id and also store this to the 'placed calls' list once the call is connected.
(closes issue #13180)
Reported by: pj
Patches:
      2008080700_skinny_calledpartyid.diff uploaded by mvanbaak (license 7)
Tested by: mvanbaak, pj


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 21:19:39 +00:00
Shaun Ruffell
f9ba4bf070 Updating codec_dahdi to the new transcoder interface.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 20:54:52 +00:00
Mark Michelson
e12e97a640 Bump a LOG_NOTICE message to LOG_DEBUG since it appears
once for every bridged call



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136660 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 20:25:43 +00:00
Mark Michelson
316fb598d2 Don't allow Answer() to accept a negative argument.
Negative argument means an infinite delay and we
don't want that.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 19:58:32 +00:00
Mark Michelson
9b5b8246c5 Fix a calculation error I had made in the poll. The poll
would reset to 500 ms every time a non-voice frame
was received. The total time we poll should be 500 ms, so
now we save the amount of time left after the poll returned
and use that as our argument for the next call to poll



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136633 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 19:54:27 +00:00
Mark Michelson
ed4e6bf52b Scrap the 500 ms delay when Asterisk auto-answers a channel.
Instead, poll the channel until receiving a voice frame. The
cap on this poll is 500 ms.

The optional delay is still allowable in the Answer() application,
but the delay has been moved back to its original position, after
the call to the channel's answer callback. The poll for the voice
frame will not happen if a delay is specified when calling Answer().

(closes issue #12708)
Reported by: kactus



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 19:36:46 +00:00
Richard Mudgett
b92df4dc1e Merged revisions 136241 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r136241 | rmudgett | 2008-08-06 16:18:53 -0500 (Wed, 06 Aug 2008) | 5 lines

*  The allowed_bearers setting in misdn.conf misspelled one
of its options: digital_restricted.
*  Fixed some other spelling errors and typos.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 19:01:03 +00:00
Kevin P. Fleming
68e670554f Blocked revisions 136560 via svnmerge
........
r136560 | kpfleming | 2008-08-07 13:25:31 -0500 (Thu, 07 Aug 2008) | 3 lines

change the required dependency for codec_dahdi to only be satisfied by DAHDI and not Zaptel, as the new transcoder interface is only in DAHDI


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 18:25:52 +00:00
Kevin P. Fleming
a67af1e018 Merged revisions 136541 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 17:44:20 +00:00
Kevin P. Fleming
ec4952cf73 stop using deprecated API call
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136504 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 17:26:23 +00:00
Tilghman Lesher
285609937a Merged revisions 136488 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r136488 | tilghman | 2008-08-07 11:50:47 -0500 (Thu, 07 Aug 2008) | 7 lines

Update persistent state on all exit conditions.
(closes issue #12916)
 Reported by: sgenyuk
 Patches: 
       app_queue.patch.txt uploaded by neutrino88 (license 297)
 Tested by: sgenyuk, aragon

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136489 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 16:55:57 +00:00
Kevin P. Fleming
a17df07e4b Blocked revisions 136458 via svnmerge
........
r136458 | kpfleming | 2008-08-07 11:11:17 -0500 (Thu, 07 Aug 2008) | 3 lines

work around a bug in gcc-4.2.3 that incorrectly ignores the casting away of 'const' for pointers when the developer knows it is safe to do so


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 16:30:23 +00:00
Kevin P. Fleming
992440aceb fix some format strings to actually compile without errors
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 16:29:08 +00:00
Sean Bright
6305009cfc More merges from resolve-shadow warnings:
utils/
  codecs/
  and a change I missed from formats/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136408 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 15:16:48 +00:00
Tilghman Lesher
8397209316 Fix runtime symbol error
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 15:10:53 +00:00
Kevin P. Fleming
60b578d631 Blocked revisions 136404 via svnmerge
........
r136404 | kpfleming | 2008-08-07 10:07:12 -0500 (Thu, 07 Aug 2008) | 2 lines

remove config.cache during distclean, in case the user is using autoconf caching

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 15:07:39 +00:00
Sean Bright
4fb07fb0c1 Merge in a few more changes. This time the include/ directory.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 14:36:59 +00:00
Tilghman Lesher
4d0a4e7bfa Blocked revisions 136348 via svnmerge
........
r136348 | tilghman | 2008-08-06 20:31:27 -0500 (Wed, 06 Aug 2008) | 3 lines

Also, parse useincomingcalleridonzaptransfer (and add appropriate deprecation
warnings).

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 01:32:10 +00:00
Tilghman Lesher
728c28baf0 Blocked revisions 136304 via svnmerge
........
r136304 | tilghman | 2008-08-06 20:17:14 -0500 (Wed, 06 Aug 2008) | 3 lines

For backwards compatibility with previous 1.4 versions which used "zapchan"
in users.conf, ensure that we still support it.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136305 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 01:18:03 +00:00
Sean Bright
16f8480882 Continue merging in changes from resolve-shadow-warnings. funcs/ this time.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 01:07:40 +00:00
Sean Bright
778b3d88a7 More from the resolve-shadow-warnings branch. This time the cdr/ directory.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136300 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 00:52:23 +00:00
Sean Bright
b7a4db0ced Start moving in changes from my resolve-shadow-warnings branch. Going to do
this in pieces so the diffs are a little bit smaller and more reviewable.

pbx/ and formats/ first.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-07 00:44:55 +00:00
Dwayne M. Hubbard
367dfcb0ab move taskprocessor CLI commands into the core namespace
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 21:22:56 +00:00
Mark Michelson
53f7d97a1a Blocked revisions 136238 via svnmerge
........
r136238 | mmichelson | 2008-08-06 15:42:15 -0500 (Wed, 06 Aug 2008) | 4 lines

We only need to unregister the QueueStatus manager
command once on an unload


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 20:43:58 +00:00
Tilghman Lesher
ebe9c21be4 Merged revisions 136190 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r136190 | tilghman | 2008-08-06 15:14:54 -0500 (Wed, 06 Aug 2008) | 4 lines

-C option takes a filename, not a directory path.
(closes issue #13007)
 Reported by: klaus3000

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 20:15:34 +00:00
Tilghman Lesher
0f601e6ffa Janitor ast_str project
(closes issue #13058)
 Reported by: pputman
 Patches: 
       app_meetme_aststr2.patch uploaded by pputman (license 81)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136141 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 17:33:48 +00:00
Tilghman Lesher
24c39b30f1 Persist DIALGROUP() values in astdb
(closes issue #13138)
 Reported by: Corydon76
 Patches: 
       20080725__bug13138.diff.txt uploaded by Corydon76 (license 14)
 Tested by: pj


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 16:58:42 +00:00
Mark Michelson
b3970abc30 Merged revisions 136062 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r136062 | mmichelson | 2008-08-06 10:58:40 -0500 (Wed, 06 Aug 2008) | 16 lines

Since adding the AST_CONTROL_SRCUPDATE frame type,
there are places where ast_rtp_new_source may be called
where the tech_pvt of a channel may not yet have an
rtp structure allocated. This caused a crash in chan_skinny,
which was fixed earlier, but now the same crash has been 
reported against chan_h323 as well. It seems that the best 
solution is to modify ast_rtp_new_source to not attempt to 
set the marker bit if the rtp structure passed in is NULL.

This change to ast_rtp_new_source also allows the removal
of what is now a redundant pointer check from chan_skinny.

(closes issue #13247)
Reported by: pj


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 15:59:29 +00:00
Tilghman Lesher
475ee479e8 Use a dynamic buffer for rendered SQL, instead of hardcoding 2048 bytes. Also,
switch to using RWLISTs for the linked list of queries.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136034 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 14:51:51 +00:00
Olle Johansson
a4436cb2ff - Formatting
- Changing debug messages from VERBOSE to DEBUG channel
- Adding a few todo's
- Adding a few more "XMPP"'s to compliment Jabber...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136005 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 13:34:08 +00:00
Tilghman Lesher
700d4501b8 Merged revisions 135949 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135949 | tilghman | 2008-08-05 22:53:36 -0500 (Tue, 05 Aug 2008) | 4 lines

Fix a longstanding bug in channel walking logic, and fix the explanation to
make sense.
(Closes issue #13124)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 03:55:49 +00:00
Tilghman Lesher
b2a42c3353 Merged revisions 135915 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135915 | tilghman | 2008-08-05 22:24:56 -0500 (Tue, 05 Aug 2008) | 4 lines

Since powerof() can return an error condition, it's foolhardy not to detect and
deal with that condition.
(Related to issue #13240)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135938 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 03:29:42 +00:00
Tilghman Lesher
29228a3afc Merged revisions 135899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135899 | tilghman | 2008-08-05 22:02:59 -0500 (Tue, 05 Aug 2008) | 4 lines

1) Bugfix for debugging code
2) Reduce compiler warnings for another section of debugging code
(Closes issue #13237)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 03:04:01 +00:00
Mark Michelson
89c2844242 Merged revisions 135841,135847,135850 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135841 | mmichelson | 2008-08-05 19:25:10 -0500 (Tue, 05 Aug 2008) | 27 lines

Merging the issue11259 branch.

The purpose of this branch was to take into account
"burps" which could cause jitterbuffers to misbehave.
One such example is if the L option to Dial() were used
to inject audio into a bridged conversation at regular
intervals. Since the audio here was not passed through
the jitterbuffer, it would cause a gap in the jitterbuffer's
timestamps which would cause a frames to be dropped for a 
brief period.

Now ast_generic_bridge will empty and reset the jitterbuffer
each time it is called. This causes injected audio to be handled
properly.

ast_generic_bridge also will empty and reset the jitterbuffer
if it receives an AST_CONTROL_SRCUPDATE frame since the change
in audio source could negatively affect the jitterbuffer.

All of this was made possible by adding a new public API call
to the abstract_jb called ast_jb_empty_and_reset.

(closes issue #11259)
Reported by: plack
Tested by: putnopvut


........
r135847 | mmichelson | 2008-08-05 19:27:54 -0500 (Tue, 05 Aug 2008) | 4 lines

Revert inadvertent changes to app_skel that occurred when
I was testing for a memory leak


........
r135850 | mmichelson | 2008-08-05 19:29:54 -0500 (Tue, 05 Aug 2008) | 3 lines

Remove properties that should not be here


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-06 00:30:53 +00:00
Steve Murphy
5eaf8450d6 Merged revisions 135799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135799 | murf | 2008-08-05 17:13:20 -0600 (Tue, 05 Aug 2008) | 34 lines

(closes issue #12982)
Reported by: bcnit
Tested by: murf

I discovered that also, in the previous bug fixes and changes,
the cdr.conf 'unanswered' option is not being obeyed, so
I fixed this.

And, yes, there are two 'answer' times involved in this
scenario, and I would agree with you, that the first 
answer time is the time that should appear in the CDR.
(the second 'answer' time is the time that the bridge
was begun).

I made the necessary adjustments, recording the first
answer time into the peer cdr, and then using that to
override the bridge cdr's value.

To get the 'unanswered' CDRs to appear, I purposely
output them, using the dial cmd to mark them as
DIALED (with a new flag), and outputting them if
they bear that flag, and you are in the right mode.

I also corrected one small mention of the Zap device
to equally consider the dahdi device.

I heavily tested 10-sec-wait macros in dial, and
without the macro call; I tested hangups while the
macro was running vs. letting the macro complete
and the bridge form. Looks OK. Removed all the
instrumentation and debug.



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 23:45:32 +00:00
Tilghman Lesher
de582e1eb2 Merged revisions 135747 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135747 | tilghman | 2008-08-05 16:34:46 -0500 (Tue, 05 Aug 2008) | 9 lines

In a conversion to use ast_strlen_zero, the meaning of the flag IAX_HASCALLERID
was perverted.  This change reverts IAX2 to the original meaning, which was,
that the callerid set on the client should be overridden on the server, even if
that means the resulting callerid is blank.  In other words, if you set
"callerid=" in the IAX config, then the callerid should be overridden to blank,
even if set on the client.  Note that there's a distinction, even on realtime,
between the field not existing (NULL in databases) and the field existing, but
set to blank (override callerid to blank).

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 21:37:35 +00:00
Tilghman Lesher
ff101d0b07 Add '+=' append operator to configuration files.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 18:25:16 +00:00
Kevin P. Fleming
f24d7a89f5 datastore inheritance is a channel feature, so move this definition back
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135681 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 17:05:34 +00:00
Kevin P. Fleming
7df8b8b848 make datastore creation and destruction a generic API since it is not really channel related, and add the ability to add/find/remove datastores to manager sessions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 16:56:11 +00:00
Tilghman Lesher
8ba981911a Always output a version string, even when we can't figure out what we are.
(Closes issue #13223)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 15:30:23 +00:00
Sean Bright
3fdc96d0b4 Merged revisions 135597 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135597 | seanbright | 2008-08-05 09:25:00 -0400 (Tue, 05 Aug 2008) | 1 line

Use PATH_MAX for filenames
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 13:26:34 +00:00
Russell Bryant
194d90bafd Merged revisions 135536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r135536 | russell | 2008-08-04 15:15:03 -0500 (Mon, 04 Aug 2008) | 2 lines

fix a config sample typo

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-04 20:15:27 +00:00