Commit Graph

11907 Commits

Author SHA1 Message Date
Russell Bryant 6857957000 Merged revisions 67119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67119 | russell | 2007-06-04 17:28:55 -0500 (Mon, 04 Jun 2007) | 6 lines

Add comments for two functions that get called with the appropriate call locked,
but perform operations that could result in the pvt structure getting destroyed
before returning again, causing numerous seg faults all over the module.
(inspired by issues #9642, #9569, and #9666, and the work done by stevedavies
 and mihai)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:29:43 +00:00
Steve Murphy ef132e25e1 Merged revisions 67073 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67073 | murf | 2007-06-04 15:59:34 -0600 (Mon, 04 Jun 2007) | 1 line

This typo has been here since 1.4 forked. It has been the source of heartburn to many a dialplan/CDR programmer.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:15:38 +00:00
Russell Bryant b5089b4a58 Merged revisions 67071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67071 | russell | 2007-06-04 16:47:36 -0500 (Mon, 04 Jun 2007) | 2 lines

Add a missing \n.  (pointed out by jcmoore on IRC)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 21:48:15 +00:00
Russell Bryant c7fec92508 Remove a leftover unlock and lock of the iax2 pvt struct lock that was left
over from my attempt at putting pvt structs in a hash table.  It can cause
seg faults, and has no reason to stay.
(issue #9642, pointed out by stevedavies)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 21:45:24 +00:00
Joshua Colp e3492b9511 Merged revisions 67068 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67068 | file | 2007-06-04 15:31:09 -0400 (Mon, 04 Jun 2007) | 2 lines

Better handle SIP devices that say they have SDP content... but really don't. (issue #9398 reported by mthomasslo)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 19:32:08 +00:00
Joshua Colp bae04fd90e Merged revisions 67066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67066 | file | 2007-06-04 13:59:14 -0400 (Mon, 04 Jun 2007) | 2 lines

Initialize cidname variable to nothing since it may be used without having been touched. (issue #9661 reported by dimas)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67067 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 18:00:24 +00:00
Joshua Colp 6e6d4be830 Merged revisions 67064 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67064 | file | 2007-06-04 13:41:59 -0400 (Mon, 04 Jun 2007) | 2 lines

Returning a value that indicates the parking of a call was a success when it really wasn't (because the parking slot selected was in use) is the wrong thing to do. (issue #9723 reported by mdu113)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:43:21 +00:00
Joshua Colp d84f78ac04 Minor clean up. Constify a few variables and use ast_strlen_zero in a few places.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:32:41 +00:00
Tilghman Lesher 2f25292c60 Merged revisions 67061 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r67061 | tilghman | 2007-06-04 12:11:43 -0500 (Mon, 04 Jun 2007) | 10 lines

Merged revisions 67060 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67060 | tilghman | 2007-06-04 12:10:30 -0500 (Mon, 04 Jun 2007) | 2 lines

Add revision Id tags (by request of tzafrir)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67062 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:12:35 +00:00
Russell Bryant becbe90833 Merged revisions 67026 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67026 | russell | 2007-06-04 11:02:31 -0500 (Mon, 04 Jun 2007) | 6 lines

Change the configure script to build a test program against libcurl to make
sure the results from curl-config can be used to compile successfully.  This is
intended to help prevent a situation where you are cross compiling, and the
configure script finds the curl library installed on the host.
(issue #9865, reported and patched by zandbelt)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67029 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 16:03:19 +00:00
Russell Bryant e1375b96c2 Change javadoc style code documentation to the same format we use elsewhere.
(issue #9864, patch from snuffy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:56:13 +00:00
Tilghman Lesher 4538cec96a Merged revisions 67021 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67021 | tilghman | 2007-06-04 10:50:16 -0500 (Mon, 04 Jun 2007) | 2 lines

Issue 9739 - Malformed jid causes a crash

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:53:15 +00:00
Russell Bryant d6f2b914e8 Merged revisions 67020 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r67020 | russell | 2007-06-04 10:47:40 -0500 (Mon, 04 Jun 2007) | 7 lines

Resolve a deadlock in chan_iax2.  When handling an implicit ACK to a frame that
was marked as the final transmission for a call, don't call iax2_destroy() for
that call while the global frame queue is still locked.  There is a very nice
explanation of the deadlock in the report.
(issue #9663, thorough report and patch from stevedavies, additional positive
 test reports from mihai and joff_oconnell)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:50:46 +00:00
Russell Bryant b1fcf2ef13 Blocked revisions 67018 via svnmerge
........
r67018 | russell | 2007-06-04 10:28:33 -0500 (Mon, 04 Jun 2007) | 3 lines

Fix some compiler warnings in C++ modules.
(issue #9866, reported by osk, patch by Corydon76)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:29:00 +00:00
Russell Bryant e4cd3c1cc2 Fix some compiler warnings in C++ modules.
(issue #9866, reported by osk, patch by Corydon76)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67017 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:26:43 +00:00
Russell Bryant 93f2be2675 Fix a couple of places where "tos" was used instead of "cos".
(issue #9540, patch by IgorG)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@67016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:14:52 +00:00
Joshua Colp 13a3661906 Add support for autocompleting start/stop options of the mixmonitor CLI command. (issue #9862 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 11:48:01 +00:00
Tilghman Lesher ce9ec91897 ast_calloc janitor (Inspired by issue 9860)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66981 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-03 06:10:27 +00:00
Russell Bryant b1490716f6 remove a bogus comment that came from copy/paste
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 23:39:18 +00:00
Russell Bryant 605368649e Merge major changes to the way device state is passed around Asterisk. The two
places that cared about device states were app_queue and the hint code in pbx.c.
The changes include converting it to use the Asterisk event system, as well as
other efficiency improvements.
 * app_queue: This module used to register a callback into devicestate.c to
   monitor device state changes.  Now, it is just a subscriber to Asterisk
   events with the type, device state.
 * pbx.c hints: Previously, the device state processing thread in devicestate.c
   would call ast_hint_state_changed() each time the state of a device changed.
   Then, that code would go looking for all the hints that monitor that device,
   and call their callbacks.  All of this blocked the device state processing
   thread.  Now, the hint code is a subscriber of Asterisk events with the
   type, device state.  Furthermore, when this code receives a device state
   change event, it queues it up to be processed by another thread so that it
   doesn't block one of the event processing threads.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 23:34:43 +00:00
Russell Bryant c9cf12b675 Remove 80 bytes in the iax2_registry struct that weren't being used
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 23:02:57 +00:00
Tilghman Lesher 7216b96319 Merged revisions 66919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66919 | tilghman | 2007-06-01 16:45:44 -0500 (Fri, 01 Jun 2007) | 2 lines

On some drivers, deallocating the statement handle isn't enough.  We also have to clear the cursor (nice, Oracle)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 21:49:34 +00:00
Mark Michelson 91d49560ac Merged revisions 66916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66918 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 21:33:24 +00:00
Mark Michelson 7173f3378f Merged revisions 66897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66897 | mmichelson | 2007-06-01 16:09:30 -0500 (Fri, 01 Jun 2007) | 3 lines

Submitting a fix for voicemail with IMAP storage. Attachments with format specified as gsm were duplicated (i.e. two attachments) were left.
Thank you very much to xmarksthespot for submitting the patch that fixed this. (Issues 9787 and 8873, Reported by xmarksthespot and jerjer, patched by xmarksthespot)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 21:16:39 +00:00
Russell Bryant 0f409e66cf Merged revisions 66881 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66881 | russell | 2007-06-01 14:41:30 -0500 (Fri, 01 Jun 2007) | 6 lines

Changes to the way DTMF is handled in the core broke dialing in chan_skinny.
This patch makes chan_skinny usable again.  I did not end up testing this,
but there are multiple positive test reports listed in the bug report.
(issue #9596, reported by pj, testing by pj and mvanbaak, and the fix was
 written by DEA)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 19:42:27 +00:00
Russell Bryant 5af2d0720e Merged revisions 66879 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66879 | russell | 2007-06-01 14:35:13 -0500 (Fri, 01 Jun 2007) | 2 lines

List app_meetme as a module that app_page depends on.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 19:35:41 +00:00
Jason Parker 545de7746c Documentation fixes for res_config_sqlite.
Issue 9854, patch by tzafrir.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 18:36:25 +00:00
Russell Bryant 0b6c6b2e89 Add some more information about the SIP Disclaimer header.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 13:48:29 +00:00
Tilghman Lesher 825315f272 Merged revisions 66821 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66821 | tilghman | 2007-05-31 18:03:28 -0500 (Thu, 31 May 2007) | 2 lines

Issue 9850 - update preferred command line syntax

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66822 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 23:04:32 +00:00
Russell Bryant 3ce231fe95 fix a typo.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 21:23:55 +00:00
Russell Bryant 3d2b58751f To satisfy some legal concerns, add an option for chan_sip to include a
disclaimer along with SIP messages in the header, X-Disclaimer.  This is off by
default.  Also, the text of the disclaimer can be customized in sip.conf.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 19:41:03 +00:00
Russell Bryant ce4051a803 Merged revisions 66775 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66775 | russell | 2007-05-31 13:41:58 -0500 (Thu, 31 May 2007) | 3 lines

Change a couple of header files to not use "new", which is a reserved keyword
in C++.  (issue #9830, reported by osk)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66776 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 18:43:59 +00:00
Russell Bryant 8d0124aba3 Add support for configuring named groups of custom call features in
features.conf.  This allows you to create a feature one time, and then map it
into groups for various different key mappings for the same feature, as well
as easy access control to groups of features.
(patch from bbryant)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 18:21:47 +00:00
Russell Bryant cc35dc8999 Revert changes that snuck in with revision 66724.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 18:09:50 +00:00
Russell Bryant 7562efed2d - Don't check if the list is empty needlessly
- Don't free structures before calling load_config(), because load_config()
  already does it
- Use the existing functions for freeing the minivm structures instead of
  replicating the code
(issue #9846, patch from eliel)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 17:56:27 +00:00
Tilghman Lesher e8c1a35607 Merged revisions 66770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r66770 | tilghman | 2007-05-31 12:15:09 -0500 (Thu, 31 May 2007) | 10 lines

Merged revisions 66744 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66744 | tilghman | 2007-05-31 10:58:45 -0500 (Thu, 31 May 2007) | 2 lines

Issue 9818 - Fix for issue 8329 breaks pbx_realtime.  Issue 8329 will remain unfixed for pbx_realtime, but only because we lack core API to do it.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66771 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 17:16:38 +00:00
Joshua Colp 9f79587d47 Merged revisions 66768 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r66768 | file | 2007-05-31 12:14:48 -0400 (Thu, 31 May 2007) | 10 lines

Merged revisions 66764 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66764 | file | 2007-05-31 12:12:39 -0400 (Thu, 31 May 2007) | 2 lines

It is now possible for this path of execution to have the frame pointer be NULL, therefore we need to check for it before trying to access it. (issue #9836 reported by barthpbx)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66769 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 16:18:14 +00:00
Tilghman Lesher e9251f42df Issue 9799 - Multirow results for func_odbc
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66734 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 15:05:56 +00:00
Russell Bryant 8ea9dcc221 Fix a crash on reload by using calloc() instead of malloc() to ensure that
data is properly initialized.
(issue #9765, reported by MatsK, patch from eliel)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 14:52:30 +00:00
Olle Johansson 0b2db74e5a Issue #9842 - Doxygen updates by snuffy. Thanks!
(Committed from Media Plaza in Utrecht, Netherlands - Open Source VoIP conference)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 10:26:55 +00:00
Mark Michelson 684f320397 Merged revisions 66671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66671 | mmichelson | 2007-05-30 18:26:39 -0500 (Wed, 30 May 2007) | 2 lines

Fixed seg-faults when recording greetings in voicemail with IMAP enabled. (Issue No. 9734, reported by xmarksthespot, patched by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 23:44:42 +00:00
Joshua Colp 880a1dade7 Blocked revisions 66637 via svnmerge
........
r66637 | file | 2007-05-30 13:21:06 -0400 (Wed, 30 May 2007) | 2 lines

When calling some peer/host that may not exist/reply back... don't keep the dialog in memory for all of eternity.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66638 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 17:23:15 +00:00
Joshua Colp c103a8d298 This concludes my tweaking of things.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 16:11:57 +00:00
Joshua Colp 9db7124ee0 Blocked revisions 66602 via svnmerge
........
r66602 | file | 2007-05-30 12:06:37 -0400 (Wed, 30 May 2007) | 2 lines

Change how channel names are generated a bit. (issue #9825 reported by eldadran)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66603 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 16:10:11 +00:00
Tilghman Lesher 1236ed3214 Issue 9477 - Improve menuselect labels
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66585 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 05:17:09 +00:00
Tilghman Lesher 2baca1b2c5 Merged revisions 66538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r66538 | tilghman | 2007-05-29 16:56:07 -0500 (Tue, 29 May 2007) | 10 lines

Merged revisions 66537 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66537 | tilghman | 2007-05-29 16:49:35 -0500 (Tue, 29 May 2007) | 2 lines

If the value of a variable passed to FIELDQTY is blank, then FIELDQTY should return 0, not 1.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 21:59:21 +00:00
Tilghman Lesher 1e9c6c4a70 Shorten description to a much more reasonable length
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 21:57:50 +00:00
Olle Johansson 4c1068c136 oops. Thanks Terry.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66505 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:53:40 +00:00
Olle Johansson ee3a0af16a Merged revisions 66503 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66503 | oej | 2007-05-29 21:32:57 +0200 (Tue, 29 May 2007) | 2 lines

Properly handle 408 request timeout - according to the RFC, the dialog dies if a request in a dialog gets this response.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66504 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:35:43 +00:00
Olle Johansson 6d6c525b10 Merged revisions 66474 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r66474 | oej | 2007-05-29 21:02:04 +0200 (Tue, 29 May 2007) | 2 lines

Don't issue hangup on hangup on hangup on hangup (for jcmoore)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@66502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:17:49 +00:00