Commit Graph

15214 Commits

Author SHA1 Message Date
Russell Bryant a3f3613d66 Correct action_ping() and action_events() with regards to Manager 1.1
documentation.  Also, fix a bug in xml_translate().

(closes issue #11649)
Reported by: ys
Patches:
      trunk_manager.c.diff uploaded by ys (license 281)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-22 15:46:01 +00:00
Russell Bryant f5a5845a29 Blocked revisions 114522 via svnmerge
........
r114522 | russell | 2008-04-22 10:20:37 -0500 (Tue, 22 Apr 2008) | 13 lines

Merge changes from team/russell/issue_9520

These changes make sure that the reference count for sip_peer objects properly
reflects the fact that the peer is sitting in the scheduler for a scheduled
callback for qualifying peers or for expiring registrations.  Without this, it
was possible for these callbacks to happen at the same time that the peer was
being destroyed.  This was especially likely to happen with realtime peers, and
for people making use of the realtime prune CLI command.

(closes issue #9520)
Reported by: kryptolus
Committed patch by me

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-22 15:20:53 +00:00
Steve Murphy 161b4abd79 Hopefully, this will resolve the issues that russellb had with this log_show_lock().
I gathered the code that filled the string, and put it in a different func which
I cryptically call "append_lock_information()".
Now, both log_show_lock(), and handle_show_locks() both call this code to do
the work. Tested, seems to work fine. 
Also, log_show_lock was modified to use the ast_str stuff, along with checking
for successful ast_str creation, and freeing the ast_str obj when finished.
A break was inserted to terminate the search for the lock; we should never
see it twice.

An example usage in chan_sip.c was created as a comment, for instructional
purposes.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-22 14:38:46 +00:00
Jeff Peeler 41fd7a6a21 (closes issue #6113)
Reported by: oej
Tested by: jpeeler

This patch implements multiple parking lots for parked calls. The default parkinglot is used by default, however setting the channel variable PARKINGLOT in the dialplan will allow use of any other configured parkinglot. See configs/features.conf.sample for more details on setting up another non-default parkinglot. Also, one can (currently) set the default parkinglot to use in the driver configuration file via the parkinglot option.

Patch initially written by oej, brought up to date and finalized by mvanbaak, and then stabilized and converted to astobj2 by me.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 23:42:45 +00:00
Doug Bailey f773e294f1 Change the time zone offset from a hard code to use res_phoneprov variables
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 22:50:33 +00:00
Steve Murphy c0b8f57b9d (closes issue #12467)
Reported by: atis
Tested by: murf

This upgrade adds the ~~ (concatenation) string operator to expr2.
While not needed in normal runtime pbx operation, it is needed when
raw exprs are being syntax checked. This plays into future syntax-
unification plans. By permission of atis, this addition in trunk 
and the reason of why things are as they are will suffice to close
this bug.

I also added a short note about the previous addition of "sip show sched"
to the CLI in CHANGES, which I discovered I forgot in a previous commit.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 21:13:02 +00:00
Matthew Fredrickson b43364eac8 Add support for generic name transmission (#12484) on SS7 in chan_zap
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 18:44:35 +00:00
Jeff Peeler b7a25e15d1 This removes an invalid warning message for an incorrectly entered pin, but more importantly removes an inapplicable check. If the first argument passed to app_authenticate does not contain a '/', the argument should be treated as the sole fixed "password" to match against and that is all. (Previous behavior was attempting to open a file based on the pin.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 15:34:37 +00:00
Russell Bryant e29b987b30 Add a simple janitor project
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114325 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 15:01:04 +00:00
Joshua Colp a79214b5b1 Merged revisions 114322 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114322 | file | 2008-04-21 11:39:32 -0300 (Mon, 21 Apr 2008) | 4 lines

Only drop audio if we receive it without a progress indication. We allow other frames through such as DTMF because they may be needed to complete the call.
(closes issue #12440)
Reported by: aragon

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114323 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 14:40:33 +00:00
Joshua Colp 6d5290a85b Only print out the error message if ldap_modify_ext_s actually returns an error, and not success.
(closes issue #12438)
Reported by: gservat
Patches:
      res_config_ldap.c-patch-code uploaded by gservat (license 466)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-21 14:34:06 +00:00
Sean Bright 87973ccea2 Minor logging cleanups
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-20 14:52:07 +00:00
Matthew Fredrickson 264cc6ff5a SS7:Added - Generic Name / Access Transport / Redirecting Number handling. #12425
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-19 16:58:24 +00:00
Tilghman Lesher 6652a46f21 Blocked revisions 114299 via svnmerge
........
r114299 | tilghman | 2008-04-19 08:57:17 -0500 (Sat, 19 Apr 2008) | 2 lines

Ensure that help text terminates with a newline

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114300 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-19 13:58:56 +00:00
Tilghman Lesher 8248b37609 Blocked revisions 114297 via svnmerge
........
r114297 | tilghman | 2008-04-19 08:49:50 -0500 (Sat, 19 Apr 2008) | 4 lines

MOH usage information needs a terminating newline, or else
"asterisk -rx 'help moh reload'" will hang.  Reported via
-dev list, fixed by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-19 13:53:38 +00:00
Sean Bright c6ed3f56d0 Ignore refcounter
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-19 00:15:31 +00:00
Russell Bryant 0bb3c15606 Merged revisions 114284 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114284 | russell | 2008-04-18 16:48:06 -0500 (Fri, 18 Apr 2008) | 2 lines

Don't destroy a manager session if poll() returns an error of EAGAIN.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 21:51:05 +00:00
Russell Bryant d02badd561 Merged revisions 114278 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114278 | russell | 2008-04-18 15:01:09 -0500 (Fri, 18 Apr 2008) | 2 lines

ensure directories are created before we try to install stuff into them

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 20:01:47 +00:00
Russell Bryant 03f05c1300 Merged revisions 114275 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114275 | russell | 2008-04-18 14:58:55 -0500 (Fri, 18 Apr 2008) | 2 lines

SUBDIRS_INSTALL is already listed as a subtarget for bininstall

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 19:59:17 +00:00
Joshua Colp b05e17fdd7 Make sure ADSI is marked as unavailable on Unistim channels so voicemail does not try to do some ADSI jazz.
(closes issue #12460)
Reported by: PerryB


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 19:35:33 +00:00
Joshua Colp e52ae01831 Add MEETME_INFO dialplan function that allows querying various properties of a Meetme conference.
(closes issue #11691)
Reported by: junky
Patches:
      meetme_info.patch uploaded by jpeeler (license 325)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 18:15:11 +00:00
Mark Michelson 0e821d7201 Merged revisions 114257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114257 | mmichelson | 2008-04-18 12:44:29 -0500 (Fri, 18 Apr 2008) | 6 lines

Clearing up error messages so they make a bit more sense. Also removing a redundant error
message.

Issue AST-15


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114259 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 18:03:06 +00:00
Joshua Colp 116859bd19 If the parsing of the config file fails make sure we unlock ldap_lock.
(closes issue #12477)
Reported by: IgorG


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 16:11:27 +00:00
Doug Bailey 30aa3d7059 Add g__object_unref to clean up gmime message object
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 16:05:29 +00:00
Russell Bryant 21ff8b6a8c Blocked revisions 114248 via svnmerge
........
r114248 | russell | 2008-04-18 10:24:09 -0500 (Fri, 18 Apr 2008) | 5 lines

Ensure that we don't ast_strdupa(NULL)
(closes issue #12476)
Reported by: davidw
Patch by me

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 15:25:50 +00:00
Sean Bright e4dce85331 Merged revisions 114245 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114245 | seanbright | 2008-04-18 09:33:32 -0400 (Fri, 18 Apr 2008) | 1 line

Only complete the SIP channel name once for 'sip show channel <channel>'
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 13:38:07 +00:00
Tilghman Lesher 2f33780bfa Merged revisions 114242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114242 | tilghman | 2008-04-18 01:49:16 -0500 (Fri, 18 Apr 2008) | 3 lines

For consistency sake, ensure that the values that ${CALLINGPRES} returns are valid as an
input to SetCallingPres.  (Closes issue #12472)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-18 06:53:47 +00:00
Russell Bryant 19f7e8cc93 Merged revisions 114230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114230 | russell | 2008-04-17 17:15:43 -0500 (Thu, 17 Apr 2008) | 6 lines

Remove redundant safety net.  The check for the autoservice channel list state
accomplishes the same goal in a better way.

(issue #12470)
Reported By: atis

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 22:24:00 +00:00
Russell Bryant 0270b3d6c9 Make this file compile. The variable str is never set anywhere. Furthermore,
it duplicates a lot of code.  I will leave it to murf to clean up.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 22:21:32 +00:00
Jeff Peeler 4d3e086a3e added info describing DNS manager
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114229 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 21:09:37 +00:00
Mark Michelson 9facdcb64f Merged revisions 114226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114226 | mmichelson | 2008-04-17 16:03:29 -0500 (Thu, 17 Apr 2008) | 9 lines

Declaration of the peer channel in this scope was making it so the peer variable defined
in the outer scope was never set properly, therefore making iterating through the channel
list always restart from the beginning. This bug would have affected anyone who called
chanspy without specifying a first argument.

(closes issue #12461)
Reported by: stever28


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 21:04:40 +00:00
Mark Michelson 67e0ee39ae Blocked revisions 114211 via svnmerge
........
r114211 | mmichelson | 2008-04-17 11:50:46 -0500 (Thu, 17 Apr 2008) | 4 lines

Add prototype for ast_dsp_frame_freed. I'm not sure how this was
compiling before...


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 16:51:09 +00:00
Mark Michelson ae52cd4a76 Merged revisions 114207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114207 | mmichelson | 2008-04-17 11:28:03 -0500 (Thu, 17 Apr 2008) | 12 lines

It was possible for a reference to a frame which was part of a freed DSP to still be
referenced, leading to memory corruption and eventual crashes. This code change ensures
that the dsp is freed when we are finished with the frame. This change is very similar
to a change Russell made with translators back a month or so ago.

(closes issue #11999)
Reported by: destiny6628
Patches:
      11999.patch uploaded by putnopvut (license 60)
Tested by: destiny6628, victoryure


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 16:40:12 +00:00
Russell Bryant 83c674bf96 Merged revisions 114204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114204 | russell | 2008-04-17 11:23:45 -0500 (Thu, 17 Apr 2008) | 3 lines

Fix the bininstall target to install from subdirs, as well.
(closes issue AST-8, patch from bmd at switchvox)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114205 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 16:25:29 +00:00
Tilghman Lesher 631d8e5fbe fileio.h does not exist; io.h does, though.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114202 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 15:12:52 +00:00
Steve Murphy 5203c664de Thanks to snuff for finding these omissions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 14:45:16 +00:00
Philippe Sultan 60a9d14d56 Merged revisions 114198 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114198 | phsultan | 2008-04-17 15:42:23 +0200 (Thu, 17 Apr 2008) | 2 lines

Use keepalives effectively in order diagnose bug #12432.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 13:46:17 +00:00
Tilghman Lesher 9809a31bb5 Merged revisions 114195 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114195 | tilghman | 2008-04-17 07:56:38 -0500 (Thu, 17 Apr 2008) | 8 lines

Add special case for when the agi cannot be executed, to comply with the documentation that
we return failure in that case.
(closes issue #12462)
 Reported by: fmueller
 Patches: 
       20080416__bug12462.diff.txt uploaded by Corydon76 (license 14)
 Tested by: fmueller

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 12:59:04 +00:00
Sean Bright 3b775e41ae Update the CHANGES file with yesterday's ChanSpy change. Sorry Kevin, just saw your e-mail.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 12:25:23 +00:00
Sean Bright 45ebcb77a2 Merged revisions 114191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114191 | seanbright | 2008-04-17 06:51:20 -0400 (Thu, 17 Apr 2008) | 1 line

Make sure we have enough room for the recording's filename.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-17 10:55:05 +00:00
Steve Murphy 5fb4b1bbe5 This is the scariest commit I've done in a long time. This is the astobj2-ification of chan_sip. I've tested a number of scenarios like crazy. It used to have 4x the call setup/teardown performance of trunk, but now it's roughly at parity. I will attempt to find the bottlenecks and get it back to the 4x mark. The changes made were somewhat invasive, but the value to the community of these upgrades outweighs waiting further for more testing. Every change being made to chan_sip was lousing this code up when we tried to merge. Peers, Users, Dialogs, are all now astobj2 objects, indexed via hashtables. Refcounting is used to track objects and free them at the bitter end of their lives. Please file issues on bugs.digium.com, and PLEASE, please, please be patient. One natural advantage to all the hash-table work is that loading large sip.conf files full of thousands of peers now goes much faster. One more please: PLEASE help thrash this code and test it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 23:53:27 +00:00
Tilghman Lesher 123ac5fd64 Standardized routines for forking processes (keeps all the specialized code in one place).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114188 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 22:57:54 +00:00
Steve Murphy 752f6681b1 A small enhancement-- I added the routine log_show_lock to utils.c, which if the mentioned lock has been acquired, this routine will log to the console the normal info about that lock you'd see from the CLI when you do a 'core show locks'. It's solely for debug-- if the lock is NOT acquired, there is no output. I use it to show 'unexpected' locks, to see where/why a lock is pre-locked. This command is to be called from points of interest, like just before a trylock, and helps to spot fleeting, highly temporal locks that normally are not locked...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114187 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 20:54:41 +00:00
Kevin P. Fleming a51fb142f9 Merged revisions 114184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114184 | kpfleming | 2008-04-16 15:46:38 -0500 (Wed, 16 Apr 2008) | 6 lines

use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10)

(closes issue #12456)
Reported by: fnordian


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 20:47:30 +00:00
Steve Murphy 8b6d8da58c Introducing a small optimization to event_unsubscribe; events now use a Doubly-Linked list for events, gives fast deletions, for the sake of channel driver mwi events. From team/murf/bug11210.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 20:28:08 +00:00
Steve Murphy 2b69ec9a38 Introducing a small upgrade to the ast_sched_xxx facility, to keep it from eating up lots of cpu cycles. See CHANGES. From the team/murf/bug11210 branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 20:09:39 +00:00
Tilghman Lesher e5ea744e1d Blocked revisions 114180 via svnmerge
........
r114180 | tilghman | 2008-04-16 14:59:37 -0500 (Wed, 16 Apr 2008) | 3 lines

Backport revisions for latest vpb drivers to 1.4
(Closes issue #12457)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 20:00:27 +00:00
Steve Murphy 6138b16995 Introducing various astobj2 enhancements, chief being a refcount tracing feature, and various documentation updates in astobj2.h, and the addition of standalone utility, refcounter, that will filter the trace output for unbalanced, unfreed objects. This comes from the team/murf/bug11210 branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 17:45:28 +00:00
Jason Parker e93d417a19 Blocked revisions 114173 via svnmerge
........
r114173 | qwell | 2008-04-16 12:30:09 -0500 (Wed, 16 Apr 2008) | 7 lines

Fix "fallthrough" behavior here, so config options in a previously configured user don't override settings in general.

(closes issue #12458)
Reported by: tzafrir
Patches:
      chanzap_users_sections.diff uploaded by tzafrir (license 46)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114174 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 17:31:02 +00:00
Steve Murphy 27891e6b4b Introducing doubly linked lists to trunk from branch team/murf/bug11210.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114172 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-16 17:14:18 +00:00