Commit graph

19502 commits

Author SHA1 Message Date
David Vossel
ba1a8d3ff0 fixes signed to unsigned int comparision issue for FaxMaxDatagram value.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-03 00:18:28 +00:00
David Vossel
7b51d1d71d fixes assumption that test failed if it did not pass when generating results
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-03 00:04:28 +00:00
David Vossel
8429882ad8 base64 unit test
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250235 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 23:38:29 +00:00
Matthew Nicholson
49aaeb1df2 Merge missed files from res_fax/res_fax_spandsp merge.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 23:22:11 +00:00
Matthew Nicholson
06dc8bc123 Merge res_fax and res_fax_spandsp.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 23:11:06 +00:00
David Vossel
b5c98d640a adds 'p' option to PickupChan
The 'p' option allows the PickupChan app to pickup
a ringing phone by looking for the first match to a
partial channel name rather than requiring a full match.

(closes issue #16613)
Reported by: syspert
Patches:
      pickipbycallid.patch uploaded by syspert (license 938)
      pickupbycallerid_v2.patch uploaded by dvossel (license 671)
Tested by: dvossel, syspert




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250141 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 21:58:03 +00:00
Leif Madsen
491ea82b6d Update IMAP documentation.
Update the IMAP documentation to make it clear that storing voicemails
in the same folder as a large number of emails could potentially cause
significant slow downs when writing or retrieving voicemails.

(issue #16704)
Reported by: TimeHider
Tested by: lmadsen, TimeHider

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 21:09:27 +00:00
Leif Madsen
b838b15702 Merged revisions 250043 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250043 | lmadsen | 2010-03-02 15:51:35 -0500 (Tue, 02 Mar 2010) | 7 lines
  
  Update documentation to clarify purpose of unanswered option.
  
  (closes issue #16267)
  Reported by: elsto
  Patches: 
        cdr.conf.sample.patch.txt uploaded by lmadsen (license 10)
  Tested by: davidw, elsto
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 20:52:19 +00:00
Leif Madsen
7ce1e145fb Recorded merge of revisions 250041 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250041 | lmadsen | 2010-03-02 15:45:37 -0500 (Tue, 02 Mar 2010) | 4 lines
  
  Update documentation to not imply we support overriding options.
  
  (issue #16855)
  Reported by: davidw
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 20:46:52 +00:00
Leif Madsen
aec5c6f840 Update documentation to not imply we support overriding options.
(closes issue #16855)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 20:36:10 +00:00
Leif Madsen
ecfa2dcb2e Fix literal values wrapped in documentation.
(closes issue #16145)
Reported by: tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:49:48 +00:00
Alec L Davis
2866c664b8 revert ability to exit echo app
caused a regression, as only supported VOICE, not VIDEO etc.

(issue #16880)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:39:58 +00:00
Leif Madsen
78fdaa6865 Add missing description of the PARKINGLOT variable in XML documentation.
(closes issue #16743)
Reported by: snuffy
Patches: 
      parkingdoc.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:24:43 +00:00
Leif Madsen
b310356d93 Convert some DUNDI functions to XML documentation.
(closes issue #16798)
Reported by: snuffy
Patches: 
      xml_dundi.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249912 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:21:19 +00:00
David Vossel
862ebf4d00 fixes adaptive jitterbuffer configuration
When configuring the adaptive jitterbuffer, the target_extra
value not only could not be set from the configuration, but was
not even being set to its proper default.  This value is required
in order for the adaptive jitterbuffer to work correctly.  To resolve
this a config option has been added to expose this value to the conf
files, and a default value is provided when no config specific value
is present.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249893 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:08:38 +00:00
Leif Madsen
06041ea28d Fix several XML documentation validate errors.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:02:56 +00:00
Jeff Peeler
717599a61f fix build by checking result of symlink in test_voicemail_vmsayname
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 18:31:05 +00:00
Jeff Peeler
bb3792a8a7 Add new application VMSayName for use with voicemail.
VMSayName that will play the recorded name of the voicemail user if it exists, 
otherwise will play the mailbox number. A unit test has been written to verify
correct functionality called test_voicemail_vmsayname.

(closes issue #14973)
Reported by: ghjm

Review: https://reviewboard.asterisk.org/r/530/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 18:22:05 +00:00
Alec L Davis
9257e8573b fixes ability to exit echo app
when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches: 
      echo_exit.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 07:38:56 +00:00
Alec L Davis
5dbe86a3c2 fix asterisk setting of pritimers from chan_dahdi.conf
regression since sig_pri split.

(issue #16909)
Reported by: alecdavis
Patches: 
      pritimer.asterisk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249759 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 06:56:14 +00:00
Sean Bright
b4b7d16f6f Merged revisions 249671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines
  
  Fix crash in app_voicemail related to message counting.
  
  We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
  causing a segfault.
  
  (closes issue #16921)
  Reported by: whardier
  Patches:
        20100301_issue16921.patch uploaded by seanbright (license 71)
  Tested by: whardier
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:36:30 +00:00
Michiel van Baak
3f1d9e881e Cleanup display_*message functions.
This patch splits transmit_displaymessage into transmit_clear_display_message and transmit_display_message which better aligns with the skinny protocol. The new transmit_display_message is not used in the current code, but will be and so it is commented.

Moved handle_datetime from this function to onhook and offhook functions (display now properly cleared at the end of a call on 30VIP).

Removed skinny debug messages from inline code as there's an ast_verb in transmit_clear_display_message. Also, removed commentary that it was a clear display as it is now apparent from the function name.

Split transmit_displaypromptmessage into display and clear.

(closes issue #16878)
Reported by: wedhorn
Patches: 
	skinny-clean02.diff uploaded by wedhorn (license 30)
	skinny-clean03.diff uploaded by wedhorn (license 30)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249670 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:33:26 +00:00
Michiel van Baak
7a54ee9159 fix endianes issues in chan_skinny
(closes issue #16826)
Reported by: PipoCanaja
Patches: 
      chan_skinny.c_bigendianPatch_20100218.diff uploaded by PipoCanaja (license 994)
Tested by: wedhorn



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:27:34 +00:00
Tilghman Lesher
dac8ccd89e Constify a bit of app_voicemail, to make ODBC and IMAP compile once again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 18:36:06 +00:00
Jeff Peeler
acd243ca65 Merged revisions 249536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249536 | jpeeler | 2010-03-01 11:02:03 -0600 (Mon, 01 Mar 2010) | 11 lines
  
  Modify queued frames from local channels to not set the other side to up
  
  In this case, attended transfers were broken due to ast_feature_request_and_dial
  detecting the channel being set to up before the answer frame could be read and
  therefore failing to mark the channel as ready. This fix is a regression fix for
  244785, which should continue to work properly as well.
  
  (closes issue #16816)
  Reported by: jamhed
  Tested by: jamhed, corruptor
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249538 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 17:11:31 +00:00
Tilghman Lesher
3b94cadaf9 Fix unit test that Alec Davis broke.
(closes issue #16927)
 Reported by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 20:50:01 +00:00
Alec L Davis
40ee6ed4f0 make unit test check for NULL folder, which then defaults to INBOX
previous test, gave false level of assurance that code was healthy.

(issue #16927)
Reported by: alecdavis
Patches: 
      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 16:36:45 +00:00
Tilghman Lesher
a6fd85250d Properly document voicemail API documents. Also fix a crash reported via the -dev list.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 07:10:22 +00:00
Alec L Davis
98154867e6 overlap receiving: automatically send CALL PROCEEDING when dialplan starts
Following Q.931 5.2.4
When the user has determined that sufficient call information has been received the 
user shall stop T302 and send CALL PROCEEDING to the network.

Previously timeouts were possible if the dialplan took a long time to issue any
response back to the network.

Verified that our local TELCO also does the same.

(issue #16789)
Reported by: alecdavis
Patches: 
      overlap_receiving_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-27 22:49:51 +00:00
Kevin P. Fleming
7e2145b9ac Merged revisions 249234 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249234 | kpfleming | 2010-02-27 09:07:59 -0500 (Sat, 27 Feb 2010) | 1 line
  
  add a reference to the now-published IAX2 RFC
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249235 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-27 14:08:35 +00:00
Tilghman Lesher
e20c28078e Cleanups to fix bugs in the VM count API functions.
- Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
- Urgent voicemails were sometimes counted twice when displaying the count of new messages.
- Backends were inconsistent as to which voicemails each API counted.
- Unit tests added to verify behavior in the future.

(closes issue #15654)
 Reported by: tomo1657
 Patches: 
       20100225__issue15654.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

(closes issue #16448)
 Reported by: hevad

Review: https://reviewboard.asterisk.org/r/525/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249187 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 18:41:57 +00:00
David Vossel
feae3dbbdf adds Time field to "test show results" cli command
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 18:41:36 +00:00
Mark Michelson
da96c84c67 Send a manager event when the manager BridgeAction command is used.
(closes issue #16769)
Reported by: syspert
Patches:
      bridgeaction.patch uploaded by syspert (license 938)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249105 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 17:13:36 +00:00
Mark Michelson
86f0690571 Merged revisions 249100 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249100 | mmichelson | 2010-02-26 11:04:29 -0600 (Fri, 26 Feb 2010) | 8 lines
  
  For T.38 reINVITEs treat a 606 the same as a 488.
  
  (closes issue #16792)
  Reported by: vrban
  Patches:
        t38_606.patch uploaded by vrban (license 756)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 17:04:58 +00:00
Russell Bryant
a297f2d04e formatting tweaks and constification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249058 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:45:11 +00:00
Russell Bryant
b607585b07 Trim trailing whitespace (to help reduce diff against cdr-q branch)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:35:42 +00:00
Russell Bryant
53bf191569 Trim trailing whitespace, convert lists of defines to enums
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:26:10 +00:00
Russell Bryant
1f2f5fadcc trivial formatting tweak (working on reducing diff against trunk for cdr-q)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249013 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:08:38 +00:00
Russell Bryant
2abbaa5b6d remove include
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:07:27 +00:00
Russell Bryant
022e262d71 constification, remove include
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:07:09 +00:00
Russell Bryant
ab9741edbb Remove unnecessary includes, formatting tweak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:05:36 +00:00
Russell Bryant
5e9c39468b constification and remove unnecessary include
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 08:04:07 +00:00
Jeff Peeler
406bb18127 Merged revisions 248860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248860 | jpeeler | 2010-02-25 15:22:06 -0600 (Thu, 25 Feb 2010) | 18 lines
  
  Ensure that monitor recordings are written to the correct location (again)
  
  This is an extension to 248757. As such the dialplan test has been extended:
  
  exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
  exten => 5040, n, dial(sip/5001)
  exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
  exten => 5041, n, dial(sip/5001)
  exten => 5042, 1, monitor(wav,monitor_test3,b)
  exten => 5042, n, dial(sip/5001)
  exten => 5043, 1, monitor(wav,tmp/jeff/monitor_test3,m)
  exten => 5043, n, changemonitor(monitor_test4)
  exten => 5043, n, dial(sip/5001)
  exten => 5044, 1, monitor(wav,monitor_test4,m)
  exten => 5044, n, changemonitor(tmp/jeff/monitor_test5) ; this looks to fail by design and emits a warning
  exten => 5044, n, dial(sip/5001)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 23:09:54 +00:00
Mark Michelson
a1af5f4f72 Fix incorrect ACL behavior when CIDR notation of "/0" is used.
AST-2010-003



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 22:41:48 +00:00
Tilghman Lesher
a0af2cff0e Merged revisions 248859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248859 | tilghman | 2010-02-25 15:21:05 -0600 (Thu, 25 Feb 2010) | 15 lines
  
  Some platforms clear /var/run at boot, which makes connecting a remote console... difficult.
  
  Previously, we only created the default /var/run/asterisk directory at install
  time.  While we could create it in the init script, that would not work for
  those who start asterisk manually from the command line.  So the safest thing
  to do is to create it as part of the Asterisk boot process.  This also changes
  the ownership of the directory, because the pid and ctl files are created after
  we setuid/setgid.
  
  (closes issue #16802)
   Reported by: Brian
   Patches: 
         20100224__issue16802.diff.txt uploaded by tilghman (license 14)
   Tested by: tzafrir
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248861 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 21:22:39 +00:00
Jeff Peeler
d64987f8ad Merged revisions 248757 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248757 | jpeeler | 2010-02-25 12:06:54 -0600 (Thu, 25 Feb 2010) | 15 lines
  
  Ensure that monitor recordings are written to the correct location.
  
  Recordings should be placed in the monitor directory when a non-absolute path
  is used.
  
  Exact dialplan used for testing:
  exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
  exten => 5040, n, dial(sip/5001)
  exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
  exten => 5041, n, dial(sip/5001)
  exten => 5042, 1, monitor(wav,monitor_test3,b)
  exten => 5042, n, dial(sip/5001)
  
  ABE-2101
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 18:37:56 +00:00
Jeff Peeler
65d3e30e8d Blocked revisions 248668 via svnmerge
........
  r248668 | jpeeler | 2010-02-24 16:58:54 -0600 (Wed, 24 Feb 2010) | 8 lines
  
  Make deletion of temporary greetings work properly with IMAP_STORAGE
  
  This same patch was merged in 220833, but was skipped in this branch
  erroneously.
  
  (closes issue #16170)
  Reported by: francesco_r
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248671 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 23:00:40 +00:00
Tilghman Lesher
ba75980904 Also kill the .i files, or else the build process will not recreate them, when we
change flags.  Fixes a weird symbol problem mmichelson was having in a group branch,
but also applies to trunk.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 22:44:55 +00:00
Tilghman Lesher
4e1e6820db Merged revisions 248582 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248582 | tilghman | 2010-02-24 15:02:18 -0600 (Wed, 24 Feb 2010) | 7 lines
  
  Remove color code sequences from verbose messages that go to logfiles.
  (closes issue #16786)
   Reported by: dodo
   Patches: 
         logger2.patch uploaded by dodo (license 989)
   Tested by: tilghman
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 21:17:26 +00:00
Russell Bryant
e3d176d0d3 Remove unnecessary warning message, make a couple of formatting tweaks
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248534 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 06:39:27 +00:00