Commit graph

3352 commits

Author SHA1 Message Date
Olle Johansson
c6ab7e7164 Increase buffer size for routing headers. When routing with enc.keys within
route headers, we're reaching the limimt for what's possible in one UDP packet...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 15:10:22 +00:00
Olle Johansson
2f6f0b19c5 Raise debugging level for message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 07:25:33 +00:00
Russell Bryant
73e8e2ab1f Blocked revisions 36725 via svnmerge
........
r36725 | russell | 2006-07-03 00:19:09 -0400 (Mon, 03 Jul 2006) | 4 lines

use ast_set_callerid to be more consistent and to make sure that the
"callerid" option in the conf files is always handled the same way and sets ANI
(issue #7285, gkloepfer)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 04:25:21 +00:00
Olle Johansson
8affb4c1f8 Issue #7421 - Hold status not working fully. Thanks jmls for a good job debugging!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-02 19:53:54 +00:00
Olle Johansson
4c8e3bcdca users want code to compile, really.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-02 17:14:32 +00:00
Olle Johansson
e995afbd10 Formatting and debug output fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-02 16:42:53 +00:00
Olle Johansson
765e420458 tell the other side that we're using 20 ms packetization for iLBC
- we need to investigate support for refusing offers of 30 ms (like the Nokia
  e-series) or supporting it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-02 14:18:00 +00:00
Olle Johansson
b971f65978 - Make use of system name in realtime SIP peers optional
- Fix small issue with SIP history


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36602 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-02 12:00:36 +00:00
North Antara
79f45173fb It might help if this had the right stimulus name
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-01 17:59:37 +00:00
Mark Spencer
d9e8e304b9 Fix chan_nbs to build...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36505 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-01 14:55:29 +00:00
Joshua Colp
59be0b03b7 Fix up a few log messages in chan_sip (issue #7449 reported by tgrman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36408 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 15:29:15 +00:00
Matthew Fredrickson
b39cb899d6 Make sure that we build chan_misdn with the object files in the right order
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 15:23:20 +00:00
Christian Richter
6027721510 added a bit logging, when we split the bridge
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 14:09:52 +00:00
Christian Richter
4bdeb383e7 added fix, that if the L2 goes down on ptp-NT that we reinitialize the NT Library. Also if we have no ntflags, we don't pass the filename to the debug routines of mISDNuser.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 14:05:42 +00:00
Olle Johansson
8d4ace1a0a Store sysname even if we do not store fullcontact (thanks tholo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36356 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-30 07:22:47 +00:00
Christian Richter
f5c0cd2ddc added better L2 handling for ptp, if it's down we don't try to call on that port in groupdial anymore, also we try to get it up then. Additionally added the configoptions ntdebugflags and ntdebugfile to debug the mISDNuser NT Stack (should have done that ages before..). isdn_lib.c compiles again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-29 20:12:19 +00:00
Olle Johansson
a38e7f01a9 ...too early in the morning for commits in Bergen, Norway...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36256 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-29 07:59:10 +00:00
Olle Johansson
d92de40c2f Add support for a=inactive in SDP for holding. This is not very well documented
in RFCs, as they keep referring to each other in a circular pattern in regards
to this item, but since the Nokia SIP/GSM phones use this, we might as well
start supporting it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-29 07:15:12 +00:00
Christian Richter
fc8d55ab15 moved a notice into a log
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-28 14:24:18 +00:00
Christian Richter
727488c81b fixed a few state problems when hanging up the call. also changed a few debug messages to higher log level
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36188 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-28 14:15:29 +00:00
Olle Johansson
dd94255a69 Don't delete initid scheduled item twice... Thanks, vecher, for bugging me about this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 20:54:06 +00:00
Olle Johansson
f48a573439 Code cleanup while trying to understand this channel...
- please check


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 20:52:52 +00:00
Olle Johansson
f12f5b7c6c Formatting and doxygen fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 19:28:04 +00:00
Olle Johansson
6d86697867 issue #7033 - Don't burst pokes to peers at load or reload.
Open for a cool algorithm to space them out...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36178 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 18:00:09 +00:00
Olle Johansson
6895f108bd Inspired by issue 6742, but solved in a different way.
(Yes, I like the system name setting)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36177 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 17:30:14 +00:00
Christian Richter
5d18356b24 fixes segfault on incoming call which is disconnected in Alerting state
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 11:28:48 +00:00
Olle Johansson
6ca399c459 Don't change direction of the dialogue when we send a re-invite
(will confuse to/from headers and to/from tags)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36171 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 10:54:57 +00:00
Olle Johansson
0dbb924cb5 Found a missing "l" on the left side of the sofa, close to the TV.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 20:43:49 +00:00
Olle Johansson
66786a7d53 Issue #7421 - Stop generator on both call legs (patch by tgrman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36147 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 20:41:54 +00:00
Olle Johansson
1cbd4effca Issue #7429 - accessing a not allocated structure causes segfault... (tgrman, fix by myself
inspired by suggested fix).


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36128 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 19:07:32 +00:00
Christian Richter
baad1c266c * fixed the busy state
* fixed tone handling after ast_hangup was called
* optimized the tone_indication function
* removed warnings in favour of log debugs
* improved the round_robin method
* added logs for channel setting/emptying
* fixed channel forgot to set bug





git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 17:37:11 +00:00
Kevin P. Fleming
93385c0fab fix for issue #7245
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36079 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 17:24:14 +00:00
Olle Johansson
9863bb982c Separate private options so we don't request bug report on those...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 08:25:33 +00:00
Olle Johansson
8ee441b649 Update the SIP options list from IANA repository
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35965 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-26 07:45:03 +00:00
Tilghman Lesher
b3c6e18a5e Merged revisions 35915 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r35915 | tilghman | 2006-06-25 10:10:06 -0500 (Sun, 25 Jun 2006) | 2 lines

Bug 7425 - Size of buffer is passed in by len

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-25 15:12:02 +00:00
Kevin P. Fleming
a579371f43 use new (separate) dependencies file from menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-25 08:50:14 +00:00
Kevin P. Fleming
e61d3d91f3 The Eurostar Commit! (it's amazing how much work you can get done on a 150 minute train ride from Paris to London <G>)
support the new location for zaptel.h and tonezone.h
use the dependency information output by menuselect to build Makefile rules for each module for header files and libraries
combine the common rules into a top-level Makefile.rules file
remove all (now) unnecessary stuff from subdir Makefiles
change translator API so that the newpvt() callback returns an int instead of a pointer (it no longer allocates memory)
alphabetize --with-<foo> options in configure script
enhance Net-SNMP support in configure script to provide a --with-netsnmp option
fix support for --with-pq so that if pg-config is not found when --with-pq is specified, an error will be generated
add 'optional package' usage to modules now that menuselect can output it
allow res_snmp to build by default, since the new loader changes coming soon will solve the function naming problem (and users can disable it via menuselect anyway)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-24 19:43:31 +00:00
Kevin P. Fleming
df0ba5ff8b search for Zaptel and libtonezone separately in the configure script
various other minor fixes


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-24 08:45:49 +00:00
Russell Bryant
1c17258f4e fix some little issues on big endian platforms to resolve compiler warnings
- don't call the byte swapping macros on single byte numbers
 - don't do a ++ increment in the argument in the argument to the byte swapping
   macros. This gets expanded to incrementing the variable 4 times in a single
   operation, which results in undefined (and obviously undesired) behavior. :)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35766 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 23:22:57 +00:00
Russell Bryant
c8ceb92a4f revert my changes that converted the jb on the channel to be dynamically
allocated. These changes caused crashes when using a channel type that did
not support the jitterbuffer. Instead of fixing why it's crashing, I'm going
to implement this in a better way next week. The way I did it caused a
jitterbuffer to be allocated on every channel where the channel type supported
jitterbuffers, even if they were disabled.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 16:49:12 +00:00
Russell Bryant
84c37e0c58 reduce indentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35629 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 02:08:10 +00:00
Russell Bryant
5e282fef07 reduce indentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 02:03:21 +00:00
Russell Bryant
5941d4d819 - move the increase of the use count to be after the possible failures
- if the pbx fails to start, set the owner channel of the pvt strucutre
  to be NULL
- return immediately if the pbx fails to start so the loop to set all of
  the variables from the "setvar" options aren't set as a bunch of global
  variables instead


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 17:10:16 +00:00
Russell Bryant
46018d5032 - dynamically allocate the ast_jb structure that is on the channel structure
so that channels not using a jitterbuffer don't waste as much memory
- ensure that the channel drivers that use jitterbuffers can handle a failure
  from configuring a jitterbuffer on a new channel because of a memory
  allocation error
- On passing through these channel drivers, configure the jitterbuffer before
  starting the PBX thread instead of afterwards. If the pbx fails to start for
  whatever reason, this would have caused a crash.
- Also on passing, move the increase of the usecount to after all of the
  possible failure conditions in the function
- fix a place where ast_update_use_count() was not called
- ensure that the owner channel pointer of the channel pvt strcutures is set to
  NULL in failure conditions


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35553 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 17:05:17 +00:00
Russell Bryant
3daaf2163f use .PHONY instead of FORCE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 15:55:13 +00:00
Russell Bryant
48ae9f0d4f - convert the 'uninstall' target to use separate targets to process each
subdirectory instead of a for loop
- remove the FORCE target from the main Makefile and add the couple places
  I used it to the .PHONY target.  .PHONY does the same thing and is a built-in
  more efficient way of doing it.
- add a bunch more targets to .PHONY ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 15:38:13 +00:00
Russell Bryant
55e8a60363 - specify that 'depend' is a .PHONY target
- use separate targets instead of a for loop for doing 'make depend' for
  each sub directory


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 15:08:08 +00:00
Russell Bryant
9db0520ff9 - specify that 'all' is a .PHONY target
- add a copyright header to the build_tools Makefile
- remove 'depend' from the 'all' target in agi/ and utils/ since it is handled
  by the main Makefile already


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35479 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 14:09:18 +00:00
Russell Bryant
c399a06450 add the 'clean', 'clean-depend', and 'dist-clean' targets as .PHONY targets
since they are targets that do not have resulting files and are never listed
as prerequisites to real targets.  Using .PHONY in this manner improves make
performance by never having to check for resulting files.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 11:27:03 +00:00
Olle Johansson
d29e2a58da Add video support to chan_agent.
More ideas for developing better video support in Asterisk?

Join the asterisk-video mailing list to help out in the 
Asterisk Video Task Force!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 20:11:09 +00:00
Olle Johansson
a256bcb080 Issue #7380 - Cannot put a one-legged call on hold/off hold
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35336 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 19:58:03 +00:00
Olle Johansson
58c243a6d4 Only formatting changes... (tabs to spaces)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 17:05:38 +00:00
Joshua Colp
5ff818f995 Fix timing issue (race) with poke/pong for very close peers that can cause a peer to be declared unreachable (issue #7396 reported by stevedavies)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 16:50:24 +00:00
Christian Richter
70a4c98a5a * added support for PID export/import to identify bridging in misdn_call already
* fixed a few inband Alerting issues, sometimes we need to create alerting, some
times it's inband
* beautified the state debugging of misdn_hangup
* removed "real"  bchannel activating/deactivating in chan_misdn.c
* fixed "round_robin" bug when there's only 1 port
* added more informative prints when channel could not be created
* changed some warnings to notices
* reworked the whole bchannel state machine stuff, 
  it is now like in the examples of mISDNuser and therefore a lot easier, 
  and it is now harder to create bugs
* bchannel_activate/deactivate is now only called in setup/cleanup bc, 
  they may merge sometime
* it is very important to setup/cleanup the bchannels under the correct 
  conditions, especially in the NT Side we can only setup the bchannels 
  when we send a Message! 
  In the TE side we can only setup the bchannel when we received the channel 
  of course
	      


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 15:21:46 +00:00
Olle Johansson
7876a86e96 - Doxygen and some formatting fixes in res_features
- Get rid of compiler warnings in chan_sip


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 07:49:29 +00:00
Olle Johansson
a85fec94fd Finally fix parking and go back to metermaids
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-21 07:13:20 +00:00
Olle Johansson
12164df2fd How many times can we free allocated memory? Many, obviously... ;-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 21:12:58 +00:00
Olle Johansson
b27fff2a9d Hunting crash when parking calls with SIP REFER
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 21:09:50 +00:00
Olle Johansson
0195279499 use correct test for checking if sip domains are enabled or not
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 15:46:49 +00:00
Olle Johansson
cb4221c7e9 Don't count unknown media streams as media streams in the offer... (Fenlander reported this on irc)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 13:31:42 +00:00
Olle Johansson
e04914b44a parse SDP properly even when we are debugging. (Thanks fenlander!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 13:28:33 +00:00
Olle Johansson
3b910323f3 Issue #6820 - SIP channels hang in semi active state
- Block fix from 1.2
- Implement part of that fix that was not already implemented, but in a different way

basically, don't cancel destruction when we receive re-transmits.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35059 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 10:34:53 +00:00
North Antara
fb0bb9b195 fix an issue with dtmf not being sent sometimes
slightly modify handling of digits


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-20 08:09:30 +00:00
Olle Johansson
bce5b8a146 - Formatting
- Create larger buffer for managing long auth headers from clients (adviced by SNOM)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 21:09:24 +00:00
Christian Richter
2302fa58d7 when we get a disconnect, we should stop the tones on te side..
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 09:44:04 +00:00
Christian Richter
cdbddf5892 we need to send DISCONNECT on Timeout in the ALERTING/PROCEEDING cases too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34762 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 07:36:18 +00:00
Russell Bryant
9f2a6516cf don't blow up in the sub Makefiles if menuselect.makeopts is not present. This
is valid in some cases, such as "make clean".


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34738 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 00:14:16 +00:00
North Antara
e832ae320f No need to have debug enabled by default anymore..
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 23:18:34 +00:00
North Antara
a5d6979fac Finally merge chan_skinny fixes into trunk.
ready...set...GO!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 22:36:39 +00:00
Russell Bryant
f75ad9736a bail if ast_calloc fails, this was done before but i accidently removed it when
moving these allocations so duplicate error messages were not produced
(issue #7345)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 21:24:35 +00:00
Russell Bryant
7ec13047bc fix various coding guidelines issues (issue #7345, with additional changes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 20:51:14 +00:00
Russell Bryant
035a8b4278 Merged revisions 34627 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r34627 | russell | 2006-06-18 16:15:15 -0400 (Sun, 18 Jun 2006) | 5 lines

don't store multiple secrets delimited with semicolons for peers because this
is only valid for users. Instead, only keep the last specified secret for a
peer entry. Also, document how multiple secrets are handled in the sample
config. (Reported by PCadach on #asterisk-bugs)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 20:18:41 +00:00
Christian Richter
829583a3dc added TONE_HANGUP, also added Tone generation by mISDN_dsp for post hangup tones, therefore the TONE_X defines are in the isdn_lib.h now. changed a REALEASE to a DISCONNECT in NT Stack, to make tones available in that state.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 19:09:32 +00:00
Christian Richter
d86993b90b * fixed bchannel cleaning race condition with new bchannel state (CLEAN_REQUEST)
* added early bridge-hook, so we know if we need to generate ringing or 
  can take it from the far end chan_misdn channel (if available)
* fixed the issue, that we may not activate the bchannel on PTMP, 
  when we receive ALERTING/PROCEEDING/PROGRESS, only on CONNECT. There might
  be other PTMP devices and we might disturb their bchannel. 



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-17 10:37:35 +00:00
Russell Bryant
b6147a21b9 remove "depend" from the "all" targets in sub Makefiles. The main Makefile
already calls "make depend" for each of the subdirectories


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 16:54:00 +00:00
BJ Weschke
ecabadf2cd Fixed per kpfleming's suggestion to asterisk-dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 12:56:03 +00:00
BJ Weschke
35a2f14d96 Quit early and print a LOG_WARNING if we are trying to check devicestate on a Local channel that's been improperly defined.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 12:55:18 +00:00
BJ Weschke
9cbcf110e1 Make sure agent_tech is unregistered within unload_module(). It's in 1.2, but was lost at some point in /trunk. #7374 (jstorm)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 12:24:14 +00:00
Joshua Colp
9ebb7c35a2 Merged revisions 34400 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r34400 | file | 2006-06-16 00:37:05 -0300 (Fri, 16 Jun 2006) | 2 lines

Zero out a declared structure so as to not crash if it contains invalid data (reported by Qwell on #asterisk-dev)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 03:38:24 +00:00
Olle Johansson
2813d15f52 Hoppsan!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 13:00:55 +00:00
Olle Johansson
83e64c7c94 - Do not require a space at the end of the m= string in a T38 re-invite
Bug reported in the t38 issue report, but by mistake ignored before commit.
  Thanks to everyone informing me about this, and Corydon for helping me sort
  out sscanf :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34217 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 06:35:55 +00:00
Kevin P. Fleming
794d0e4d1f make Local channel return sensible device state values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 22:39:19 +00:00
Kevin P. Fleming
11dac47877 Merged revisions 34159-34160 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r34159 | kpfleming | 2006-06-14 17:17:37 -0500 (Wed, 14 Jun 2006) | 2 lines

use existing dial string parser for strings supplied to iax2_devicestate, because they can be complete dial strings, not just device names

........
r34160 | kpfleming | 2006-06-14 17:22:21 -0500 (Wed, 14 Jun 2006) | 2 lines

coding style cleanups on queue interface handling code that was committed for the last release

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 22:35:49 +00:00
Olle Johansson
8fd35365f5 Add some debug logging
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 15:15:29 +00:00
Olle Johansson
fb8483c430 - Use our standard of doxygen comments, not javadoc style
- small reformatting changes


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 14:46:19 +00:00
Olle Johansson
4b6d6a1a0b Formatting fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 11:40:31 +00:00
Kevin P. Fleming
fca19e7635 use a compiler builtin (which uses processor instructions) for this operation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-13 20:59:15 +00:00
Matt O'Gorman
b22e7bf558 adds support for t38 pass through patch brought up to trunk from
bug 5090 by josh colp.  Thanks to everyone who help get this patch through
especially to the author Steven Underwood.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33890 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-13 18:35:53 +00:00
Russell Bryant
55ffe394a5 only set the QOS variables if the pvt has an owner so that they are not
created as global variables.  (The fact that these were getting created on
my system probably means that these are in the wrong place so oej, you may
want to look at this again.)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 21:01:48 +00:00
Olle Johansson
1ec28daa30 Formatting fix and doxygen update
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 20:07:35 +00:00
Olle Johansson
2ab4e12549 Fix typo (Thanks Vechers!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 20:01:05 +00:00
Kevin P. Fleming
79f5f61474 Merged revisions 33638 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r33638 | kpfleming | 2006-06-12 11:03:29 -0500 (Mon, 12 Jun 2006) | 2 lines

only allow chan_local to masquerade the outbound channel onto its owner, instead of the other way around (this will ensure that group variables on the outbound channel as preserved)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33643 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 16:07:32 +00:00
Olle Johansson
5d3d87900e - Remove redundant forward declaration
- Change variable name to make register_verify more readable (p -> peer not pvt in this function)
- Get Contact: header only once instead of twice
- Add some comments to register_verify

Caused by issue #7327... :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 15:17:18 +00:00
Joshua Colp
ce311227ac Change a bit of logic in peer expiry back to the way it used to be
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-12 02:54:32 +00:00
Olle Johansson
e41fcca65a - Complete addition of forward declarations and grouping of functions
- Change/add comments
- Declare internal function as static
- Remove functionname: in descriptions of functions
- Move Enums to top of file


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-11 20:42:11 +00:00
Olle Johansson
8ef5092031 Issue #7325 - Parse string after URI decoding (casper)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 21:32:48 +00:00
Olle Johansson
d2fa9efdad Store RTCP reports in channel variables and SIP history
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 21:28:52 +00:00
Olle Johansson
6d4ab87321 - RTP debug message formatting
- Add rtcp report to SIP history


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 21:09:42 +00:00
Olle Johansson
8bee8de932 Another try at hanging up the transferer channel after the masq
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 20:09:55 +00:00
Joshua Colp
6723184a62 Merged revisions 33297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r33297 | file | 2006-06-09 15:26:42 -0300 (Fri, 09 Jun 2006) | 2 lines

Remove an unneeded double lock (issue #7310 reported by arkadia)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 18:29:58 +00:00
Joshua Colp
5349ae6f46 Wait until we have the lock before getting the pvt structure pointer (issue #7313 reported by arkadia)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 18:20:28 +00:00
Olle Johansson
bcf82f32d5 Don't force context for domain= setting (imported from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 15:57:28 +00:00
Olle Johansson
2366793c63 Remove the return value from functions that return something that is never checked anywhere.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33215 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 13:35:41 +00:00
Christian Richter
fcb7d3df26 when we don't want the call we need to release_complete it.. ignoring it breaks the ETSI rules ..
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 10:31:30 +00:00
Olle Johansson
ce10b34ca6 Enabling and disabling debug messages...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 09:38:13 +00:00
Kevin P. Fleming
09778b268e move 'struct ast_rtp' back to rtp.c where it belongs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 23:10:45 +00:00
Olle Johansson
36506dad2d Debug logging fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 20:30:20 +00:00
Olle Johansson
fee02a9b7d At least reply if we get a fatal error in handling a packet.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 20:14:54 +00:00
Olle Johansson
91732256db Don't crash if chan2 does not exist (one-legged call situations, like echo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33110 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 20:07:05 +00:00
Olle Johansson
b796bf414b Improve SIP history
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33109 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 20:06:04 +00:00
Olle Johansson
89081c3d06 Issue #7294 - Asterisk sends INVITE instead of BYE. Fix by Philippe Sultan. Thanks!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 18:13:06 +00:00
Christian Richter
05eed16044 Fixed detection of dtmfs with bridged channels.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-08 09:51:13 +00:00
Kevin P. Fleming
472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Russell Bryant
739385e761 remove the WITH_SMDI define
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:28:29 +00:00
Russell Bryant
66dca5e378 Merged revisions 32818 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r32818 | russell | 2006-06-07 13:53:21 -0400 (Wed, 07 Jun 2006) | 2 lines

fix some broken code with BRIDGE_OPTIMIZATION defined (issue #7292)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 17:54:26 +00:00
Russell Bryant
39bcaa0773 add an updated patch that adds dnsmgr support for outgoing iax2 registrations
(issue #6305, by ivanfm, with mods)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 17:44:36 +00:00
Russell Bryant
503f99e2e8 remove the need to have to re-run make after a default menuselect.makeopts
file is generated.  This allows a fresh checkout of asterisk to be built
and installed with the standard "./configure && make && make install".


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 16:03:31 +00:00
Christian Richter
7924c21e33 changed the clean_up_bc function to work proper again. fixed the print with the conference nr. when bridged
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 13:01:02 +00:00
Russell Bryant
efd1fd9829 revert my changes to convert fields of zt_pvt to use stringfields. When I did
this, I was not keeping in mind the fact that after a stringfield is overwritten
by another string, the memory used by the old string can not be recovered.  I
would like to go back through these changes and make sure that stringfields are
not used for fields that are written to many times before these changes are
committed.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32759 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 23:22:12 +00:00
Matthew Fredrickson
f809fde426 Add q.921 state information. (#7260)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 22:19:19 +00:00
Olle Johansson
479181951a Merge of the "sdpcleanup" branch. Thanks to John Martin for a lot of tests
and some patches (all disclaimed).

- Don't change RTP properties if we reject a re-INVITE
- Don't add video to an outbound channel if there's no video on the inbound channel
- Don't include video in the "preferred codec" list for codec selection
- Clean up and document code that parses and adds SDP attachments

Since we do not transcode video, we can't handle video the same way as audio. This is a
bug fix patch. In future releases, we need to work on a solution for video negotiation,
not codecs but formats and framerates instead.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 16:09:33 +00:00
Kevin P. Fleming
22b45aa4d3 Merged revisions 32566 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r32566 | kpfleming | 2006-06-06 10:48:00 -0500 (Tue, 06 Jun 2006) | 2 lines

clean up yesterday's security fix to not cause breakage when video mini frames are received

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32567 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 15:48:42 +00:00
Russell Bryant
fa595a8d82 don't return -1 if zapata.conf is not present (part of the patch from
issue #7290, tzafrir)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 14:24:59 +00:00
Christian Richter
24818d53b1 added select before write to avoid deadlock on full buffer. added some defines for deadlock debugging. added code snippet for generating silence if we don't have data to write.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 09:40:41 +00:00
Russell Bryant
80a153af79 - use stringfields in a bunch of the fields of the zt_pvt structure in chan_zap
- constify some arguments to functions in callerid.c / callerid.h


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 01:22:47 +00:00
Kevin P. Fleming
e856010714 use module names, not file names, in menuselect
work around XML parsing bug in menuselect for default sounds package


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 20:46:27 +00:00
Kevin P. Fleming
8a95a1ddc1 Merged revisions 32373 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r32373 | kpfleming | 2006-06-05 14:53:16 -0500 (Mon, 05 Jun 2006) | 2 lines

ensure that the received number of bytes is included in all IAX2 incoming frame analysis checks (fixes a known vulnerability)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 20:10:06 +00:00
Russell Bryant
b0260c1039 revert the changes to allow chan_iax2 to use dnsmgr for registrations.
my concerns are listed in issue #6305


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 16:17:31 +00:00
Joshua Colp
2a71835d41 Convert chan_iax2 to use dnsmgr in order to deal with hostnames that can change their resolved IP (aka dynamic dns setups) (issue #6305 reported and fixed by ivanfm)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32304 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 15:44:37 +00:00
Olle Johansson
8bc0599b11 Issue 7208 - Handle ; in userinfo part of URI too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 07:43:40 +00:00
Olle Johansson
404f8db694 Do not use ':' as a separator between arguments (kept around for 1.4 for backwards compatibility)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 06:36:18 +00:00
Olle Johansson
62dd0dc6f2 Only override callingpres set by rpid if user/peer preference is set. (Issue #7240)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 06:23:22 +00:00
Olle Johansson
02bc3637da Code simplification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32138 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 21:13:48 +00:00
Olle Johansson
d520d238f1 - Fix more problems in transfer code (thanks Tholo!)
- Add debug for hangup not in UP state


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 21:01:13 +00:00
Olle Johansson
043b765bdc Respond to some of Luigis questions...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 19:18:24 +00:00
Olle Johansson
e97507e8fb Fix potential bug. THanks luigi!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 18:58:27 +00:00
Olle Johansson
0d6906e107 - Doxygen fix
- Debug message change


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 18:35:29 +00:00
Olle Johansson
c2b50fd2bd Show max bitrate in "sip show user" and "sip show channel"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 17:35:30 +00:00
Olle Johansson
439e4963ab - Typo in chan_sip (: missing)
- Only print formats once in dumpchan()


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32017 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 11:09:14 +00:00
Luigi Rizzo
531ed6f290 add a bit of comment on what build_route does,
plus minor code simplification.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 00:09:13 +00:00
Luigi Rizzo
88077a4d1f remove some duplicated code;
fix indentation on one line;
mark XXX some unreachable code;
mark XXX another place where we could reduce the nesting depth.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:58:32 +00:00
Luigi Rizzo
2724885b78 small simplification in assignments, and fix a typo in a comment.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:46:23 +00:00
Luigi Rizzo
24d1d23a93 mark XXX some places where there is a return right before
a large "else" block, which is suitable for a reduction of
the nesting depth.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:34:01 +00:00
Luigi Rizzo
8dbdd8518b fix indentation of a block
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:23:24 +00:00
Luigi Rizzo
d18e363523 some code simplifications using S_OR() to remove some if blocks
and duplicate code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:17:54 +00:00
Luigi Rizzo
ec46b5a4ce use ast_skip_blanks() where appropriate, and use standard
C jargoon  *foo++ = '\0'; instead of two separate statements.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31861 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:03:29 +00:00
Luigi Rizzo
b7b716b618 mark XXX a buggy section of code and implement a probable
replacement (leave the original in case my code does not
do what the function was meant to do).
oej, please check this...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31843 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:56:45 +00:00
Luigi Rizzo
7483e1d2b6 simplify logic in a small block of code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:29:37 +00:00
Luigi Rizzo
c7a5a96fc6 mark XXX a bug in the code. oej/kevin, any idea what you want
to use here ?



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31841 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:18:41 +00:00
Luigi Rizzo
a63b2e4c53 remove duplicate code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 20:40:54 +00:00