9b5d9279be
Fix a couple of spots in the handling of device states that could lead to a
...
double free. (issue #9772 , reported by Mike Anikienko, fix by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@65375 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 12:52:03 +00:00
ff73bfb7e7
I know we have talked about rewriting app_queue for Asterisk 1.6, but once I
...
saw this, I couldn't help myself from changing it. Previously, for *every*
device state change, app_queue would spawn a thread to handle it. Now, the
device state callback just puts the state change in a queue and it gets
handled by a single state change processing thread.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@65298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-21 06:56:21 +00:00
3ecad89b42
Merged revisions 64868 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r64868 | russell | 2007-05-17 21:48:51 -0500 (Thu, 17 May 2007) | 5 lines
Fix a small bug I noticed while working on something else. app_queue did not
unregister its device state monitoring callback in unload_module(). So, this
would make Asterisk crash on the first device state change after you
unload the module.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@64869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 02:51:07 +00:00
2d1b06faef
Don't allow rounding seconds to weird values that may cause "unexpected" results.
...
Issue 9514.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@64263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-14 18:08:54 +00:00
83c00e346e
Add 'c' option to app_queue which allows for continuing in the dialplan if the callee hangs up.
...
Issue 9284, patch by lyl, modified a little bit by me (I felt 'continue' was better than 'keepalive')
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@64243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-14 17:38:36 +00:00
683417407e
This patch adds additional information to the EXITWITHKEY and EXITWITHTIMEOUT
...
entries in the queue log.
(issue #7561 , reported and originally patched by fkasumovic, patch slightly
modified and updated to trunk by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@62462 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-30 16:46:49 +00:00
672fbc1f81
Add a min-announce-frequency option to queues.conf which allows you to control the
...
minimum amount of time between queue announcements for use when the caller's queue
position changes frequently.
(issue #9604 , patch by Matthew Roth)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@62242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-27 22:08:54 +00:00
52ae7d58f7
Merged revisions 61694 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r61694 | qwell | 2007-04-20 14:51:49 -0500 (Fri, 20 Apr 2007) | 13 lines
Merged revisions 61692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61692 | qwell | 2007-04-20 14:49:54 -0500 (Fri, 20 Apr 2007) | 5 lines
If the '* to hangup' option is not enabled, we don't need to disable * as a valid exit key.
If it was enabled, this statement would've never been checked in the first place.
Issue #9552
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@61695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-20 19:54:54 +00:00
0cb6714ce8
Merged revisions 61022 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r61022 | qwell | 2007-04-09 14:05:48 -0500 (Mon, 09 Apr 2007) | 4 lines
Use the appropriate interface name with COMPLETECALLER.
Issue 9395.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@61023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 19:06:36 +00:00
9ab4327d8b
Merged revisions 60762 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r60762 | file | 2007-04-08 13:04:44 -0400 (Sun, 08 Apr 2007) | 2 lines
Allow app_queue to use MONITOR_EXEC even if MONITOR_OPTIONS is not set. (issue #9495 reported by cduffy)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@60763 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-08 17:13:39 +00:00
f0aeab730f
Send a manager AgentComplete event when the agent transfers the call, in
...
addition to where it is already sent if either side hangs up.
(issue #9219 , rgollent)
In passing, I put this code in a function so it would not be duplicated
a third time.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@58123 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-06 23:20:57 +00:00
f95a15ed58
Merged revisions 55219 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r55219 | file | 2007-02-17 12:39:32 -0500 (Sat, 17 Feb 2007) | 2 lines
Add missing membername option to AddQueueMember documentation. (issue #9088 reported by seanbright)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@55220 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 17:41:47 +00:00
177953c8f1
We want to skip the queue if the name doesn't match the specified one, not if they *do*.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@55198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 16:48:20 +00:00
d4c75e57c0
Increase "queue show" buffer size from 80 to 240. This should be more then enough for most cases. (issue #9089 reported by mvanbaak)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@55197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 16:39:24 +00:00
213983dee2
Merged revisions 55129 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r55129 | file | 2007-02-16 21:59:50 -0500 (Fri, 16 Feb 2007) | 2 lines
Make the 'i' option of Queue actually work. (issue #8986 reported by utis)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@55132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 03:01:38 +00:00
f60efe347a
This introduces a new dialplan function, DEVSTATE, which allows you to do some
...
pretty cool things.
First, you can get the device state of anything in the dialplan:
NoOp(SIP/mypeer has state ${DEVSTATE(SIP/mypeer)})
NoOp(The conference room 1234 has state ${DEVSTATE(MeetMe:1234)})
Most importantly, this allows you to create custom device states so you can
control phone lamps directly from the dialplan.
Set(DEVSTATE(Custom:mycustomlamp)=BUSY)
...
exten => mycustomlamp,hint,Custom:mycustomlamp
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@54261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-13 22:02:20 +00:00
655da6da05
Clean up documentation of Queue application. (issue #9022 reported by seanbright)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-09 17:14:10 +00:00
d07e640c6f
Merged revisions 53081 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r53081 | oej | 2007-02-01 21:38:58 +0100 (Thu, 01 Feb 2007) | 2 lines
Change debug level for state change message that is not really informative when debugging app_queue
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53083 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-01 20:44:49 +00:00
b233892198
Merged revisions 53046 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r53046 | russell | 2007-01-31 15:32:08 -0600 (Wed, 31 Jan 2007) | 11 lines
Merged revisions 53045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines
Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53047 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 21:35:15 +00:00
26a33b2ffc
Merged revisions 53037 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r53037 | russell | 2007-01-31 11:39:28 -0600 (Wed, 31 Jan 2007) | 3 lines
Only changed the paused status in an existing queue member if the paused
column exists.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53038 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 17:39:55 +00:00
59b382021e
Merged revisions 53035 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r53035 | russell | 2007-01-31 11:34:22 -0600 (Wed, 31 Jan 2007) | 4 lines
Instead of always creating a realtime queue member as unpaused, read the
"paused" column and use that value for the paused status of the member.
(issue #8949 , jmls)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53036 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 17:35:14 +00:00
44beb7c475
Merged revisions 52416 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r52416 | file | 2007-01-26 21:13:41 -0500 (Fri, 26 Jan 2007) | 10 lines
Merged revisions 52415 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r52415 | file | 2007-01-26 21:09:10 -0500 (Fri, 26 Jan 2007) | 2 lines
Make COMPLETECALLER and COMPLETEAGENT output to queue_log follow documentation. (issue #7677 reported by amilcar)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@52417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-27 02:15:21 +00:00
cd73a483f1
const-ify some more APIs, and fix rev 49710 from branch-1.4 in a better way here
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@49711 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 23:32:42 +00:00
87b9abc892
Merged revisions 49676 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r49676 | kpfleming | 2007-01-05 16:16:33 -0600 (Fri, 05 Jan 2007) | 2 lines
reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@49678 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:43:18 +00:00
ccebf3511c
convert the final clients of ast_build_string to use ast_str_*()
...
Now the only module left using it is chan_sip.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-18 15:38:50 +00:00
18e5017634
replace ast_build_string() with ast_str_*();
...
simplify __queues_show()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-17 22:47:30 +00:00
5824af9cbc
Resolve some pointer signedness compiler warnings in app_osplookup, and
...
constify a bunch of usage strings for CLI commands.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-06 07:39:39 +00:00
a1a37dddfe
Add ability to add custom queue log via manager interface.
...
Issue 7806, patch by alexrch, with slight modifications by me.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-17 20:46:36 +00:00
64d5316a53
Add 'loose' option to joinempty and leavewhenempty which is almost exactly like 'strict' except it does not count paused queue members as unavailable. (issue #8263 reported by gnarf)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47567 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 18:23:55 +00:00
9398ac87a2
Merged revisions 47433 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47433 | kpfleming | 2006-11-10 10:36:49 -0600 (Fri, 10 Nov 2006) | 2 lines
if adding a queue member is LOG_NOTICE, then removing them should be LOG_NOTICE, not LOG_DEBUG
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:38:33 +00:00
fed9126600
Merged revisions 47432 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47432 | kpfleming | 2006-11-10 10:34:04 -0600 (Fri, 10 Nov 2006) | 2 lines
reflect addition/removal of dynamic queue members in queue_log, so that people using dialplan replacement for AgentCallbackLogin can still track login/logout (issue #7736 , reported/patched by whoiswes but this commit was written by me and covers all three paths for AQM/RQM)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:37:42 +00:00
6b459ebd0c
%ld and time_t don't match, so cast the argument to long
...
to ease portability problems
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 22:26:48 +00:00
10875731ec
Merged revisions 47051 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47051 | tilghman | 2006-11-02 17:00:20 -0600 (Thu, 02 Nov 2006) | 2 lines
Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:16:09 +00:00
eea3a260da
Let's make sure we hold the mutex lock before we go looking at values in the queue structure that could potentially be changing while we're running.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-27 19:28:34 +00:00
95a4fc7af2
* Added option to run macro when a queue member is connected to a caller,
...
see queues.conf.sample for details.
* Added QUEUE_VARIABLES function to set queue variables added setqueuevar and
setqueueentryvar options for each queue, see queues.conf.sample for details.
(#8216 , jmls reported and submitted)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-27 18:59:16 +00:00
414f448b09
Merged revisions 46249 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46249 | russell | 2006-10-25 14:08:18 -0500 (Wed, 25 Oct 2006) | 2 lines
update warning message to include "agi" option (issue #8225 , jmls)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 19:10:43 +00:00
749029de38
Merged revisions 46200 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46200 | kpfleming | 2006-10-25 09:32:08 -0500 (Wed, 25 Oct 2006) | 2 lines
apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 14:44:50 +00:00
3c876af5cf
Merged revisions 44378 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r44378 | kpfleming | 2006-10-04 14:47:22 -0500 (Wed, 04 Oct 2006) | 4 lines
update thread creation code a bit
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space
add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 19:51:38 +00:00
e486316dc6
Merged revisions 44298 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r44298 | kpfleming | 2006-10-03 15:18:29 -0500 (Tue, 03 Oct 2006) | 10 lines
Merged revisions 44296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r44296 | kpfleming | 2006-10-03 15:14:13 -0500 (Tue, 03 Oct 2006) | 2 lines
fix a logic error in my previous fix to the queue reload code
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:19:32 +00:00
31800f61c3
Strat becomes Strategy based on feedback from two nameless fellows
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:17:40 +00:00
e550109383
Add 'Strat' manager field to QueueParams event. (issue #7704 reported by renemendoza)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 17:41:41 +00:00
ae8cc3e18b
bug #8076 check option_debug before printing to debug channel.
...
patch provided in bugnote, with minor changes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 15:53:07 +00:00
8ff3dd273a
Expand setinterfacevar option to also set a variable, MEMBERNAME, which contains the member's name. (issue #8046 reported by jmls)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44218 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-02 20:58:48 +00:00
3e4a081e1c
Make callerid fields in Manager events more consistent. CallerIDNum for number and CallerIDName for name. (issue #7976 reported by suhler)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44217 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-02 20:35:16 +00:00
cc1945ce1b
Add option 'keepstats' which will keep queue statistics during a reload. (issue #7908 reported by jmls)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-02 15:40:38 +00:00
e2a52816fc
Merged revisions 43944 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r43944 | qwell | 2006-09-28 13:11:22 -0700 (Thu, 28 Sep 2006) | 4 lines
Fix incorrect argument order for member names, on persisted members.
Issue 8047, patch by jmls.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43945 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 20:13:09 +00:00
5ae60ec272
Merged revisions 43919 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r43919 | kpfleming | 2006-09-28 12:35:42 -0500 (Thu, 28 Sep 2006) | 10 lines
Merged revisions 43916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r43916 | kpfleming | 2006-09-28 12:31:57 -0500 (Thu, 28 Sep 2006) | 2 lines
fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:38:07 +00:00
9baf50ee9a
Merged revisions 43899 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r43899 | bweschke | 2006-09-28 12:41:05 -0400 (Thu, 28 Sep 2006) | 11 lines
Merged revisions 43897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r43897 | bweschke | 2006-09-28 12:37:15 -0400 (Thu, 28 Sep 2006) | 3 lines
app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. (#8040 reported and patch by tim_ringenbach)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43902 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:54:01 +00:00
3b3702f9bc
Merged revisions 43873 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r43873 | bweschke | 2006-09-28 11:29:21 -0400 (Thu, 28 Sep 2006) | 11 lines
Merged revisions 43871 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r43871 | bweschke | 2006-09-28 11:18:05 -0400 (Thu, 28 Sep 2006) | 3 lines
Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:32:48 +00:00
4a50548ab2
Merged revisions 43864 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r43864 | bweschke | 2006-09-28 09:24:10 -0400 (Thu, 28 Sep 2006) | 3 lines
Autopause not working for queue members. (#8042 - jmls reported and patch)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 13:35:04 +00:00
Russell Bryant
Jason Parker
Joshua Colp
Olle Johansson
Kevin P. Fleming
Luigi Rizzo
Tilghman Lesher
BJ Weschke
Matt O'Gorman