Commit Graph

20232 Commits

Author SHA1 Message Date
Jean Galarneau e533a48c16 Merged revisions 277906 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277906 | jeang | 2010-07-19 15:16:36 -0500 (Mon, 19 Jul 2010) | 7 lines
  
  Avoid trying to pickup a parked extension before the park operation is completed.
  
  A crash could occur if the extension is picked up while the parking extension is
  being announced. Testing pu->notquiteyet while searching for a parked extension
  resolves this crash.
  
  (ABE-2418)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277945 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-19 21:07:08 +00:00
Mark Michelson cb5892bb67 Fix port setting of external address in SIP.
There are two changes here:

1. Since the externip setting can now have a port attached
to it, calling it "externip" is misleading. The option is now
documented and parsed as "externaddr." This also extends to the
"matchexterniplocally" setting. It is now documented and parsed
as "matchexternaddrlocally." The old names for the options may
still be used, but they are no longer used in the sip.conf.sample
file.

2. If no port is set for the externaddr, and UDP is the transport
to be used, then we will set the port of the externaddr to that of
the udpbindaddr. This was how things worked prior to the IPv6 merge,
so this is a regression fix.

(closes issue #17665)
Reported by: mmichelson
Patches: 
      17665.diff#2 uploaded by pprindeville (license 347)
Tested by: pprindeville



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277873 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-19 17:16:23 +00:00
Mark Michelson d6cc7dd982 Remove the fe80🔢:1234 test case from test_acl.c
The ACL test was failing on Mac OS X because it would
convert the above invalid link-local address into
fe80::1234 while reporting no error from getaddrinfo().
Linux does not do this.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-19 17:10:00 +00:00
Jeff Peeler 58061391a1 Fix regression with distinctive ring detection.
The issue here is that passing an array to a function prohibits the ARRAY_LEN
macro from returning the real size. To avoid this the size is now defined and
use of ARRAY_LEN is avoided.

(closes issue #15718)
Reported by: alecdavis
Patches: 
      bug15718.patch uploaded by jpeeler (license 325)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277837 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-19 14:39:07 +00:00
Mark Michelson 6fa79e8f77 Make ACLs IPv6-capable.
ACLs can now be configured to match IPv6 networks. This is only
relevant for ACLs in chan_sip for now since other channel drivers
do not support IPv6 addressing. However, once those channel drivers
are outfitted to support IPv6 addressing, the ACLs will already be
ready for IPv6 support.

https://reviewboard.asterisk.org/r/791



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-19 14:17:16 +00:00
Tilghman Lesher 76d4bbacd1 Merged revisions 277738 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277738 | tilghman | 2010-07-17 11:59:11 -0500 (Sat, 17 Jul 2010) | 5 lines
  
  Remove uclibc cross-compile triplet, as uclibc has a working fork()... it's only uclinux that does not.
  
  (closes issue #17616)
   Reported by: pprindeville
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-17 17:42:32 +00:00
Tilghman Lesher a7c92fad28 Merged revisions 277568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277568 | tilghman | 2010-07-16 16:54:29 -0500 (Fri, 16 Jul 2010) | 8 lines
  
  Since we split values at the semicolon, we should store values with a semicolon as an encoded value.
  
  (closes issue #17369)
   Reported by: gkservice
   Patches: 
         20100625__issue17369.diff.txt uploaded by tilghman (license 14)
   Tested by: tilghman
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-17 17:39:28 +00:00
Russell Bryant e5c4c90064 Allow xmllint to be used for XML docs validation.
xmllint seems to be more commonly available since it comes with libxml2.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277703 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-17 13:10:47 +00:00
Bradley Latus c0607e02b5 Update res_fax.c to be a good xml citizen.
(closes issues #17667)
 Reported by: snuffy


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-17 00:03:37 +00:00
Tim Ringenbach 3442f13da4 Merged revisions 277625 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277625 | tringenbach | 2010-07-16 17:43:39 -0500 (Fri, 16 Jul 2010) | 9 lines
  
  Save and restore AST_FLAG_BRIDGE_HANGUP_DONT on attended transfer.
  
  ast_bridge_call() clears AST_FLAG_BRIDGE_HANGUP_DONT. But during an attended
  transfer, ast_bridge_call() is called for a second bridge on the same channel,
  and it clears that flag, which still needs to get set for when the original
  ast_bridge_call() gets control back and checks it.
  
  Review: https://reviewboard.asterisk.org/r/741
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277657 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 23:23:15 +00:00
Matthew Nicholson 5150954d4a Merged revisions 277497 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277497 | mnicholson | 2010-07-16 16:18:38 -0500 (Fri, 16 Jul 2010) | 4 lines
  
  Default to no udptl error correction so that error correction will be disabled in the event that the remote end indicates that they do not support the error correction mode we requested.
  
  FAX-128
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277530 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 21:24:45 +00:00
Jeff Peeler 5b8a8fc6c8 Fix reporting estimated queue hold time.
Just say the number of seconds (after minutes) rather than doing some incorrect
calculation with respect to minutes.

(closes issue #17498)
Reported by: corruptor
Patches: 
      holdesecs_bug.diff uploaded by corruptor (license 253)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277488 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 21:16:08 +00:00
Tilghman Lesher fe9e0e672e Finally, a method that really fixes the assertions in chan_iax2.c related to cancelling lagid.
No, replacing usleep(1) with sched_yield() did not have an effect.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 20:35:28 +00:00
Richard Mudgett 34bc4b1dcb Merged revisions 277419 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277419 | rmudgett | 2010-07-16 15:18:54 -0500 (Fri, 16 Jul 2010) | 15 lines
  
  priexclusive in chan_dahdi.conf ignored when reloading dahdi module
  
  During a reload, the priexclusive and outsignalling parameters are not
  read in from the config file as intended.  Unfortunately, they get set to
  defaults as a result.  This patch makes sure that they do not get set to
  defaults during a reload.
  
  (closes issue #17441)
  Reported by: mtryfoss
  Patches:
        issue17441_v1.4.patch uploaded by rmudgett (license 664)
        issue17441_v1.6.2.patch uploaded by rmudgett (license 664)
        issue17441_trunk.patch uploaded by rmudgett (license 664)
  Tested by: rmudgett
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 20:27:51 +00:00
Tilghman Lesher f12afaaebc Add documentation for MOH realtime fields
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277452 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 20:25:11 +00:00
Matthew Nicholson 1fd618de5b updated devicestate test for device state changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277409 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 19:32:10 +00:00
Jeff Peeler b73c1377e5 Add missing handling for ringing state for use with queue empty options.
(closes issue #17471)
Reported by: jazzy
Patches: 
      app_queue.c.diff uploaded by jazzy (license 1056)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 19:22:49 +00:00
Matthew Nicholson 1c848835aa Merged revisions 277327 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277327 | mnicholson | 2010-07-16 13:30:22 -0500 (Fri, 16 Jul 2010) | 8 lines
  
  Interpret device state AST_DEVICE_UNKNOWN as extension state AST_EXTENSION_NOT_INUSE.
  
  (closes issue #16035)
  Reported by: francesco_r
  Patches:
        pbx.c.patch uploaded by viniciusfontes (license 978)
  Tested by: francesco_r, agx, lawbar
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277331 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 18:31:08 +00:00
Tilghman Lesher d72336e83f Merged revisions 277261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277261 | tilghman | 2010-07-16 13:04:11 -0500 (Fri, 16 Jul 2010) | 5 lines
  
  If variable gotten is not set, will segfault on Solaris.
  
  (closes issue #17636)
   Reported by: bklang
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 18:14:05 +00:00
Matthew Nicholson e16a5e4727 Print f->subclass.integer instead of f->subclass.
(fix build breakage introduced in r277250)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 18:05:01 +00:00
Matthew Nicholson d787ccff35 Merged revisions 277247 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277247 | mnicholson | 2010-07-16 12:29:57 -0500 (Fri, 16 Jul 2010) | 4 lines
  
  For pass through DTMF tones, measure the actual duration between the begin and end packets on the wire.  If it is detected to be less than AST_MIN_DTMF_DURATION, trigger dtmf emulation.
  
  AST-362
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 17:30:39 +00:00
Paul Belanger 8eb9e0b938 Merged revisions 277182 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277182 | pabelanger | 2010-07-16 13:10:36 -0400 (Fri, 16 Jul 2010) | 8 lines
  
  Total analysis time error with SIP and silence suppression
  
  When using app_amd with SIP providers that have silence
  suppression on, the iTotalTime count increases exponentially.
  
  (closes issue #17656)
  Reported by: juls
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 17:13:46 +00:00
Mark Michelson 2289649901 Fix up some weird indentation problems in reqresp_parser.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 16:25:01 +00:00
Sean Bright 215fb1ab9f Avoid crashing when installing a duplicate translation path with a lower cost.
(closes issue #17092)
Reported by: moy
Patches:
      translate.rev254273.patch uploaded by moy (license 222)
Tested by: moy


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277143 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 15:20:40 +00:00
Eliel C. Sardanons 0bb1fbb540 Add Despegar.com (my main sponsor) to the CREDITS file.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 13:40:30 +00:00
Olle Johansson 5a1ed1f070 Formatting changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 13:32:22 +00:00
Olle Johansson 93373d7bdf Formatting fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 13:10:24 +00:00
Olle Johansson a3dd1d2188 Clarify syntax changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 12:13:45 +00:00
Olle Johansson fcae566e94 Adding a few more to the list of CREDITS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@277027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 11:45:05 +00:00
Olle Johansson cbe0a6dc02 Formatting changes (guideline corrections)
Found a unused bag of curly brackets under my table. I always wondered where 
they had gone. They where indeed needed in chan_sip.c


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 10:31:42 +00:00
Olle Johansson 8c0ab98786 Adding a few more credits
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 10:08:45 +00:00
Olle Johansson e129b31fc6 Add ability to configure the Max-Forwards header in the dialplan, as well as in
sip.conf configuration for the channel and for devices.

The Max-Forwards header is used to prevent loops in a SIP network. Each intermediary,
like SIP proxys and SBCs, decrement this counter and detects when it reaches zero,
at which point the SIP request is nicely killed in a SIP-friendly way.

Review: https://reviewboard.asterisk.org/r/778/

Thanks to dvossel for the review and good advice.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 10:00:58 +00:00
Olle Johansson 65203b12dd Add a dialplan function to check if a queue exists: QUEUE_EXISTS
Review: https://reviewboard.asterisk.org/r/777/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 09:25:48 +00:00
Tilghman Lesher 7515e03c8b And yet one more
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276911 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 06:04:22 +00:00
Tilghman Lesher be7fbdf25d "Item may be used uninitialized in this function."
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 05:59:11 +00:00
Mark Michelson dfba265a0b Fix reversed logic of if statement.
Found based on message from Philip Prindeville on the
Asterisk Developers mailing list.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 05:42:24 +00:00
Tilghman Lesher a76c8e36f5 Detect the --dynamic-list flag a bit better
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 05:38:06 +00:00
Tilghman Lesher 0ab4420d66 Fix build on FreeBSD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 04:45:33 +00:00
Tilghman Lesher e990f89a0e Fix trunk build for Mac OS X 10.6
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 04:23:02 +00:00
Tilghman Lesher 3cd3824171 Allow ipaddress to contain the maximum IPv6 address.
Also, update meetme to the full list of supported fields.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-16 04:18:58 +00:00
Tilghman Lesher 3299f13d94 Quote AC_SUBST within m4_ifval, so it does not get prematurely expanded.
(closes issue #17654)
 Reported by: pprindeville
 Patches: 
       issue17654.diff uploaded by qwell (license 4)
 Tested by: qwell, pprindeville


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 23:25:09 +00:00
Jeff Peeler 44ae0033be Correct not setting the bindport before attempting to open the socket.
Related to changes from 276571, I was accidentally testing with a port set in
my configuration causing me to miss this. Also moved the TCP handling as well
to occur before build_peer is called.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 20:21:03 +00:00
Tilghman Lesher 753fa3b278 Define LLONG_MAX on systems that do not have it.
(closes issue #17644)
 Reported by: pprindeville


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276769 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 19:46:57 +00:00
Tilghman Lesher e2ff55122d Fix linking asterisk on CentOS 5, which is using gcc 4.1.1. Gcc 4.1.2 has the real fix.
Review: https://reviewboard.asterisk.org/r/790/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 18:44:20 +00:00
Jeff Peeler e7591ab428 Merged revisions 276652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r276652 | jpeeler | 2010-07-15 08:48:58 -0500 (Thu, 15 Jul 2010) | 2 lines
  
  In a perfect world, the frame source would never be NULL. In the meantime, don't crash when it is.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 13:51:11 +00:00
Russell Bryant 9778856a03 Add lua5.1 to the handy dandy list of packages.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-15 12:21:10 +00:00
Jeff Peeler 2b2a6123de Fix MWI notification transmission problems over SIP.
MWI updates were not being sent if no messages were found in the event cache.
This was corrected since a phone may need to clear its MWI status configured
previously from another mailbox.

Upon module or sip reload, MWI updates could not be sent due to the sipsock
socket not being set early enough in reload_config. The code handling the
descriptor assignment and such has simply been moved before the call to
build_peer.

Issuing a sip reload cleared the IP address of the peer, but skipped checking
the database for registration information. The database is now checked both
for sip reload and actually reloading the module.

If a transmission occurs before the do_monitor thread has started, do not
attempt to send a signal to it.

(closes issue #17398)
Reported by: ip-rob


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-14 22:58:24 +00:00
Mark Michelson 1e8c66e749 Fix errors where incorrect address information was printed.
ast_sockaddr_stringiy_fmt (which is call by all ast_sockaddr_stringify* functions)
uses thread-local storage for storing the string that it creates. In cases where
ast_sockaddr_stringify_fmt was being called twice within the same statement, the
result of one call would be overwritten by the result of the other call. This
usually was happening in printf-like statements and was resulting in the same
stringified addressed being printed twice instead of two separate addresses.

I have fixed this by using ast_strdupa on the result of stringify functions if
they are used twice within the same statement. As far as I could tell, there were
no instances where a pointer to the result of such a call were saved anywhere, so
this is the only situation I could see where this error could occur.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-14 22:32:29 +00:00
Richard Mudgett 5d9aa45721 Make compile again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276531 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-14 21:29:32 +00:00
Tilghman Lesher 4c94d1ee23 Oops, merge reverted this fix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-14 21:11:09 +00:00