Commit Graph

15398 Commits

Author SHA1 Message Date
Mark Michelson f10440a35f Prevent crashes from occurring due to a strcmp of a NULL pointer.
(closes issue #12661)
Reported by: jaroth
Patches:
      urgentcompare.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 15:13:11 +00:00
Luigi Rizzo 18065a175d Use casts or intermediate variables to remove a number
of platform/compiler-dependent warnings when handing
struct timeval fields, both reading and printing them.

It is a lost battle to handle the different ways struct timeval
is handled on the various platforms and compilers, so try
to be pragmatic and go through int/long which are universally
supported.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116557 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 10:56:29 +00:00
Mark Michelson 193d16cbde Adding a new option to Chanspy(). The 'd' option allows for the spy to
press DTMF digits to switch between spying modes. Pressing 4 activates spy mode,
pressing 5 activates whisper mode, and pressing 6 activates barge mode. Use of
this feature overrides the normal operation of DTMF numbers. 

This feature is courtesy of Switchvox.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 22:15:12 +00:00
Joshua Colp 46423f6e09 Fix pedanticness.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:54:03 +00:00
Russell Bryant 08f91c1192 Merged revisions 116463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116463 | russell | 2008-05-14 16:32:00 -0500 (Wed, 14 May 2008) | 4 lines

Add ast_assert(), which can be used to handle fatal errors.  It is only compiled
in if dev-mode is enabled, and only aborts if DO_CRASH is defined.
(inspired by issue #12650)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:40:43 +00:00
Tilghman Lesher c51989a309 Merged revisions 116466 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116466 | tilghman | 2008-05-14 16:38:09 -0500 (Wed, 14 May 2008) | 7 lines

Avoid zombies when the channel exits before the AGI.
(closes issue #12648)
 Reported by: gkloepfer
 Patches: 
       20080514__bug12648.diff.txt uploaded by Corydon76 (license 14)
 Tested by: gkloepfer

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:39:06 +00:00
Joshua Colp 0d85a0eff7 Add a missing context unlock.
(closes issue #12649)
Reported by: ys
Patches:
      pbx.c.diff uploaded by ys (license 281)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:11:49 +00:00
Jason Parker 424a7816ea Merged revisions 116409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116409 | qwell | 2008-05-14 15:43:08 -0500 (Wed, 14 May 2008) | 1 line

Document exitcontext in app_voicemail sample config
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 20:43:26 +00:00
Jason Parker 8340b21c1d Voicemail "* exit" should not require an exitcontext to be specified.
The behavior in 1.4 was that it would use the current context if an exitcontext existed.

(closes issue #12605)
Reported by: kenjreno
Patches:
      12605-starexit.diff uploaded by qwell (license 4)
Tested by: file


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 20:36:55 +00:00
Joshua Colp 5ec16b6d6b Merged revisions 116352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116352 | file | 2008-05-14 15:53:39 -0300 (Wed, 14 May 2008) | 4 lines

Add linux-gnueabi in.
(closes issue #12529)
Reported by: tzafrir

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 18:54:16 +00:00
Joshua Colp ac876a8e4e Make the ldap version setting work without having both version and protocol set.
(closes issue #12613)
Reported by: suretec


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 18:25:54 +00:00
Tilghman Lesher c15ed0f3f6 Merged revisions 116296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116296 | tilghman | 2008-05-14 11:46:48 -0500 (Wed, 14 May 2008) | 2 lines

Detect another way for a connection to have gone away.
(closes issue #12618)
 Reported by: ctooley
 Patches: 
       1.4-externalivr-test_fd.diff uploaded by ctooley (license 136)
       trunk-externalivr-test_fd.diff uploaded by ctooley (license 136)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 16:53:23 +00:00
Jeff Peeler 4729632721 Fixed a few problems with multiparking: call not being parked in the correct parking spot, caller not being notified of parking spot position, and improperly hanging up the call during a transfer due to timing out (not providing the extension in which to transfer).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 16:52:30 +00:00
Olle Johansson eecea3268e Don't add linefeed on received MESSAGE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 14:16:51 +00:00
Olle Johansson f07454f25d Properly declare charset for text messages.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 14:03:42 +00:00
Olle Johansson bb386c84e7 Adding spport for T.140 RED - Simple RTP redundancy to prevent packet loss in text stream
Work sponsored by Omnitor AB, Stockholm, Sweden (http://www.omnitor.se)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 13:37:07 +00:00
Olle Johansson 47bf217ee8 Merged revisions 116230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116230 | oej | 2008-05-14 14:51:06 +0200 (Ons, 14 Maj 2008) | 3 lines

Accept text messages even with
Content-Type: text/plain;charset=Södermanländska

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 13:05:15 +00:00
Olle Johansson 29b1d73567 Add support for codec settings in originate via call file and manager.
This is to enable video and text in originated calls. Development sponsored
by Omnitor AB, Sweden. (http://www.omnitor.se)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116229 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 12:32:57 +00:00
Olle Johansson e4c544cd5a Formatting changes (coding guidelines) while thinking about something else...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116224 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 11:51:09 +00:00
Olle Johansson 9c2956a3b0 Reformatting
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 11:37:21 +00:00
Olle Johansson 615ed013d3 Adding comments
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 11:32:05 +00:00
Olle Johansson cc6d4100ad Doxygen formatting change only
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 08:16:25 +00:00
Mark Michelson 0ebec7fa4f Undo inadvertent changes to chan_skinny caused by the merging of urgent messaging
support.

Thanks to Damien Wedhorn for pointing out the problem.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116138 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 00:20:05 +00:00
Mark Michelson b6aef57619 Merged revisions 116088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116088 | mmichelson | 2008-05-13 18:47:49 -0500 (Tue, 13 May 2008) | 12 lines

A change to the way channel locks are handled when DEBUG_CHANNEL_LOCKS is defined.

After debugging a deadlock, it was noticed that when DEBUG_CHANNEL_LOCKS
is enabled in menuselect, the actual origin of channel locks is obscured
by the fact that all channel locks appear to happen in the function
ast_channel_lock(). This code change redefines ast_channel_lock to be a
macro which maps to __ast_channel_lock(), which then relays the proper
file name, line number, and function name information to the core lock
functions so that this information will be displayed in the case that
there is some sort of locking error or core show locks is issued.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 23:54:01 +00:00
Russell Bryant 739a3c88a5 Merged revisions 116038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116038 | russell | 2008-05-13 16:17:23 -0500 (Tue, 13 May 2008) | 24 lines

Fix a deadlock involving channel autoservice and chan_local that was debugged
and fixed by mmichelson and me.

We observed a system that had a bunch of threads stuck in ast_autoservice_stop().
The reason these threads were waiting around is because this function waits to
ensure that the channel list in the autoservice thread gets rebuilt before the
stop() function returns.  However, the autoservice thread was also locked, so
the autoservice channel list was never getting rebuilt.

The autoservice thread was stuck waiting for the channel lock on a local channel.
However, the local channel was locked by a thread that was stuck in the autoservice
stop function.

It turned out that the issue came down to the local_queue_frame() function in
chan_local.  This function assumed that one of the channels passed in as an
argument was locked when called.  However, that was not always the case.  There
were multiple cases in which this channel was not locked when the function was
called.  We fixed up chan_local to indicate to this function whether this channel
was locked or not.  The previous assumption had caused local_queue_frame() to
improperly return with the channel locked, where it would then never get unlocked.

(closes issue #12584)
(related to issue #12603)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 21:18:55 +00:00
Russell Bryant 8e4c0e85d8 Merged revisions 115990 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115990 | russell | 2008-05-13 16:05:57 -0500 (Tue, 13 May 2008) | 5 lines

Fix an issue that I noticed in autoservice while mmichelson and I were debugging
a different problem.  I noticed that it was theoretically possible for two threads
to attempt to start the autoservice thread at the same time.  This change makes the
process of starting the autoservice thread, thread-safe.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116001 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 21:07:59 +00:00
Joshua Colp 8d18723961 Merged revisions 115944 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115944 | file | 2008-05-13 17:28:23 -0300 (Tue, 13 May 2008) | 4 lines

Use the right flag to open the audio in non-blocking.
(closes issue #12616)
Reported by: nicklewisdigiumuser

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115945 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 20:29:27 +00:00
Matthew Fredrickson a439ea6fe2 Need to clear calling_party_cat variable after we retrieve it
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 20:18:04 +00:00
Matthew Fredrickson df175cebc3 Add support for receiving calling party category
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 20:11:20 +00:00
Tilghman Lesher 99cad5bf49 Merged revisions 115884 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115884 | tilghman | 2008-05-13 13:36:13 -0500 (Tue, 13 May 2008) | 3 lines

If the socket dies (read returns 0=EOF), return immediately.
(Closes issue #12637)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 18:38:11 +00:00
Russell Bryant ea3fb96b29 Re-introduce proper error handling that was removed in recent commits.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 17:42:17 +00:00
Russell Bryant dcbc0aab3f Initialize the start time in smdi_msg_wait. Somehow this code got lost in trunk.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-13 17:14:22 +00:00
Tilghman Lesher 8722b3b5ae Add a script which installs every package needed for a Debian install of
Asterisk, and includes possible support (to be contributed) for various other
distributions.
(closes issue #10523)
 Reported by: tzafrir
 Patches: 
       install_prereq_2 uploaded by tzafrir (license 46)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115813 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-12 20:34:38 +00:00
Olle Johansson e30c26c689 Add support for playing an audio file for caller and callee at start and stop of monitoring (one-touch monitor).
Keep messages short, since the other party is waiting while one party hear the message...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-12 18:39:09 +00:00
Mark Michelson 2e054642d5 Merged revisions 115735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115735 | mmichelson | 2008-05-12 12:51:14 -0500 (Mon, 12 May 2008) | 7 lines

If a thread holds no locks, do not print any information on the thread when issuing
a core show locks command. This will help to de-clutter output somewhat.

Russell said it would be fine to place this improvement in the 1.4 branch, so that's
why it's going here too.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-12 17:55:08 +00:00
Jason Parker e785520eb9 Correctly document state interface for AddQueueMember. Discovered while looking at issue #12626.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-12 16:35:50 +00:00
Brett Bryant 9575b82389 A small change to fix iax2 native bridging.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-12 15:17:32 +00:00
Matthew Fredrickson 5e3d36e4aa Add Zap MTP2 support to chan_zap
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-11 03:23:05 +00:00
Matthew Fredrickson 1a492c49d4 Open up audio channel when we get ACM on SS7 event
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-11 02:19:21 +00:00
Tilghman Lesher 0c08b7727d Ensure that "calldate" is acceptable for a column name.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-10 14:19:41 +00:00
Claude Patry 485b1d9be1 fix a sample since we now required , and not | for the arguments separator
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-10 03:30:59 +00:00
Claude Patry dfe475cc59 ameliorate load and unload to dont use DECLINED or FAILED, when theres no .conf involved.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-10 03:28:50 +00:00
Claude Patry df1912cd4f since we unregister, that has not been properly registered, i standardized this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-10 03:04:25 +00:00
Mark Michelson 93e84a7d76 Remove a debug line
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115591 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 22:36:50 +00:00
Mark Michelson 7daebcd610 Adding support for "urgent" voicemail messages. Messages which are
marked "urgent" are considered to be higher priority than other messages
and so they will be played before any other messages in a user's mailbox.

There are two ways to leave an urgent message. 
1. send the 'U' option to VoiceMail().
2. Set review=yes in voicemail.conf. This will give instructions for 
   a caller to mark a message as urgent after the message has been recorded.

I have tested that this works correctly with file and ODBC storage, and James
Rothenberger (who wrote initial support for this feature) has tested its use
with IMAP storage.

(closes issue #11817)
Reported by: jaroth
	Based on branch http://svn.digium.com/svn/asterisk/team/jrothenberger/asterisk-urgent
Tested by: putnopvut, jaroth



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 21:22:42 +00:00
Brett Bryant 59817ce0d8 Update CHANGES file for previous commit of ENUM and TXCIDNAME changes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115586 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 20:05:50 +00:00
Brett Bryant 65b8381550 The following patch adds new options and alters the default behavior of the ENUM* functions. The TXCIDNAME lookup function has also gotten a
new paramater. The new options for ENUM* functions include 'u', 's', 'i', and 'd' which return the full uri, trigger isn specific rewriting, look 
for branches into an infrastructure enum tree, or do a direct dns lookup of a number respectively. The new paramater for TXCIDNAME adds a 
zone-suffix argument for looking up caller id's in DNS that aren't e164.arpa.

This patch is based on the original code from otmar, modified by snuffy, and tested by jtodd, me, and others.

(closes issue #8089)
Reported by: otmar
Patches:
      20080508_bug8089-1.diff 
	- original code by otmar (license 480), 
	- revised by snuffy (license 35)
Tested by: oej, otmar, jtodd, Corydon76, snuffy, alexnikolov, bbryant


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 19:54:45 +00:00
Tilghman Lesher 8b1d52c9a5 Allow a password change to be validated by an external script.
(closes issue #12090)
 Reported by: jaroth
 Patches: 
       vm-check-newpassword.diff.txt uploaded by mvanbaak (license 7)
       20080509__bug12090.diff.txt uploaded by Corydon76 (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 17:28:06 +00:00
Joshua Colp ea483db47a Merged revisions 115579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115579 | file | 2008-05-09 13:34:08 -0300 (Fri, 09 May 2008) | 2 lines

Improve res_ninit and res_ndestroy autoconf logic on the Darwin platform.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-09 16:36:58 +00:00
Russell Bryant b280054c38 Merged revisions 115568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115568 | russell | 2008-05-08 14:19:50 -0500 (Thu, 08 May 2008) | 2 lines

Remove debug output.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-08 19:20:35 +00:00