Commit Graph

15835 Commits

Author SHA1 Message Date
Olle Johansson f99a310219 Make sure we stop session timers as soon as we start hanging up an active call.
May fix issue 12919.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:48:23 +00:00
Olle Johansson 2491cc6e65 Revert some logic for session timers. We do send in-dialog requests that should not have session-timer
require headers, like MESSAGE and REFER. So in the future, only add them on requests and responses
that are related to INVITEs and re-INVITEs.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:25:59 +00:00
Kevin P. Fleming e99eece42a some minor fixes found while working on issue #12911 (and block the rev from 1.4 since the equivalent is already here)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127767 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:22:02 +00:00
Mark Michelson e4c93fc8c3 Added a new option, "timeoutpriority" to queues.conf. A detailed
explanation of the change may be found in configs/queues.conf.sample

(closes issue #12690)
Reported by: atis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 14:34:25 +00:00
Olle Johansson b423a939b0 Fix bad formatting in a very confusing function. Who added the sipdb sql output?
It's mixing peers and users in a strange way and should really not be a CLI command,
since it's not meant for human output. It should be done with an app connecting to
manager.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 09:59:12 +00:00
Tilghman Lesher 267b9d4eb4 Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 22:17:37 +00:00
Brett Bryant 6aa9419cfe Update transport= in sip so that the option is not broken from a recent commit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127621 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 22:16:29 +00:00
Tilghman Lesher 885d17506b Keep ast_app_inboxcount API compatible with 1.6.0.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 21:27:53 +00:00
Mark Michelson 55e4daef88 Add a janitor project to use ARRAY_LEN instead of in-line
sizeof() and division.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 21:09:18 +00:00
Tilghman Lesher 3a27a6a9e7 Fix some crashlike bugs because flag could be NULL in play_record_review().
(Closes issue #12892)
Reported by: jaroth
Patch originally by jaroth, fixed by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 20:52:27 +00:00
Mark Michelson 1d6573e8ef Merged revisions 127560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127560 | mmichelson | 2008-07-02 15:47:38 -0500 (Wed, 02 Jul 2008) | 3 lines

Fix thread-safety of some of the pbx_builtin_getvar_helper calls


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 20:49:08 +00:00
Mark Michelson 953947b70b The ackcall and endcall options in agents.conf now have supplemental options
acceptdtmf and enddtmf. These allow for the DTMF pressed to be configurable
instead of being hardcoded to '#' and '*'.

(AST-86)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 20:43:55 +00:00
Terry Wilson a32369fcd5 Expose the prefix variable so that it can be used by modules depending on http support
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 20:28:17 +00:00
Tilghman Lesher dea559d7da Blocked revisions 127501 via svnmerge
................
r127501 | tilghman | 2008-07-02 14:47:15 -0500 (Wed, 02 Jul 2008) | 14 lines

Merged revisions 127466 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
r127466 | tilghman | 2008-07-02 13:31:11 -0500 (Wed, 02 Jul 2008) | 6 lines

Solaris fix
(closes issue #12949)
 Reported by: snuffy
 Patches: 
       bug_12949.diff uploaded by snuffy (license 35)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 19:47:50 +00:00
Tilghman Lesher 1bb7334fef Solaris fix
(closes issue #12949)
 Reported by: snuffy
 Patches: 
       bug_12949.diff uploaded by snuffy (license 35)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 18:31:11 +00:00
Brett Bryant b30ed551e0 Fix to sip_parse_host so that it passes the correct information to sip_registry.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 17:27:36 +00:00
Russell Bryant 3cf77c4c7f Fix a bunch of places where \arg was used instead of \param. Using \arg
to document arguments seems logical, and does work, but is not the best
thing to use.

\arg in doxygen is simply for creating non-nested unordered lists.  \param is
the correct tag to use to document function parameters, and will come out
better in the generated documentation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 14:50:45 +00:00
Sean Bright 097ac98034 Fix a bug I noticed while doing the previous merge
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127398 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 14:30:09 +00:00
Russell Bryant 604b819b1c Add a locking section to the coding guidelines document.
This section covers some locking fundamentals, as well as some information on
locking as it is used in Asterisk.  It describes some of the ways that are used
and could be used to achieve deadlock avoidance.  It also demonstrates the
unfortunate conclusion that with the use of recursive locks, none of the
constructs in use today are failsafe from deadlocks.  Finally, it makes some
recommendations for new code being written.  As proper locking strategies is a
complex subject, this section still has room for expansion and improvement.

This is a result of collaboration between Luigi Rizzo and myself on the 
asterisk-dev mailing list.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 12:08:33 +00:00
Luigi Rizzo 8cd40e3950 plug another panic when the gui cannot be started.
We can still send video, just don't try to use what is not available.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127362 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 12:06:48 +00:00
Luigi Rizzo f26e7b97cb prevent a segfault when trying to start the gui without any
specific configuration in oss.conf
(reported by Klaus Darillion on the -video mailing list).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 09:16:29 +00:00
Tilghman Lesher cce1ec5463 Change the global timer B to be dependent on the value of the T1 timer, as
recommended in RFC 3261, instead of being hardcoded to 32 seconds.  This is
important for LANs, as it allows autocongestion to occur much more quickly, if
desired by the local PBX administrator.  It also corrects a bug: if the T1
timer was increased beyond 500ms, then timer B would have been set at a much
lower value than recommended.
(closes issue #12544)
 Reported by: kactus
 Patches: 
       20080616__bug12544.diff.txt uploaded by Corydon76 (license 14)
 Tested by: kactus


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 02:48:43 +00:00
Mark Michelson 13a81dd7ae Merged revisions 127244 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127244 | mmichelson | 2008-07-01 18:36:40 -0500 (Tue, 01 Jul 2008) | 5 lines

Add error message to failed open(2) calls inside the copy() function of
app_voicemail. This idea came as part of my work in helping to resolve
issue #12764.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 23:38:12 +00:00
Russell Bryant 90f7ad4869 Add a \todo
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:43:55 +00:00
Tilghman Lesher 638a720eee Add AMI events for start/stop of MOH
(closes issue #12909)
 Reported by: chris-mac
 Patches: 
       res_musiconhold-event.patch uploaded by chris-mac (license 506)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:21:26 +00:00
Mark Michelson 37db658b1f Place the delay in __ast_answer prior to the channel-specific answer
callback. This change differs from commit 127113 in that now the 
channel is not set to AST_STATE_UP until after the answer callback.

(closes issue #12924)
Reported by: snyfer



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:16:00 +00:00
Brett Bryant 1b07e87538 Add a configuration option so the global outboundproxy can use tcptls without it being defined by each sip user.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:03:52 +00:00
Jason Parker 38519b5f5e Fix a typo that caused this asterisk.conf to not get correctly generated.
(closes issue #12966)
Reported by: ibc
Patches:
      12966.patch uploaded by bkruse (license 132)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 20:51:43 +00:00
Tilghman Lesher e347f8bc70 Merged revisions 127133 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127133 | tilghman | 2008-07-01 15:25:37 -0500 (Tue, 01 Jul 2008) | 2 lines

Disable the old, slow search for matching callno in chan_iax2 (but allow it to be reenabled for debugging)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127143 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 20:28:54 +00:00
Kevin P. Fleming 8cdb1f7f41 change the process of inserting a delay into the ast_answer() path so that we don't tell the calling channel that it has been answered unutil after the delay; for a single-thread call this won't matter all, but for a dual-thread call (using chan_local) this may fix the problem in issue 12924
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 19:53:03 +00:00
Tilghman Lesher cfb8fb7e43 Blocked revisions 127069 via svnmerge
........
r127069 | tilghman | 2008-07-01 14:05:28 -0500 (Tue, 01 Jul 2008) | 2 lines

Oops

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 19:24:29 +00:00
Tilghman Lesher 3217aed39c Merged revisions 127068 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127068 | tilghman | 2008-07-01 13:52:53 -0500 (Tue, 01 Jul 2008) | 8 lines

Change around how we schedule pings and lagrqs, and fix a reason why the
jobs were not getting properly cancelled.
(closes issue #12903)
 Reported by: stevedavies
 Patches: 
       20080620__bug12903__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: stevedavies

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127074 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 19:20:25 +00:00
Kevin P. Fleming 00696f5f37 make the AIS checking a little more generic, and have a more useful configure script command line option for OpenAIS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127017 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 17:22:47 +00:00
Tilghman Lesher 6fa1dab33d Merged revisions 126999 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126999 | tilghman | 2008-07-01 11:50:46 -0500 (Tue, 01 Jul 2008) | 2 lines

Suppress annoying warning by finding the remaining cases where the callno is not in the hash.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127000 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 16:52:29 +00:00
Luigi Rizzo 46c3a53739 even uglier gui with more buttons
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 16:28:43 +00:00
Kevin P. Fleming da14954bdc another minor ast_channel memory size decrease... for nearly all channels, 'dialcontext' is only going to be set once during the channel's lifetime, so make it a string field instead of a char array
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 16:16:36 +00:00
Luigi Rizzo 52c6ee5155 add documentation on video console support
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 16:14:28 +00:00
Olle Johansson b6b5525347 Merged revisions 126902 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126902 | oej | 2008-07-01 16:59:31 +0200 (Tis, 01 Jul 2008) | 7 lines

Use domain part of SIP uri in register= configuration as fromdomain.

Reported by: one47
Patches: 
      sip-reg-fromdom2.dpatch uploaded by one47 (license 23)
(closes issue #12474)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 15:03:59 +00:00
Olle Johansson f3170a4946 Merged revisions 126899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126899 | oej | 2008-07-01 16:27:33 +0200 (Tis, 01 Jul 2008) | 8 lines

Handle escaped URI's in call pickups. Patch by oej and IgorG.

Reported by: IgorG
Patches: 
      bug12299-11062-v2.patch uploaded by IgorG (license 20)
Tested by: IgorG, oej
(closes issue #12299)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 14:32:15 +00:00
Olle Johansson 1626397996 Merged revisions 126844 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126844 | oej | 2008-07-01 14:53:01 +0200 (Tis, 01 Jul 2008) | 5 lines

Clear up documentation on "domain=" setting in sip.conf

Reported by: davidw
(closes issue #12413)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 12:54:57 +00:00
Luigi Rizzo e2807b69a3 use %p to print a pointer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 12:29:31 +00:00
Olle Johansson 42bed356d1 Merged revisions 126789 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126789 | oej | 2008-07-01 13:51:38 +0200 (Tis, 01 Jul 2008) | 6 lines

Report 200 OK to all in-dialog OPTIONs requests (to confirm that the dialog
exist). Don't bother checking the request URI.

(closes issue #11264)
Reported by: ibc

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 11:58:17 +00:00
Olle Johansson 983b851e3b Merged revisions 126735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126735 | oej | 2008-07-01 09:49:15 +0200 (Tis, 01 Jul 2008) | 7 lines

Fix bad XML for hold notification.
Reported by: gowen72
Patches: 
      hold.patch uploaded by gowen72 (license 432)
(closes issue #12942)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 09:51:22 +00:00
Jeff Peeler 6ca7706e3c Blocked revisions 126680 via svnmerge
........
r126680 | jpeeler | 2008-06-30 18:11:16 -0500 (Mon, 30 Jun 2008) | 3 lines

Load the proper channel configuration file based on which driver was detected.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126681 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 23:11:51 +00:00
Jeff Peeler 8f216ea83a rename zapata.conf.sample to chan_dahdi.conf.sample
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 22:34:08 +00:00
Matthew Fredrickson 5862f66c88 Add support to see MTP2 down events when the link layer drops in SS7
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 20:25:46 +00:00
Russell Bryant 6f58a4f63a Merged revisions 126573 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126573 | russell | 2008-06-30 11:05:08 -0500 (Mon, 30 Jun 2008) | 10 lines

Fix a typo in the non-DEBUG_THREADS version of the recently added DEADLOCK_AVOIDANCE()
macro.  This caused the lock to not actually be released, and as a result, not
avoid deadlocks at all.  This resolves the issues reported in the last while about
Asterisk locking up all over the place (and most commonly, in chan_iax2).

(closes issue #12927)
(closes issue #12940)
(closes issue #12925)
(potentially closes others ...)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126574 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 16:07:25 +00:00
Luigi Rizzo ff8ad6b497 implement the 'freeze' function for incoming frames;
fix a bug which caused a crash when a videodevice was
specified after startgui=1 in the config file. This also
involves a slightly different method to determine if the
gui is active or not.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 15:45:15 +00:00
Luigi Rizzo f55143f0a6 fix an uninitialized variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 15:44:50 +00:00
Olle Johansson 33a54ee23b The following patch with some changes for trunk...
Merged revisions 126516 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126516 | oej | 2008-06-30 14:50:55 +0200 (MÃ¥n, 30 Jun 2008) | 10 lines

Send all responses to an INVITE reliably, so that we retransmit if we don't get an ACK and
also fail if we don't get the very same precious ACK. Based on patch by tsearle, with
my own additions.

(closes issue #12951)

Reported by: tsearle
Patches: 
      busy_retransmit.patch uploaded by tsearle (license 373)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 13:03:53 +00:00