Commit graph

15835 commits

Author SHA1 Message Date
Russell Bryant
e64aaf24b0 Merged revisions 117514 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117514 | russell | 2008-05-21 13:28:46 -0500 (Wed, 21 May 2008) | 4 lines

Don't filter the magic character in the network verboser.  It gets filtered
once it reaches the client.
(related to issue #12702, pointed out by tilghman)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117515 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 18:29:05 +00:00
Russell Bryant
457dbc1b4f Merged revisions 117507 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117507 | russell | 2008-05-21 13:19:34 -0500 (Wed, 21 May 2008) | 7 lines

1) Don't print the verbose marker in front of every message from ast_verbose()
   being sent to remote consoles.

2) Fix pbx_gtkconsole to filter out the verbose marker.

(related to issue #12702)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 18:20:11 +00:00
Russell Bryant
467b4746ab Merged revisions 117479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117479 | russell | 2008-05-21 13:11:51 -0500 (Wed, 21 May 2008) | 6 lines

Don't display the verbose marker for calls to ast_verbose() that do not include
a VERBOSE_PREFIX in front of the message.
(closes issue #12702)
Reported by: johnlange
Patched by me

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 18:12:19 +00:00
Tilghman Lesher
ffc9f89189 On socket-based connections, there is no error FD, so don't try waiting on one.
(closes issue #12697)
 Reported by: ctooley
 Patches: 
       fix_externalivr_waitfor_nandfds-v3.diff uploaded by ctooley (license 136)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 13:39:41 +00:00
Luigi Rizzo
e1ae86f643 do not die on SDL_ACTIVEEVENT reporting lost focus.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 11:24:50 +00:00
Mark Michelson
46e68c36b6 Be sure that we cache included files for each source file which loads
a configuration file.  As it was, only the first did so. This led to 
a problem if the included file was changed (but not the configuration 
file which includes it) and the second source file attempted to reload 
the configuration. It would not see that the included file had changed.

In this particular example, res_phoneprov and chan_sip both loaded
sip.conf, which included a file call sip.peers.conf. Since res_phoneprov
was the first to load sip.conf, only it cached the fact that sip.conf
included sip.peers.conf. If sip.peers.conf were changed and sip.conf were
not and a sip reload were issued (meaning that chan_sip attempts to 
reload sip.conf only if it and its included files have changed) the changes
made to sip.peers.conf would not be seen and therefore no action would be
taken.

(closes issue #12693)
Reported by: marsosa



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117367 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 02:20:31 +00:00
Steve Murphy
6d16c8915e These changes were made via the comments atis_work made at 4:30am (Mountain Time zone- US)
in #asterisk-dev on 20 May 2008. He noted that a backslash was being inserted before commas
in app call arguments in the extensions.conf.aeldump file that you get from aelparse with the
-w arg. This was being generated from code left over from 1.4, where commas were substituted
with '|', and any remaining commas needed to be escaped.

Many thanks to atis for his comment; please let us know if these changes break anything!




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-21 01:00:28 +00:00
Luigi Rizzo
d5c75ee032 + Implement a variant of astman_get_header() to return the first or
last match, and possibly skip empty fields.  The function is useful
  (and used here) when a form submits multiple 'Action' fields to the
  Manager.

  This change slightly modifies the current behaviour, but only in the
  case the user supplies multiple 'Action: ' lines and the first
  ones are empty, so the change is totally harmless.
 
+ Fix style on a couple of "if (displayconnects)" statements;
 
+ Expand a bit the 'Manager Test' interface, to make it slightly
  more user friendly. But also comment that the HTML should not
  be embedded in the C source.
 
None of this stuff needs to be applied to 1.4.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-20 18:07:24 +00:00
Luigi Rizzo
c7a4899ac4 Document the possible presence of multiple variables with the
same name in http queries, which might confuse the manager.

Replace calls to ast_uri_decode() with a local function that also
replaces '+' with ' ', as this is the normal encoding for
spaces in http requests.
This allows passing cli commands to the manager through the
http interface.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-20 17:48:43 +00:00
Luigi Rizzo
d56a42cb1a Reverse the check for Cookie: and remove leftover code implementing
the same thing.
Add an ast_debug() call to help debugging the url matching.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-20 16:39:39 +00:00
Tilghman Lesher
6353bddc57 Increase limit of unshared connections from 1023 to 4.2 billion.
(Related to issue #12677)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-20 16:25:16 +00:00
Tilghman Lesher
01e2bd1e2f Revert part of previous fix, and heavily comment the logic for object
destruction, for future users.
(Closes issue #12677)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-20 16:13:48 +00:00
Russell Bryant
7d2d373d6f Minor formatting change to test a mantis change ...
(issue #12674)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 20:45:25 +00:00
Tilghman Lesher
fced823c08 Change the default for the pridialplan parameter to the far more common case of
'unknown', and better document the use of each parameter.
(closes issue #12633)
 Reported by: tzafrir
 Patches: 
       pridialplan_unknown_2.diff uploaded by tzafrir (license 46)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 20:06:38 +00:00
Joshua Colp
a5cb416c86 Merged revisions 117135 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117135 | file | 2008-05-19 13:50:52 -0300 (Mon, 19 May 2008) | 6 lines

Use the right pthread lock and condition when waiting.
(closes issue #12664)
Reported by: tomo1657
Patches:
      res_smdi.c.patch uploaded by tomo1657 (license 484)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117136 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 16:53:33 +00:00
Joshua Colp
872eaba11d Remove a premature mutex destroy (the destruction callback will end up destroying it) and use a callback to purge remaining classes.
(closes issue #12677)
Reported by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 16:22:56 +00:00
Tilghman Lesher
452b3e204f Merged revisions 117086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117086 | tilghman | 2008-05-19 11:05:05 -0500 (Mon, 19 May 2008) | 2 lines

The addition of usleep(2) within ast_assert requires the inclusion of the unistd.h header

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 16:07:09 +00:00
Joshua Colp
83e37eaf1c The logger closes the files it is logging to when reloading so we have to read in the logger configuration even if it has not changed so that the logs get opened again.
(closes issue #12665)
Reported by: DennisD


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 16:03:33 +00:00
Luigi Rizzo
775542f753 trap potential failures of SDL when SDL_WINDOWID is pointing to a
random window.

This commit is essentially a workaround for some undesirable behaviour of SDL;
we should not be doing this in the application, but in the library.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117084 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 15:47:46 +00:00
Joshua Colp
0894cae92c Merged revisions 117081 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117081 | file | 2008-05-19 12:22:10 -0300 (Mon, 19 May 2008) | 6 lines

Make chan_h323 work with pwlib 1.12.0
(closes issue #12682)
Reported by: bamby
Patches:
      pwlib_nopipe.diff uploaded by bamby (license 430)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 15:24:44 +00:00
Luigi Rizzo
f0093bfc42 fix example configuration for video support in chan_oss
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 14:54:34 +00:00
Luigi Rizzo
391f5ffcf1 Some fixes to the code to support running on an externally
supplied window.

SDL (at least recent 1.2.x versions) has the ability to run the
graphic output into an externally supplied window, whose ID in the
environment variable SDL_WINDOWID. Ideally, applications should
run unchanged irrespective of who creates the window. Unfortunately,
SDL does not subscribe to mouse, key and resize events on externally
supplied windows, so we need to do ask for these events explicitly.
 
On passing, also add some code to handle SDL_ACTIVEEVENT so if
the X11 window is killed while we are active, we call
"stop now" to terminate the asterisk instance.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 14:22:04 +00:00
Luigi Rizzo
db8475bb4e Allow users to specify 'startgui=1' in oss.conf so that the
graphic screen for the video console is activated at startup.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 13:33:08 +00:00
Russell Bryant
affbbe3bd2 Merged revisions 116978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116978 | russell | 2008-05-18 22:44:04 -0500 (Sun, 18 May 2008) | 4 lines

Avoid access of uninitialized memory.  This caused a bunch of crashes for me
while doing load testing of development branch where I'm working on some
performance improvements.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 03:44:28 +00:00
Tilghman Lesher
edc0591ad5 Add a set of text to the file astcanary uses to communicate back the main
Asterisk process, which explains the purpose for the file being there.  This
should assist people who find the file and wonder why it exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116948 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-18 21:15:58 +00:00
Russell Bryant
29a9d477df Remove duplicate colon on Reason header
(closes issue #12678)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116919 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-18 19:58:10 +00:00
Joshua Colp
4943cbcf2c Improve native transfers when a chain of IAX2 connections are in use.
(closes issue #7567)
Reported by: tjd
Patches:
      bug_7567_update_v2.diff uploaded by snuffy (license 35)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116884 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-17 19:39:35 +00:00
Joshua Colp
30aedbade7 Try to fix attended transfers.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116848 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-16 21:34:45 +00:00
Joshua Colp
df6cd7a879 Merged revisions 116799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116799 | file | 2008-05-16 17:28:11 -0300 (Fri, 16 May 2008) | 4 lines

Check to make sure an RTP structure exists before calling ast_rtp_new_source on it.
(closes issue #12669)
Reported by: sbisker

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-16 20:30:24 +00:00
Matthew Fredrickson
74c9d35cb5 Try to see if we can make our ringback situation a little better
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-16 20:00:04 +00:00
Sean Bright
1e65b27439 Compile under dev-mode, please.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-16 17:08:59 +00:00
Jim Dixon
76707a409c Bring all app_rpt and chan_usbradio stuff up to date
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-16 00:51:14 +00:00
Tilghman Lesher
5168282ba1 Add an extra check in ast_strlen_zero, and make ast_assert() not print the
file, line, and function name twice.
(Closes issue #12650)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 22:05:47 +00:00
Jeff Peeler
f97d547aba Fixes a problem I was having with two SIP phones using Packet2Packet bridging dropping audio nearly immediately. The problem was that the lock on the SIP dialog was not being unlocked while the bridge was still active. (Related to issue #12566)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 21:54:18 +00:00
Tilghman Lesher
1207e9207e Don't unload config on reload, when config has not changed.
(Closes issue #12652)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 17:58:22 +00:00
Mark Michelson
028016b401 When counting urgent messages when using IMAP storage, take into account that
the urgent messages are not in their own folder but are actually "flagged" messages
in the INBOX.


(closes issue #12659)
Reported by: jaroth
Patches:
      urgentfolder_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 15:40:29 +00:00
Mark Michelson
a92223a240 Modify externnotify to take the number of urgent voicemails as a final argument instead
of the string "Urgent" 

(closes issue #12660)
Reported by: jaroth
Patches:
      externnotify.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116592 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 15:24:29 +00:00
Mark Michelson
f10440a35f Prevent crashes from occurring due to a strcmp of a NULL pointer.
(closes issue #12661)
Reported by: jaroth
Patches:
      urgentcompare.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 15:13:11 +00:00
Luigi Rizzo
18065a175d Use casts or intermediate variables to remove a number
of platform/compiler-dependent warnings when handing
struct timeval fields, both reading and printing them.

It is a lost battle to handle the different ways struct timeval
is handled on the various platforms and compilers, so try
to be pragmatic and go through int/long which are universally
supported.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116557 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-15 10:56:29 +00:00
Mark Michelson
193d16cbde Adding a new option to Chanspy(). The 'd' option allows for the spy to
press DTMF digits to switch between spying modes. Pressing 4 activates spy mode,
pressing 5 activates whisper mode, and pressing 6 activates barge mode. Use of
this feature overrides the normal operation of DTMF numbers. 

This feature is courtesy of Switchvox.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 22:15:12 +00:00
Joshua Colp
46423f6e09 Fix pedanticness.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:54:03 +00:00
Russell Bryant
08f91c1192 Merged revisions 116463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116463 | russell | 2008-05-14 16:32:00 -0500 (Wed, 14 May 2008) | 4 lines

Add ast_assert(), which can be used to handle fatal errors.  It is only compiled
in if dev-mode is enabled, and only aborts if DO_CRASH is defined.
(inspired by issue #12650)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:40:43 +00:00
Tilghman Lesher
c51989a309 Merged revisions 116466 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116466 | tilghman | 2008-05-14 16:38:09 -0500 (Wed, 14 May 2008) | 7 lines

Avoid zombies when the channel exits before the AGI.
(closes issue #12648)
 Reported by: gkloepfer
 Patches: 
       20080514__bug12648.diff.txt uploaded by Corydon76 (license 14)
 Tested by: gkloepfer

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:39:06 +00:00
Joshua Colp
0d85a0eff7 Add a missing context unlock.
(closes issue #12649)
Reported by: ys
Patches:
      pbx.c.diff uploaded by ys (license 281)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 21:11:49 +00:00
Jason Parker
424a7816ea Merged revisions 116409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116409 | qwell | 2008-05-14 15:43:08 -0500 (Wed, 14 May 2008) | 1 line

Document exitcontext in app_voicemail sample config
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 20:43:26 +00:00
Jason Parker
8340b21c1d Voicemail "* exit" should not require an exitcontext to be specified.
The behavior in 1.4 was that it would use the current context if an exitcontext existed.

(closes issue #12605)
Reported by: kenjreno
Patches:
      12605-starexit.diff uploaded by qwell (license 4)
Tested by: file


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 20:36:55 +00:00
Joshua Colp
5ec16b6d6b Merged revisions 116352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116352 | file | 2008-05-14 15:53:39 -0300 (Wed, 14 May 2008) | 4 lines

Add linux-gnueabi in.
(closes issue #12529)
Reported by: tzafrir

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 18:54:16 +00:00
Joshua Colp
ac876a8e4e Make the ldap version setting work without having both version and protocol set.
(closes issue #12613)
Reported by: suretec


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 18:25:54 +00:00
Tilghman Lesher
c15ed0f3f6 Merged revisions 116296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r116296 | tilghman | 2008-05-14 11:46:48 -0500 (Wed, 14 May 2008) | 2 lines

Detect another way for a connection to have gone away.
(closes issue #12618)
 Reported by: ctooley
 Patches: 
       1.4-externalivr-test_fd.diff uploaded by ctooley (license 136)
       trunk-externalivr-test_fd.diff uploaded by ctooley (license 136)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 16:53:23 +00:00
Jeff Peeler
4729632721 Fixed a few problems with multiparking: call not being parked in the correct parking spot, caller not being notified of parking spot position, and improperly hanging up the call during a transfer due to timing out (not providing the extension in which to transfer).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-14 16:52:30 +00:00