Commit Graph

10423 Commits

Author SHA1 Message Date
Luigi Rizzo fbb143b829 Bring in the improved internal API for the CLI.
WATCH OUT: this changes the binary interface (ABI) for modules,
so e.g. users of g729 codecs need a rebuilt module (but read below).

The new way to write CLI handlers is described in detail in cli.h,
and there are a few converted handlers in cli.c, look for NEW_CLI.

After converting a couple of commands i am convinced that
it is reasonably convenient to use, and it makes it easier to fix the
pending CLI issues.

On passing, note a bug with the current 'complete' architecture:
if a command is a prefix of multiple CLI entries, we miss some
of the possible options. As an example, "core set debug" can
continue with "channel" from one CLI entry, and "off" or "atleast"
from another one.

We address this problem in a separate commit
(when i have figured out a fix, that is).

ABI issues:
I asked Kevin if it was ok to make this change and he said yes.
While it would have been possible to make the change without breaking
the module ABI, the code would have been more convoluted.

I am happy to restore the old ABI (while still being able
to use the "new style" handlers) if there is demand.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 15:23:35 +00:00
Olle Johansson 063ebdf279 Adding some debug output to trace bug in realtime
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 13:17:38 +00:00
Olle Johansson f9f8237a2f Adding a new debug line for issue #7351 - trying to find where an ACK can overwrite the initreq...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 12:32:46 +00:00
Olle Johansson c2b4c7a9c7 Issue #8272 imported from 1.2/1.4 - Let the peerpoke system destroy it's own packets, please.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 11:26:06 +00:00
Olle Johansson fb211aa610 Remove flags not used any more (thanks Luigi)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 11:00:33 +00:00
Matt O'Gorman a19602869b oops no parens
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47587 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 22:40:01 +00:00
Matt O'Gorman 43aefe9116 fix bytesize to 5.3kb for g723 codec and add support for multimode of tc400p
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47586 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 22:01:43 +00:00
Joshua Colp 380d0e9070 Merged revisions 47584 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47584 | file | 2006-11-13 16:28:57 -0500 (Mon, 13 Nov 2006) | 10 lines

Merged revisions 47583 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47583 | file | 2006-11-13 16:26:36 -0500 (Mon, 13 Nov 2006) | 2 lines

Initialize global pointers for connection and result to NULL. (issue #8356 reported by james)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47585 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 21:32:13 +00:00
Tilghman Lesher 98e17e1cb9 Merged revisions 47581 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47581 | tilghman | 2006-11-13 14:20:01 -0600 (Mon, 13 Nov 2006) | 10 lines

Merged revisions 47580 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47580 | tilghman | 2006-11-13 14:18:30 -0600 (Mon, 13 Nov 2006) | 2 lines

Having more than 255 old messages caused corruption in the new/old count

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 20:21:33 +00:00
Olle Johansson ea64cd393f Small fix for uncommon scenario.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:20:54 +00:00
Steve Murphy d8b355bc65 Blocking 47576 from merging into trunk. Already done in 47577
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:19:16 +00:00
Steve Murphy cd74836d3a This solves bug 8342, whereby a crash occurs under certain circumstances while reading a config file with comments-- a call to CB_ADD shouldn't happen if withcomments is zero
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:15:45 +00:00
Joshua Colp 24afed6a81 Make chan_h323 build again and make the CLI commands work. (reported on asterisk-dev mailing list by Di-Shi Sun)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:14:39 +00:00
Tilghman Lesher 7adabbd41e Blocked revisions 47573 via svnmerge
........
r47573 | tilghman | 2006-11-13 13:11:15 -0600 (Mon, 13 Nov 2006) | 2 lines

Re-enable old deprecated commands

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47574 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:12:23 +00:00
Steve Murphy 564d03e86c blocked 47564 from 1.4 to be merged onto trunk; 47566 already did it
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 18:24:20 +00:00
Joshua Colp 64d5316a53 Add 'loose' option to joinempty and leavewhenempty which is almost exactly like 'strict' except it does not count paused queue members as unavailable. (issue #8263 reported by gnarf)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47567 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 18:23:55 +00:00
Steve Murphy 2bdd7b7790 Eager people beat me to fixing the messed if, but we all forgot to update the regressions. Until now.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 18:20:56 +00:00
Joshua Colp 4546bd26fc Don't play the "entering conference number <insert number here>" prompts if the 'q' option is used. If others believe this should be in 1.2/1.4 then we can put it in, but I'm uncomfortable doing so right now as it is a change of behavior. (issue #8138 reported by tmancill)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:55:24 +00:00
Joshua Colp 9362f42454 Blocked revisions 47558 via svnmerge
........
r47558 | file | 2006-11-13 12:38:44 -0500 (Mon, 13 Nov 2006) | 2 lines

Clean up last commit to better conform to standards.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:41:22 +00:00
Joshua Colp 23ebec40a5 Clean up last commit to better conform to standards.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47556 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:36:28 +00:00
Steve Murphy 613e503260 Blocking 47553 from 1.4 to trunk... 47554 is done for it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:36:01 +00:00
Steve Murphy 4115ea029d AEL need not complain about parkedcalls not being found... just confuses users
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:32:16 +00:00
Joshua Colp 34e40c93bc Merged revisions 47551 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47551 | file | 2006-11-13 12:08:07 -0500 (Mon, 13 Nov 2006) | 10 lines

Merged revisions 47549 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47549 | file | 2006-11-13 12:05:32 -0500 (Mon, 13 Nov 2006) | 2 lines

When sending an SMS with a user data header properly set the UDH flag in the first byte. (issue #8347 reported by hoffmeis)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:10:21 +00:00
Joshua Colp 209628c6e2 Return module show to a working state. (issue #8353 reported by jserve)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:41:45 +00:00
Joshua Colp 292589b534 Blocked revisions 47542 via svnmerge
........
r47542 | file | 2006-11-13 11:30:38 -0500 (Mon, 13 Nov 2006) | 2 lines

Free full command string upon unregistering of CLI command. Backported from revision 47536 from rizzo.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:33:46 +00:00
Olle Johansson ffc1dc331a Only produce error message once, don't fill the screen with them...
(Testing SIPP thanks to JerJer and Greg)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:08:12 +00:00
Luigi Rizzo 52148c96f5 merge from astobj2-r47450: use UNLINK to remove a packet from its queue,
and related code rearrangement.

Approved by: oej

This could be made better if we declared

	struct sip_pvt *dialpg = pkt->owner;

at the beginning of the function, and use it throughout the function.
I'll let the boss decide :)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 14:29:31 +00:00
Luigi Rizzo c26ccb97b9 merge from codename-pineapple and astobj2 47499:
simplify __sip_ack() removing a strcmp for looking up packets.

no functional change, only performance, so don't need to merging
to earlier branches now.

Approved By: oej



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47538 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 14:14:54 +00:00
Luigi Rizzo 06c9ef6411 stop looking for new entries when we know we are done.
there is no functional change, so it is not necessary to
bother merging this to 1.4 now.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 12:04:05 +00:00
Luigi Rizzo b2e2f3f957 free memory when unregistering an entry.
needs to be merged to 1.4



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 12:01:25 +00:00
Tilghman Lesher f2bc05d1d4 Feature: allow the sanity SQL to be customized per connection class (Issue 6453)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47530 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 05:58:14 +00:00
Russell Bryant 6fb342ecfe Merged revisions 47527 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47527 | russell | 2006-11-13 00:48:18 -0500 (Mon, 13 Nov 2006) | 5 lines

AC_PROG_SED is included in autoconf 2.60, but apparently it is not included
in 2.59.  So, to maintain compatability with 2.59 since it is a small change,
copy this macro into acinclude.m4 and rename it to AST_PROG_SED.
(issue #8345)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 05:51:30 +00:00
Tilghman Lesher 70f6330157 Merged revisions 47526 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47526 | tilghman | 2006-11-12 23:46:18 -0600 (Sun, 12 Nov 2006) | 10 lines

Merged revisions 47525 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47525 | tilghman | 2006-11-12 23:45:11 -0600 (Sun, 12 Nov 2006) | 2 lines

If the execute fails a second time, make sure that we don't pass back a stale handle

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47528 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 05:48:27 +00:00
Tilghman Lesher 8dbe2063ed Merged revisions 47523 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47523 | tilghman | 2006-11-12 19:12:01 -0600 (Sun, 12 Nov 2006) | 10 lines

Merged revisions 47522 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47522 | tilghman | 2006-11-12 18:34:44 -0600 (Sun, 12 Nov 2006) | 2 lines

Don't play dialtone if the seizing the channel fails (Bug 7754)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 01:16:30 +00:00
Olle Johansson 139bf2b626 Part of patch in #7403 to improve tag checking in pedantic mode (stephen_dredge)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 20:47:25 +00:00
Russell Bryant 462407a3a6 The use of an ifdef to check for FreeBSD is useless here because the two
versions of the format string are identical.  Also, since each format is only
used once, get rid of the use of defines all together.  (issue #8344, julieng)

In passing, also clean up the formatting a but to get rid of the nesting
without the use of braces, as defined in the coding guidelines.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 19:22:19 +00:00
Olle Johansson 2286ff9659 Restore auto-framing (DEA). Imported from 1.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47514 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 16:15:49 +00:00
Olle Johansson aa275d4970 - Support UDPTL as well as udptl in T38 sdp.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:40:03 +00:00
Olle Johansson b744a76565 - Don't hangup because of failed re-invite. Go back to previous state.
- Keep RTP running during T.38 session
  We might improve the code to issue ast_rtp_stop if T.38 re-invite not fails
  later on in the code, but I don't see many reasons to.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:30:48 +00:00
Olle Johansson 1f9dcf758c - Add some comments to t.38 code
- Remove improper blocking of ptime: in SDP


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:14:35 +00:00
Russell Bryant e19fc06e2c Merged revisions 47497 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47497 | russell | 2006-11-12 01:23:23 -0500 (Sun, 12 Nov 2006) | 12 lines

Merged revisions 47496 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47496 | russell | 2006-11-12 01:09:03 -0500 (Sun, 12 Nov 2006) | 4 lines

Only do the check to determine whether the channel calling this function is an
IAX2 channel when getting the IP address using the special argument, 
CURRENTCHANNEL.  (issue #8341, jcovert)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47498 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 06:31:39 +00:00
Russell Bryant f5176bcebb Merged revisions 47494 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47494 | russell | 2006-11-11 10:31:08 -0500 (Sat, 11 Nov 2006) | 6 lines

Add the target "menuconfig" as an alias for the "menuselect" target.  This is
just a favor to users so that if you accidentally type "make menuconfig"
instead of "make menuselect", it still works.
(inspired by a comment on IRC from wangster calling me an "especially devious
asterisk developer" for having it be menuselect instead of menuconfig. :) )

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-11 15:33:06 +00:00
Russell Bryant f575b7e25d Merged revisions 47492 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47492 | russell | 2006-11-11 10:18:02 -0500 (Sat, 11 Nov 2006) | 2 lines

Tweak the formatting of this new function to better conform to coding guidelines.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-11 15:22:08 +00:00
Matt O'Gorman b025702287 safe terminal output is sweet.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-11 02:12:27 +00:00
Matthew Fredrickson 69d3416c12 Make sure we don't use 32bits for a value that only requires 1 bit. Also, fix a compiler warning for one of the SS7 functions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47478 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 22:06:11 +00:00
Olle Johansson 0c18d91817 Add some history and fix some debug output for autodestruct.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 21:55:31 +00:00
Olle Johansson 2b6d3952e1 Proper fix for adding debug...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47475 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 21:39:58 +00:00
Olle Johansson d5243cc7aa Make sure we destroy dialog in case of loop
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47468 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 20:31:57 +00:00
Olle Johansson d69eb90f82 Cleanup imported from 1.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 20:25:32 +00:00
Joshua Colp eceb5c60d7 Fine, take this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 20:05:31 +00:00