Commit graph

19252 commits

Author SHA1 Message Date
Mark Michelson
fe72baf06b Make sure to set owner_line, ownder_func, and owner_file in ast_calloc_with_stringfields.
Asterisk would crash on startup if MALLOC_DEBUG were set in menuselect. This is because
the manager action UpdateConfig had to resize its string field allocation to set the
description. When the resize occurred, ast_copy_string would crash because we were
attempting to copy a string from a NULL pointer. Setting the strings initially makes
the code much less crashy.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:58:24 +00:00
Tilghman Lesher
f94e723a27 Make sure that the limit is N, not N - 1.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:58:19 +00:00
Tilghman Lesher
6bc1fc7240 Merged revisions 240414 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines
  
  Disallow leaving more than maxmsg voicemails.
  This is a possibility because our previous method assumed that no messages are
  left in parallel, which is not a safe assumption.  Due to the vmu structure
  duplication, it was necessary to track in-process messages via a separate
  structure.  If at some point, we switch vmu to an ao2-reference-counted
  structure, which would eliminate the prior noted duplication of structures,
  then we could incorporate this new in-process structure directly into vmu.
  (closes issue #16271)
   Reported by: sohosys
   Patches: 
         20100108__issue16271.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14)
   Tested by: jsutton
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:54:24 +00:00
Russell Bryant
86c57df84e Ensure payload type is properly checked when comparing against cached events.
(closes issue #16607)
Reported by: ddv2005
Patches:
      event.patch uploaded by ddv2005 (license 769)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240411 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:41:11 +00:00
Sean Bright
e612d87695 Convert a few places to use ast_calloc_with_stringfields where applicable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 18:21:50 +00:00
Russell Bryant
89413e9ae2 Update configure script for an OSP toolkit related change.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 16:51:34 +00:00
Kevin P. Fleming
1ef8082cd3 Clarify RTP NAT handling a bit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 16:28:38 +00:00
Sean Bright
37b73283ff Plug a memory leak in res_config_ldap.
(closes issue #16257)
Reported by: nito
Patches:
      issue16257_20100111.diff uploaded by seanbright (license 71)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 23:13:02 +00:00
Sean Bright
cd2ba30e9e If we aren't running on a machine that support CLOCK_MONOTONIC, don't load.
Group developed and tested by seanbright, Corydon76, Kobaz, and Amorsen.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240226 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 20:30:03 +00:00
Jeff Peeler
9228fba7d7 Fix broken call pickup
The problem was the OUTGOING flag was not getting set properly on the channel,
resulting in pickup failing as ast_read thought the call was inbound. Refer to
170393 for a more verbose description as this is the same exact change.

(closes issue #16539)
Reported by: syspert
Patches: 
      bug16539.patch uploaded by jpeeler (license 325)
Tested by: syspert


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 18:03:31 +00:00
Tilghman Lesher
3eb8f0a8dc Similarly, ensure that matchcid is duplicated correctly when merging contexts.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 17:34:53 +00:00
Tilghman Lesher
20e57b12e8 Ensure that the callerid is NULL when the parent is effectively NULL.
This applies only to pattern-match hints, which create exact-match
hints on the fly.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 16:52:22 +00:00
Matthew Nicholson
ef0da09c74 This change fixes a few bugs in the way the far max IFP was calculated that were introduced in r231692.
(closes issue #16497)
Reported by: globalnetinc
Patches:
      udptl-max-ifp-fix1.diff uploaded by mnicholson (license 96)
Tested by: globalnetinc



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 16:14:35 +00:00
Leif Madsen
712b500ee2 Add documentation about how to build queues.
Add a how-to set of documentation about building queues with Asterisk.
This documentation is based on Asterisk 1.6.2 but should work on most
versions with minor modifications.

(closes issue #16237)
Reported by: lmadsen
Patches:
      Building Queues (FINAL).txt uploaded by lmadsen (license 10)
Tested by: pdhales, lmadsen, cmdrwalrus

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-14 14:38:01 +00:00
Tilghman Lesher
87ea570ef1 Oops, another tag error
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239997 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 23:22:56 +00:00
Tilghman Lesher
b01df91513 Oops, missed a closing tag
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239996 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 23:21:46 +00:00
Tilghman Lesher
ecbe7eff7a Add the TESTTIME() dialplan function, which permits testing GotoIfTime.
Specifically, by setting TESTTIME() to a particular date and time, you
can test whether a dialplan correctly branches as was intended.  This was
developed after recent questions on the -users list on how to test their
holiday dialplan logic.
(closes issue #16464)
 Reported by: tilghman
 Patches: 
       20100112__issue16464.diff.txt uploaded by tilghman (license 14)
 
Review: https://reviewboard.asterisk.org/r/458/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 21:27:34 +00:00
Tilghman Lesher
919437428e Flex uses fwrite incorrectly, which breaks the build. Providing a workaround.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 20:38:42 +00:00
Jeff Peeler
495b701a85 Merged revisions 239838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r239838 | jpeeler | 2010-01-13 13:43:33 -0600 (Wed, 13 Jan 2010) | 11 lines
  
  Fix regression for timed out parked call returning to caller
  
  This issue seems to have been exposed by the fix in 160390 whereby using a
  masquerade prevented a crash. The new channel used in the masquerade was
  not copying the macro information from the old channel.
  
  (closes issue #15459)
  Reported by: djrodman
  Patches: 
        patch_15459.txt uploaded by mnick (license )
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 19:48:16 +00:00
Leif Madsen
f44630cd01 Add more examples to extensions.conf showing how to use various
functionality and provide commonly useful features.

(closes issue #16090)
Reported by: pprindeville
Patches:
      extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
Tested by: tzafrir, pprindeville, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 19:31:13 +00:00
Tilghman Lesher
6d1086ec86 Code previously added to ast_expr2f.c warranted a change in the source file ast_expr2.fl.
Also, made a Makefile change to ensure that the expression parser C source files get
regenerated correctly, when we need that to happen.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 18:16:13 +00:00
David Vossel
2c1c3a2cab Blocked revisions 239718 via svnmerge
........
  r239718 | dvossel | 2010-01-13 11:16:12 -0600 (Wed, 13 Jan 2010) | 23 lines
  
  add silence gen to wait apps
    
  asterisk.conf's 'transmit_silence' option existed before
  this patch, but was limited to only generating silence
  while recording and sending DTMF. Now enabling the
  transmit_silence option generates silence during wait
  times as well.
    
  To achieve this, ast_safe_sleep has been modified to
  generate silence anytime no other generators are present
  and transmit_silence is enabled. Wait apps not using
  ast_safe_sleep now generate silence when transmit_silence
  is enabled as well.
  
  (closes issue 0016524)
  Reported by: kobaz
  
  (closes issue 0016523)
  Reported by: kobaz
  Tested by: dvossel
    
  Review: https://reviewboard.asterisk.org/r/456/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239719 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 17:16:58 +00:00
David Vossel
03529837cc add silence gen to wait apps
asterisk.conf's 'transmit_silence' option existed before
this patch, but was limited to only generating silence
while recording and sending DTMF.  Now enabling the
transmit_silence option generates silence during wait
times as well.

To achieve this, ast_safe_sleep has been modified to
generate silence anytime no other generators are present
and transmit_silence is enabled.  Wait apps not using
ast_safe_sleep now generate silence when transmit_silence
is enabled as well.

(closes issue #16524)
Reported by: kobaz

(closes issue #16523)
Reported by: kobaz
Tested by: dvossel

Review: https://reviewboard.asterisk.org/r/456/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 16:31:14 +00:00
Olle Johansson
c300b12b18 MAX() moved to utils.h
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 10:45:19 +00:00
Olle Johansson
c15a667733 SIP Show channelstats fix - use float division to show proper stats
(closes issue #15819)
Reported by: klaus3000
Patches: 
      asterisk-sip-show-channelstats-trunk.txt uploaded by klaus3000 (license 65)
Tested by: klaus3000, oej

This patch is for trunk only and will be blocked in 1.6.2



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 10:24:23 +00:00
TransNexus OSP Development
ce80ff55c8 Updated channel variable list of osplookup application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239625 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 07:02:13 +00:00
TransNexus OSP Development
912d4da476 Updated XML doc for OSP.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 07:00:13 +00:00
Tilghman Lesher
d80a38310a Blank callerid and NULL callerid should not compare equal.
The second is the default state for matching CID in the dialplan (no matching)
while the first matches one particular CallerID.  This is a regression.
(fixes AST-314, SWP-611)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 19:58:00 +00:00
Alec L Davis
113ff66f7f add Dialed Number Identifier (DNID) field to cdr records.
reviewboard link: https://reviewboard.asterisk.org/r/455/

  Reported by: alecdavis
  Tested by: alecdavis
  Patch
	 cdr_dnid.diff2.txt uploaded by alecdavis (license 585)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 18:55:54 +00:00
Leif Madsen
c2f486e118 Note that direct T.38 is not supported.
(closes issue #16411)
Reported by: stanusr
Patches:
      __20091210-sip.conf.sample-documentation.txt uploaded by lmadsen (license 10)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 18:22:45 +00:00
Sean Bright
a5688e483b Fix crash in res_config_ldap.
We need to allocate enough room for 2 pointers, not 2 characters.

(closes issue #16397)
Reported by: bklang
Patches:
      res_config_ldap.patch uploaded by applsplatz (license 949)
Tested by: applsplatz


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 17:09:12 +00:00
David Vossel
fa0ef8031d fixes text support in sdp answer
The code that handled setting 'm=text' in the sdp was not executing
in the correct order.  The check to see if text was needed came after
the check to add 'm=text' to the sdp, this resulted in 'm=text' always
being set to 0 because it looked like text was never required.

(closes issue #16457)
Reported by: peterj
Patches:
      textportinsdp.diff uploaded by peterj (license 951)
      issue16457.diff uploaded by dvossel (license 671)
Tested by: peterj


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 16:14:41 +00:00
Olle Johansson
bd2c63a59d Adding Tilghman's documentation from asterisk-dev to the actual file.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 07:48:16 +00:00
Tilghman Lesher
3168cb379d Merged revisions 239307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r239307 | tilghman | 2010-01-11 21:18:36 -0600 (Mon, 11 Jan 2010) | 8 lines
  
  Portability and other fixes for the safe_asterisk script
  (closes issue #16416)
   Reported by: bklang
   Patches: 
         safe_asterisk-compat-1.patch uploaded by bklang (license 919)
         20100106__issue16416__trunk.diff.txt uploaded by tilghman (license 14)
   Tested by: bklang
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-12 03:21:40 +00:00
Tilghman Lesher
dd0ab33cb2 Add LSB headers to init scripts.
(closes issue #14864)
 Reported by: lathama
 Patches: 
       lsb-init-info-debian.diff uploaded by pkempgen (license 169)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 23:53:32 +00:00
Tilghman Lesher
cd8aa003e4 Socket level option is SOL_SOCKET, not SO_SOCKET.
(issue #16580)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 23:19:51 +00:00
Tilghman Lesher
38957995ff Permit more options in the Makefile as to startup options
(closes issue #16454)
 Reported by: syspert
 Patches: 
       20091228__issue16454__3.diff.txt uploaded by tilghman (license 14)
 Tested by: syspert


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 23:00:55 +00:00
Tilghman Lesher
d079b371c7 Including bundle1.o breaks Tiger and Leopard
(issue #16449)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 22:06:38 +00:00
Tilghman Lesher
b4504ada8b Permit dates and times to be stored in timezones other than the default (typically, UTC)
(closes issue #16401)
 Reported by: lordmortis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 21:03:46 +00:00
Sean Bright
ea47ab7ed9 Pass NULL for the ao2_callback function pointer instead of duplicating cb_true.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239114 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 16:41:44 +00:00
Sean Bright
ba6201cae6 Fix ao2_callback when both OBJ_MULTIPLE and OBJ_NODATA are passed.
There is an issue which only affects trunk and the new ao2_callback OBJ_MULTIPLE
implementation.  When both OBJ_MULTIPLE and OBJ_NODATA are passed, only the first
object is visited, regardless of what is returned by the specified callback. This
causes a problem when we are clearing a container, i.e.:

    ao2_callback(container, OBJ_UNLINK | OBJ_NODATA | OBJ_MULTIPLE, NULL, NULL);

Only unlinks the first object.  This patch resolves this.

(closes issue #16564)
Reported by: pj
Patches:
      issue16564_20100111.diff uploaded by seanbright (license 71)
Tested by: pj, seanbright

Review: https://reviewboard.asterisk.org/r/457/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 16:40:23 +00:00
Sean Bright
1ad2999112 Fix spelling of 'category.'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 16:22:09 +00:00
Tilghman Lesher
9c1b53cab4 According to POSIX, the capital L modifier applies only to floating point types.
Fixes a crash on Solaris.
(closes issue #16572)
 Reported by: crjw
 Patches: 
       frame_changes.patch uploaded by crjw (license 963)
       Plus several others found and fixed by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239074 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-10 19:37:30 +00:00
Alexandr Anikin
11e1780402 add docallbacks flag in q931decode function because
when we decode received q931 packet we must do callbacks and
when we print sended q931 packet we must not. 


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-10 17:53:59 +00:00
Tilghman Lesher
5e0762370c It's been long enough -- make the behavior introduced in 1.6 the default.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239000 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-10 06:56:36 +00:00
Tilghman Lesher
31e93b2865 Merged revisions 238915 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r238915 | tilghman | 2010-01-08 18:57:58 -0600 (Fri, 08 Jan 2010) | 6 lines
  
  -1 is interpreted as an error, intead of the maximum mask.
  (closes issue #16241)
   Reported by: vnovy
   Patches: 
         manager.c.patch uploaded by vnovy (license 922)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-09 01:08:04 +00:00
Jeff Peeler
cde1057ec3 Merged revisions 238834 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r238834 | jpeeler | 2010-01-08 17:28:37 -0600 (Fri, 08 Jan 2010) | 4 lines
  
  Stop a crash when no peer is passed to masq_park_call.
  
  (distantly related to issue #16406)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-08 23:30:55 +00:00
Tilghman Lesher
055cb0e0ae Add the class actually used in the MusicOnHold start event.
(closes issue #16499)
 Reported by: syspert
 Patches: 
       mohclass.patch uploaded by syspert (license 938)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238795 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-08 22:54:59 +00:00
Tilghman Lesher
963319d807 Initialize variables that we attempt to free later.
(closes issue #16302)
 Reported by: yahsyn
 Patches: 
       20091124__issue16302.diff.txt uploaded by tilghman (license 14)
 Tested by: yahsyn


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-08 22:17:03 +00:00
Matthew Nicholson
f92938ff67 Added a test for ast_format_reduce_str().
(related to issue #16560)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-08 21:04:51 +00:00