test: Make exceptions compatible with Python 3

Use "except Type as var" syntax to work with both Python >= 2.6
and Python 3.
This commit is contained in:
Martin Pitt 2014-03-11 17:39:19 +01:00 committed by Denis Kenzior
parent 0c1fcd2b50
commit 0393a41e35
17 changed files with 45 additions and 45 deletions

View File

@ -35,6 +35,6 @@ for path, properties in modems:
try: try:
context.SetProperty("Active", dbus.Boolean(1), timeout = 100) context.SetProperty("Active", dbus.Boolean(1), timeout = 100)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Error activating %s: %s" % (path, str(e))) print("Error activating %s: %s" % (path, str(e)))
exit(2) exit(2)

View File

@ -33,6 +33,6 @@ for path, properties in modems:
try: try:
context.SetProperty("Active", dbus.Boolean(0)) context.SetProperty("Active", dbus.Boolean(0))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Error activating %s: %s" % (path, str(e))) print("Error activating %s: %s" % (path, str(e)))
exit(2) exit(2)

View File

@ -41,7 +41,7 @@ if __name__ == "__main__":
try: try:
cf.DisableAll(type, timeout = 100) cf.DisableAll(type, timeout = 100)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to DisableAll %s" % e) print("Unable to DisableAll %s" % e)
sys.exit(1); sys.exit(1);

View File

@ -46,13 +46,13 @@ if __name__ == "__main__":
try: try:
cf.SetProperty(property, dbus.UInt16(value), cf.SetProperty(property, dbus.UInt16(value),
timeout = 100) timeout = 100)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable SetProperty %s" % e) print("Unable SetProperty %s" % e)
sys.exit(1); sys.exit(1);
else: else:
try: try:
cf.SetProperty(property, value, timeout = 100) cf.SetProperty(property, value, timeout = 100)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable SetProperty %s" % e) print("Unable SetProperty %s" % e)
sys.exit(1); sys.exit(1);

View File

@ -33,7 +33,7 @@ for path, properties in modems:
try: try:
context.SetProperty(sys.argv[2], sys.argv[3]) context.SetProperty(sys.argv[2], sys.argv[3])
except dbus.DBusException, e: except dbus.DBusException as e:
print("Error setting context %s property %s: %s" %\ print("Error setting context %s property %s: %s" %\
(path, sys.argv[2], str(e))) (path, sys.argv[2], str(e)))
exit(2) exit(2)

View File

@ -67,7 +67,7 @@ if __name__ == "__main__":
print("Resetting Accumulated Call Meter") print("Resetting Accumulated Call Meter")
try: try:
cm.Reset(pin) cm.Reset(pin)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to reset ACM: %s" % e) print("Unable to reset ACM: %s" % e)
sys.exit(1) sys.exit(1)
else: else:
@ -77,7 +77,7 @@ if __name__ == "__main__":
elif property == 'PricePerUnit': elif property == 'PricePerUnit':
newvalue = float(newvalue) newvalue = float(newvalue)
cm.SetProperty(property, newvalue, pin) cm.SetProperty(property, newvalue, pin)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set property: %s" % e) print("Unable to set property: %s" % e)
sys.exit(1) sys.exit(1)

View File

@ -60,13 +60,13 @@ if __name__ == "__main__":
print("Disabling all barrings") print("Disabling all barrings")
try: try:
cb.DisableAll(pin) cb.DisableAll(pin)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to Disable All barrings: ", e) print("Unable to Disable All barrings: ", e)
sys.exit(1) sys.exit(1)
elif (sys.argv[1] == 'passwd'): elif (sys.argv[1] == 'passwd'):
try: try:
cb.ChangePassword(old_password, new_password) cb.ChangePassword(old_password, new_password)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to change password: ", e) print("Unable to change password: ", e)
sys.exit(1) sys.exit(1)
print("Password changed") print("Password changed")
@ -74,7 +74,7 @@ if __name__ == "__main__":
else: else:
try: try:
cb.SetProperty(property, newvalue, pin) cb.SetProperty(property, newvalue, pin)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set property: ", e) print("Unable to set property: ", e)
sys.exit(1) sys.exit(1)

View File

@ -36,47 +36,47 @@ if __name__ == "__main__":
try: try:
cf.SetProperty("FoobarNoReplyTimeout", dbus.UInt16(19)) cf.SetProperty("FoobarNoReplyTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("VoiceNotReachableTimeout", dbus.UInt16(19)) cf.SetProperty("VoiceNotReachableTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("VoiceNoReplyTimeout", dbus.UInt16(19)) cf.SetProperty("VoiceNoReplyTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("DataNoReplyTimeout", dbus.UInt16(19)) cf.SetProperty("DataNoReplyTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("FaxNoReplyTimeout", dbus.UInt16(19)) cf.SetProperty("FaxNoReplyTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("SmsNoReplyTimeout", dbus.UInt16(19)) cf.SetProperty("SmsNoReplyTimeout", dbus.UInt16(19))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set timeout - Good") print("Unable to set timeout - Good")
try: try:
cf.SetProperty("VoiceNoReply", "") cf.SetProperty("VoiceNoReply", "")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to erase voice no reply rule - Bad") print("Unable to erase voice no reply rule - Bad")
try: try:
cf.SetProperty("VoiceNoReply", "+134444") cf.SetProperty("VoiceNoReply", "+134444")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to register voice no reply rule - Bad") print("Unable to register voice no reply rule - Bad")
try: try:
cf.SetProperty("VoiceNoReplyTimeout", dbus.UInt16(30)) cf.SetProperty("VoiceNoReplyTimeout", dbus.UInt16(30))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set voice no reply timeout - Bad") print("Unable to set voice no reply timeout - Bad")
properties = cf.GetProperties() properties = cf.GetProperties()
@ -86,7 +86,7 @@ if __name__ == "__main__":
try: try:
cf.SetProperty("VoiceUnconditional", "+155555") cf.SetProperty("VoiceUnconditional", "+155555")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set Voice Unconditional - Bad") print("Unable to set Voice Unconditional - Bad")
properties = cf.GetProperties() properties = cf.GetProperties()
@ -95,12 +95,12 @@ if __name__ == "__main__":
try: try:
cf.DisableAll("foobar") cf.DisableAll("foobar")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to delete invalids - Good") print("Unable to delete invalids - Good")
try: try:
cf.DisableAll("conditional") cf.DisableAll("conditional")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to delete all conditional - Bad") print("Unable to delete all conditional - Bad")
properties = cf.GetProperties() properties = cf.GetProperties()
@ -110,7 +110,7 @@ if __name__ == "__main__":
try: try:
cf.DisableAll("all") cf.DisableAll("all")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to delete all conditional - Bad") print("Unable to delete all conditional - Bad")
print(properties["VoiceUnconditional"]) print(properties["VoiceUnconditional"])

View File

@ -67,7 +67,7 @@ if __name__ == "__main__":
try: try:
cs.SetProperty(property, newvalue) cs.SetProperty(property, newvalue)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set property: %s" % e) print("Unable to set property: %s" % e)
sys.exit(1); sys.exit(1);

View File

@ -103,7 +103,7 @@ def set_topics(cbs):
try: try:
print("Setting Cell Broadcast topics...") print("Setting Cell Broadcast topics...")
cbs.SetProperty("Topics", topics); cbs.SetProperty("Topics", topics);
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set topic: %s" % e) print("Unable to set topic: %s" % e)
print("-----------------------------------------------------------") print("-----------------------------------------------------------")

View File

@ -44,21 +44,21 @@ def stdin_handler(fd, condition, gnss, path):
try: try:
gnss.SendPositioningElement(dbus.String(xml)) gnss.SendPositioningElement(dbus.String(xml))
print("ok") print("ok")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to send positioning element") print("Unable to send positioning element")
elif in_key == '1': elif in_key == '1':
try: try:
gnss.RegisterPositioningRequestAgent("/test/posagent") gnss.RegisterPositioningRequestAgent("/test/posagent")
print("ok") print("ok")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to register positioning agent") print("Unable to register positioning agent")
elif in_key == '2': elif in_key == '2':
try: try:
gnss.UnregisterPositioningRequestAgent(path) gnss.UnregisterPositioningRequestAgent(path)
print("ok") print("ok")
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to unregister positioning agent") print("Unable to unregister positioning agent")
elif in_key == 'x': elif in_key == 'x':
sys.exit(1) sys.exit(1)

View File

@ -61,7 +61,7 @@ if __name__ == "__main__":
obj = bus.get_object('org.ofono', plmn); obj = bus.get_object('org.ofono', plmn);
op = dbus.Interface(obj, 'org.ofono.NetworkOperator') op = dbus.Interface(obj, 'org.ofono.NetworkOperator')
op.Register() op.Register()
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to register: %s" % e) print("Unable to register: %s" % e)
sys.exit(1) sys.exit(1)

View File

@ -48,7 +48,7 @@ def message_delivery_report(sms, value):
try: try:
sms.SetProperty("UseDeliveryReports", dbus.Boolean(value)) sms.SetProperty("UseDeliveryReports", dbus.Boolean(value))
except dbus.DBusException, e: except dbus.DBusException as e:
if value == 1: if value == 1:
print("Unable to activate Delivery Reports - FAIL") print("Unable to activate Delivery Reports - FAIL")
@ -58,13 +58,13 @@ def message_delivery_report(sms, value):
def message_service_center_address(sms, value): def message_service_center_address(sms, value):
try: try:
sms.SetProperty("ServiceCenterAddress",dbus.String(value)) sms.SetProperty("ServiceCenterAddress",dbus.String(value))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set correct Service Center Address - FAIL") print("Unable to set correct Service Center Address - FAIL")
def message_bearer(sms, value): def message_bearer(sms, value):
try: try:
sms.SetProperty("Bearer", dbus.String(value)) sms.SetProperty("Bearer", dbus.String(value))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to set Bearer[%s] - FAIL" % (value)) print("Unable to set Bearer[%s] - FAIL" % (value))

View File

@ -22,7 +22,7 @@ ss = dbus.Interface(bus.get_object('org.ofono', modem),
try: try:
ss_type, properties = ss.Initiate(ss_code, timeout=100) ss_type, properties = ss.Initiate(ss_code, timeout=100)
except dbus.DBusException, e: except dbus.DBusException as e:
print("Unable to perform operation: %s" % e) print("Unable to perform operation: %s" % e)
sys.exit(1); sys.exit(1);

View File

@ -37,25 +37,25 @@ if __name__ == "__main__":
print("Trying invalid SS request for CB") print("Trying invalid SS request for CB")
try: try:
print(ss.Initiate("*33#456666")) print(ss.Initiate("*33#456666"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CB") print("Trying invalid SS request for CB")
try: try:
print(ss.Initiate("*33*ABC#")) print(ss.Initiate("*33*ABC#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CB") print("Trying invalid SS request for CB")
try: try:
print(ss.Initiate("*33**ABC#")) print(ss.Initiate("*33**ABC#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CB") print("Trying invalid SS request for CB")
try: try:
print(ss.Initiate("*33***12#")) print(ss.Initiate("*33***12#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Query Outgoing All") print("Query Outgoing All")

View File

@ -37,19 +37,19 @@ if __name__ == "__main__":
print("Trying invalid SS request for CLIR") print("Trying invalid SS request for CLIR")
try: try:
print(ss.Initiate("*31#456666")) print(ss.Initiate("*31#456666"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CLIR") print("Trying invalid SS request for CLIR")
try: try:
print(ss.Initiate("*31*455*4#")) print(ss.Initiate("*31*455*4#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CLIR") print("Trying invalid SS request for CLIR")
try: try:
print(ss.Initiate("*31**44435#")) print(ss.Initiate("*31**44435#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Query CLIP") print("Query CLIP")
@ -77,19 +77,19 @@ if __name__ == "__main__":
print("Trying invalid SS request for CW") print("Trying invalid SS request for CW")
try: try:
print(ss.Initiate("*43#456666")) print(ss.Initiate("*43#456666"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CW") print("Trying invalid SS request for CW")
try: try:
print(ss.Initiate("*43*455*4#")) print(ss.Initiate("*43*455*4#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Trying invalid SS request for CW") print("Trying invalid SS request for CW")
try: try:
print(ss.Initiate("*43**44435#")) print(ss.Initiate("*43**44435#"))
except dbus.DBusException, e: except dbus.DBusException as e:
print("Failed with %s - Good" % e) print("Failed with %s - Good" % e)
print("Query CW") print("Query CW")

View File

@ -238,7 +238,7 @@ class StkAgent(dbus.service.Object):
if key == 't': if key == 't':
raise EndSession("User wishes to terminate" raise EndSession("User wishes to terminate"
" session") " session")
except Exception, exc: except Exception as exc:
print(exc) print(exc)
@dbus.service.method("org.ofono.SimToolkitAgent", @dbus.service.method("org.ofono.SimToolkitAgent",