Andrzej Zaborowski
bb9e26f2a5
sim: Set sane number len in empty EFmsisdn records
...
Valid number length range is 1 - 11 bytes, other values, such as 0xff,
could potentially crash external parsers.
2010-12-21 14:25:09 -06:00
Jeevaka Badrappan
a8c94c044f
sim: fix minor issue in ofono_sim_get_phase
2010-12-12 04:37:52 -06:00
Jeevaka Badrappan
5154d5e38d
sim: be more paranoid for triggering EFest read
2010-11-29 14:57:04 -06:00
Lucas De Marchi
b210838e87
core: explicitly compare pointers to NULL
...
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/ )
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Rémi Denis-Courmont
e7c4442c69
core: Remove stray newlines in messages sent to log
2010-11-26 13:50:15 -06:00
Jeevaka Badrappan
2d0cb92155
src: coding style fixes - rule M6
2010-11-22 05:07:52 -06:00
Andrzej Zaborowski
3083841f72
sim: Add sim_service_available()
...
This is meant to query EFsst or EFust.
The function is not public api because the service constants are in
src/simutil.h.
2010-11-10 09:09:05 -06:00
Denis Kenzior
d7403d521b
sim: Check both EFust and EFest for FDN & BDN
...
We were checking EFest only for whether BDN and FDN were enabled.
According to 31.102 Section 5.3.2 we should be checking both EFust
(availability of the service) and EFest (whether it is enabled)
2010-11-05 09:14:32 -05:00
Denis Kenzior
e613c686a6
sim: Don't read EFest if the file is not available
2010-11-05 09:14:32 -05:00
Guillaume Lucas
aa2c87886f
sim: use mask for check of sim file status
...
It is the first bit of the sim file status who indicates if a file
is valid or not. So a mask must be used to check this.
2010-11-05 09:14:32 -05:00
Denis Kenzior
dc43b56154
sim: Fix minor style issue
2010-10-25 10:39:09 -05:00
Jeevaka Badrappan
233bd42820
sim: add barred dialing support
2010-10-25 10:39:09 -05:00
Denis Kenzior
107a38de85
sim: Pass dbus types
...
Can't really assume they're the same as glib types
2010-10-22 11:58:59 -05:00
Denis Kenzior
8b40f6c1a0
sim: Get rid of unneeded empty line
2010-10-22 11:57:18 -05:00
Denis Kenzior
39a3080a4b
sim: Break out common FDN property signaling
2010-10-22 11:56:35 -05:00
Petteri Tikander
7de5e48df8
sim: check existence of imsi-code
...
For instance: when handling sim_get_properties
in PRE_SIM-state imsi is not received/stored.
2010-10-22 11:23:08 -05:00
Petteri Tikander
d82600c893
sim: check if Fixed Dial is enabled in SIM-card
...
If SIM-card is inserted, status is checked from EFsst
(is FDN activated) and EFadn (is ADN invalidated).
If USIM-card is inserted, status is checked from EFest
(is FDN activated).
If FD is enabled, halt SIM initialization procedure.
New property (FixedDialing) is added. If FD is enabled,
this has been signalled via DBUS.
2010-10-22 11:21:23 -05:00
Denis Kenzior
b92662634d
sim: Read EFust and EFest after phase is known
2010-10-19 14:20:57 -05:00
Denis Kenzior
04755acc3a
sim: Fix setting the correct phase from EFphase
2010-10-19 14:07:41 -05:00
Denis Kenzior
0564176a9c
sim: Fix crash on sim re-insertion
2010-10-15 06:26:34 -05:00
Denis Kenzior
a4d90fd4eb
sim: Refactor iidf reading
...
Get rid of image_data since it can lead to potential memory leaks when
sim is removed while the IIDF operations are in progress.
2010-10-13 08:41:41 -05:00
Denis Kenzior
ccf4b34522
sim: Use ay return signature for GetIcon
2010-10-13 05:04:47 -05:00
Denis Kenzior
56e0a7644f
simfs: Reflow to get rid of unnecessary label
2010-10-13 05:04:46 -05:00
Denis Kenzior
90f531768f
sim: Use g_dbus_create_reply
...
Instead of compound statements
2010-10-13 05:04:46 -05:00
Denis Kenzior
b750de3ec6
sim: Don't re-check for id != 0
...
We already check the id is valid in the get_icon function, there's no
reason to re-check it.
2010-10-13 05:04:46 -05:00
Kristen Carlson Accardi
42c29c795f
sim: implement GetIcon
2010-10-13 05:04:46 -05:00
Jeevaka Badrappan
4196182770
Fix multi-line comment style issues
2010-09-21 21:16:01 -05:00
Denis Kenzior
cd8df455e1
sim: Use sim_fs_check_version
2010-09-09 08:50:29 -05:00
Denis Kenzior
5754eaf7e9
sim: Break out sim file reading into simfs
2010-09-09 08:50:28 -05:00
Denis Kenzior
e3bd339e16
sim: Unify sim_read and sim_read_bytes
2010-09-09 08:50:28 -05:00
Kristen Carlson Accardi
95d957b62e
sim: read EFiidf
...
EFiidf can be larger than 256 bytes, so allow callers to read
portions of the EFiidf from a specified offset. Cache EFiidf
files as blocks of 256 bytes so that it's not necessary to
read the entire (potentially large) file.
2010-09-09 08:45:32 -05:00
Denis Kenzior
4b43650116
sim: cleanup sim atom private structure
...
The number of elements was getting out of hand and out of order
2010-09-01 12:06:59 -05:00
Denis Kenzior
0cf73b73eb
sim: tweak efimg length
2010-09-01 12:06:56 -05:00
Yang Gu
d43b2c0a61
sim: Read EFsst
2010-08-31 13:07:54 -05:00
Denis Kenzior
4292b2dbed
sim: Turn around the order of arguments
...
The void *user argument was first. It should be last instead to be
consistent with the other watch functions.
2010-08-30 14:29:34 -05:00
Kristen Carlson Accardi
d3eb346b40
sim: read EFimg
2010-08-26 18:40:12 -05:00
Denis Kenzior
74a88dda81
sim: Check PIN even if no EFli / EFpl not read
2010-08-25 10:00:09 -05:00
Denis Kenzior
687e171949
sim: Retrieve EFphase according to the spec
2010-08-23 14:29:22 -05:00
Denis Kenzior
38300af0da
sim: Reorder SIM initialization
2010-08-23 14:29:22 -05:00
Denis Kenzior
cbf783c334
sim: Reset mnc_length when removing SIM
...
In case the next SIM doesn't have it or something else weird happens.
2010-08-23 14:29:22 -05:00
Denis Kenzior
f78eaf94cf
sim: Update the SIM initialization comment
2010-08-23 14:29:22 -05:00
Denis Kenzior
fc70af8ea1
sim: Minor style fix
2010-08-23 14:29:21 -05:00
Yang Gu
c679babdc5
sim: Read EFust and EFest
2010-08-23 14:29:21 -05:00
Denis Kenzior
8eb9425f32
sim: Use less space for locked_pins
...
Use only as required, since we only track PINs in this one, not PUKs
2010-08-05 10:19:04 -05:00
Denis Kenzior
764afde1fe
sim: Fix LockedPins in case SIM wants a PUK first
...
In the case that oFono is started with the SIM asking for a PUK, we
don't report LockedPins properly.
2010-08-05 10:00:57 -05:00
Marcel Holtmann
1fedd096a0
Check sanity the MNC length value from the SIM card
...
In case the SIM entry is wrong or we force reading of it, nasty things
like this can happen:
ofonod[12456]: Control:> AT+CRSM=176,28589,0,0,4\r
ofonod[12456]: Control:< +CRSM: 144,0,"00FFFF"\r\n\r\nOK\r\n
*** buffer overflow detected ***: ./src/ofonod terminated
======= Backtrace: =========
/lib64/libc.so.6(__fortify_fail+0x37)[0x3e42efb417]
/lib64/libc.so.6[0x3e42ef9310]
/lib64/libc.so.6(__strncpy_chk+0x17b)[0x3e42ef85cb]
2010-06-22 17:21:03 +02:00
Denis Kenzior
f2f5810942
sim: move ServiceDiallingNumbers to ServiceNumbers
...
In line with the API documentation
2010-05-27 14:58:29 -05:00
Denis Kenzior
73bfae4f46
sim: Read EFiccid after EFphase
2010-05-19 23:48:34 -05:00
Denis Kenzior
bbd6a1d48a
sim: No need for this define
2010-05-19 23:47:41 -05:00
Daniel Wagner
b338033307
Read EF_ICCID property of SIM
...
Tested with phonesim.
2010-05-19 23:41:03 -05:00